)]}'
{"deployment/nova/nova-libvirt-container-puppet.yaml":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"1b835563779fb3e80acd4525788e72bde0e23ecf","unresolved":false,"context_lines":[{"line_number":703,"context_line":"              list_concat:"},{"line_number":704,"context_line":"                - {get_attr: [ContainersCommon, container_puppet_apply_volumes]}"},{"line_number":705,"context_line":"                -"},{"line_number":706,"context_line":"                  - /var/run/libvirt:/var/run/libvirt:shared,z"},{"line_number":707,"context_line":"                  - /var/lib/libvirt:/var/lib/libvirt:shared,z"},{"line_number":708,"context_line":"                  - /var/lib/nova:/var/lib/nova:shared,z"},{"line_number":709,"context_line":"            environment:"},{"line_number":710,"context_line":"              # NOTE: this should force this container to re-run on each"},{"line_number":711,"context_line":"              # update (scale-out, etc.)"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9f560f44_3c01f03a","line":708,"range":{"start_line":706,"start_character":0,"end_line":708,"end_character":56},"updated":"2020-09-17 11:59:43.000000000","message":"unsure about using :z here","commit_id":"bd0f1fbdae1d8178a1a57d5a042c5122c6813781"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"cc3dc746d1a44f10cb49bc668a94bba19a945acc","unresolved":false,"context_lines":[{"line_number":703,"context_line":"              list_concat:"},{"line_number":704,"context_line":"                - {get_attr: [ContainersCommon, container_puppet_apply_volumes]}"},{"line_number":705,"context_line":"                -"},{"line_number":706,"context_line":"                  - /var/run/libvirt:/var/run/libvirt:shared,z"},{"line_number":707,"context_line":"                  - /var/lib/libvirt:/var/lib/libvirt:shared,z"},{"line_number":708,"context_line":"                  - /var/lib/nova:/var/lib/nova:shared,z"},{"line_number":709,"context_line":"            environment:"},{"line_number":710,"context_line":"              # NOTE: this should force this container to re-run on each"},{"line_number":711,"context_line":"              # update (scale-out, etc.)"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9f560f44_dee4153f","line":708,"range":{"start_line":706,"start_character":0,"end_line":708,"end_character":56},"in_reply_to":"9f560f44_3c01f03a","updated":"2020-09-18 10:51:57.000000000","message":"Thanks, will test suggested change locally and update the patch.","commit_id":"bd0f1fbdae1d8178a1a57d5a042c5122c6813781"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"713e726849cb28e64f361cf1234277c0a067d42f","unresolved":false,"context_lines":[{"line_number":703,"context_line":"              list_concat:"},{"line_number":704,"context_line":"                - {get_attr: [ContainersCommon, container_puppet_apply_volumes]}"},{"line_number":705,"context_line":"                -"},{"line_number":706,"context_line":"                  - /var/run/libvirt:/var/run/libvirt:shared,z"},{"line_number":707,"context_line":"                  - /var/lib/libvirt:/var/lib/libvirt:shared,z"},{"line_number":708,"context_line":"                  - /var/lib/nova:/var/lib/nova:shared,z"},{"line_number":709,"context_line":"            environment:"},{"line_number":710,"context_line":"              # NOTE: this should force this container to re-run on each"},{"line_number":711,"context_line":"              # update (scale-out, etc.)"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9f560f44_57df5f65","line":708,"range":{"start_line":706,"start_character":0,"end_line":708,"end_character":56},"in_reply_to":"9f560f44_3c01f03a","updated":"2020-09-17 12:17:07.000000000","message":"indeed: \"z\" is wrong for some bind-mounts.\n\nAlso, please point to /run/libvirt instead of /var/run for consistency.\n\nHere\u0027s an example of the mounts as they should be listed:\nhttps://opendev.org/openstack/tripleo-heat-templates/src/branch/master/deployment/nova/nova-libvirt-container-puppet.yaml#L683","commit_id":"bd0f1fbdae1d8178a1a57d5a042c5122c6813781"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"cc3dc746d1a44f10cb49bc668a94bba19a945acc","unresolved":false,"context_lines":[{"line_number":703,"context_line":"              list_concat:"},{"line_number":704,"context_line":"                - {get_attr: [ContainersCommon, container_puppet_apply_volumes]}"},{"line_number":705,"context_line":"                -"},{"line_number":706,"context_line":"                  - /var/run/libvirt:/var/run/libvirt:shared,z"},{"line_number":707,"context_line":"                  - /var/lib/libvirt:/var/lib/libvirt:shared,z"},{"line_number":708,"context_line":"                  - /var/lib/nova:/var/lib/nova:shared,z"},{"line_number":709,"context_line":"            environment:"},{"line_number":710,"context_line":"              # NOTE: this should force this container to re-run on each"},{"line_number":711,"context_line":"              # update (scale-out, etc.)"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9f560f44_bedfa164","line":708,"range":{"start_line":706,"start_character":0,"end_line":708,"end_character":56},"in_reply_to":"9f560f44_57df5f65","updated":"2020-09-18 10:51:57.000000000","message":"Thanks, will test suggested change locally and update the patch.","commit_id":"bd0f1fbdae1d8178a1a57d5a042c5122c6813781"}]}