)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"c1d8a819e29c9f8dd5c997a465f3dbe02446a448","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Make sure docker-puppet uses LANG\u003den_US.UTF-8"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This anticipates the backport of https://review.opendev.org/#/c/720787/."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Force the environment variable LANG when we run the puppet command. To"},{"line_number":12,"context_line":"ensure we have a unicode system and prevent unicode error problems. For"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"8c589ba6_140c4c15","line":9,"updated":"2021-01-14 13:57:10.000000000","message":"Actually we don\u0027t need the patch for master. That works well on train+, we can replace the link with the patch[1] of ussuri.\n\n[1] https://review.opendev.org/c/openstack/tripleo-heat-templates/+/753407/","commit_id":"f2f856433774cd8110fea84780d155812d860314"}],"docker/docker-puppet.py":[{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"2b7cfa7cf04744f28ab1144263979ecdc45a101c","unresolved":false,"context_lines":[{"line_number":230,"context_line":"    # $::deployment_type in puppet-tripleo"},{"line_number":231,"context_line":"    export FACTER_deployment_type\u003dcontainers"},{"line_number":232,"context_line":"    export FACTER_uuid\u003d$(cat /sys/class/dmi/id/product_uuid | tr \u0027[:upper:]\u0027 \u0027[:lower:]\u0027)"},{"line_number":233,"context_line":"    : ${LANG\u003den_US.UTF-8}"},{"line_number":234,"context_line":"    export LANG"},{"line_number":235,"context_line":"    FACTER_hostname\u003d$HOSTNAME /usr/bin/puppet apply --summarize \\"},{"line_number":236,"context_line":"    --detailed-exitcodes --color\u003dfalse --logdest syslog --logdest console --modulepath\u003d/etc/puppet/modules:/usr/share/openstack-puppet/modules $TAGS /etc/config.pp"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_a5ce3b80","line":233,"updated":"2020-09-22 15:09:32.000000000","message":"Nice idiom for setting the value if not empty, it\u0027s definitively the one that requires the less character. Awesome!\n\nlonger version:\n\n  LANG\u003d${LANG:-en_US.UTF-8}\n  : ${LANG:-en_US.UTF-8}\n\nwe can even do which is still even less characters ...\n\n   export LANG\u003d${LANG\u003den_US.UTF-8}\n\nNow, I\u0027m wondering if we should follow what LANG says here.  If LANG is set to C in the container for /some reasons/ then this won\u0027t work and we will hit the problem again.  Should we care ?","commit_id":"f2f856433774cd8110fea84780d155812d860314"}]}