)]}'
{"deployment/neutron/neutron-plugin-ml2-ovn.yaml":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"a98f7454708850e12974b41ece1bd97681449abb","unresolved":false,"context_lines":[{"line_number":78,"context_line":"  OVNMetadataEnabled:"},{"line_number":79,"context_line":"    description: Whether Metadata Service has to be enabled"},{"line_number":80,"context_line":"    type: boolean"},{"line_number":81,"context_line":"    default: true"},{"line_number":82,"context_line":"  OVNDnsServers:"},{"line_number":83,"context_line":"    default: []"},{"line_number":84,"context_line":"    description: List of servers to use as as dns forwarders"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f560f44_1a3363c6","line":81,"updated":"2020-10-01 11:56:37.000000000","message":"NeutronNetworkType is used to set neutron::plugins::ml2::tenant_network_types in this template, so shouldn\u0027t be removed.","commit_id":"4b8331fdf47daa2f060f0c93c2da4574ac36a0f4"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"ade7710869e221d024f5816cf878ed88dda444ef","unresolved":false,"context_lines":[{"line_number":78,"context_line":"  OVNMetadataEnabled:"},{"line_number":79,"context_line":"    description: Whether Metadata Service has to be enabled"},{"line_number":80,"context_line":"    type: boolean"},{"line_number":81,"context_line":"    default: true"},{"line_number":82,"context_line":"  OVNDnsServers:"},{"line_number":83,"context_line":"    default: []"},{"line_number":84,"context_line":"    description: List of servers to use as as dns forwarders"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7f6b1bfe_133258f2","line":81,"in_reply_to":"9f560f44_1a3363c6","updated":"2020-10-14 13:20:15.000000000","message":"I think the NeutronNetworkType could be removed here as long as the reference further down in the file is removed since the required hiera is set in neutron plugin ml2 which should be pulled in by NeutronML2Base in this template.","commit_id":"4b8331fdf47daa2f060f0c93c2da4574ac36a0f4"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"ade7710869e221d024f5816cf878ed88dda444ef","unresolved":false,"context_lines":[{"line_number":146,"context_line":"            neutron::server::igmp_snooping_enable: {get_param: NeutronEnableIgmpSnooping}"},{"line_number":147,"context_line":"            neutron::plugins::ml2::max_header_size: {get_param: NeutronGeneveMaxHeaderSize}"},{"line_number":148,"context_line":"            neutron::plugins::ml2::ovn::dns_servers: {get_param: OVNDnsServers}"},{"line_number":149,"context_line":"            neutron::plugins::ml2::tenant_network_types: {get_param: NeutronNetworkType}"},{"line_number":150,"context_line":"            neutron::plugins::ml2::ovn::ovn_emit_need_to_frag: {get_param: OVNEmitNeedToFrag}"},{"line_number":151,"context_line":"          - if:"},{"line_number":152,"context_line":"              - internal_tls_enabled"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7f6b1bfe_3807731f","line":149,"updated":"2020-10-14 13:20:15.000000000","message":"remove the above line.","commit_id":"4b8331fdf47daa2f060f0c93c2da4574ac36a0f4"}],"tools/yaml-validate.py":[{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"c98bdb02edbde8bd6f710890f83789a3918b2779","unresolved":false,"context_lines":[{"line_number":202,"context_line":"    # tenant networks have a limited support"},{"line_number":203,"context_line":"    # in OVN. Till that is fixed, we restrict"},{"line_number":204,"context_line":"    # NeutronNetworkType to \u0027geneve\u0027."},{"line_number":205,"context_line":"    \u0027NeutronNetworkType\u0027: [\u0027description\u0027, \u0027default\u0027, \u0027constraints\u0027],"},{"line_number":206,"context_line":"    \u0027KeyName\u0027: [\u0027constraints\u0027],"},{"line_number":207,"context_line":"    \u0027OVNSouthboundServerPort\u0027: [\u0027description\u0027],"},{"line_number":208,"context_line":"    \u0027ExternalInterfaceDefaultRoute\u0027: [\u0027description\u0027, \u0027default\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_4ea10ef7","line":205,"updated":"2020-09-24 12:27:31.000000000","message":"fyi. this override was introduced only to support ml2-ovs and ml2-ovn together as the paramete description and contraints were different. now that we only support only ml2-ovn, this entry can be removed.","commit_id":"77ea7476015887726a95c38309a053e4ca785aec"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"533d1dce29cb7cfbf086daf88e842a5e0956452d","unresolved":false,"context_lines":[{"line_number":202,"context_line":"    # tenant networks have a limited support"},{"line_number":203,"context_line":"    # in OVN. Till that is fixed, we restrict"},{"line_number":204,"context_line":"    # NeutronNetworkType to \u0027geneve\u0027."},{"line_number":205,"context_line":"    \u0027NeutronNetworkType\u0027: [\u0027description\u0027, \u0027default\u0027, \u0027constraints\u0027],"},{"line_number":206,"context_line":"    \u0027KeyName\u0027: [\u0027constraints\u0027],"},{"line_number":207,"context_line":"    \u0027OVNSouthboundServerPort\u0027: [\u0027description\u0027],"},{"line_number":208,"context_line":"    \u0027ExternalInterfaceDefaultRoute\u0027: [\u0027description\u0027, \u0027default\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_947e5568","line":205,"in_reply_to":"9f560f44_222e6b42","updated":"2020-09-29 04:16:35.000000000","message":"contraints has been added when ml2-ovn is added (since it was not supporting vxlan earlier). But it is good to have constraints, which validates the inputs before the deployment itself. copy the constraints as you mentioned and remove this entry from there.","commit_id":"77ea7476015887726a95c38309a053e4ca785aec"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"a343af3db34484f01aeefe9ffab751c1a5688571","unresolved":false,"context_lines":[{"line_number":202,"context_line":"    # tenant networks have a limited support"},{"line_number":203,"context_line":"    # in OVN. Till that is fixed, we restrict"},{"line_number":204,"context_line":"    # NeutronNetworkType to \u0027geneve\u0027."},{"line_number":205,"context_line":"    \u0027NeutronNetworkType\u0027: [\u0027description\u0027, \u0027default\u0027, \u0027constraints\u0027],"},{"line_number":206,"context_line":"    \u0027KeyName\u0027: [\u0027constraints\u0027],"},{"line_number":207,"context_line":"    \u0027OVNSouthboundServerPort\u0027: [\u0027description\u0027],"},{"line_number":208,"context_line":"    \u0027ExternalInterfaceDefaultRoute\u0027: [\u0027description\u0027, \u0027default\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_222e6b42","line":205,"in_reply_to":"9f560f44_4ea10ef7","updated":"2020-09-24 15:46:48.000000000","message":"Should I move NeutronNetworkType constraints from ./deployment/neutron/neutron-plugin-ml2-ovn.yaml into ./deployment/neutron/neutron-plugin-ml2.yaml then? Or should I remove the constraints version completely and allow anything configured for type drivers?","commit_id":"77ea7476015887726a95c38309a053e4ca785aec"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"eb7b28bff582ea08d2bebde93cd6ce5a2db54d3c","unresolved":false,"context_lines":[{"line_number":195,"context_line":"    \u0027BondInterfaceOvsOptions\u0027: [\u0027description\u0027,"},{"line_number":196,"context_line":"                                \u0027default\u0027,"},{"line_number":197,"context_line":"                                \u0027constraints\u0027],"},{"line_number":198,"context_line":"    # NOTE(anil): This is a temporary change and"},{"line_number":199,"context_line":"    # will be removed once bug #1767070 properly"},{"line_number":200,"context_line":"    # fixed. OVN supports only VLAN, geneve, VXLAN,"},{"line_number":201,"context_line":"    # and flat for NeutronNetworkType. But VLAN"},{"line_number":202,"context_line":"    # tenant networks have a limited support"},{"line_number":203,"context_line":"    # in OVN. Till that is fixed, we restrict"},{"line_number":204,"context_line":"    # NeutronNetworkType to \u0027geneve\u0027."},{"line_number":205,"context_line":"    \u0027NeutronNetworkType\u0027: [\u0027description\u0027, \u0027default\u0027, \u0027constraints\u0027],"},{"line_number":206,"context_line":"    \u0027KeyName\u0027: [\u0027constraints\u0027],"},{"line_number":207,"context_line":"    \u0027OVNSouthboundServerPort\u0027: [\u0027description\u0027],"},{"line_number":208,"context_line":"    \u0027ExternalInterfaceDefaultRoute\u0027: [\u0027description\u0027, \u0027default\u0027],"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f621f24_f9750ffc","line":205,"range":{"start_line":198,"start_character":0,"end_line":205,"end_character":68},"updated":"2020-10-28 09:39:58.000000000","message":"This entry can be removed, as there is no mismatch in the definition of this parameter (as it is defined in only one file after this patch). Is there anything stopping from removing this entry?","commit_id":"5c191cac563a6e93f3dc4a7c71b2f76bbfaec37f"}]}