)]}'
{"deployment/rabbitmq/rabbitmq-container-puppet.yaml":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"4b0bf0997685d11fc140756755b63629f95b8aa7","unresolved":false,"context_lines":[{"line_number":166,"context_line":"            rabbitmq_config_variables:"},{"line_number":167,"context_line":"              cluster_partition_handling: \u0027ignore\u0027"},{"line_number":168,"context_line":"              queue_master_locator: \u0027\u003c\u003c\"min-masters\"\u003e\u003e\u0027"},{"line_number":169,"context_line":"              log: \"[ { file, [ { rotation, [ { date, \u0027\u0027 }, { size, 0 } ] } ] } ]\""},{"line_number":170,"context_line":"            rabbitmq::erlang_cookie:"},{"line_number":171,"context_line":"              yaql:"},{"line_number":172,"context_line":"                expression: $.data.passwords.where($ !\u003d \u0027\u0027).first()"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9f560f44_9c4b05b0","line":169,"range":{"start_line":169,"start_character":14,"end_line":169,"end_character":52},"updated":"2020-09-30 09:56:20.000000000","message":"unsure if the classic erlang config format translates to the new format just as it is... So that log.file.rotation.date can become something totally different.","commit_id":"6af7deb454aa962f5359d68e966a6e5367babb46"},{"author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"change_message_id":"29f13939687a344ac49a014013d47e930d1d9186","unresolved":false,"context_lines":[{"line_number":166,"context_line":"            rabbitmq_config_variables:"},{"line_number":167,"context_line":"              cluster_partition_handling: \u0027ignore\u0027"},{"line_number":168,"context_line":"              queue_master_locator: \u0027\u003c\u003c\"min-masters\"\u003e\u003e\u0027"},{"line_number":169,"context_line":"              log: \"[ { file, [ { rotation, [ { date, \u0027\u0027 }, { size, 0 } ] } ] } ]\""},{"line_number":170,"context_line":"            rabbitmq::erlang_cookie:"},{"line_number":171,"context_line":"              yaql:"},{"line_number":172,"context_line":"                expression: $.data.passwords.where($ !\u003d \u0027\u0027).first()"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9f560f44_e748ae63","line":169,"range":{"start_line":169,"start_character":14,"end_line":169,"end_character":52},"in_reply_to":"9f560f44_9c4b05b0","updated":"2020-09-30 10:19:28.000000000","message":"so last night when I tried it by hand, rabbitmq did not complain and rabbitmqctl environment showed the setting. Now if it works or not is an entirely separate matter :)","commit_id":"6af7deb454aa962f5359d68e966a6e5367babb46"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"38e561e93d6870c0d34c9bce98b4a598b59414f3","unresolved":false,"context_lines":[{"line_number":166,"context_line":"            rabbitmq_config_variables:"},{"line_number":167,"context_line":"              cluster_partition_handling: \u0027ignore\u0027"},{"line_number":168,"context_line":"              queue_master_locator: \u0027\u003c\u003c\"min-masters\"\u003e\u003e\u0027"},{"line_number":169,"context_line":"              lager: \u0027[{ handlers, [{ lager_file_backend, [{ file, \"crash.log\"}, { size, 0 }, { date, \"\"} ] }] }]\u0027"},{"line_number":170,"context_line":"            rabbitmq::erlang_cookie:"},{"line_number":171,"context_line":"              yaql:"},{"line_number":172,"context_line":"                expression: $.data.passwords.where($ !\u003d \u0027\u0027).first()"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1f621f24_e642be0e","line":169,"updated":"2020-11-13 11:54:15.000000000","message":"seems functionally identical to that had been proposed in https://review.opendev.org/#/c/755218/1/deployment/rabbitmq/rabbitmq-container-puppet.yaml\n\nso LGTM as well, thanks!","commit_id":"a64caa0f4a894702618fb7983ebcd5d2ca83ac75"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"d3ca2b4bb914e4821be199b72dd8af49afa2f45d","unresolved":true,"context_lines":[{"line_number":172,"context_line":"              cluster_partition_handling: \u0027ignore\u0027"},{"line_number":173,"context_line":"              queue_master_locator: \u0027\u003c\u003c\"min-masters\"\u003e\u003e\u0027"},{"line_number":174,"context_line":"            rabbitmq::config_additional_variables:"},{"line_number":175,"context_line":"              lager: \u0027[{ handlers, [{ lager_file_backend, [{ file, \"crash.log\"}, { size, 0 }, { date, \"\"} ] }] }]\u0027"},{"line_number":176,"context_line":"            rabbitmq::erlang_cookie: {get_param: RabbitCookie}"},{"line_number":177,"context_line":"            # NOTE: bind IP is found in hiera replacing the network name with the"},{"line_number":178,"context_line":"            # local node IP for the given network; replacement examples"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"12ab709d_aedcf206","line":175,"updated":"2021-04-09 10:05:50.000000000","message":"I think we should keep the handler and also add { crash_log_date, \"\"}, { clash_log_size, 0 }","commit_id":"71ca55e2b6553f41afb080bebcb24eaa8a3ec5a8"}]}