)]}'
{"deployment/horizon/horizon-container-puppet.yaml":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"1b363dafff56cd14b6080934a4b0a9d447c3e5aa","unresolved":false,"context_lines":[{"line_number":259,"context_line":"      service_config_settings:"},{"line_number":260,"context_line":"        rsyslog:"},{"line_number":261,"context_line":"          tripleo_logging_sources_horizon:"},{"line_number":262,"context_line":"            yaql:"},{"line_number":263,"context_line":"              expression: $.data.sources.flatten()"},{"line_number":264,"context_line":"              data:"},{"line_number":265,"context_line":"                sources:"},{"line_number":266,"context_line":"                  - {get_param: HorizonLoggingSource}"},{"line_number":267,"context_line":"      # BEGIN DOCKER SETTINGS"},{"line_number":268,"context_line":"      puppet_config:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9f560f44_78593859","line":265,"range":{"start_line":262,"start_character":0,"end_line":265,"end_character":24},"updated":"2020-10-12 11:32:50.000000000","message":"Is there any reason why we need to flatten the json specifically for HorizonLoggingSource ?\n\nI\u0027m asking this because we pass the parameter directly to tripleo_logging_sources_horizon in the other service definitions like cinder, nova, glance, etc.","commit_id":"f2fc8c8fafd1c29c8ddfa0c78b875cb9f48291a7"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"df6dd9701dec31572c832fb56e3bdb719e6943ca","unresolved":false,"context_lines":[{"line_number":259,"context_line":"      service_config_settings:"},{"line_number":260,"context_line":"        rsyslog:"},{"line_number":261,"context_line":"          tripleo_logging_sources_horizon:"},{"line_number":262,"context_line":"            yaql:"},{"line_number":263,"context_line":"              expression: $.data.sources.flatten()"},{"line_number":264,"context_line":"              data:"},{"line_number":265,"context_line":"                sources:"},{"line_number":266,"context_line":"                  - {get_param: HorizonLoggingSource}"},{"line_number":267,"context_line":"      # BEGIN DOCKER SETTINGS"},{"line_number":268,"context_line":"      puppet_config:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9f560f44_5be26ed5","line":265,"range":{"start_line":262,"start_character":0,"end_line":265,"end_character":24},"in_reply_to":"9f560f44_38122062","updated":"2020-10-12 12:13:09.000000000","message":"It is written in the commit message:\n\nTo keep consistency with other services the default value is set as single log located\nin appropriate log directory, but we also need to enable customer to pass multiple\nhorizon log files also used by httpd.","commit_id":"f2fc8c8fafd1c29c8ddfa0c78b875cb9f48291a7"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e5cd2eda5e2bf82a860d6af5800e7cdc41f8cc87","unresolved":false,"context_lines":[{"line_number":259,"context_line":"      service_config_settings:"},{"line_number":260,"context_line":"        rsyslog:"},{"line_number":261,"context_line":"          tripleo_logging_sources_horizon:"},{"line_number":262,"context_line":"            yaql:"},{"line_number":263,"context_line":"              expression: $.data.sources.flatten()"},{"line_number":264,"context_line":"              data:"},{"line_number":265,"context_line":"                sources:"},{"line_number":266,"context_line":"                  - {get_param: HorizonLoggingSource}"},{"line_number":267,"context_line":"      # BEGIN DOCKER SETTINGS"},{"line_number":268,"context_line":"      puppet_config:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9f560f44_3b817ac3","line":265,"range":{"start_line":262,"start_character":0,"end_line":265,"end_character":24},"in_reply_to":"9f560f44_5be26ed5","updated":"2020-10-12 12:20:39.000000000","message":"Thanks for clarification. Sorry I should have been more careful about that.\n\nIf we want to include apache logs then maybe we need the same implementation for api services, I guess, but that\u0027s another thing.","commit_id":"f2fc8c8fafd1c29c8ddfa0c78b875cb9f48291a7"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"cffa95e78e8d0f51d52c8bd9c5b6d599116ee2bd","unresolved":false,"context_lines":[{"line_number":259,"context_line":"      service_config_settings:"},{"line_number":260,"context_line":"        rsyslog:"},{"line_number":261,"context_line":"          tripleo_logging_sources_horizon:"},{"line_number":262,"context_line":"            yaql:"},{"line_number":263,"context_line":"              expression: $.data.sources.flatten()"},{"line_number":264,"context_line":"              data:"},{"line_number":265,"context_line":"                sources:"},{"line_number":266,"context_line":"                  - {get_param: HorizonLoggingSource}"},{"line_number":267,"context_line":"      # BEGIN DOCKER SETTINGS"},{"line_number":268,"context_line":"      puppet_config:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9f560f44_38122062","line":265,"range":{"start_line":262,"start_character":0,"end_line":265,"end_character":24},"in_reply_to":"9f560f44_78593859","updated":"2020-10-12 11:33:57.000000000","message":"I should have said;\n\n... because we pass the parameter directly to tripleo_logging_sources_\u003cservice name\u003e in the other service definitions ...","commit_id":"f2fc8c8fafd1c29c8ddfa0c78b875cb9f48291a7"}]}