)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"1d4a621959091e0a79b16189888e3855a6dcc206","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Rajesh Tailor \u003cratailor@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-10-12 18:56:23 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Expose new THT parameters"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change adds new THT parameters `NovaLibvirtCPUMode`,"},{"line_number":10,"context_line":"`NovaLibvirtCPUModels` and `NovaLibvirtCPUModelExtraFlags`"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9f560f44_207e59e2","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":25},"updated":"2020-10-13 10:09:28.000000000","message":"something like \"Expose new THT params for cpu model\" would be better","commit_id":"7a38a2c276161325c3ca3c6f1b0400c116189a25"}],"deployment/nova/nova-compute-container-puppet.yaml":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"0bbdd30e0b7ef3dfe188ef240b25d657782b0e13","unresolved":false,"context_lines":[{"line_number":464,"context_line":"      The libvirt CPU mode to configure. Possible values include custom, host-model,"},{"line_number":465,"context_line":"      none, host-passthrough."},{"line_number":466,"context_line":"      Defaults to \u0027host-model\u0027 if virt_type is set to kvm, otherwise defaults to \u0027none\u0027"},{"line_number":467,"context_line":"    default: \u0027\u0027"},{"line_number":468,"context_line":"    tags:"},{"line_number":469,"context_line":"      - role_specific"},{"line_number":470,"context_line":"  NovaLibvirtCPUModels:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9f560f44_78d65855","line":467,"range":{"start_line":467,"start_character":3,"end_line":467,"end_character":15},"updated":"2020-10-12 10:52:50.000000000","message":"Currently this makes empty value set to the cpu_mode parameter\n https://zuul.opendev.org/t/openstack/build/a4f8d1de5a45482c907ddce1458701ea/log/logs/subnode-1/var/lib/config-data/puppet-generated/nova_libvirt/etc/nova/nova.conf#3051\n\nand this prevents nova-compute from starting up correctly.\n https://zuul.opendev.org/t/openstack/build/a4f8d1de5a45482c907ddce1458701ea/log/logs/subnode-1/var/log/containers/nova/nova-compute.log#465\n\nIMO you should update the patch in one of the following manner to resolve the failure.\n - Set \u0027none\u0027 as default\n - Do not set cpu parameters if NovaLibvirtCPUMode is unset.","commit_id":"0454d446eb61fda32fc04d1a3a6740bb1439bb94"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"ef11f35b1f9c342025f3e25b3c9d6f320442d424","unresolved":false,"context_lines":[{"line_number":464,"context_line":"      The libvirt CPU mode to configure. Possible values include custom, host-model,"},{"line_number":465,"context_line":"      none, host-passthrough."},{"line_number":466,"context_line":"      Defaults to \u0027host-model\u0027 if virt_type is set to kvm, otherwise defaults to \u0027none\u0027"},{"line_number":467,"context_line":"    default: \u0027\u0027"},{"line_number":468,"context_line":"    tags:"},{"line_number":469,"context_line":"      - role_specific"},{"line_number":470,"context_line":"  NovaLibvirtCPUModels:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9f560f44_913a27ca","line":467,"range":{"start_line":467,"start_character":3,"end_line":467,"end_character":15},"in_reply_to":"9f560f44_78d65855","updated":"2020-10-12 13:27:31.000000000","message":"I have updated the patch. Thanks for review.","commit_id":"0454d446eb61fda32fc04d1a3a6740bb1439bb94"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"1d4a621959091e0a79b16189888e3855a6dcc206","unresolved":false,"context_lines":[{"line_number":461,"context_line":"  NovaLibvirtCPUMode:"},{"line_number":462,"context_line":"    type: string"},{"line_number":463,"context_line":"    description: \u003e"},{"line_number":464,"context_line":"      The libvirt CPU mode to configure. Possible values include custom, host-model,"},{"line_number":465,"context_line":"      none, host-passthrough."},{"line_number":466,"context_line":"      Defaults to \u0027host-model\u0027 if virt_type is set to kvm, otherwise defaults to \u0027none\u0027"},{"line_number":467,"context_line":"    default: \u0027none\u0027"},{"line_number":468,"context_line":"    tags:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9f560f44_40fd4d39","line":465,"range":{"start_line":464,"start_character":41,"end_line":465,"end_character":29},"updated":"2020-10-13 10:09:28.000000000","message":"Why not just add a constraint instead, e.g\n\nconstraints:\n  - allowed_values:\n    - custom\n    - host-model\n    - none\n    - host-passthrough","commit_id":"7a38a2c276161325c3ca3c6f1b0400c116189a25"}]}