)]}'
{"deployment/logging/rsyslog-container-puppet.yaml":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"a8aac3f0dfc1994fbfb24f0c162c79cf7e8de778","unresolved":true,"context_lines":[{"line_number":255,"context_line":"        - block:"},{"line_number":256,"context_line":"          when: step|int \u003d\u003d 1"},{"line_number":257,"context_line":"          tasks:"},{"line_number":258,"context_line":"            - name: Ensure fluentd service is removed"},{"line_number":259,"context_line":"              package:"},{"line_number":260,"context_line":"                name: fluentd"},{"line_number":261,"context_line":"                state: absent"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"037c6306_32cb032e","line":258,"range":{"start_line":258,"start_character":35,"end_line":258,"end_character":42},"updated":"2020-11-24 11:11:34.000000000","message":"would it be better to rephrase this to \"package\" ? IIUC this is not removing only service but the whole package providing that service.","commit_id":"059149352f8d0eabb5f0c313eb4ea2678aafd80a"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"db4576f75fca0245c47d30eb853ec47ae319aea0","unresolved":true,"context_lines":[{"line_number":255,"context_line":"        - block:"},{"line_number":256,"context_line":"          when: step|int \u003d\u003d 1"},{"line_number":257,"context_line":"          tasks:"},{"line_number":258,"context_line":"            - name: Check if fluentd is deployed on the host"},{"line_number":259,"context_line":"              command: systemctl is-enabled --quiet fluentd"},{"line_number":260,"context_line":"              failed_when: false"},{"line_number":261,"context_line":"              register: fluentd_enabled_result"},{"line_number":262,"context_line":"            - name: Set fact fluentd_enabled"},{"line_number":263,"context_line":"              set_fact:"},{"line_number":264,"context_line":"                fluentd_enabled: \"{{ fluentd_enabled_result.rc \u003d\u003d 0 }}\""},{"line_number":265,"context_line":"            - name: Stop and disable fluentd service"},{"line_number":266,"context_line":"              service:"},{"line_number":267,"context_line":"                name: fluentd"},{"line_number":268,"context_line":"                state: stopped"},{"line_number":269,"context_line":"                enabled: no"},{"line_number":270,"context_line":"              when: fluentd_enabled|bool"},{"line_number":271,"context_line":"            - name: Ensure fluentd package is removed"},{"line_number":272,"context_line":"              package:"},{"line_number":273,"context_line":"                name: fluentd"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"f07e06b8_fba084ba","line":270,"range":{"start_line":258,"start_character":0,"end_line":270,"end_character":40},"updated":"2021-01-07 14:31:49.000000000","message":"we should use the systemd module\n\n  - name: Disable fluentd\n    systemd:\n      name: fluentd\n      enabled: no\n      state: stopped","commit_id":"a059460535a06e9656b41f976cc9d7f922a9cd32"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"c8180baf6f5ce9f2c4c98042266d233d99c52e63","unresolved":false,"context_lines":[{"line_number":255,"context_line":"        - block:"},{"line_number":256,"context_line":"          when: step|int \u003d\u003d 1"},{"line_number":257,"context_line":"          tasks:"},{"line_number":258,"context_line":"            - name: Check if fluentd is deployed on the host"},{"line_number":259,"context_line":"              command: systemctl is-enabled --quiet fluentd"},{"line_number":260,"context_line":"              failed_when: false"},{"line_number":261,"context_line":"              register: fluentd_enabled_result"},{"line_number":262,"context_line":"            - name: Set fact fluentd_enabled"},{"line_number":263,"context_line":"              set_fact:"},{"line_number":264,"context_line":"                fluentd_enabled: \"{{ fluentd_enabled_result.rc \u003d\u003d 0 }}\""},{"line_number":265,"context_line":"            - name: Stop and disable fluentd service"},{"line_number":266,"context_line":"              service:"},{"line_number":267,"context_line":"                name: fluentd"},{"line_number":268,"context_line":"                state: stopped"},{"line_number":269,"context_line":"                enabled: no"},{"line_number":270,"context_line":"              when: fluentd_enabled|bool"},{"line_number":271,"context_line":"            - name: Ensure fluentd package is removed"},{"line_number":272,"context_line":"              package:"},{"line_number":273,"context_line":"                name: fluentd"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ef5f8802_c79163a7","line":270,"range":{"start_line":258,"start_character":0,"end_line":270,"end_character":40},"in_reply_to":"f07e06b8_fba084ba","updated":"2021-01-07 15:14:15.000000000","message":"Ack","commit_id":"a059460535a06e9656b41f976cc9d7f922a9cd32"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"602a27a63312897cfd14e0cc70d63817de2a8c4c","unresolved":true,"context_lines":[{"line_number":255,"context_line":"        - block:"},{"line_number":256,"context_line":"          when: step|int \u003d\u003d 1"},{"line_number":257,"context_line":"          tasks:"},{"line_number":258,"context_line":"            - name: Check if fluentd is deployed on the host"},{"line_number":259,"context_line":"              command: systemctl is-enabled --quiet fluentd"},{"line_number":260,"context_line":"              failed_when: false"},{"line_number":261,"context_line":"              register: fluentd_enabled_result"},{"line_number":262,"context_line":"            - name: Set fact fluentd_enabled"},{"line_number":263,"context_line":"              set_fact:"},{"line_number":264,"context_line":"                fluentd_enabled: \"{{ fluentd_enabled_result.rc \u003d\u003d 0 }}\""},{"line_number":265,"context_line":"            - name: Stop and disable fluentd service"},{"line_number":266,"context_line":"              systemd:"},{"line_number":267,"context_line":"                name: fluentd"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"85f34007_0e97a9cf","line":264,"range":{"start_line":258,"start_character":0,"end_line":264,"end_character":71},"updated":"2021-01-07 15:22:58.000000000","message":"there\u0027s no need to do any of this. However, if you want to do the test for the unit file before calling the systemd module we can do the following.\n\n            - name: Check if fluentd is deployed on the host\n              command: systemctl is-enabled --quiet fluentd\n              failed_when: false\n              register: fluentd_enabled_result\n            - name: Stop and disable fluentd service\n              systemd:\n                name: fluentd\n                state: stopped\n                enabled: no\n              when:\n                - fluentd_enabled_result.rc \u003d\u003d 0\n\nWhich will get rid of the extra fact.","commit_id":"97603ac6e5f4c4525d1ab8bb5a1c8472d7e838ec"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"5cca9089efb2ce9b7773f1cf1a5bbc72292719e9","unresolved":true,"context_lines":[{"line_number":255,"context_line":"        - block:"},{"line_number":256,"context_line":"          when: step|int \u003d\u003d 1"},{"line_number":257,"context_line":"          tasks:"},{"line_number":258,"context_line":"            - name: Stop and disable fluentd service"},{"line_number":259,"context_line":"              systemd:"},{"line_number":260,"context_line":"                name: fluentd"},{"line_number":261,"context_line":"                state: stopped"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"bb2c70b7_c07e30b1","line":258,"updated":"2021-03-19 13:19:25.000000000","message":"shall we not ensure we have the service first? IIRC systemd module fails in case we mention an unknown unit.","commit_id":"68de50f3d7e0b2ec2bcfe0ea3eebec53aad3d0bf"}]}