)]}'
{"container_config_scripts/pacemaker_mutex_shutdown.sh":[{"author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"change_message_id":"b7e515dfc676ca39c36104434e30c9da99b550a9","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    log \"Acquiring the shutdown lock\""},{"line_number":36,"context_line":"    while [ $rc -ne 0 ]; do"},{"line_number":37,"context_line":"        /var/lib/container-config-scripts/pacemaker_resource_lock.sh --acquire-once $lockname $requester $ttl"},{"line_number":38,"context_line":"        rc\u003d$?"},{"line_number":39,"context_line":"        if [ $rc -ne 0 ]; then"},{"line_number":40,"context_line":"            if [ $rc -eq 2 ]; then"}],"source_content_type":"text/x-sh","patch_set":1,"id":"3f65232a_8d6484bb","line":37,"range":{"start_line":37,"start_character":8,"end_line":37,"end_character":68},"updated":"2020-10-22 10:41:45.000000000","message":"keep this in a variable/constant at the top of the file since you use it all over?","commit_id":"10ee9293243e9a78d661f1f43ae16d67eda10dd4"},{"author":{"_account_id":20778,"name":"Damien Ciabrini","email":"dciabrin@redhat.com","username":"dciabrin"},"change_message_id":"a91d2edda3c701fdebc4f1aee80448fa1ea2637b","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    log \"Acquiring the shutdown lock\""},{"line_number":36,"context_line":"    while [ $rc -ne 0 ]; do"},{"line_number":37,"context_line":"        /var/lib/container-config-scripts/pacemaker_resource_lock.sh --acquire-once $lockname $requester $ttl"},{"line_number":38,"context_line":"        rc\u003d$?"},{"line_number":39,"context_line":"        if [ $rc -ne 0 ]; then"},{"line_number":40,"context_line":"            if [ $rc -eq 2 ]; then"}],"source_content_type":"text/x-sh","patch_set":1,"id":"3f65232a_0dcd145d","line":37,"range":{"start_line":37,"start_character":8,"end_line":37,"end_character":68},"in_reply_to":"3f65232a_8d6484bb","updated":"2020-10-22 11:03:54.000000000","message":"I\u0027d rather not, to stay consistent with what we already have in pacemaker_mutex_restart_bundle.sh, which uses the same idiom.","commit_id":"10ee9293243e9a78d661f1f43ae16d67eda10dd4"},{"author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"change_message_id":"b7e515dfc676ca39c36104434e30c9da99b550a9","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    log \"Releasing the shutdown lock\""},{"line_number":75,"context_line":"    /var/lib/container-config-scripts/pacemaker_resource_lock.sh --release $lockname $requester"},{"line_number":76,"context_line":"    rc\u003d$?"},{"line_number":77,"context_line":"    if [ $rc !\u003d 0 ]; then"},{"line_number":78,"context_line":"        if [ $rc -gt 1 ]; then"},{"line_number":79,"context_line":"            error \"Could not acquire the shutdown lock due to unrecoverable error (rc: $rc), bailing out\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"3f65232a_2d73b082","line":76,"range":{"start_line":76,"start_character":1,"end_line":76,"end_character":9},"updated":"2020-10-22 10:41:45.000000000","message":"local rc, missing?","commit_id":"10ee9293243e9a78d661f1f43ae16d67eda10dd4"},{"author":{"_account_id":20778,"name":"Damien Ciabrini","email":"dciabrin@redhat.com","username":"dciabrin"},"change_message_id":"a91d2edda3c701fdebc4f1aee80448fa1ea2637b","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    log \"Releasing the shutdown lock\""},{"line_number":75,"context_line":"    /var/lib/container-config-scripts/pacemaker_resource_lock.sh --release $lockname $requester"},{"line_number":76,"context_line":"    rc\u003d$?"},{"line_number":77,"context_line":"    if [ $rc !\u003d 0 ]; then"},{"line_number":78,"context_line":"        if [ $rc -gt 1 ]; then"},{"line_number":79,"context_line":"            error \"Could not acquire the shutdown lock due to unrecoverable error (rc: $rc), bailing out\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"3f65232a_4dd70cef","line":76,"range":{"start_line":76,"start_character":1,"end_line":76,"end_character":9},"in_reply_to":"3f65232a_2d73b082","updated":"2020-10-22 11:03:54.000000000","message":"thx, done","commit_id":"10ee9293243e9a78d661f1f43ae16d67eda10dd4"},{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"338e92a4f2db54f6399641ce7a8403c8d9b3a736","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    log \"Releasing the shutdown lock\""},{"line_number":76,"context_line":"    /var/lib/container-config-scripts/pacemaker_resource_lock.sh --release $lockname $requester"},{"line_number":77,"context_line":"    rc\u003d$?"},{"line_number":78,"context_line":"    if [ $rc !\u003d 0 ]; then"},{"line_number":79,"context_line":"        if [ $rc -gt 1 ]; then"},{"line_number":80,"context_line":"            error \"Could not acquire the shutdown lock due to unrecoverable error (rc: $rc), bailing out\""},{"line_number":81,"context_line":"        else"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3f65232a_b0d27333","line":78,"updated":"2020-10-22 12:07:46.000000000","message":"I would use -ne as I don\u0027t see !\u003d anywhere else.","commit_id":"4a656019b3e135ad7c97a3c742e8a10754d8b911"},{"author":{"_account_id":20778,"name":"Damien Ciabrini","email":"dciabrin@redhat.com","username":"dciabrin"},"change_message_id":"9526656d1974c4876c819c0d0fdbc33214cc0200","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    log \"Releasing the shutdown lock\""},{"line_number":76,"context_line":"    /var/lib/container-config-scripts/pacemaker_resource_lock.sh --release $lockname $requester"},{"line_number":77,"context_line":"    rc\u003d$?"},{"line_number":78,"context_line":"    if [ $rc !\u003d 0 ]; then"},{"line_number":79,"context_line":"        if [ $rc -gt 1 ]; then"},{"line_number":80,"context_line":"            error \"Could not acquire the shutdown lock due to unrecoverable error (rc: $rc), bailing out\""},{"line_number":81,"context_line":"        else"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3f65232a_90e137d4","line":78,"in_reply_to":"3f65232a_b0d27333","updated":"2020-10-22 12:20:34.000000000","message":"Done","commit_id":"4a656019b3e135ad7c97a3c742e8a10754d8b911"},{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"e992a412013cce459a8a3baa429bea7d6c591fe8","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    rc\u003d$?"},{"line_number":78,"context_line":"    if [ $rc !\u003d 0 ]; then"},{"line_number":79,"context_line":"        if [ $rc -gt 1 ]; then"},{"line_number":80,"context_line":"            error \"Could not acquire the shutdown lock due to unrecoverable error (rc: $rc), bailing out\""},{"line_number":81,"context_line":"        else"},{"line_number":82,"context_line":"            log \"Shutdown lock no longer held, nothing to do\""},{"line_number":83,"context_line":"        fi"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3f65232a_50195f77","line":80,"updated":"2020-10-22 12:06:00.000000000","message":"s/acquire/release/","commit_id":"4a656019b3e135ad7c97a3c742e8a10754d8b911"},{"author":{"_account_id":20778,"name":"Damien Ciabrini","email":"dciabrin@redhat.com","username":"dciabrin"},"change_message_id":"9526656d1974c4876c819c0d0fdbc33214cc0200","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    rc\u003d$?"},{"line_number":78,"context_line":"    if [ $rc !\u003d 0 ]; then"},{"line_number":79,"context_line":"        if [ $rc -gt 1 ]; then"},{"line_number":80,"context_line":"            error \"Could not acquire the shutdown lock due to unrecoverable error (rc: $rc), bailing out\""},{"line_number":81,"context_line":"        else"},{"line_number":82,"context_line":"            log \"Shutdown lock no longer held, nothing to do\""},{"line_number":83,"context_line":"        fi"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3f65232a_f0e6abe8","line":80,"in_reply_to":"3f65232a_50195f77","updated":"2020-10-22 12:20:34.000000000","message":"Done","commit_id":"4a656019b3e135ad7c97a3c742e8a10754d8b911"}],"deployment/pacemaker/pacemaker-baremetal-puppet.yaml":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"8f98589376dc70bc65a21e3b48e958b535ab77f8","unresolved":false,"context_lines":[{"line_number":374,"context_line":"          when: step|int \u003d\u003d 1"},{"line_number":375,"context_line":"          cmd: /var/lib/container-config-scripts/pacemaker_mutex_shutdown.sh --acquire"},{"line_number":376,"context_line":"        - name: Stop pacemaker cluster"},{"line_number":377,"context_line":"          when: step|int \u003d\u003d 1"},{"line_number":378,"context_line":"          pacemaker_cluster: state\u003doffline"},{"line_number":379,"context_line":"        - name: Start pacemaker cluster"},{"line_number":380,"context_line":"          when: step|int \u003d\u003d 4"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f65232a_d060cf35","line":377,"updated":"2020-10-22 12:34:56.000000000","message":"shouldn\u0027t those without the lock obtained retry and wait?","commit_id":"47769874361584e823d50bd36d21eb0268440717"},{"author":{"_account_id":20778,"name":"Damien Ciabrini","email":"dciabrin@redhat.com","username":"dciabrin"},"change_message_id":"3d7ec21c45b464d7617356dffde4957cd073e527","unresolved":false,"context_lines":[{"line_number":374,"context_line":"          when: step|int \u003d\u003d 1"},{"line_number":375,"context_line":"          cmd: /var/lib/container-config-scripts/pacemaker_mutex_shutdown.sh --acquire"},{"line_number":376,"context_line":"        - name: Stop pacemaker cluster"},{"line_number":377,"context_line":"          when: step|int \u003d\u003d 1"},{"line_number":378,"context_line":"          pacemaker_cluster: state\u003doffline"},{"line_number":379,"context_line":"        - name: Start pacemaker cluster"},{"line_number":380,"context_line":"          when: step|int \u003d\u003d 4"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1f621f24_c7202e4d","line":377,"in_reply_to":"3f65232a_d060cf35","updated":"2020-10-28 11:19:49.000000000","message":"Not sure i got the question straight?\nthe acquire part of the script loops until:\n 1. the lock gets available, which is eventually going always true because in the worst case the locks have a TTL.\n 2. ansible job timeout","commit_id":"47769874361584e823d50bd36d21eb0268440717"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"7f303c6be104fb87d0e770b933d7d61a9ac79945","unresolved":false,"context_lines":[{"line_number":372,"context_line":"            done"},{"line_number":373,"context_line":"        - name: Acquire the cluster shutdown lock to stop pacemaker cluster"},{"line_number":374,"context_line":"          when: step|int \u003d\u003d 1"},{"line_number":375,"context_line":"          command: /var/lib/container-config-scripts/pacemaker_mutex_shutdown.sh --acquire"},{"line_number":376,"context_line":"        - name: Stop pacemaker cluster"},{"line_number":377,"context_line":"          when: step|int \u003d\u003d 1"},{"line_number":378,"context_line":"          pacemaker_cluster: state\u003doffline"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1f621f24_1898e072","line":375,"updated":"2020-11-16 14:56:02.000000000","message":"update tasks aren\u0027t parallel (e.g. using tripleo_free) so it won\u0027t move on to the next task until this task finishes on all hosts. Does this actually work?","commit_id":"93793d2ad62e5c370420b4cd4927c9e6151cb82a"}]}