)]}'
{"ci/environments/scenario001-standalone.yaml":[{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"0498d59e312c85d63cf470fcb01cb8ebc20fabaf","unresolved":false,"context_lines":[{"line_number":187,"context_line":"    foo: bar"},{"line_number":188,"context_line":"  NfsUrl: 127.0.0.1"},{"line_number":189,"context_line":"  CephMsgrSecureMode: true"},{"line_number":190,"context_line":"  CephAnsibleClientDisable: true"},{"line_number":191,"context_line":"  LVMFilterEnabled: true"},{"line_number":192,"context_line":"  LVMFilterAllowlist:"},{"line_number":193,"context_line":"    - /dev/loop2"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"1f621f24_b097213b","line":190,"range":{"start_line":190,"start_character":2,"end_line":190,"end_character":32},"updated":"2020-11-18 15:23:51.000000000","message":"Let\u0027s start collecting some feedback from CI!","commit_id":"0ab3dff7f26132540349a00a98b79c0ef25ce931"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"3ffb4e1fdc09db327a98a3e51e637c092b536a63","unresolved":false,"context_lines":[{"line_number":187,"context_line":"    foo: bar"},{"line_number":188,"context_line":"  NfsUrl: 127.0.0.1"},{"line_number":189,"context_line":"  CephMsgrSecureMode: true"},{"line_number":190,"context_line":"  CephAnsibleClientDisable: true"},{"line_number":191,"context_line":"  LVMFilterEnabled: true"},{"line_number":192,"context_line":"  LVMFilterAllowlist:"},{"line_number":193,"context_line":"    - /dev/loop2"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"1f621f24_6b263cbd","line":190,"range":{"start_line":190,"start_character":2,"end_line":190,"end_character":32},"in_reply_to":"1f621f24_b097213b","updated":"2020-11-18 15:41:14.000000000","message":"++","commit_id":"0ab3dff7f26132540349a00a98b79c0ef25ce931"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"5ea79f613aecb4e1ad2b059d7c948be9f374ba8e","unresolved":false,"context_lines":[{"line_number":189,"context_line":"  NfsUrl: 127.0.0.1"},{"line_number":190,"context_line":"  CephMsgrSecureMode: true"},{"line_number":191,"context_line":"  CephAnsibleClientDisable: true"},{"line_number":192,"context_line":"  CephConfigPath: \"/var/lib/ceph/config-data/\""},{"line_number":193,"context_line":"  LVMFilterEnabled: true"},{"line_number":194,"context_line":"  LVMFilterAllowlist:"},{"line_number":195,"context_line":"    - /dev/loop2"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"fffc6b78_0ad7bac1","line":192,"updated":"2020-11-20 09:59:27.000000000","message":"not sure if we can use /var/lib/ceph though which should be owned by ceph user","commit_id":"33d3642c77bf9f57b77c1bad763da1fef610c34e"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"5f140237c6d7b9d2e8c1a785f3344d1949bef702","unresolved":true,"context_lines":[{"line_number":95,"context_line":"        osd: \"profile rbd pool\u003dimages\""},{"line_number":96,"context_line":"      key: \"AQBRgQ9eAAAAABAAv84zEilJYZPNuJ0Iwn9Ndg\u003d\u003d\""},{"line_number":97,"context_line":"      mode: \"0600\""},{"line_number":98,"context_line":"  CephExternalMultiConfig:"},{"line_number":99,"context_line":"    # create client conf and key file for two non-existent external ceph clusters"},{"line_number":100,"context_line":"    - cluster: \u0027ceph2\u0027"},{"line_number":101,"context_line":"      fsid: \u0027af25554b-42f6-4d2b-9b9b-d08a1132d3e8\u0027"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"5c05216f_73726548","line":98,"range":{"start_line":98,"start_character":2,"end_line":98,"end_character":25},"updated":"2020-11-30 15:39:50.000000000","message":"We can either \n\n1. keep this and not merge this patch\u0027s deps until they support this parameter\n2. remove this line with a todo so that we use a separate submission to add support for this feature which includes adding this test back.","commit_id":"773d49e1147a8aabdf3e2fe25b33add48cdbd994"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"ee2784593720dc7d2e2ce254eadb824e7090730f","unresolved":true,"context_lines":[{"line_number":95,"context_line":"        osd: \"profile rbd pool\u003dimages\""},{"line_number":96,"context_line":"      key: \"AQBRgQ9eAAAAABAAv84zEilJYZPNuJ0Iwn9Ndg\u003d\u003d\""},{"line_number":97,"context_line":"      mode: \"0600\""},{"line_number":98,"context_line":"  CephExternalMultiConfig:"},{"line_number":99,"context_line":"    # create client conf and key file for two non-existent external ceph clusters"},{"line_number":100,"context_line":"    - cluster: \u0027ceph2\u0027"},{"line_number":101,"context_line":"      fsid: \u0027af25554b-42f6-4d2b-9b9b-d08a1132d3e8\u0027"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"9f49464d_de1d5306","line":98,"range":{"start_line":98,"start_character":2,"end_line":98,"end_character":25},"in_reply_to":"5c05216f_73726548","updated":"2020-11-30 17:25:59.000000000","message":"As per our conversation, let\u0027s do #1 but merge the deps and add new deps. The new dep will be a patch to the new client ansible role to add support for this parameter. We can merge the current patch which introduces that role but we won\u0027t change CI to use that role (with this patch) until we have a follow up patch on tripleo-ansible.","commit_id":"773d49e1147a8aabdf3e2fe25b33add48cdbd994"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"668ecfb4e0c13fc5ed0dee68cfb4a7e7c8abbd3c","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        osd: \"profile rbd pool\u003dimages\""},{"line_number":96,"context_line":"      key: \"AQBRgQ9eAAAAABAAv84zEilJYZPNuJ0Iwn9Ndg\u003d\u003d\""},{"line_number":97,"context_line":"      mode: \"0600\""},{"line_number":98,"context_line":"  CephExternalMultiConfig:"},{"line_number":99,"context_line":"    # create client conf and key file for two non-existent external ceph clusters"},{"line_number":100,"context_line":"    - cluster: \u0027ceph2\u0027"},{"line_number":101,"context_line":"      fsid: \u0027af25554b-42f6-4d2b-9b9b-d08a1132d3e8\u0027"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"4d8414d4_8b15cab0","line":98,"range":{"start_line":98,"start_character":2,"end_line":98,"end_character":25},"in_reply_to":"9f49464d_de1d5306","updated":"2020-11-30 17:46:55.000000000","message":"+1, let\u0027s keep this change around for follow-up patches and testing purposes","commit_id":"773d49e1147a8aabdf3e2fe25b33add48cdbd994"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"13852ac12b4d0de1609f8e583c14c2023df35b16","unresolved":true,"context_lines":[{"line_number":188,"context_line":"    foo: bar"},{"line_number":189,"context_line":"  NfsUrl: 127.0.0.1"},{"line_number":190,"context_line":"  CephMsgrSecureMode: true"},{"line_number":191,"context_line":"  CephAnsibleSkipClient: false"},{"line_number":192,"context_line":"  CephConfigPath: \"/etc/ceph\""},{"line_number":193,"context_line":"  LVMFilterEnabled: true"},{"line_number":194,"context_line":"  LVMFilterAllowlist:"},{"line_number":195,"context_line":"    - /dev/loop2"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"a51c2514_dffbab25","line":192,"range":{"start_line":191,"start_character":0,"end_line":192,"end_character":29},"updated":"2020-12-23 14:11:22.000000000","message":"By doing this we can make sure ceph-ansible client role is still tested using scenario001: this will be entirely removed during the next cycle.","commit_id":"453f36aa5f267eda755e7ff804c14fea9856eb6f"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"81f955c2998d09667c1fadba933725f5a09b46dd","unresolved":true,"context_lines":[{"line_number":189,"context_line":"  NfsUrl: 127.0.0.1"},{"line_number":190,"context_line":"  CephMsgrSecureMode: true"},{"line_number":191,"context_line":"  CephAnsibleSkipClient: false"},{"line_number":192,"context_line":"  CephConfigPath: \"/etc/ceph\""},{"line_number":193,"context_line":"  LVMFilterEnabled: true"},{"line_number":194,"context_line":"  LVMFilterAllowlist:"},{"line_number":195,"context_line":"    - /dev/loop2"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"7ac81fed_f4161850","line":192,"updated":"2020-12-23 14:12:16.000000000","message":"We\u0027re choosing to override the new defaults [1] so that we can still test the now deprecated ceph-ansible configuration. People might still use it for a while. We\u0027ll test the new defaults in 004 though we shouldn\u0027t need to update 004 as it should use the new defaults [1].\n\n[1] https://review.opendev.org/c/openstack/tripleo-heat-templates/+/760915/27/deployment/ceph-ansible/ceph-base.yaml","commit_id":"453f36aa5f267eda755e7ff804c14fea9856eb6f"}],"ci/environments/scenario004-standalone.yaml":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"002384e16a3ea5fac9606bf0786d2c7701f85fce","unresolved":true,"context_lines":[{"line_number":47,"context_line":"  CephDashboardPort: 8445"},{"line_number":48,"context_line":"  GrafanaDashboardPort: 3200"},{"line_number":49,"context_line":"  CephAnsibleSkipClient: true"},{"line_number":50,"context_line":"  CephConfigPath: \"/var/lib/tripleo-config/ceph\""},{"line_number":51,"context_line":"  CephAnsibleExtraConfig:"},{"line_number":52,"context_line":"    centos_package_dependencies: []"},{"line_number":53,"context_line":"    ceph_osd_docker_memory_limit: \u00271g\u0027"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"3939e692_82c34dd4","line":50,"updated":"2020-12-22 14:13:38.000000000","message":"do we need to customize this?","commit_id":"64f4f4cdffc3edabe7a4193303bc177e5e86cb40"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"95d9835bac02ffe340cb3fcbce2f9a4e92060f3d","unresolved":true,"context_lines":[{"line_number":47,"context_line":"  CephDashboardPort: 8445"},{"line_number":48,"context_line":"  GrafanaDashboardPort: 3200"},{"line_number":49,"context_line":"  CephAnsibleSkipClient: true"},{"line_number":50,"context_line":"  CephConfigPath: \"/var/lib/tripleo-config/ceph\""},{"line_number":51,"context_line":"  CephAnsibleExtraConfig:"},{"line_number":52,"context_line":"    centos_package_dependencies: []"},{"line_number":53,"context_line":"    ceph_osd_docker_memory_limit: \u00271g\u0027"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"e4a6c04f_4e962c73","line":50,"in_reply_to":"3939e692_82c34dd4","updated":"2020-12-22 15:08:34.000000000","message":"Yeah, this is the most relevant scenario because it allows to test the client config on most of the tripleo services (and of course can help us catching issues soon).","commit_id":"64f4f4cdffc3edabe7a4193303bc177e5e86cb40"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"9fc2a43b5e410829e1c0420ef24051584610f7a4","unresolved":true,"context_lines":[{"line_number":47,"context_line":"  CephDashboardPort: 8445"},{"line_number":48,"context_line":"  GrafanaDashboardPort: 3200"},{"line_number":49,"context_line":"  CephAnsibleSkipClient: true"},{"line_number":50,"context_line":"  CephConfigPath: \"/var/lib/tripleo-config/ceph\""},{"line_number":51,"context_line":"  CephAnsibleExtraConfig:"},{"line_number":52,"context_line":"    centos_package_dependencies: []"},{"line_number":53,"context_line":"    ceph_osd_docker_memory_limit: \u00271g\u0027"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"082a2e9b_018374e1","line":50,"in_reply_to":"e4a6c04f_4e962c73","updated":"2020-12-23 14:09:37.000000000","message":"Francesco and I talked more about this. \n\nFor 004 we\u0027ll remove these changes as they are the new defaults so they shouldn\u0027t be needed.\n\nhttps://review.opendev.org/c/openstack/tripleo-heat-templates/+/760915/26/deployment/ceph-ansible/ceph-base.yaml\n\nFor 001 we\u0027ll override them to true and /etc so we keep a ceph-ansible client scenario in CI. This way we excericse both client configurations for W before we remove ceph-ansible overrides in 001 in X.","commit_id":"64f4f4cdffc3edabe7a4193303bc177e5e86cb40"}],"deployment/ceph-ansible/ceph-base.yaml":[{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"d938c84ee6d605f14c184987c379c7998c8f270a","unresolved":false,"context_lines":[{"line_number":332,"context_line":"  CephAnsibleClientDisable:"},{"line_number":333,"context_line":"    description: |"},{"line_number":334,"context_line":"      This boolean (when true) prevents the ceph-ansible client role execution"},{"line_number":335,"context_line":"      by enabling the --limit option and excluding the clients group from the"},{"line_number":336,"context_line":"      provided inventory."},{"line_number":337,"context_line":"    type: boolean"},{"line_number":338,"context_line":"    default: false"},{"line_number":339,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1f621f24_69067a54","line":336,"range":{"start_line":335,"start_character":0,"end_line":336,"end_character":25},"updated":"2020-11-14 14:38:18.000000000","message":"\"by adding the ceph-ansible tag \u0027ceph_ansible_client_disabled\u0027 to the --skip-tags list\"","commit_id":"8eba0946d67931b9b741eddf852aa3fa0dab8d07"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"ab5e0c43a498299a026908529cf8e19fa2e6a029","unresolved":false,"context_lines":[{"line_number":332,"context_line":"  CephAnsibleClientDisable:"},{"line_number":333,"context_line":"    description: |"},{"line_number":334,"context_line":"      This boolean (when true) prevents the ceph-ansible client role execution"},{"line_number":335,"context_line":"      by enabling the --limit option and excluding the clients group from the"},{"line_number":336,"context_line":"      provided inventory."},{"line_number":337,"context_line":"    type: boolean"},{"line_number":338,"context_line":"    default: false"},{"line_number":339,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1f621f24_75d80452","line":336,"range":{"start_line":335,"start_character":0,"end_line":336,"end_character":25},"in_reply_to":"1f621f24_69067a54","updated":"2020-11-16 06:41:35.000000000","message":"\u003e \"by adding the ceph-ansible tag \u0027ceph_ansible_client_disabled\u0027 to\n \u003e the --skip-tags list\"\n\n+1 Thanks, forgot to update the description!","commit_id":"8eba0946d67931b9b741eddf852aa3fa0dab8d07"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"bde7005b13f7b991fba3ad211a95fbe13c1ffa57","unresolved":false,"context_lines":[{"line_number":695,"context_line":"                tasks_from: gather"},{"line_number":696,"context_line":"            - name: run ceph-ansible"},{"line_number":697,"context_line":"              include_role:"},{"line_number":698,"context_line":"                name: tripleo_ceph_run_ansible"},{"line_number":699,"context_line":"            - name: ensure ceph health is OK before proceeding"},{"line_number":700,"context_line":"              import_role:"},{"line_number":701,"context_line":"                role: ceph"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1f621f24_663ea9c1","line":698,"updated":"2020-11-13 18:28:12.000000000","message":"- name: configure ceph clients\n              include_role:\n                name: tripleo_ceph_client","commit_id":"8eba0946d67931b9b741eddf852aa3fa0dab8d07"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"d938c84ee6d605f14c184987c379c7998c8f270a","unresolved":false,"context_lines":[{"line_number":695,"context_line":"                tasks_from: gather"},{"line_number":696,"context_line":"            - name: run ceph-ansible"},{"line_number":697,"context_line":"              include_role:"},{"line_number":698,"context_line":"                name: tripleo_ceph_run_ansible"},{"line_number":699,"context_line":"            - name: ensure ceph health is OK before proceeding"},{"line_number":700,"context_line":"              import_role:"},{"line_number":701,"context_line":"                role: ceph"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1f621f24_951b2571","line":698,"in_reply_to":"1f621f24_663ea9c1","updated":"2020-11-14 14:38:18.000000000","message":"+            - name: configure ceph clients\n+              include_role:\n+                name: tripleo_ceph_client\n+              when: {get_param: CephAnsibleClientDisable}","commit_id":"8eba0946d67931b9b741eddf852aa3fa0dab8d07"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"ab5e0c43a498299a026908529cf8e19fa2e6a029","unresolved":false,"context_lines":[{"line_number":695,"context_line":"                tasks_from: gather"},{"line_number":696,"context_line":"            - name: run ceph-ansible"},{"line_number":697,"context_line":"              include_role:"},{"line_number":698,"context_line":"                name: tripleo_ceph_run_ansible"},{"line_number":699,"context_line":"            - name: ensure ceph health is OK before proceeding"},{"line_number":700,"context_line":"              import_role:"},{"line_number":701,"context_line":"                role: ceph"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1f621f24_35ea0cd7","line":698,"in_reply_to":"1f621f24_951b2571","updated":"2020-11-16 06:41:35.000000000","message":"\u003e +            - name: configure ceph clients\n \u003e +              include_role:\n \u003e +                name: tripleo_ceph_client\n \u003e +              when: {get_param: CephAnsibleClientDisable}\n\nexactly, we want this role when we skip the ceph-ansible one, so +1 for the condition here.\n/me updating the PS","commit_id":"8eba0946d67931b9b741eddf852aa3fa0dab8d07"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"80bf55e9112523994ac55d2d4d529f17fe192c74","unresolved":false,"context_lines":[{"line_number":695,"context_line":"            - name: run ceph-ansible"},{"line_number":696,"context_line":"              include_role:"},{"line_number":697,"context_line":"                name: tripleo_ceph_run_ansible"},{"line_number":698,"context_line":"            - name: configure ceph clients"},{"line_number":699,"context_line":"              include_role:"},{"line_number":700,"context_line":"                name: tripleo_ceph_client"},{"line_number":701,"context_line":"              when: {get_param: CephAnsibleClientDisable}"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1f621f24_5efc053d","line":698,"updated":"2020-11-16 11:59:28.000000000","message":"so can\u0027t we just add this here and \u0027ceph_client\u0027 in the list of skipped tags?\n\nI was in fact hoping it would be sufficient to just remove [1] from tripleo-common ... I would avoid adding a new parameter to \"edit inplace\" the list of tags and just add it to the default list\n\n1. https://github.com/openstack/tripleo-common/blob/master/tripleo_common/inventory.py#L327","commit_id":"313ba302cabec5179601e04d5730946f3d0c3649"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"6c51c8b1a75afaa8e643d81c79c2ee5ebcaa5ede","unresolved":false,"context_lines":[{"line_number":695,"context_line":"            - name: run ceph-ansible"},{"line_number":696,"context_line":"              include_role:"},{"line_number":697,"context_line":"                name: tripleo_ceph_run_ansible"},{"line_number":698,"context_line":"            - name: configure ceph clients"},{"line_number":699,"context_line":"              include_role:"},{"line_number":700,"context_line":"                name: tripleo_ceph_client"},{"line_number":701,"context_line":"              when: {get_param: CephAnsibleClientDisable}"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1f621f24_790c6493","line":698,"in_reply_to":"1f621f24_5efc053d","updated":"2020-11-17 17:36:40.000000000","message":"adding ceph_client to the list of skipped tags would make it hard to conditionally enable the role here though\n\nputting the import in ceph-client.yaml is not possible either because we can\u0027t manipulate the ceph-ansible tags in that template, we need to do that in ceph-base.yaml\n\ncopying ceph-base.yaml into a newer template for the only purpose of adding the import would only create additional maintenance work\n\nwe\u0027ll probably have to maintain this piece of code in stable/train only in the future, should we decide to backport the client role in train, but that seems the least problematic option","commit_id":"313ba302cabec5179601e04d5730946f3d0c3649"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"1e4cc7a777ee1f013e388967289890596babd3ee","unresolved":false,"context_lines":[{"line_number":575,"context_line":"        step_config: \u0027\u0027"},{"line_number":576,"context_line":"      docker_config: {}"},{"line_number":577,"context_line":"      config_settings: {}"},{"line_number":578,"context_line":"      external_deploy_tasks:"},{"line_number":579,"context_line":"        - name: ceph_base_external_deploy_init"},{"line_number":580,"context_line":"          when: step|int \u003d\u003d 1"},{"line_number":581,"context_line":"          tags:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"1f621f24_7320009d","line":578,"range":{"start_line":578,"start_character":6,"end_line":578,"end_character":27},"updated":"2020-11-17 20:35:24.000000000","message":"Because external_deploy_tasks are used these roles ONLY run on the undercloud. Thus, when we include the new client role on line 697 it generates files but ONLY rsyncs them /etc/ceph on the undercloud. Probably need to move line 697 out from under external_deploy_tasks.","commit_id":"c3385e63635b8fa5676fc91820489912a49093ea"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"fd3cdfdba1733a4be96467e90e4f53e3b1f261e0","unresolved":false,"context_lines":[{"line_number":575,"context_line":"        step_config: \u0027\u0027"},{"line_number":576,"context_line":"      docker_config: {}"},{"line_number":577,"context_line":"      config_settings: {}"},{"line_number":578,"context_line":"      external_deploy_tasks:"},{"line_number":579,"context_line":"        - name: ceph_base_external_deploy_init"},{"line_number":580,"context_line":"          when: step|int \u003d\u003d 1"},{"line_number":581,"context_line":"          tags:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"1f621f24_cd532d6c","line":578,"range":{"start_line":578,"start_character":6,"end_line":578,"end_character":27},"in_reply_to":"1f621f24_7320009d","updated":"2020-11-18 08:55:15.000000000","message":"I\u0027m not sure moving away from external_deploy_task is the best move (didn\u0027t test this kind of approach), and I\u0027m also trying to minimize the additional code we need to maintain in tht.\nAs per my comment [1], I\u0027m trying to leave this part as it is, changing the sync() logic a bit [2]\n\n[1] https://review.opendev.org/#/c/758039/34/tripleo_ansible/roles/tripleo_ceph_client/tasks/sync.yml@29\n\n[2] https://review.opendev.org/#/c/758039/34..35/tripleo_ansible/roles/tripleo_ceph_client/tasks/sync.yml","commit_id":"c3385e63635b8fa5676fc91820489912a49093ea"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"31b578a88b7bb654070ec40b9c2e8ce8a1878a97","unresolved":false,"context_lines":[{"line_number":575,"context_line":"        step_config: \u0027\u0027"},{"line_number":576,"context_line":"      docker_config: {}"},{"line_number":577,"context_line":"      config_settings: {}"},{"line_number":578,"context_line":"      external_deploy_tasks:"},{"line_number":579,"context_line":"        - name: ceph_base_external_deploy_init"},{"line_number":580,"context_line":"          when: step|int \u003d\u003d 1"},{"line_number":581,"context_line":"          tags:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"1f621f24_956bf7ef","line":578,"range":{"start_line":578,"start_character":6,"end_line":578,"end_character":27},"in_reply_to":"1f621f24_cd532d6c","updated":"2020-11-18 15:00:57.000000000","message":"[2] works for me. Thanks!","commit_id":"c3385e63635b8fa5676fc91820489912a49093ea"}]}