)]}'
{"deployment/ceilometer/ceilometer-base-container-puppet.yaml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"55dfc77c8b5eaba593032511b1fa82dfd3589b8d","unresolved":true,"context_lines":[{"line_number":102,"context_line":"conditions:"},{"line_number":103,"context_line":"  service_debug_unset: {equals : [{get_param: CeilometerDebug}, \u0027\u0027]}"},{"line_number":104,"context_line":"  ceilometer_qdr_publish: {equals: [{get_param: CeilometerQdrPublish}, true]}"},{"line_number":105,"context_line":"  memcached_tls: {equals: [{get_param: MemcachedTLS}, true]}"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"outputs:"},{"line_number":108,"context_line":"  role_data:"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"321141fd_9f31836d","line":105,"updated":"2021-03-01 21:55:35.000000000","message":"for the sake of template consistency, I think we should implement this same condition across the board, wherever possible.","commit_id":"9725836285387a97c65220b593e66ef569a7d60c"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"031115e1ce18c928c074619c9499a8145cac2327","unresolved":true,"context_lines":[{"line_number":102,"context_line":"conditions:"},{"line_number":103,"context_line":"  service_debug_unset: {equals : [{get_param: CeilometerDebug}, \u0027\u0027]}"},{"line_number":104,"context_line":"  ceilometer_qdr_publish: {equals: [{get_param: CeilometerQdrPublish}, true]}"},{"line_number":105,"context_line":"  memcached_tls: {equals: [{get_param: MemcachedTLS}, true]}"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"outputs:"},{"line_number":108,"context_line":"  role_data:"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"c1f80f1f_26af2c2c","line":105,"in_reply_to":"321141fd_9f31836d","updated":"2021-03-10 09:22:20.000000000","message":"Do you mean to add it to the swift templates?","commit_id":"9725836285387a97c65220b593e66ef569a7d60c"}],"deployment/heat/heat-base-puppet.yaml":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"8e81dbf06970c6004676b551dacb6ec1a4f4e0d6","unresolved":true,"context_lines":[{"line_number":209,"context_line":"          -"},{"line_number":210,"context_line":"            if:"},{"line_number":211,"context_line":"            - nontls_cache_enabled"},{"line_number":212,"context_line":"            - heat::cache::enabled: true"},{"line_number":213,"context_line":"              heat::cache::backend: \u0027dogpile.cache.memcached\u0027"},{"line_number":214,"context_line":"              heat::cache::resource_finder_caching: false"},{"line_number":215,"context_line":"            - {}"},{"line_number":216,"context_line":"            if:"},{"line_number":217,"context_line":"            - tls_cache_enabled"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"b2793c77_9e2facdd","line":214,"range":{"start_line":212,"start_character":14,"end_line":214,"end_character":57},"updated":"2021-03-16 13:23:41.000000000","message":"We don\u0027t even need these conditionals\n\n   heat::cache::enabled: {get_param: EnableCache}\n   heat::cache::backend: \u0027dogpile.cache.memcached\u0027\n   heat::cache::tls_enabled: {get_param: MemcacheTLS}\n   heat::cache::resource_finder_caching: false","commit_id":"32e80a82ed41f00dba3d719bd4edf962bb048241"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"dc643161b12847a241ac5c21cc9e6ad46589604a","unresolved":true,"context_lines":[{"line_number":209,"context_line":"          -"},{"line_number":210,"context_line":"            if:"},{"line_number":211,"context_line":"            - nontls_cache_enabled"},{"line_number":212,"context_line":"            - heat::cache::enabled: true"},{"line_number":213,"context_line":"              heat::cache::backend: \u0027dogpile.cache.memcached\u0027"},{"line_number":214,"context_line":"              heat::cache::resource_finder_caching: false"},{"line_number":215,"context_line":"            - {}"},{"line_number":216,"context_line":"            if:"},{"line_number":217,"context_line":"            - tls_cache_enabled"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"d6c15754_4c962ec7","line":214,"range":{"start_line":212,"start_character":14,"end_line":214,"end_character":57},"in_reply_to":"1f0df7f3_cac00712","updated":"2021-03-16 13:45:10.000000000","message":"I didn\u0027t switch the backend altogether just to be on the safe side, since we want to backport this back to train and wouldn\u0027t want to impact upgrades.","commit_id":"32e80a82ed41f00dba3d719bd4edf962bb048241"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"9575d89255481b0cf27feac53dfd1c2d6d791c36","unresolved":true,"context_lines":[{"line_number":209,"context_line":"          -"},{"line_number":210,"context_line":"            if:"},{"line_number":211,"context_line":"            - nontls_cache_enabled"},{"line_number":212,"context_line":"            - heat::cache::enabled: true"},{"line_number":213,"context_line":"              heat::cache::backend: \u0027dogpile.cache.memcached\u0027"},{"line_number":214,"context_line":"              heat::cache::resource_finder_caching: false"},{"line_number":215,"context_line":"            - {}"},{"line_number":216,"context_line":"            if:"},{"line_number":217,"context_line":"            - tls_cache_enabled"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"1f0df7f3_cac00712","line":214,"range":{"start_line":212,"start_character":14,"end_line":214,"end_character":57},"in_reply_to":"3f1b3eb7_f43ddd4a","updated":"2021-03-16 13:36:48.000000000","message":"Ok well you could just put the condition around the backend instead of the rest.  can we just switch to pymemcache across the board?","commit_id":"32e80a82ed41f00dba3d719bd4edf962bb048241"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"5f66eb9fa17a5b84587d0d32299ea56498cae852","unresolved":false,"context_lines":[{"line_number":209,"context_line":"          -"},{"line_number":210,"context_line":"            if:"},{"line_number":211,"context_line":"            - nontls_cache_enabled"},{"line_number":212,"context_line":"            - heat::cache::enabled: true"},{"line_number":213,"context_line":"              heat::cache::backend: \u0027dogpile.cache.memcached\u0027"},{"line_number":214,"context_line":"              heat::cache::resource_finder_caching: false"},{"line_number":215,"context_line":"            - {}"},{"line_number":216,"context_line":"            if:"},{"line_number":217,"context_line":"            - tls_cache_enabled"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"811c7a10_dea17186","line":214,"range":{"start_line":212,"start_character":14,"end_line":214,"end_character":57},"in_reply_to":"60c5ec29_a5ebbfa3","updated":"2021-03-16 14:12:54.000000000","message":"Ok, I updated the patch with your proposal","commit_id":"32e80a82ed41f00dba3d719bd4edf962bb048241"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"94dda59f8373fbebb519c8841615db1d4959ca1c","unresolved":true,"context_lines":[{"line_number":209,"context_line":"          -"},{"line_number":210,"context_line":"            if:"},{"line_number":211,"context_line":"            - nontls_cache_enabled"},{"line_number":212,"context_line":"            - heat::cache::enabled: true"},{"line_number":213,"context_line":"              heat::cache::backend: \u0027dogpile.cache.memcached\u0027"},{"line_number":214,"context_line":"              heat::cache::resource_finder_caching: false"},{"line_number":215,"context_line":"            - {}"},{"line_number":216,"context_line":"            if:"},{"line_number":217,"context_line":"            - tls_cache_enabled"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"3f1b3eb7_f43ddd4a","line":214,"range":{"start_line":212,"start_character":14,"end_line":214,"end_character":57},"in_reply_to":"b2793c77_9e2facdd","updated":"2021-03-16 13:33:54.000000000","message":"dogpile.cache.memcached doesn\u0027t support TLS, so that wouldn\u0027t work","commit_id":"32e80a82ed41f00dba3d719bd4edf962bb048241"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"306dd8e6e740eca854fb1dd951d1171bf5f1e1b6","unresolved":true,"context_lines":[{"line_number":209,"context_line":"          -"},{"line_number":210,"context_line":"            if:"},{"line_number":211,"context_line":"            - nontls_cache_enabled"},{"line_number":212,"context_line":"            - heat::cache::enabled: true"},{"line_number":213,"context_line":"              heat::cache::backend: \u0027dogpile.cache.memcached\u0027"},{"line_number":214,"context_line":"              heat::cache::resource_finder_caching: false"},{"line_number":215,"context_line":"            - {}"},{"line_number":216,"context_line":"            if:"},{"line_number":217,"context_line":"            - tls_cache_enabled"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"60c5ec29_a5ebbfa3","line":214,"range":{"start_line":212,"start_character":14,"end_line":214,"end_character":57},"in_reply_to":"d6c15754_4c962ec7","updated":"2021-03-16 13:48:19.000000000","message":"Ok you can just do\n\n   heat::cache::enabled: {get_param: EnableCache}\n   heat::cache::tls_enabled: {get_param: MemcacheTLS}\n   heat::cache::resource_finder_caching: false\n - if:\n   - tls_cache_enabled\n   - heat::cache::backend: \u0027dogpile.cache.pymemcached\u0027\n   - heat::cache::backend: \u0027dogpile.cache.memcached\u0027","commit_id":"32e80a82ed41f00dba3d719bd4edf962bb048241"},{"author":{"_account_id":27954,"name":"Moisés Guimarães de Medeiros","email":"guimaraes@pm.me","username":"moguimar"},"change_message_id":"d6cedcf1a346ebc860d494db89999b0987223ab2","unresolved":true,"context_lines":[{"line_number":208,"context_line":"            heat::cache::resource_finder_caching: false"},{"line_number":209,"context_line":"            if:"},{"line_number":210,"context_line":"              - tls_cache_enabled"},{"line_number":211,"context_line":"              - heat::cache::backend: \u0027dogpile.cache.pymemcached\u0027"},{"line_number":212,"context_line":"              - heat::cache::backend: \u0027dogpile.cache.memcached\u0027"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"b899449a_107f547e","line":211,"range":{"start_line":211,"start_character":63,"end_line":211,"end_character":64},"updated":"2021-03-16 14:21:48.000000000","message":"there is no trailing d in dogpile.cache.pymemcache","commit_id":"5ac7b36862c8d05be62693f8cd59dbf9735887dc"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"04750a6e70924864907e6f6a9bf13aec61db4655","unresolved":false,"context_lines":[{"line_number":208,"context_line":"            heat::cache::resource_finder_caching: false"},{"line_number":209,"context_line":"            if:"},{"line_number":210,"context_line":"              - tls_cache_enabled"},{"line_number":211,"context_line":"              - heat::cache::backend: \u0027dogpile.cache.pymemcached\u0027"},{"line_number":212,"context_line":"              - heat::cache::backend: \u0027dogpile.cache.memcached\u0027"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"52928fe7_57a59441","line":211,"range":{"start_line":211,"start_character":63,"end_line":211,"end_character":64},"in_reply_to":"b899449a_107f547e","updated":"2021-03-16 14:30:14.000000000","message":"Done","commit_id":"5ac7b36862c8d05be62693f8cd59dbf9735887dc"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"76fa888d53ff3298f35c5dc614efb4c2fa0cfd8a","unresolved":true,"context_lines":[{"line_number":206,"context_line":"            heat::cache::enabled: {get_param: EnableCache}"},{"line_number":207,"context_line":"            heat::cache::tls_enabled: {get_param: MemcachedTLS}"},{"line_number":208,"context_line":"            heat::cache::resource_finder_caching: false"},{"line_number":209,"context_line":"            if:"},{"line_number":210,"context_line":"              - tls_cache_enabled"},{"line_number":211,"context_line":"              - heat::cache::backend: \u0027dogpile.cache.pymemcache\u0027"},{"line_number":212,"context_line":"              - heat::cache::backend: \u0027dogpile.cache.memcached\u0027"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"261cdfda_cdfd440c","line":212,"range":{"start_line":209,"start_character":0,"end_line":212,"end_character":63},"updated":"2021-03-17 17:44:14.000000000","message":"You can also do something like the heat::logging::debug has\n\n  heat::cache::backend:\n    if:\n    - tls_cache_enabled\n    - \u0027dogpile.cache.pymemcache\u0027\n    - \u0027dogpile.cache.memcached\u0027","commit_id":"1ceb521805875b41ebfafb1ff7a862df4df6fd16"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"c09f53d86dffa0d954e36ff1e0f4d8f448263201","unresolved":false,"context_lines":[{"line_number":206,"context_line":"            heat::cache::enabled: {get_param: EnableCache}"},{"line_number":207,"context_line":"            heat::cache::tls_enabled: {get_param: MemcachedTLS}"},{"line_number":208,"context_line":"            heat::cache::resource_finder_caching: false"},{"line_number":209,"context_line":"            if:"},{"line_number":210,"context_line":"              - tls_cache_enabled"},{"line_number":211,"context_line":"              - heat::cache::backend: \u0027dogpile.cache.pymemcache\u0027"},{"line_number":212,"context_line":"              - heat::cache::backend: \u0027dogpile.cache.memcached\u0027"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"d1cb5d62_ca281eb2","line":212,"range":{"start_line":209,"start_character":0,"end_line":212,"end_character":63},"in_reply_to":"261cdfda_cdfd440c","updated":"2021-03-17 18:32:51.000000000","message":"Ack","commit_id":"1ceb521805875b41ebfafb1ff7a862df4df6fd16"}],"deployment/keystone/keystone-container-puppet.yaml":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"8e81dbf06970c6004676b551dacb6ec1a4f4e0d6","unresolved":true,"context_lines":[{"line_number":495,"context_line":"            if:"},{"line_number":496,"context_line":"            - nontls_cache_enabled"},{"line_number":497,"context_line":"            - keystone::cache::enabled: true"},{"line_number":498,"context_line":"              keystone::cache::backend: \u0027dogpile.cache.memcached\u0027"},{"line_number":499,"context_line":"            - {}"},{"line_number":500,"context_line":"            if:"},{"line_number":501,"context_line":"            - tls_cache_enabled"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"8d81097f_609621b6","line":498,"updated":"2021-03-16 13:23:41.000000000","message":"same comment as the heat service","commit_id":"32e80a82ed41f00dba3d719bd4edf962bb048241"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"5f66eb9fa17a5b84587d0d32299ea56498cae852","unresolved":false,"context_lines":[{"line_number":495,"context_line":"            if:"},{"line_number":496,"context_line":"            - nontls_cache_enabled"},{"line_number":497,"context_line":"            - keystone::cache::enabled: true"},{"line_number":498,"context_line":"              keystone::cache::backend: \u0027dogpile.cache.memcached\u0027"},{"line_number":499,"context_line":"            - {}"},{"line_number":500,"context_line":"            if:"},{"line_number":501,"context_line":"            - tls_cache_enabled"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"2cc7e14a_a2519c33","line":498,"in_reply_to":"8d81097f_609621b6","updated":"2021-03-16 14:12:54.000000000","message":"Done","commit_id":"32e80a82ed41f00dba3d719bd4edf962bb048241"}],"deployment/nova/nova-base-puppet.yaml":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"888a9e8bd2d231db8f9b217f647c554b74cf2b61","unresolved":true,"context_lines":[{"line_number":264,"context_line":"    and:"},{"line_number":265,"context_line":"      - {equals : [{get_param: EnableCache}, true]}"},{"line_number":266,"context_line":"      - {equals : [{get_param: MemcachedTLS}, true]}"},{"line_number":267,"context_line":"  cache_disabled: {equals : [{get_param: EnableCache}, false]}"},{"line_number":268,"context_line":"  enable_sqlalchemy_collectd: {equals : [{get_param: EnableSQLAlchemyCollectd}, true]}"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"resources:"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"e280cca8_84060b33","line":267,"updated":"2021-02-21 06:19:37.000000000","message":"How about implementing these condicitons\n\n```\nconditions:\n  cache_enabled: {qeuals: [{get_param: EnableCache} true, true]}\n  memcached_tls_enabled: {qeuals: [{get_param: MemcachedTLS} true, true]}\n```\n\nand the below logic in config_settings like;\n       \n```\n- if:\n  - cache_enabled\n  - map_merge:\n    - nova::cache::enabled: true\n      nova::cache::backend: \u0027dogpile.cache.pymemcache\u0027\n    - if:\n      - memcached_tls_enabled:\n      - nova::cache::tls_enabled: true\n      - {}\n  - {}\n```\n\nThis allows us to maintain basic cache parameters in a single place.","commit_id":"7600338c165d6170bfd48fd405a7a7d8d58540cf"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"f6d117415e56536a4f5aac168107b2b7ddc12503","unresolved":true,"context_lines":[{"line_number":264,"context_line":"    and:"},{"line_number":265,"context_line":"      - {equals : [{get_param: EnableCache}, true]}"},{"line_number":266,"context_line":"      - {equals : [{get_param: MemcachedTLS}, true]}"},{"line_number":267,"context_line":"  cache_disabled: {equals : [{get_param: EnableCache}, false]}"},{"line_number":268,"context_line":"  enable_sqlalchemy_collectd: {equals : [{get_param: EnableSQLAlchemyCollectd}, true]}"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"resources:"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"2544deda_e57a114f","line":267,"in_reply_to":"07cbc5e5_81428bea","updated":"2021-02-23 13:44:29.000000000","message":"Oh, sorry I didn\u0027t notice that the different backend is used for TLS. Regarding the fact we have only one common parameter, the current implementation looks reasonable because it helps us to understand set of parameters actually used.\n\nCan we update cache_enabled to non_tls_cache_enabled ? My little concern here is that the current name, cache_enabled, is not very clearly explaining what it is and would cause a wrong usage later.","commit_id":"7600338c165d6170bfd48fd405a7a7d8d58540cf"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"6bd3f21f8f933f780e8801b2c077c43b8a3f65c6","unresolved":false,"context_lines":[{"line_number":264,"context_line":"    and:"},{"line_number":265,"context_line":"      - {equals : [{get_param: EnableCache}, true]}"},{"line_number":266,"context_line":"      - {equals : [{get_param: MemcachedTLS}, true]}"},{"line_number":267,"context_line":"  cache_disabled: {equals : [{get_param: EnableCache}, false]}"},{"line_number":268,"context_line":"  enable_sqlalchemy_collectd: {equals : [{get_param: EnableSQLAlchemyCollectd}, true]}"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"resources:"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"e6d42130_5c736571","line":267,"in_reply_to":"2544deda_e57a114f","updated":"2021-02-23 14:34:12.000000000","message":"Ok, I\u0027m updating the patch.","commit_id":"7600338c165d6170bfd48fd405a7a7d8d58540cf"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"9cbee02e48c73d7c23c5780780ceba1ee189395f","unresolved":true,"context_lines":[{"line_number":264,"context_line":"    and:"},{"line_number":265,"context_line":"      - {equals : [{get_param: EnableCache}, true]}"},{"line_number":266,"context_line":"      - {equals : [{get_param: MemcachedTLS}, true]}"},{"line_number":267,"context_line":"  cache_disabled: {equals : [{get_param: EnableCache}, false]}"},{"line_number":268,"context_line":"  enable_sqlalchemy_collectd: {equals : [{get_param: EnableSQLAlchemyCollectd}, true]}"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"resources:"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"07cbc5e5_81428bea","line":267,"in_reply_to":"e280cca8_84060b33","updated":"2021-02-22 09:42:41.000000000","message":"I did that initially (see patchset 13), but I want to change the caching backend to dogpile.cache.pymemcache only when TLS is enabled. This is because we want to backport this back to Train, and switching to a new library with a minor upgrade is probably a bad idea (even though the original library is unmaintained for over 4 years). So I\u0027m switching to pymemcache only when the user intentionally enables Memcache TLS.","commit_id":"7600338c165d6170bfd48fd405a7a7d8d58540cf"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"79b57b9d8ac535aac83008488d3fc6235ffd1823","unresolved":true,"context_lines":[{"line_number":362,"context_line":"          - nova::cache::enabled: true"},{"line_number":363,"context_line":"            nova::cache::backend: \u0027dogpile.cache.memcached\u0027"},{"line_number":364,"context_line":"          - {}"},{"line_number":365,"context_line":"          if:"},{"line_number":366,"context_line":"          - memcached_tls_enabled"},{"line_number":367,"context_line":"          - nova::cache::enabled: true"},{"line_number":368,"context_line":"            nova::cache::tls_enabled: true"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"750a4c71_1a23bcca","line":365,"range":{"start_line":365,"start_character":8,"end_line":365,"end_character":9},"updated":"2021-02-21 06:20:22.000000000","message":"just wondering why this works without \u0027-\u0027 here","commit_id":"7600338c165d6170bfd48fd405a7a7d8d58540cf"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"9cbee02e48c73d7c23c5780780ceba1ee189395f","unresolved":false,"context_lines":[{"line_number":362,"context_line":"          - nova::cache::enabled: true"},{"line_number":363,"context_line":"            nova::cache::backend: \u0027dogpile.cache.memcached\u0027"},{"line_number":364,"context_line":"          - {}"},{"line_number":365,"context_line":"          if:"},{"line_number":366,"context_line":"          - memcached_tls_enabled"},{"line_number":367,"context_line":"          - nova::cache::enabled: true"},{"line_number":368,"context_line":"            nova::cache::tls_enabled: true"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"d0a6bae4_04a55b82","line":365,"range":{"start_line":365,"start_character":8,"end_line":365,"end_character":9},"in_reply_to":"750a4c71_1a23bcca","updated":"2021-02-22 09:42:41.000000000","message":"Strange, I\u0027m adding it.","commit_id":"7600338c165d6170bfd48fd405a7a7d8d58540cf"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"79b57b9d8ac535aac83008488d3fc6235ffd1823","unresolved":true,"context_lines":[{"line_number":368,"context_line":"            nova::cache::tls_enabled: true"},{"line_number":369,"context_line":"            nova::cache::backend: \u0027dogpile.cache.pymemcache\u0027"},{"line_number":370,"context_line":"          - {}"},{"line_number":371,"context_line":"          if:"},{"line_number":372,"context_line":"          - cache_disabled"},{"line_number":373,"context_line":"          - nova::cache::enabled: false"},{"line_number":374,"context_line":"          - {}"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"67428043_2a07caff","line":371,"range":{"start_line":371,"start_character":8,"end_line":371,"end_character":9},"updated":"2021-02-21 06:20:22.000000000","message":"ditto","commit_id":"7600338c165d6170bfd48fd405a7a7d8d58540cf"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"9cbee02e48c73d7c23c5780780ceba1ee189395f","unresolved":false,"context_lines":[{"line_number":368,"context_line":"            nova::cache::tls_enabled: true"},{"line_number":369,"context_line":"            nova::cache::backend: \u0027dogpile.cache.pymemcache\u0027"},{"line_number":370,"context_line":"          - {}"},{"line_number":371,"context_line":"          if:"},{"line_number":372,"context_line":"          - cache_disabled"},{"line_number":373,"context_line":"          - nova::cache::enabled: false"},{"line_number":374,"context_line":"          - {}"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"0813fd18_114bc79c","line":371,"range":{"start_line":371,"start_character":8,"end_line":371,"end_character":9},"in_reply_to":"67428043_2a07caff","updated":"2021-02-22 09:42:41.000000000","message":"Done","commit_id":"7600338c165d6170bfd48fd405a7a7d8d58540cf"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"8e81dbf06970c6004676b551dacb6ec1a4f4e0d6","unresolved":true,"context_lines":[{"line_number":359,"context_line":"        - if:"},{"line_number":360,"context_line":"          - nontls_cache_enabled"},{"line_number":361,"context_line":"          - nova::cache::enabled: true"},{"line_number":362,"context_line":"            nova::cache::backend: \u0027dogpile.cache.memcached\u0027"},{"line_number":363,"context_line":"          - {}"},{"line_number":364,"context_line":"        - if:"},{"line_number":365,"context_line":"          - tls_cache_enabled"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"44dca03b_65d9c0bf","line":362,"updated":"2021-03-16 13:23:41.000000000","message":"same","commit_id":"32e80a82ed41f00dba3d719bd4edf962bb048241"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"5f66eb9fa17a5b84587d0d32299ea56498cae852","unresolved":false,"context_lines":[{"line_number":359,"context_line":"        - if:"},{"line_number":360,"context_line":"          - nontls_cache_enabled"},{"line_number":361,"context_line":"          - nova::cache::enabled: true"},{"line_number":362,"context_line":"            nova::cache::backend: \u0027dogpile.cache.memcached\u0027"},{"line_number":363,"context_line":"          - {}"},{"line_number":364,"context_line":"        - if:"},{"line_number":365,"context_line":"          - tls_cache_enabled"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"5d17941d_ac7342ae","line":362,"in_reply_to":"44dca03b_65d9c0bf","updated":"2021-03-16 14:12:54.000000000","message":"Done","commit_id":"32e80a82ed41f00dba3d719bd4edf962bb048241"},{"author":{"_account_id":27954,"name":"Moisés Guimarães de Medeiros","email":"guimaraes@pm.me","username":"moguimar"},"change_message_id":"0ac183fb8bf831426bec262b6cf8c16035cb2504","unresolved":true,"context_lines":[{"line_number":356,"context_line":"          nova::cache::tls_enabled: {get_param: MemcachedTLS}"},{"line_number":357,"context_line":"          if:"},{"line_number":358,"context_line":"            - tls_cache_enabled"},{"line_number":359,"context_line":"            - nova::cache::backend: \u0027dogpile.cache.pymemcached\u0027"},{"line_number":360,"context_line":"            - nova::cache::backend: \u0027dogpile.cache.memcached\u0027"},{"line_number":361,"context_line":"        - if:"},{"line_number":362,"context_line":"          - compute_upgrade_level_empty"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"06540801_25e92216","line":359,"range":{"start_line":359,"start_character":61,"end_line":359,"end_character":62},"updated":"2021-03-16 14:23:21.000000000","message":"same here","commit_id":"5ac7b36862c8d05be62693f8cd59dbf9735887dc"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"04750a6e70924864907e6f6a9bf13aec61db4655","unresolved":false,"context_lines":[{"line_number":356,"context_line":"          nova::cache::tls_enabled: {get_param: MemcachedTLS}"},{"line_number":357,"context_line":"          if:"},{"line_number":358,"context_line":"            - tls_cache_enabled"},{"line_number":359,"context_line":"            - nova::cache::backend: \u0027dogpile.cache.pymemcached\u0027"},{"line_number":360,"context_line":"            - nova::cache::backend: \u0027dogpile.cache.memcached\u0027"},{"line_number":361,"context_line":"        - if:"},{"line_number":362,"context_line":"          - compute_upgrade_level_empty"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"ba59b54f_36854bc9","line":359,"range":{"start_line":359,"start_character":61,"end_line":359,"end_character":62},"in_reply_to":"06540801_25e92216","updated":"2021-03-16 14:30:14.000000000","message":"Done","commit_id":"5ac7b36862c8d05be62693f8cd59dbf9735887dc"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"04bf7426977885eb040d4008df7992d7a28ef60c","unresolved":true,"context_lines":[{"line_number":258,"context_line":"  service_debug_unset: {equals : [{get_param: NovaDebug}, \u0027\u0027]}"},{"line_number":259,"context_line":"  tls_cache_enabled:"},{"line_number":260,"context_line":"    and:"},{"line_number":261,"context_line":"      - {equals : [{get_param: EnableCache}, true]}"},{"line_number":262,"context_line":"      - {equals : [{get_param: MemcachedTLS}, true]}"},{"line_number":263,"context_line":"  cache_disabled: {equals : [{get_param: EnableCache}, false]}"},{"line_number":264,"context_line":"  enable_sqlalchemy_collectd: {equals : [{get_param: EnableSQLAlchemyCollectd}, true]}"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"f6681abd_b17cf4ea","line":261,"updated":"2021-03-17 23:28:55.000000000","message":"nit, I think this can be simplified to ...\n\n  and:\n    - {get_param: EnableCache}\n    - {get_param: MemcachedTLS}\n\n ... since both are parameters are booleans.\n\nThis is likely true for the two following conditions as well.","commit_id":"1ceb521805875b41ebfafb1ff7a862df4df6fd16"}]}