)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"38a06e36a1456ee6011f396bd954b6e324e143f4","unresolved":true,"context_lines":[{"line_number":14,"context_line":"able to mount a different path than /etc/ceph wich"},{"line_number":15,"context_line":"was hardcoded."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Depends-On: Iaabb66cd26f0246defe391a4e34f4eab3c3c5fee"},{"line_number":18,"context_line":"Change-Id: I36673367411cc8d68ffb9ec4a2fbff64ebf12f29"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":24,"id":"75b13189_88186ab0","line":17,"updated":"2020-11-26 13:26:12.000000000","message":"should we make it depend on the tripleo-ansible change too?","commit_id":"28408a04ad44e6028187bf47aea58bfee93cd2fa"}],"ci/environments/scenario001-standalone.yaml":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"38a06e36a1456ee6011f396bd954b6e324e143f4","unresolved":true,"context_lines":[{"line_number":188,"context_line":"    foo: bar"},{"line_number":189,"context_line":"  NfsUrl: 127.0.0.1"},{"line_number":190,"context_line":"  CephMsgrSecureMode: true"},{"line_number":191,"context_line":"  CephConfigPath: \"/var/lib/tripleo-config/ceph\""},{"line_number":192,"context_line":"  LVMFilterEnabled: true"},{"line_number":193,"context_line":"  LVMFilterAllowlist:"},{"line_number":194,"context_line":"    - /dev/loop2"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"00bbb55d_56094d79","line":191,"updated":"2020-11-26 13:26:12.000000000","message":"let\u0027s keep this in https://review.opendev.org/c/openstack/tripleo-heat-templates/+/760915","commit_id":"28408a04ad44e6028187bf47aea58bfee93cd2fa"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"fd54b3d633de6654314369efba9e9d387155a711","unresolved":true,"context_lines":[{"line_number":188,"context_line":"    foo: bar"},{"line_number":189,"context_line":"  NfsUrl: 127.0.0.1"},{"line_number":190,"context_line":"  CephMsgrSecureMode: true"},{"line_number":191,"context_line":"  CephConfigPath: \"/var/lib/tripleo-config/ceph\""},{"line_number":192,"context_line":"  LVMFilterEnabled: true"},{"line_number":193,"context_line":"  LVMFilterAllowlist:"},{"line_number":194,"context_line":"    - /dev/loop2"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"8e3acdeb_4da49d35","line":191,"range":{"start_line":191,"start_character":2,"end_line":191,"end_character":48},"updated":"2020-11-26 13:52:59.000000000","message":"will remove this before merging","commit_id":"86759e544ae59b7ec338b3e5456baed3764ad83c"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"cb64142dd243cb0ef77d2a3764cb69321b89c042","unresolved":true,"context_lines":[{"line_number":188,"context_line":"    foo: bar"},{"line_number":189,"context_line":"  NfsUrl: 127.0.0.1"},{"line_number":190,"context_line":"  CephMsgrSecureMode: true"},{"line_number":191,"context_line":"  CephConfigPath: \"/var/lib/tripleo-config/ceph\""},{"line_number":192,"context_line":"  LVMFilterEnabled: true"},{"line_number":193,"context_line":"  LVMFilterAllowlist:"},{"line_number":194,"context_line":"    - /dev/loop2"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"6e246ec0_28f33f06","line":191,"updated":"2020-11-26 14:24:34.000000000","message":"remove","commit_id":"10cf3c87469c2d755d539ece618be3c7738fc452"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"427848cf4c67e9ed721bc1fa18787737a10391ed","unresolved":true,"context_lines":[{"line_number":188,"context_line":"    foo: bar"},{"line_number":189,"context_line":"  NfsUrl: 127.0.0.1"},{"line_number":190,"context_line":"  CephMsgrSecureMode: true"},{"line_number":191,"context_line":"  CephConfigPath: \"/var/lib/tripleo-config/ceph\""},{"line_number":192,"context_line":"  LVMFilterEnabled: true"},{"line_number":193,"context_line":"  LVMFilterAllowlist:"},{"line_number":194,"context_line":"    - /dev/loop2"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"b4d3fb66_b488fc56","line":191,"in_reply_to":"6e246ec0_28f33f06","updated":"2020-11-26 14:56:42.000000000","message":"need it for testing purposes, will remove later","commit_id":"10cf3c87469c2d755d539ece618be3c7738fc452"}],"ci/environments/scenario004-standalone.yaml":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"a84069e54ee11d223c827d913b60c271906d1a91","unresolved":true,"context_lines":[{"line_number":61,"context_line":"  CephRgwKey: \u0027AQDLOh1VgEp6FRAAFzT7Zw+Y9V6JJExQAsRnRQ\u003d\u003d\u0027"},{"line_number":62,"context_line":"  CephAnsiblePlaybookVerbosity: 1"},{"line_number":63,"context_line":"  CephAnsibleRepo: \"tripleo-centos-ceph-nautilus\""},{"line_number":64,"context_line":"  CephConfigPath: \"/var/lib/tripleo-config/ceph\""},{"line_number":65,"context_line":"  CephAnsibleEnvironmentVariables:"},{"line_number":66,"context_line":"    ANSIBLE_SSH_RETRIES: 4"},{"line_number":67,"context_line":"    DEFAULT_FORKS: 3"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"807a4f15_88802891","line":64,"updated":"2020-11-24 18:12:11.000000000","message":"missing CephAnsibleClientDisable","commit_id":"c31498dc754932e30252fb286aa9254af29122ba"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"b6c55675f4fc06f9228a3e6ee5e2f62b90e0ff0b","unresolved":true,"context_lines":[{"line_number":61,"context_line":"  CephRgwKey: \u0027AQDLOh1VgEp6FRAAFzT7Zw+Y9V6JJExQAsRnRQ\u003d\u003d\u0027"},{"line_number":62,"context_line":"  CephAnsiblePlaybookVerbosity: 1"},{"line_number":63,"context_line":"  CephAnsibleRepo: \"tripleo-centos-ceph-nautilus\""},{"line_number":64,"context_line":"  CephConfigPath: \"/var/lib/tripleo-config/ceph\""},{"line_number":65,"context_line":"  CephAnsibleClientDisable: true"},{"line_number":66,"context_line":"  CephAnsibleEnvironmentVariables:"},{"line_number":67,"context_line":"    ANSIBLE_SSH_RETRIES: 4"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"21216e4e_28c2afac","line":64,"updated":"2020-11-25 13:10:23.000000000","message":"should we add CephAnsibleClientDisable here too?","commit_id":"3248f4e65ab6958a71f90a63ef8e6d8994f7708d"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"38a06e36a1456ee6011f396bd954b6e324e143f4","unresolved":true,"context_lines":[{"line_number":61,"context_line":"  CephRgwKey: \u0027AQDLOh1VgEp6FRAAFzT7Zw+Y9V6JJExQAsRnRQ\u003d\u003d\u0027"},{"line_number":62,"context_line":"  CephAnsiblePlaybookVerbosity: 1"},{"line_number":63,"context_line":"  CephAnsibleRepo: \"tripleo-centos-ceph-nautilus\""},{"line_number":64,"context_line":"  CephConfigPath: \"/var/lib/tripleo-config/ceph\""},{"line_number":65,"context_line":"  CephAnsibleEnvironmentVariables:"},{"line_number":66,"context_line":"    ANSIBLE_SSH_RETRIES: 4"},{"line_number":67,"context_line":"    DEFAULT_FORKS: 3"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"b521431a_9c1cc1c5","line":64,"updated":"2020-11-26 13:26:12.000000000","message":"keep this in https://review.opendev.org/c/openstack/tripleo-heat-templates/+/760915","commit_id":"28408a04ad44e6028187bf47aea58bfee93cd2fa"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"fd54b3d633de6654314369efba9e9d387155a711","unresolved":true,"context_lines":[{"line_number":61,"context_line":"  CephRgwKey: \u0027AQDLOh1VgEp6FRAAFzT7Zw+Y9V6JJExQAsRnRQ\u003d\u003d\u0027"},{"line_number":62,"context_line":"  CephAnsiblePlaybookVerbosity: 1"},{"line_number":63,"context_line":"  CephAnsibleRepo: \"tripleo-centos-ceph-nautilus\""},{"line_number":64,"context_line":"  CephConfigPath: \"/var/lib/tripleo-config/ceph\""},{"line_number":65,"context_line":"  CephAnsibleEnvironmentVariables:"},{"line_number":66,"context_line":"    ANSIBLE_SSH_RETRIES: 4"},{"line_number":67,"context_line":"    DEFAULT_FORKS: 3"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"b16a49f1_1a366a29","line":64,"range":{"start_line":64,"start_character":2,"end_line":64,"end_character":48},"updated":"2020-11-26 13:52:59.000000000","message":"will remove this before merging","commit_id":"86759e544ae59b7ec338b3e5456baed3764ad83c"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"cb64142dd243cb0ef77d2a3764cb69321b89c042","unresolved":true,"context_lines":[{"line_number":61,"context_line":"  CephRgwKey: \u0027AQDLOh1VgEp6FRAAFzT7Zw+Y9V6JJExQAsRnRQ\u003d\u003d\u0027"},{"line_number":62,"context_line":"  CephAnsiblePlaybookVerbosity: 1"},{"line_number":63,"context_line":"  CephAnsibleRepo: \"tripleo-centos-ceph-nautilus\""},{"line_number":64,"context_line":"  CephConfigPath: \"/var/lib/tripleo-config/ceph\""},{"line_number":65,"context_line":"  CephAnsibleEnvironmentVariables:"},{"line_number":66,"context_line":"    ANSIBLE_SSH_RETRIES: 4"},{"line_number":67,"context_line":"    DEFAULT_FORKS: 3"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"db9f8fff_7ba92ce5","line":64,"updated":"2020-11-26 14:24:34.000000000","message":"remove","commit_id":"10cf3c87469c2d755d539ece618be3c7738fc452"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"427848cf4c67e9ed721bc1fa18787737a10391ed","unresolved":true,"context_lines":[{"line_number":61,"context_line":"  CephRgwKey: \u0027AQDLOh1VgEp6FRAAFzT7Zw+Y9V6JJExQAsRnRQ\u003d\u003d\u0027"},{"line_number":62,"context_line":"  CephAnsiblePlaybookVerbosity: 1"},{"line_number":63,"context_line":"  CephAnsibleRepo: \"tripleo-centos-ceph-nautilus\""},{"line_number":64,"context_line":"  CephConfigPath: \"/var/lib/tripleo-config/ceph\""},{"line_number":65,"context_line":"  CephAnsibleEnvironmentVariables:"},{"line_number":66,"context_line":"    ANSIBLE_SSH_RETRIES: 4"},{"line_number":67,"context_line":"    DEFAULT_FORKS: 3"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"a6df51a7_e792dadd","line":64,"in_reply_to":"db9f8fff_7ba92ce5","updated":"2020-11-26 14:56:42.000000000","message":"need it for testing purposes, will remove later","commit_id":"10cf3c87469c2d755d539ece618be3c7738fc452"}],"deployment/ceph-ansible/ceph-base.yaml":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"849e905dd63d2672a4434b51430ae57bc59febcc","unresolved":true,"context_lines":[{"line_number":333,"context_line":"  EnableInternalTLS:"},{"line_number":334,"context_line":"    type: boolean"},{"line_number":335,"context_line":"    default: false"},{"line_number":336,"context_line":"  CephConfigPath:"},{"line_number":337,"context_line":"    type: string"},{"line_number":338,"context_line":"    default: \"/etc/ceph\""},{"line_number":339,"context_line":"    description: The path where the Ceph Cluster config file are stored."}],"source_content_type":"text/x-yaml","patch_set":11,"id":"91f163ac_15e0064c","line":336,"updated":"2020-11-24 11:47:55.000000000","message":"if we don\u0027t consume this in the template, we don\u0027t need to add it","commit_id":"c051a1a64535d07769d9ae5fa8105cca062b8e70"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"17618a166456618dc2fbf6f784ae68262dbc1a86","unresolved":true,"context_lines":[{"line_number":333,"context_line":"  EnableInternalTLS:"},{"line_number":334,"context_line":"    type: boolean"},{"line_number":335,"context_line":"    default: false"},{"line_number":336,"context_line":"  CephConfigPath:"},{"line_number":337,"context_line":"    type: string"},{"line_number":338,"context_line":"    default: \"/etc/ceph\""},{"line_number":339,"context_line":"    description: The path where the Ceph Cluster config file are stored."}],"source_content_type":"text/x-yaml","patch_set":11,"id":"43ca1396_a74aee7e","line":336,"in_reply_to":"91f163ac_15e0064c","updated":"2020-11-24 12:06:12.000000000","message":"we will here [1], when we need to set the \u0027tripleo_ceph_conf\u0027 variable which is the path the tripleo_ceph_client role uses to push the rendered files \n\n[1] https://review.opendev.org/c/openstack/tripleo-heat-templates/+/760915","commit_id":"c051a1a64535d07769d9ae5fa8105cca062b8e70"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"a84069e54ee11d223c827d913b60c271906d1a91","unresolved":true,"context_lines":[{"line_number":333,"context_line":"  EnableInternalTLS:"},{"line_number":334,"context_line":"    type: boolean"},{"line_number":335,"context_line":"    default: false"},{"line_number":336,"context_line":"  CephConfigPath:"},{"line_number":337,"context_line":"    type: string"},{"line_number":338,"context_line":"    default: \"/etc/ceph\""},{"line_number":339,"context_line":"    description: The path where the Ceph Cluster config file are stored."}],"source_content_type":"text/x-yaml","patch_set":14,"id":"f967e935_78db7b24","line":336,"updated":"2020-11-24 18:12:11.000000000","message":"you can remove this","commit_id":"c31498dc754932e30252fb286aa9254af29122ba"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"e10c6114c4900b2529dc2693c5a037aa3bc98081","unresolved":false,"context_lines":[{"line_number":333,"context_line":"  EnableInternalTLS:"},{"line_number":334,"context_line":"    type: boolean"},{"line_number":335,"context_line":"    default: false"},{"line_number":336,"context_line":"  CephConfigPath:"},{"line_number":337,"context_line":"    type: string"},{"line_number":338,"context_line":"    default: \"/etc/ceph\""},{"line_number":339,"context_line":"    description: The path where the Ceph Cluster config file are stored."}],"source_content_type":"text/x-yaml","patch_set":14,"id":"516d4633_d0e248db","line":336,"in_reply_to":"f967e935_78db7b24","updated":"2020-11-25 06:24:11.000000000","message":"ack, removing this for now, we probably need to add this parameter in a follow up review when the new client role is introduced (and the tripleo_ceph_conf_home is set)","commit_id":"c31498dc754932e30252fb286aa9254af29122ba"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"cb64142dd243cb0ef77d2a3764cb69321b89c042","unresolved":true,"context_lines":[{"line_number":333,"context_line":"  EnableInternalTLS:"},{"line_number":334,"context_line":"    type: boolean"},{"line_number":335,"context_line":"    default: false"},{"line_number":336,"context_line":"  CephConfigPath:"},{"line_number":337,"context_line":"    type: string"},{"line_number":338,"context_line":"    default: \"/etc/ceph\""},{"line_number":339,"context_line":"    description: The path where the Ceph Cluster config files are stored."}],"source_content_type":"text/x-yaml","patch_set":27,"id":"806116b8_783dce1d","line":336,"updated":"2020-11-26 14:24:34.000000000","message":"I think we only need CephAnsibleClientDisable","commit_id":"10cf3c87469c2d755d539ece618be3c7738fc452"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"427848cf4c67e9ed721bc1fa18787737a10391ed","unresolved":false,"context_lines":[{"line_number":333,"context_line":"  EnableInternalTLS:"},{"line_number":334,"context_line":"    type: boolean"},{"line_number":335,"context_line":"    default: false"},{"line_number":336,"context_line":"  CephConfigPath:"},{"line_number":337,"context_line":"    type: string"},{"line_number":338,"context_line":"    default: \"/etc/ceph\""},{"line_number":339,"context_line":"    description: The path where the Ceph Cluster config files are stored."}],"source_content_type":"text/x-yaml","patch_set":27,"id":"7af48c34_49abad39","line":336,"in_reply_to":"806116b8_783dce1d","updated":"2020-11-26 14:56:42.000000000","message":"I need this because I want to consume this parameter in the tripleo_ceph_client role.\nL712 will be:\n\n```\n             include_role:\n               name: tripleo_ceph_client\n             vars:\n               tripleo_ceph_config_home: {get_param: CephConfigPath}\n```\nI\u0027ll do in the next PS","commit_id":"10cf3c87469c2d755d539ece618be3c7738fc452"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"3f2f8b35b728738cc1dbe30b32d6f1fb411fd9ae","unresolved":true,"context_lines":[{"line_number":337,"context_line":"    type: string"},{"line_number":338,"context_line":"    default: \"/etc/ceph\""},{"line_number":339,"context_line":"    description: The path where the Ceph Cluster config files are stored."},{"line_number":340,"context_line":"  CephAnsibleClientDisable:"},{"line_number":341,"context_line":"    description: |"},{"line_number":342,"context_line":"      This boolean (when true) prevents the ceph-ansible client role execution"},{"line_number":343,"context_line":"      by adding the ceph-ansible tag \u0027ceph_client\u0027 to the --skip-tags list."}],"source_content_type":"text/x-yaml","patch_set":34,"id":"ea702993_01167318","line":340,"updated":"2020-12-03 22:17:58.000000000","message":"We have lots of XxxEnable THT parameters, so I\u0027m curious why you chose a \u0027Disable\u0027 name that defaults to False. For me, the double-negative \"disabled is False\" feels awkward.","commit_id":"4a26a0a88ce226bcf21c369d51ebb4057798e949"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"8f9ae9c4ec652b2619f75bf8c56bb0a1739799f6","unresolved":false,"context_lines":[{"line_number":337,"context_line":"    type: string"},{"line_number":338,"context_line":"    default: \"/etc/ceph\""},{"line_number":339,"context_line":"    description: The path where the Ceph Cluster config files are stored."},{"line_number":340,"context_line":"  CephAnsibleClientDisable:"},{"line_number":341,"context_line":"    description: |"},{"line_number":342,"context_line":"      This boolean (when true) prevents the ceph-ansible client role execution"},{"line_number":343,"context_line":"      by adding the ceph-ansible tag \u0027ceph_client\u0027 to the --skip-tags list."}],"source_content_type":"text/x-yaml","patch_set":34,"id":"7bfc5443_7d227242","line":340,"in_reply_to":"c57bf672_5f8fc9f7","updated":"2020-12-04 07:45:08.000000000","message":"Done","commit_id":"4a26a0a88ce226bcf21c369d51ebb4057798e949"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"9893293630f9032fac2e9b300995aaa490dd69b4","unresolved":true,"context_lines":[{"line_number":337,"context_line":"    type: string"},{"line_number":338,"context_line":"    default: \"/etc/ceph\""},{"line_number":339,"context_line":"    description: The path where the Ceph Cluster config files are stored."},{"line_number":340,"context_line":"  CephAnsibleClientDisable:"},{"line_number":341,"context_line":"    description: |"},{"line_number":342,"context_line":"      This boolean (when true) prevents the ceph-ansible client role execution"},{"line_number":343,"context_line":"      by adding the ceph-ansible tag \u0027ceph_client\u0027 to the --skip-tags list."}],"source_content_type":"text/x-yaml","patch_set":34,"id":"c57bf672_5f8fc9f7","line":340,"in_reply_to":"ea702993_01167318","updated":"2020-12-04 07:44:27.000000000","message":"I see your point, but I\u0027m not sure how to change this name:  it\u0027s about disabling or not the ceph-ansible client role, perhaps something like CephAnsibleSkipClient works better, and it\u0027s consistent with the other variable used to build the list of SkipTags","commit_id":"4a26a0a88ce226bcf21c369d51ebb4057798e949"}],"deployment/cinder/cinder-backup-container-puppet.yaml":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"849e905dd63d2672a4434b51430ae57bc59febcc","unresolved":true,"context_lines":[{"line_number":162,"context_line":"              dest: \"/\""},{"line_number":163,"context_line":"              merge: true"},{"line_number":164,"context_line":"              preserve_properties: true"},{"line_number":165,"context_line":"            - source: \"/var/lib/kolla/config_files/src-ceph/\""},{"line_number":166,"context_line":"              dest: {get_param: CephConfigPath}"},{"line_number":167,"context_line":"              merge: true"},{"line_number":168,"context_line":"              preserve_properties: true"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"d529de96_2f96bed1","line":165,"updated":"2020-11-24 11:47:55.000000000","message":"it\u0027s the source path we want to change, not the dest","commit_id":"c051a1a64535d07769d9ae5fa8105cca062b8e70"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"849e905dd63d2672a4434b51430ae57bc59febcc","unresolved":true,"context_lines":[{"line_number":184,"context_line":"              recurse: true"},{"line_number":185,"context_line":"            - path:"},{"line_number":186,"context_line":"                str_replace:"},{"line_number":187,"context_line":"                  template: CEPH_CONFIG_HOME/CLUSTER.client.USER.keyring"},{"line_number":188,"context_line":"                  params:"},{"line_number":189,"context_line":"                    CEPH_CONFIG_HOME: {get_param: CephConfigPath}"},{"line_number":190,"context_line":"                    CLUSTER: {get_param: CephClusterName}"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"b95630db_163c82c1","line":187,"updated":"2020-11-24 11:47:55.000000000","message":"this does not need to be changed","commit_id":"c051a1a64535d07769d9ae5fa8105cca062b8e70"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"e10c6114c4900b2529dc2693c5a037aa3bc98081","unresolved":false,"context_lines":[{"line_number":184,"context_line":"              recurse: true"},{"line_number":185,"context_line":"            - path:"},{"line_number":186,"context_line":"                str_replace:"},{"line_number":187,"context_line":"                  template: CEPH_CONFIG_HOME/CLUSTER.client.USER.keyring"},{"line_number":188,"context_line":"                  params:"},{"line_number":189,"context_line":"                    CEPH_CONFIG_HOME: {get_param: CephConfigPath}"},{"line_number":190,"context_line":"                    CLUSTER: {get_param: CephClusterName}"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"a32f20fc_317d9ad2","line":187,"in_reply_to":"b95630db_163c82c1","updated":"2020-11-25 06:24:11.000000000","message":"Done","commit_id":"c051a1a64535d07769d9ae5fa8105cca062b8e70"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"a84069e54ee11d223c827d913b60c271906d1a91","unresolved":true,"context_lines":[{"line_number":126,"context_line":"            cinder::backup::ceph::backup_ceph_conf:"},{"line_number":127,"context_line":"              list_join:"},{"line_number":128,"context_line":"              - \u0027\u0027"},{"line_number":129,"context_line":"              - - {get_param: CephConfigPath}"},{"line_number":130,"context_line":"                - \u0027/\u0027"},{"line_number":131,"context_line":"                - {get_param: CephClusterName}"},{"line_number":132,"context_line":"                - \u0027.conf\u0027"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"8223459e_859bde1b","line":129,"updated":"2020-11-24 18:12:11.000000000","message":"this shouldn\u0027t change","commit_id":"c31498dc754932e30252fb286aa9254af29122ba"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"b6c55675f4fc06f9228a3e6ee5e2f62b90e0ff0b","unresolved":false,"context_lines":[{"line_number":126,"context_line":"            cinder::backup::ceph::backup_ceph_conf:"},{"line_number":127,"context_line":"              list_join:"},{"line_number":128,"context_line":"              - \u0027\u0027"},{"line_number":129,"context_line":"              - - {get_param: CephConfigPath}"},{"line_number":130,"context_line":"                - \u0027/\u0027"},{"line_number":131,"context_line":"                - {get_param: CephClusterName}"},{"line_number":132,"context_line":"                - \u0027.conf\u0027"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"a4aa9a76_7a939c5c","line":129,"in_reply_to":"4ded61ee_f63ce249","updated":"2020-11-25 13:10:23.000000000","message":"cinder::backup::ceph is a class [1] so every time it is called, if this parameter is set it will be consumed (that is when the cinder-backup service is enabled)\n\nhttps://github.com/openstack/puppet-cinder/blob/master/manifests/backup/ceph.pp#L60","commit_id":"c31498dc754932e30252fb286aa9254af29122ba"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"e10c6114c4900b2529dc2693c5a037aa3bc98081","unresolved":false,"context_lines":[{"line_number":126,"context_line":"            cinder::backup::ceph::backup_ceph_conf:"},{"line_number":127,"context_line":"              list_join:"},{"line_number":128,"context_line":"              - \u0027\u0027"},{"line_number":129,"context_line":"              - - {get_param: CephConfigPath}"},{"line_number":130,"context_line":"                - \u0027/\u0027"},{"line_number":131,"context_line":"                - {get_param: CephClusterName}"},{"line_number":132,"context_line":"                - \u0027.conf\u0027"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"4ded61ee_f63ce249","line":129,"in_reply_to":"8223459e_859bde1b","updated":"2020-11-25 06:24:11.000000000","message":"you mean it should stay /etc/ceph? I\u0027m wondering where this parameter is consumed in puppet-tripleo because I don\u0027t see it :/\nRestoring it","commit_id":"c31498dc754932e30252fb286aa9254af29122ba"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"38a06e36a1456ee6011f396bd954b6e324e143f4","unresolved":true,"context_lines":[{"line_number":86,"context_line":"  MonitoringSubscriptionCinderBackup:"},{"line_number":87,"context_line":"    default: \u0027overcloud-cinder-backup\u0027"},{"line_number":88,"context_line":"    type: string"},{"line_number":89,"context_line":"  CephConfigPath:"},{"line_number":90,"context_line":"    type: string"},{"line_number":91,"context_line":"    default: \"/etc/ceph\""},{"line_number":92,"context_line":"    description: The path where the Ceph Cluster config files are stored."}],"source_content_type":"text/x-yaml","patch_set":24,"id":"1b7e2fb6_e71704ba","line":89,"updated":"2020-11-26 13:26:12.000000000","message":"seems unnecessary","commit_id":"28408a04ad44e6028187bf47aea58bfee93cd2fa"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"64f8ac5fca3ece906337e818d62010ab1455e51e","unresolved":false,"context_lines":[{"line_number":86,"context_line":"  MonitoringSubscriptionCinderBackup:"},{"line_number":87,"context_line":"    default: \u0027overcloud-cinder-backup\u0027"},{"line_number":88,"context_line":"    type: string"},{"line_number":89,"context_line":"  CephConfigPath:"},{"line_number":90,"context_line":"    type: string"},{"line_number":91,"context_line":"    default: \"/etc/ceph\""},{"line_number":92,"context_line":"    description: The path where the Ceph Cluster config files are stored."}],"source_content_type":"text/x-yaml","patch_set":24,"id":"f7abbe94_b2423abc","line":89,"in_reply_to":"1b7e2fb6_e71704ba","updated":"2020-11-26 13:32:39.000000000","message":"Done","commit_id":"28408a04ad44e6028187bf47aea58bfee93cd2fa"}],"deployment/cinder/cinder-backup-pacemaker-puppet.yaml":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"a84069e54ee11d223c827d913b60c271906d1a91","unresolved":true,"context_lines":[{"line_number":142,"context_line":"            tripleo::profile::pacemaker::cinder::backup_bundle::docker_volumes: {get_attr: [CinderCommon, cinder_backup_volumes]}"},{"line_number":143,"context_line":"            tripleo::profile::pacemaker::cinder::backup_bundle::docker_environment: {get_attr: [CinderCommon, cinder_backup_environment]}"},{"line_number":144,"context_line":"            tripleo::profile::pacemaker::cinder::backup_bundle::container_backend: {get_param: ContainerCli}"},{"line_number":145,"context_line":"            tripleo::profile::pacemaker::cinder::backup_bundle::ceph_conf: {get_param: CephConfigPath}"},{"line_number":146,"context_line":"            cinder::backup::manage_service: false"},{"line_number":147,"context_line":"            cinder::backup::enabled: false"},{"line_number":148,"context_line":"      service_config_settings:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"6b301885_6ff3734e","line":145,"updated":"2020-11-24 18:12:11.000000000","message":"not this but tripleo::profile::pacemaker::cinder::backup_bundle::ceph_conf","commit_id":"c31498dc754932e30252fb286aa9254af29122ba"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"e10c6114c4900b2529dc2693c5a037aa3bc98081","unresolved":false,"context_lines":[{"line_number":142,"context_line":"            tripleo::profile::pacemaker::cinder::backup_bundle::docker_volumes: {get_attr: [CinderCommon, cinder_backup_volumes]}"},{"line_number":143,"context_line":"            tripleo::profile::pacemaker::cinder::backup_bundle::docker_environment: {get_attr: [CinderCommon, cinder_backup_environment]}"},{"line_number":144,"context_line":"            tripleo::profile::pacemaker::cinder::backup_bundle::container_backend: {get_param: ContainerCli}"},{"line_number":145,"context_line":"            tripleo::profile::pacemaker::cinder::backup_bundle::ceph_conf: {get_param: CephConfigPath}"},{"line_number":146,"context_line":"            cinder::backup::manage_service: false"},{"line_number":147,"context_line":"            cinder::backup::enabled: false"},{"line_number":148,"context_line":"      service_config_settings:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"a2aa8b45_d843c52f","line":145,"in_reply_to":"6b301885_6ff3734e","updated":"2020-11-25 06:24:11.000000000","message":"Sorry don\u0027t get this, the param is:\n\ntripleo::profile::pacemaker::cinder::backup_bundle::ceph_conf\n\nand should be correct, right?","commit_id":"c31498dc754932e30252fb286aa9254af29122ba"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"b6c55675f4fc06f9228a3e6ee5e2f62b90e0ff0b","unresolved":false,"context_lines":[{"line_number":142,"context_line":"            tripleo::profile::pacemaker::cinder::backup_bundle::docker_volumes: {get_attr: [CinderCommon, cinder_backup_volumes]}"},{"line_number":143,"context_line":"            tripleo::profile::pacemaker::cinder::backup_bundle::docker_environment: {get_attr: [CinderCommon, cinder_backup_environment]}"},{"line_number":144,"context_line":"            tripleo::profile::pacemaker::cinder::backup_bundle::container_backend: {get_param: ContainerCli}"},{"line_number":145,"context_line":"            tripleo::profile::pacemaker::cinder::backup_bundle::ceph_conf: {get_param: CephConfigPath}"},{"line_number":146,"context_line":"            cinder::backup::manage_service: false"},{"line_number":147,"context_line":"            cinder::backup::enabled: false"},{"line_number":148,"context_line":"      service_config_settings:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"81689d9a_a8bebfb1","line":145,"in_reply_to":"a2aa8b45_d843c52f","updated":"2020-11-25 13:10:23.000000000","message":"it\u0027s correct yes, it might have been a stale draft comment I had","commit_id":"c31498dc754932e30252fb286aa9254af29122ba"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"3f2f8b35b728738cc1dbe30b32d6f1fb411fd9ae","unresolved":true,"context_lines":[{"line_number":86,"context_line":"  CephConfigPath:"},{"line_number":87,"context_line":"    type: string"},{"line_number":88,"context_line":"    default: \"/etc/ceph\""},{"line_number":89,"context_line":"    description: The path where the Ceph Cluster config files are stored."},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"conditions:"},{"line_number":92,"context_line":"  docker_enabled: {equals: [{get_param: ContainerCli}, \u0027docker\u0027]}"}],"source_content_type":"text/x-yaml","patch_set":34,"id":"8a2994ee_f0bb74c5","line":89,"updated":"2020-12-03 22:17:58.000000000","message":"nit: append with something like \"... on the host.\"","commit_id":"4a26a0a88ce226bcf21c369d51ebb4057798e949"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"9893293630f9032fac2e9b300995aaa490dd69b4","unresolved":false,"context_lines":[{"line_number":86,"context_line":"  CephConfigPath:"},{"line_number":87,"context_line":"    type: string"},{"line_number":88,"context_line":"    default: \"/etc/ceph\""},{"line_number":89,"context_line":"    description: The path where the Ceph Cluster config files are stored."},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"conditions:"},{"line_number":92,"context_line":"  docker_enabled: {equals: [{get_param: ContainerCli}, \u0027docker\u0027]}"}],"source_content_type":"text/x-yaml","patch_set":34,"id":"848c7cb9_41fb5dd4","line":89,"in_reply_to":"8a2994ee_f0bb74c5","updated":"2020-12-04 07:44:27.000000000","message":"Done","commit_id":"4a26a0a88ce226bcf21c369d51ebb4057798e949"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"3f2f8b35b728738cc1dbe30b32d6f1fb411fd9ae","unresolved":true,"context_lines":[{"line_number":142,"context_line":"            tripleo::profile::pacemaker::cinder::backup_bundle::docker_volumes: {get_attr: [CinderCommon, cinder_backup_volumes]}"},{"line_number":143,"context_line":"            tripleo::profile::pacemaker::cinder::backup_bundle::docker_environment: {get_attr: [CinderCommon, cinder_backup_environment]}"},{"line_number":144,"context_line":"            tripleo::profile::pacemaker::cinder::backup_bundle::container_backend: {get_param: ContainerCli}"},{"line_number":145,"context_line":"            tripleo::profile::pacemaker::cinder::backup_bundle::ceph_conf: {get_param: CephConfigPath}"},{"line_number":146,"context_line":"            cinder::backup::manage_service: false"},{"line_number":147,"context_line":"            cinder::backup::enabled: false"},{"line_number":148,"context_line":"      service_config_settings:"}],"source_content_type":"text/x-yaml","patch_set":34,"id":"3b51797c_e2189994","line":145,"updated":"2020-12-03 22:17:58.000000000","message":"-1: the puppet-tripleo parameter is now \u0027ceph_conf_path\u0027\n\nhttps://review.opendev.org/c/openstack/puppet-tripleo/+/763545/24/manifests/profile/pacemaker/cinder/backup_bundle.pp#68","commit_id":"4a26a0a88ce226bcf21c369d51ebb4057798e949"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"9893293630f9032fac2e9b300995aaa490dd69b4","unresolved":false,"context_lines":[{"line_number":142,"context_line":"            tripleo::profile::pacemaker::cinder::backup_bundle::docker_volumes: {get_attr: [CinderCommon, cinder_backup_volumes]}"},{"line_number":143,"context_line":"            tripleo::profile::pacemaker::cinder::backup_bundle::docker_environment: {get_attr: [CinderCommon, cinder_backup_environment]}"},{"line_number":144,"context_line":"            tripleo::profile::pacemaker::cinder::backup_bundle::container_backend: {get_param: ContainerCli}"},{"line_number":145,"context_line":"            tripleo::profile::pacemaker::cinder::backup_bundle::ceph_conf: {get_param: CephConfigPath}"},{"line_number":146,"context_line":"            cinder::backup::manage_service: false"},{"line_number":147,"context_line":"            cinder::backup::enabled: false"},{"line_number":148,"context_line":"      service_config_settings:"}],"source_content_type":"text/x-yaml","patch_set":34,"id":"d1ab301f_b9573004","line":145,"in_reply_to":"3b51797c_e2189994","updated":"2020-12-04 07:44:27.000000000","message":"Done","commit_id":"4a26a0a88ce226bcf21c369d51ebb4057798e949"}],"deployment/cinder/cinder-volume-container-puppet.yaml":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"a84069e54ee11d223c827d913b60c271906d1a91","unresolved":true,"context_lines":[{"line_number":244,"context_line":"            tripleo::profile::base::cinder::volume::rbd::cinder_rbd_extra_pools: {get_param: CinderRbdExtraPools}"},{"line_number":245,"context_line":"            tripleo::profile::base::cinder::volume::rbd::cinder_rbd_secret_uuid: {get_param: CephClusterFSID}"},{"line_number":246,"context_line":"            tripleo::profile::base::cinder::volume::rbd::cinder_rbd_user_name: {get_param: CephClientUserName}"},{"line_number":247,"context_line":"            tripleo::profile::base::cinder::volume::cinder_rbd_ceph_conf: {get_param: CephConfigPath}"},{"line_number":248,"context_line":"            tripleo::profile::base::cinder::volume::rbd::cinder_rbd_flatten_volume_from_snapshot: {get_param: CinderRbdFlattenVolumeFromSnapshot}"},{"line_number":249,"context_line":"            # NOTE: bind IP is found in hiera replacing the network name with the local node IP"},{"line_number":250,"context_line":"            # for the given network; replacement examples (eg. for internal_api):"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"67cc285e_b5b8bfb8","line":247,"updated":"2020-11-24 18:12:11.000000000","message":"not this but tripleo::profile::base::cinder::volume::cinder_rbd_ceph_conf","commit_id":"c31498dc754932e30252fb286aa9254af29122ba"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"a84069e54ee11d223c827d913b60c271906d1a91","unresolved":true,"context_lines":[{"line_number":326,"context_line":"              recurse: true"},{"line_number":327,"context_line":"            - path:"},{"line_number":328,"context_line":"                str_replace:"},{"line_number":329,"context_line":"                  template: CEPH_CONFIG_HOME/CLUSTER.client.USER.keyring"},{"line_number":330,"context_line":"                  params:"},{"line_number":331,"context_line":"                    CEPH_CONFIG_HOME: {get_param: CephConfigPath}"},{"line_number":332,"context_line":"                    CLUSTER: {get_param: CephClusterName}"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"ab2cd80b_78c95d96","line":329,"updated":"2020-11-24 18:12:11.000000000","message":"don\u0027t change this, it runs within the container","commit_id":"c31498dc754932e30252fb286aa9254af29122ba"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"e10c6114c4900b2529dc2693c5a037aa3bc98081","unresolved":false,"context_lines":[{"line_number":326,"context_line":"              recurse: true"},{"line_number":327,"context_line":"            - path:"},{"line_number":328,"context_line":"                str_replace:"},{"line_number":329,"context_line":"                  template: CEPH_CONFIG_HOME/CLUSTER.client.USER.keyring"},{"line_number":330,"context_line":"                  params:"},{"line_number":331,"context_line":"                    CEPH_CONFIG_HOME: {get_param: CephConfigPath}"},{"line_number":332,"context_line":"                    CLUSTER: {get_param: CephClusterName}"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"6f569b19_7ef3d8b1","line":329,"in_reply_to":"ab2cd80b_78c95d96","updated":"2020-11-25 06:24:11.000000000","message":"+1","commit_id":"c31498dc754932e30252fb286aa9254af29122ba"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"38a06e36a1456ee6011f396bd954b6e324e143f4","unresolved":true,"context_lines":[{"line_number":244,"context_line":"            tripleo::profile::base::cinder::volume::rbd::cinder_rbd_extra_pools: {get_param: CinderRbdExtraPools}"},{"line_number":245,"context_line":"            tripleo::profile::base::cinder::volume::rbd::cinder_rbd_secret_uuid: {get_param: CephClusterFSID}"},{"line_number":246,"context_line":"            tripleo::profile::base::cinder::volume::rbd::cinder_rbd_user_name: {get_param: CephClientUserName}"},{"line_number":247,"context_line":"            tripleo::profile::base::cinder::volume::cinder_rbd_ceph_conf: {get_param: CephConfigPath}"},{"line_number":248,"context_line":"            tripleo::profile::base::cinder::volume::rbd::cinder_rbd_flatten_volume_from_snapshot: {get_param: CinderRbdFlattenVolumeFromSnapshot}"},{"line_number":249,"context_line":"            # NOTE: bind IP is found in hiera replacing the network name with the local node IP"},{"line_number":250,"context_line":"            # for the given network; replacement examples (eg. for internal_api):"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"abc9ec58_f15b2dd9","line":247,"updated":"2020-11-26 13:26:12.000000000","message":"I think we also need tripleo::profile::pacemaker::cinder::volume_bundle::ceph_conf","commit_id":"28408a04ad44e6028187bf47aea58bfee93cd2fa"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"283241d0c05baceee311e522179ba3d3af2203d0","unresolved":true,"context_lines":[{"line_number":244,"context_line":"            tripleo::profile::base::cinder::volume::rbd::cinder_rbd_extra_pools: {get_param: CinderRbdExtraPools}"},{"line_number":245,"context_line":"            tripleo::profile::base::cinder::volume::rbd::cinder_rbd_secret_uuid: {get_param: CephClusterFSID}"},{"line_number":246,"context_line":"            tripleo::profile::base::cinder::volume::rbd::cinder_rbd_user_name: {get_param: CephClientUserName}"},{"line_number":247,"context_line":"            tripleo::profile::base::cinder::volume::cinder_rbd_ceph_conf: {get_param: CephConfigPath}"},{"line_number":248,"context_line":"            tripleo::profile::base::cinder::volume::rbd::cinder_rbd_flatten_volume_from_snapshot: {get_param: CinderRbdFlattenVolumeFromSnapshot}"},{"line_number":249,"context_line":"            # NOTE: bind IP is found in hiera replacing the network name with the local node IP"},{"line_number":250,"context_line":"            # for the given network; replacement examples (eg. for internal_api):"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"b37eaff9_449a09c1","line":247,"in_reply_to":"abc9ec58_f15b2dd9","updated":"2020-11-26 13:33:14.000000000","message":"and that goes in cinder-volume-pacemaker-puppet.yaml","commit_id":"28408a04ad44e6028187bf47aea58bfee93cd2fa"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"68f1b59bde283d3dd5f2019f852d9fb118e0716d","unresolved":true,"context_lines":[{"line_number":244,"context_line":"            tripleo::profile::base::cinder::volume::rbd::cinder_rbd_extra_pools: {get_param: CinderRbdExtraPools}"},{"line_number":245,"context_line":"            tripleo::profile::base::cinder::volume::rbd::cinder_rbd_secret_uuid: {get_param: CephClusterFSID}"},{"line_number":246,"context_line":"            tripleo::profile::base::cinder::volume::rbd::cinder_rbd_user_name: {get_param: CephClientUserName}"},{"line_number":247,"context_line":"            tripleo::profile::base::cinder::volume::cinder_rbd_ceph_conf: {get_param: CephConfigPath}"},{"line_number":248,"context_line":"            tripleo::profile::base::cinder::volume::rbd::cinder_rbd_flatten_volume_from_snapshot: {get_param: CinderRbdFlattenVolumeFromSnapshot}"},{"line_number":249,"context_line":"            # NOTE: bind IP is found in hiera replacing the network name with the local node IP"},{"line_number":250,"context_line":"            # for the given network; replacement examples (eg. for internal_api):"}],"source_content_type":"text/x-yaml","patch_set":33,"id":"579d91fb_705c39c6","line":247,"updated":"2020-11-30 22:34:04.000000000","message":"::cinder_rbd_ceph_conf_path","commit_id":"a9e72de2baad19a6d801aa2f47a1129001fe48d6"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"42f88d4093f0617cb554d60e749201f346ef721c","unresolved":false,"context_lines":[{"line_number":244,"context_line":"            tripleo::profile::base::cinder::volume::rbd::cinder_rbd_extra_pools: {get_param: CinderRbdExtraPools}"},{"line_number":245,"context_line":"            tripleo::profile::base::cinder::volume::rbd::cinder_rbd_secret_uuid: {get_param: CephClusterFSID}"},{"line_number":246,"context_line":"            tripleo::profile::base::cinder::volume::rbd::cinder_rbd_user_name: {get_param: CephClientUserName}"},{"line_number":247,"context_line":"            tripleo::profile::base::cinder::volume::cinder_rbd_ceph_conf: {get_param: CephConfigPath}"},{"line_number":248,"context_line":"            tripleo::profile::base::cinder::volume::rbd::cinder_rbd_flatten_volume_from_snapshot: {get_param: CinderRbdFlattenVolumeFromSnapshot}"},{"line_number":249,"context_line":"            # NOTE: bind IP is found in hiera replacing the network name with the local node IP"},{"line_number":250,"context_line":"            # for the given network; replacement examples (eg. for internal_api):"}],"source_content_type":"text/x-yaml","patch_set":33,"id":"60394a0f_d4dc996b","line":247,"in_reply_to":"579d91fb_705c39c6","updated":"2020-12-01 08:43:08.000000000","message":"Done","commit_id":"a9e72de2baad19a6d801aa2f47a1129001fe48d6"}],"deployment/cinder/cinder-volume-pacemaker-puppet.yaml":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"38a06e36a1456ee6011f396bd954b6e324e143f4","unresolved":true,"context_lines":[{"line_number":71,"context_line":"    default:"},{"line_number":72,"context_line":"      tag: openstack.cinder.volume"},{"line_number":73,"context_line":"      file: /var/log/containers/cinder/cinder-volume.log"},{"line_number":74,"context_line":"  CephConfigPath:"},{"line_number":75,"context_line":"    type: string"},{"line_number":76,"context_line":"    default: \"/etc/ceph\""},{"line_number":77,"context_line":"    description: The path where the Ceph Cluster config files are stored."}],"source_content_type":"text/x-yaml","patch_set":24,"id":"59744383_d6fa4260","line":74,"updated":"2020-11-26 13:26:12.000000000","message":"seems unnecessary","commit_id":"28408a04ad44e6028187bf47aea58bfee93cd2fa"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"64f8ac5fca3ece906337e818d62010ab1455e51e","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    default:"},{"line_number":72,"context_line":"      tag: openstack.cinder.volume"},{"line_number":73,"context_line":"      file: /var/log/containers/cinder/cinder-volume.log"},{"line_number":74,"context_line":"  CephConfigPath:"},{"line_number":75,"context_line":"    type: string"},{"line_number":76,"context_line":"    default: \"/etc/ceph\""},{"line_number":77,"context_line":"    description: The path where the Ceph Cluster config files are stored."}],"source_content_type":"text/x-yaml","patch_set":24,"id":"4b557f40_eb4d5757","line":74,"in_reply_to":"59744383_d6fa4260","updated":"2020-11-26 13:32:39.000000000","message":"Done","commit_id":"28408a04ad44e6028187bf47aea58bfee93cd2fa"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"283241d0c05baceee311e522179ba3d3af2203d0","unresolved":true,"context_lines":[{"line_number":71,"context_line":"    default:"},{"line_number":72,"context_line":"      tag: openstack.cinder.volume"},{"line_number":73,"context_line":"      file: /var/log/containers/cinder/cinder-volume.log"},{"line_number":74,"context_line":"  CephConfigPath:"},{"line_number":75,"context_line":"    type: string"},{"line_number":76,"context_line":"    default: \"/etc/ceph\""},{"line_number":77,"context_line":"    description: The path where the Ceph Cluster config files are stored."}],"source_content_type":"text/x-yaml","patch_set":24,"id":"b8a56743_aa002e7a","line":74,"in_reply_to":"59744383_d6fa4260","updated":"2020-11-26 13:33:14.000000000","message":"we do need this, see below","commit_id":"28408a04ad44e6028187bf47aea58bfee93cd2fa"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"e620c133ee5a87c83c34b662c3d1c5b51003ad12","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    default:"},{"line_number":72,"context_line":"      tag: openstack.cinder.volume"},{"line_number":73,"context_line":"      file: /var/log/containers/cinder/cinder-volume.log"},{"line_number":74,"context_line":"  CephConfigPath:"},{"line_number":75,"context_line":"    type: string"},{"line_number":76,"context_line":"    default: \"/etc/ceph\""},{"line_number":77,"context_line":"    description: The path where the Ceph Cluster config files are stored."}],"source_content_type":"text/x-yaml","patch_set":24,"id":"41b4ca7e_8c7c2b4a","line":74,"in_reply_to":"b8a56743_aa002e7a","updated":"2020-11-26 13:58:35.000000000","message":"Done","commit_id":"28408a04ad44e6028187bf47aea58bfee93cd2fa"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"283241d0c05baceee311e522179ba3d3af2203d0","unresolved":true,"context_lines":[{"line_number":128,"context_line":"                    expression: concat($.data.rightSplit(separator \u003d\u003e \":\", maxSplits \u003d\u003e 1)[0], \":pcmklatest\")"},{"line_number":129,"context_line":"            tripleo::profile::pacemaker::cinder::volume_bundle::docker_volumes: {get_attr: [CinderCommon, cinder_volume_volumes]}"},{"line_number":130,"context_line":"            tripleo::profile::pacemaker::cinder::volume_bundle::docker_environment: {get_attr: [CinderCommon, cinder_volume_environment]}"},{"line_number":131,"context_line":"            tripleo::profile::pacemaker::cinder::volume_bundle::container_backend: {get_param: ContainerCli}"},{"line_number":132,"context_line":"            cinder::volume::manage_service: false"},{"line_number":133,"context_line":"            cinder::volume::enabled: false"},{"line_number":134,"context_line":"            cinder::backend_host: hostgroup"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"cb572c29_6a4b08e7","line":131,"updated":"2020-11-26 13:33:14.000000000","message":"need to add tripleo::profile::pacemaker::cinder::volume_bundle::ceph_conf","commit_id":"28408a04ad44e6028187bf47aea58bfee93cd2fa"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"e620c133ee5a87c83c34b662c3d1c5b51003ad12","unresolved":false,"context_lines":[{"line_number":128,"context_line":"                    expression: concat($.data.rightSplit(separator \u003d\u003e \":\", maxSplits \u003d\u003e 1)[0], \":pcmklatest\")"},{"line_number":129,"context_line":"            tripleo::profile::pacemaker::cinder::volume_bundle::docker_volumes: {get_attr: [CinderCommon, cinder_volume_volumes]}"},{"line_number":130,"context_line":"            tripleo::profile::pacemaker::cinder::volume_bundle::docker_environment: {get_attr: [CinderCommon, cinder_volume_environment]}"},{"line_number":131,"context_line":"            tripleo::profile::pacemaker::cinder::volume_bundle::container_backend: {get_param: ContainerCli}"},{"line_number":132,"context_line":"            cinder::volume::manage_service: false"},{"line_number":133,"context_line":"            cinder::volume::enabled: false"},{"line_number":134,"context_line":"            cinder::backend_host: hostgroup"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"d70274e9_e7fa000c","line":131,"in_reply_to":"cb572c29_6a4b08e7","updated":"2020-11-26 13:58:35.000000000","message":"Done","commit_id":"28408a04ad44e6028187bf47aea58bfee93cd2fa"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"3f2f8b35b728738cc1dbe30b32d6f1fb411fd9ae","unresolved":true,"context_lines":[{"line_number":129,"context_line":"            tripleo::profile::pacemaker::cinder::volume_bundle::docker_volumes: {get_attr: [CinderCommon, cinder_volume_volumes]}"},{"line_number":130,"context_line":"            tripleo::profile::pacemaker::cinder::volume_bundle::docker_environment: {get_attr: [CinderCommon, cinder_volume_environment]}"},{"line_number":131,"context_line":"            tripleo::profile::pacemaker::cinder::volume_bundle::container_backend: {get_param: ContainerCli}"},{"line_number":132,"context_line":"            tripleo::profile::pacemaker::cinder::volume_bundle::ceph_conf: {get_param: CephConfigPath}"},{"line_number":133,"context_line":"            cinder::volume::manage_service: false"},{"line_number":134,"context_line":"            cinder::volume::enabled: false"},{"line_number":135,"context_line":"            cinder::backend_host: hostgroup"}],"source_content_type":"text/x-yaml","patch_set":34,"id":"7a5b3a9a_1a9a6a7b","line":132,"updated":"2020-12-03 22:17:58.000000000","message":"-1: input param is now \u0027ceph_conf_path\u0027\n\nhttps://review.opendev.org/c/openstack/puppet-tripleo/+/763545/24/manifests/profile/pacemaker/cinder/volume_bundle.pp#50","commit_id":"4a26a0a88ce226bcf21c369d51ebb4057798e949"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"9893293630f9032fac2e9b300995aaa490dd69b4","unresolved":false,"context_lines":[{"line_number":129,"context_line":"            tripleo::profile::pacemaker::cinder::volume_bundle::docker_volumes: {get_attr: [CinderCommon, cinder_volume_volumes]}"},{"line_number":130,"context_line":"            tripleo::profile::pacemaker::cinder::volume_bundle::docker_environment: {get_attr: [CinderCommon, cinder_volume_environment]}"},{"line_number":131,"context_line":"            tripleo::profile::pacemaker::cinder::volume_bundle::container_backend: {get_param: ContainerCli}"},{"line_number":132,"context_line":"            tripleo::profile::pacemaker::cinder::volume_bundle::ceph_conf: {get_param: CephConfigPath}"},{"line_number":133,"context_line":"            cinder::volume::manage_service: false"},{"line_number":134,"context_line":"            cinder::volume::enabled: false"},{"line_number":135,"context_line":"            cinder::backend_host: hostgroup"}],"source_content_type":"text/x-yaml","patch_set":34,"id":"2a3d590d_88c7c02a","line":132,"in_reply_to":"7a5b3a9a_1a9a6a7b","updated":"2020-12-04 07:44:27.000000000","message":"Done","commit_id":"4a26a0a88ce226bcf21c369d51ebb4057798e949"}],"deployment/glance/glance-api-container-puppet.yaml":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"f35c46bf3b9cd82de3886c9239e72c4f7065d818","unresolved":true,"context_lines":[{"line_number":615,"context_line":"                        data:"},{"line_number":616,"context_line":"                          user: {get_param: CephClientUserName}"},{"line_number":617,"context_line":"                          multistore: {get_param: GlanceMultistoreConfig}"},{"line_number":618,"context_line":"                  params:"},{"line_number":619,"context_line":"                    CEPH_CONFIG_HOME: {get_param: CephConfigPath}"},{"line_number":620,"context_line":"        /var/lib/kolla/config_files/glance_api_tls_proxy.json:"},{"line_number":621,"context_line":"          command: /usr/sbin/httpd -DFOREGROUND"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"0abfe051_ffd74eb4","line":618,"updated":"2020-11-24 11:13:23.000000000","message":"I don\u0027t think you can use params: with \u0027repeat\u0027 though, does this work?","commit_id":"c051a1a64535d07769d9ae5fa8105cca062b8e70"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"ed46d69fcd96767a27ade576d8841c2bc5bbb441","unresolved":true,"context_lines":[{"line_number":615,"context_line":"                        data:"},{"line_number":616,"context_line":"                          user: {get_param: CephClientUserName}"},{"line_number":617,"context_line":"                          multistore: {get_param: GlanceMultistoreConfig}"},{"line_number":618,"context_line":"                  params:"},{"line_number":619,"context_line":"                    CEPH_CONFIG_HOME: {get_param: CephConfigPath}"},{"line_number":620,"context_line":"        /var/lib/kolla/config_files/glance_api_tls_proxy.json:"},{"line_number":621,"context_line":"          command: /usr/sbin/httpd -DFOREGROUND"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"0554ceab_bd66588c","line":618,"in_reply_to":"0abfe051_ffd74eb4","updated":"2020-11-24 11:32:00.000000000","message":"Sounds like it works but I need to take a look. I used this \"params\" with template the same way used in L601","commit_id":"c051a1a64535d07769d9ae5fa8105cca062b8e70"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"a84069e54ee11d223c827d913b60c271906d1a91","unresolved":true,"context_lines":[{"line_number":596,"context_line":"                  recurse: true"},{"line_number":597,"context_line":"                - path:"},{"line_number":598,"context_line":"                    str_replace:"},{"line_number":599,"context_line":"                      template: CEPH_CONFIG_HOME/CLUSTER.client.USER.keyring"},{"line_number":600,"context_line":"                      params:"},{"line_number":601,"context_line":"                        CEPH_CONFIG_HOME: {get_param: CephConfigPath}"},{"line_number":602,"context_line":"                        CLUSTER: {get_param: CephClusterName}"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"83291b02_c34a8caf","line":599,"updated":"2020-11-24 18:12:11.000000000","message":"don\u0027t change this, it runs within the container","commit_id":"c31498dc754932e30252fb286aa9254af29122ba"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"e10c6114c4900b2529dc2693c5a037aa3bc98081","unresolved":false,"context_lines":[{"line_number":596,"context_line":"                  recurse: true"},{"line_number":597,"context_line":"                - path:"},{"line_number":598,"context_line":"                    str_replace:"},{"line_number":599,"context_line":"                      template: CEPH_CONFIG_HOME/CLUSTER.client.USER.keyring"},{"line_number":600,"context_line":"                      params:"},{"line_number":601,"context_line":"                        CEPH_CONFIG_HOME: {get_param: CephConfigPath}"},{"line_number":602,"context_line":"                        CLUSTER: {get_param: CephClusterName}"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"b5ce154b_367e5b9a","line":599,"in_reply_to":"83291b02_c34a8caf","updated":"2020-11-25 06:24:11.000000000","message":"+1","commit_id":"c31498dc754932e30252fb286aa9254af29122ba"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"a84069e54ee11d223c827d913b60c271906d1a91","unresolved":true,"context_lines":[{"line_number":605,"context_line":"                  perm: \u00270600\u0027"},{"line_number":606,"context_line":"              - repeat:"},{"line_number":607,"context_line":"                  template:"},{"line_number":608,"context_line":"                    path: CEPH_CONFIG_HOME/\u003c%keyring%\u003e"},{"line_number":609,"context_line":"                    owner: glance:glance"},{"line_number":610,"context_line":"                    perm: \u00270600\u0027"},{"line_number":611,"context_line":"                  for_each:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"a0967baf_52c6232d","line":608,"updated":"2020-11-24 18:12:11.000000000","message":"don\u0027t change this, it runs within the container","commit_id":"c31498dc754932e30252fb286aa9254af29122ba"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"e10c6114c4900b2529dc2693c5a037aa3bc98081","unresolved":true,"context_lines":[{"line_number":605,"context_line":"                  perm: \u00270600\u0027"},{"line_number":606,"context_line":"              - repeat:"},{"line_number":607,"context_line":"                  template:"},{"line_number":608,"context_line":"                    path: CEPH_CONFIG_HOME/\u003c%keyring%\u003e"},{"line_number":609,"context_line":"                    owner: glance:glance"},{"line_number":610,"context_line":"                    perm: \u00270600\u0027"},{"line_number":611,"context_line":"                  for_each:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"87340c31_4578aeff","line":608,"in_reply_to":"a0967baf_52c6232d","updated":"2020-11-25 06:24:11.000000000","message":"+1","commit_id":"c31498dc754932e30252fb286aa9254af29122ba"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"e10c6114c4900b2529dc2693c5a037aa3bc98081","unresolved":false,"context_lines":[{"line_number":605,"context_line":"                  perm: \u00270600\u0027"},{"line_number":606,"context_line":"              - repeat:"},{"line_number":607,"context_line":"                  template:"},{"line_number":608,"context_line":"                    path: CEPH_CONFIG_HOME/\u003c%keyring%\u003e"},{"line_number":609,"context_line":"                    owner: glance:glance"},{"line_number":610,"context_line":"                    perm: \u00270600\u0027"},{"line_number":611,"context_line":"                  for_each:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"b4767ad2_524209a5","line":608,"in_reply_to":"a0967baf_52c6232d","updated":"2020-11-25 06:24:11.000000000","message":"+1","commit_id":"c31498dc754932e30252fb286aa9254af29122ba"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"68f1b59bde283d3dd5f2019f852d9fb118e0716d","unresolved":true,"context_lines":[{"line_number":503,"context_line":"              - - \u0027/etc/ceph/\u0027"},{"line_number":504,"context_line":"                - {get_param: CephClusterName}"},{"line_number":505,"context_line":"                - \u0027.conf\u0027"},{"line_number":506,"context_line":"            glance::backend::rbd::rbd_store_pool: {get_param: GlanceRbdPoolName}"},{"line_number":507,"context_line":"            glance::backend::rbd::rbd_store_user: {get_param: CephClientUserName}"},{"line_number":508,"context_line":"            glance_backend: {get_param: GlanceBackend}"},{"line_number":509,"context_line":"            tripleo::profile::base::glance::api::glance_backend_id: {get_param: GlanceBackendID}"}],"source_content_type":"text/x-yaml","patch_set":33,"id":"d1030a9a_6766973e","line":506,"updated":"2020-11-30 22:34:04.000000000","message":"add here:\n\nglance::backend::rbd::glance_rbd_ceph_conf_path: {get_param: CephConfigPath}","commit_id":"a9e72de2baad19a6d801aa2f47a1129001fe48d6"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"42f88d4093f0617cb554d60e749201f346ef721c","unresolved":false,"context_lines":[{"line_number":503,"context_line":"              - - \u0027/etc/ceph/\u0027"},{"line_number":504,"context_line":"                - {get_param: CephClusterName}"},{"line_number":505,"context_line":"                - \u0027.conf\u0027"},{"line_number":506,"context_line":"            glance::backend::rbd::rbd_store_pool: {get_param: GlanceRbdPoolName}"},{"line_number":507,"context_line":"            glance::backend::rbd::rbd_store_user: {get_param: CephClientUserName}"},{"line_number":508,"context_line":"            glance_backend: {get_param: GlanceBackend}"},{"line_number":509,"context_line":"            tripleo::profile::base::glance::api::glance_backend_id: {get_param: GlanceBackendID}"}],"source_content_type":"text/x-yaml","patch_set":33,"id":"c8a22368_9db5a6f7","line":506,"in_reply_to":"d1030a9a_6766973e","updated":"2020-12-01 08:43:08.000000000","message":"Done","commit_id":"a9e72de2baad19a6d801aa2f47a1129001fe48d6"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"3f2f8b35b728738cc1dbe30b32d6f1fb411fd9ae","unresolved":true,"context_lines":[{"line_number":504,"context_line":"                - {get_param: CephClusterName}"},{"line_number":505,"context_line":"                - \u0027.conf\u0027"},{"line_number":506,"context_line":"            glance::backend::rbd::rbd_store_pool: {get_param: GlanceRbdPoolName}"},{"line_number":507,"context_line":"            glance::backend::rbd::glance_rbd_ceph_conf_path: {get_param: CephConfigPath}"},{"line_number":508,"context_line":"            glance::backend::rbd::rbd_store_user: {get_param: CephClientUserName}"},{"line_number":509,"context_line":"            glance_backend: {get_param: GlanceBackend}"},{"line_number":510,"context_line":"            tripleo::profile::base::glance::api::glance_backend_id: {get_param: GlanceBackendID}"}],"source_content_type":"text/x-yaml","patch_set":34,"id":"65d03017_62fd6522","line":507,"updated":"2020-12-03 22:17:58.000000000","message":"This doesn\u0027t look right. You shouldn\u0027t set it here for puppet-glance (glance::backend::rbd), but instead it should be for puppet-tripleo (tripleo::profile::base::glance::backend::rbd).","commit_id":"4a26a0a88ce226bcf21c369d51ebb4057798e949"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"9893293630f9032fac2e9b300995aaa490dd69b4","unresolved":false,"context_lines":[{"line_number":504,"context_line":"                - {get_param: CephClusterName}"},{"line_number":505,"context_line":"                - \u0027.conf\u0027"},{"line_number":506,"context_line":"            glance::backend::rbd::rbd_store_pool: {get_param: GlanceRbdPoolName}"},{"line_number":507,"context_line":"            glance::backend::rbd::glance_rbd_ceph_conf_path: {get_param: CephConfigPath}"},{"line_number":508,"context_line":"            glance::backend::rbd::rbd_store_user: {get_param: CephClientUserName}"},{"line_number":509,"context_line":"            glance_backend: {get_param: GlanceBackend}"},{"line_number":510,"context_line":"            tripleo::profile::base::glance::api::glance_backend_id: {get_param: GlanceBackendID}"}],"source_content_type":"text/x-yaml","patch_set":34,"id":"f42d6c95_a6c0b935","line":507,"in_reply_to":"65d03017_62fd6522","updated":"2020-12-04 07:44:27.000000000","message":"ack, no problem to have that kind of reference in the code. Why the other variables (rbd_store_pool and rbd_store_user) of the same class are referenced omitting \"tripleo::profile::base::\"? maybe it\u0027s because they\u0027re resolved using hiera?","commit_id":"4a26a0a88ce226bcf21c369d51ebb4057798e949"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"4eb48372a7d90779299a0e7e22f63846a2a18ecc","unresolved":false,"context_lines":[{"line_number":504,"context_line":"                - {get_param: CephClusterName}"},{"line_number":505,"context_line":"                - \u0027.conf\u0027"},{"line_number":506,"context_line":"            glance::backend::rbd::rbd_store_pool: {get_param: GlanceRbdPoolName}"},{"line_number":507,"context_line":"            glance::backend::rbd::glance_rbd_ceph_conf_path: {get_param: CephConfigPath}"},{"line_number":508,"context_line":"            glance::backend::rbd::rbd_store_user: {get_param: CephClientUserName}"},{"line_number":509,"context_line":"            glance_backend: {get_param: GlanceBackend}"},{"line_number":510,"context_line":"            tripleo::profile::base::glance::api::glance_backend_id: {get_param: GlanceBackendID}"}],"source_content_type":"text/x-yaml","patch_set":34,"id":"162bc40d_dc1928da","line":507,"in_reply_to":"6a50075a_4fdcf9db","updated":"2020-12-04 17:20:59.000000000","message":"Ack, thanks for clarify this aspect of how puppet parameters are consumed.\nThis is fixed in PS 35 [1]\n\n[1] https://review.opendev.org/c/openstack/tripleo-heat-templates/+/763542/35/deployment/glance/glance-api-container-puppet.yaml#513","commit_id":"4a26a0a88ce226bcf21c369d51ebb4057798e949"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"9e50dc1307230ae6ef18ce6c0a7ae1a33af610f8","unresolved":true,"context_lines":[{"line_number":504,"context_line":"                - {get_param: CephClusterName}"},{"line_number":505,"context_line":"                - \u0027.conf\u0027"},{"line_number":506,"context_line":"            glance::backend::rbd::rbd_store_pool: {get_param: GlanceRbdPoolName}"},{"line_number":507,"context_line":"            glance::backend::rbd::glance_rbd_ceph_conf_path: {get_param: CephConfigPath}"},{"line_number":508,"context_line":"            glance::backend::rbd::rbd_store_user: {get_param: CephClientUserName}"},{"line_number":509,"context_line":"            glance_backend: {get_param: GlanceBackend}"},{"line_number":510,"context_line":"            tripleo::profile::base::glance::api::glance_backend_id: {get_param: GlanceBackendID}"}],"source_content_type":"text/x-yaml","patch_set":34,"id":"6a50075a_4fdcf9db","line":507,"in_reply_to":"f42d6c95_a6c0b935","updated":"2020-12-04 17:04:23.000000000","message":"Not quite. The rbd_store_pool and rbd_store_user are actual puppet-glance parameters [1], but glance_rbd_ceph_conf_path is not, it\u0027s just a puppet-tripleo parameter [2]. For [2] to be resolved via hiera you need to set tripleo::profile::base::glance::backend::rbd::glance_rbd_ceph_conf_path\n\n[1] https://opendev.org/openstack/puppet-glance/src/branch/master/manifests/backend/rbd.pp#L62\n[2] https://review.opendev.org/c/openstack/puppet-tripleo/+/763545/25/manifests/profile/base/glance/backend/rbd.pp#28","commit_id":"4a26a0a88ce226bcf21c369d51ebb4057798e949"}],"deployment/gnocchi/gnocchi-api-container-puppet.yaml":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"68f1b59bde283d3dd5f2019f852d9fb118e0716d","unresolved":true,"context_lines":[{"line_number":219,"context_line":"                  $NETWORK: {get_param: [ServiceNetMap, GnocchiApiNetwork]}"},{"line_number":220,"context_line":"            tripleo::profile::base::gnocchi::api::gnocchi_backend: {get_param: GnocchiBackend}"},{"line_number":221,"context_line":"            tripleo::profile::base::gnocchi::api::incoming_storage_driver: {get_param: GnocchiIncomingStorageDriver}"},{"line_number":222,"context_line":"            tripleo::profile::base::gnocchi::api::gnocchi_rbd_ceph_conf: {get_param: CephConfigPath}"},{"line_number":223,"context_line":"            # NOTE: bind IP is found in hiera replacing the network name with the"},{"line_number":224,"context_line":"            # local node IP for the given network; replacement examples"},{"line_number":225,"context_line":"            # (eg. for internal_api):"}],"source_content_type":"text/x-yaml","patch_set":33,"id":"1a410860_11b4f014","line":222,"updated":"2020-11-30 22:34:04.000000000","message":"::gnocchi_rbd_ceph_conf_path","commit_id":"a9e72de2baad19a6d801aa2f47a1129001fe48d6"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"42f88d4093f0617cb554d60e749201f346ef721c","unresolved":false,"context_lines":[{"line_number":219,"context_line":"                  $NETWORK: {get_param: [ServiceNetMap, GnocchiApiNetwork]}"},{"line_number":220,"context_line":"            tripleo::profile::base::gnocchi::api::gnocchi_backend: {get_param: GnocchiBackend}"},{"line_number":221,"context_line":"            tripleo::profile::base::gnocchi::api::incoming_storage_driver: {get_param: GnocchiIncomingStorageDriver}"},{"line_number":222,"context_line":"            tripleo::profile::base::gnocchi::api::gnocchi_rbd_ceph_conf: {get_param: CephConfigPath}"},{"line_number":223,"context_line":"            # NOTE: bind IP is found in hiera replacing the network name with the"},{"line_number":224,"context_line":"            # local node IP for the given network; replacement examples"},{"line_number":225,"context_line":"            # (eg. for internal_api):"}],"source_content_type":"text/x-yaml","patch_set":33,"id":"e9a5bbbd_7ffc080a","line":222,"in_reply_to":"1a410860_11b4f014","updated":"2020-12-01 08:43:08.000000000","message":"Done","commit_id":"a9e72de2baad19a6d801aa2f47a1129001fe48d6"}],"deployment/gnocchi/gnocchi-base.yaml":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"4e744d91cf1da63dba820c20a9d8b840ab2abaf9","unresolved":true,"context_lines":[{"line_number":167,"context_line":"        gnocchi::storage::swift::swift_endpoint_type: {get_param: GnocchiStorageSwiftEndpointType}"},{"line_number":168,"context_line":"        gnocchi::storage::ceph::ceph_pool: {get_param: GnocchiRbdPoolName}"},{"line_number":169,"context_line":"        gnocchi::storage::ceph::ceph_username: {get_param: CephClientUserName}"},{"line_number":170,"context_line":"        gnocchi::storage::ceph::ceph_conf: {get_param: CephConfigPath}"},{"line_number":171,"context_line":"        gnocchi::storage::ceph::ceph_conffile:"},{"line_number":172,"context_line":"          list_join:"},{"line_number":173,"context_line":"          - \u0027\u0027"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"af6ee13d_66259a34","line":170,"updated":"2020-11-24 11:23:16.000000000","message":"I think this should be ceph_conffile [1]\n\n1. https://github.com/openstack/puppet-gnocchi/blob/master/manifests/storage/ceph.pp#L61","commit_id":"c051a1a64535d07769d9ae5fa8105cca062b8e70"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"a84069e54ee11d223c827d913b60c271906d1a91","unresolved":true,"context_lines":[{"line_number":167,"context_line":"        gnocchi::storage::swift::swift_endpoint_type: {get_param: GnocchiStorageSwiftEndpointType}"},{"line_number":168,"context_line":"        gnocchi::storage::ceph::ceph_pool: {get_param: GnocchiRbdPoolName}"},{"line_number":169,"context_line":"        gnocchi::storage::ceph::ceph_username: {get_param: CephClientUserName}"},{"line_number":170,"context_line":"        gnocchi::storage::ceph::ceph_conf: {get_param: CephConfigPath}"},{"line_number":171,"context_line":"        gnocchi::storage::ceph::ceph_conffile:"},{"line_number":172,"context_line":"          list_join:"},{"line_number":173,"context_line":"          - \u0027\u0027"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"87f82b9f_6deeb734","line":170,"updated":"2020-11-24 18:12:11.000000000","message":"remove this, set tripleo::profile::base::gnocchi::api::gnocchi_rbd_ceph_conf","commit_id":"c31498dc754932e30252fb286aa9254af29122ba"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"e10c6114c4900b2529dc2693c5a037aa3bc98081","unresolved":false,"context_lines":[{"line_number":167,"context_line":"        gnocchi::storage::swift::swift_endpoint_type: {get_param: GnocchiStorageSwiftEndpointType}"},{"line_number":168,"context_line":"        gnocchi::storage::ceph::ceph_pool: {get_param: GnocchiRbdPoolName}"},{"line_number":169,"context_line":"        gnocchi::storage::ceph::ceph_username: {get_param: CephClientUserName}"},{"line_number":170,"context_line":"        gnocchi::storage::ceph::ceph_conf: {get_param: CephConfigPath}"},{"line_number":171,"context_line":"        gnocchi::storage::ceph::ceph_conffile:"},{"line_number":172,"context_line":"          list_join:"},{"line_number":173,"context_line":"          - \u0027\u0027"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"fb07a942_aea51b66","line":170,"in_reply_to":"87f82b9f_6deeb734","updated":"2020-11-25 06:24:11.000000000","message":"Done","commit_id":"c31498dc754932e30252fb286aa9254af29122ba"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"283241d0c05baceee311e522179ba3d3af2203d0","unresolved":true,"context_lines":[{"line_number":167,"context_line":"        gnocchi::storage::swift::swift_endpoint_type: {get_param: GnocchiStorageSwiftEndpointType}"},{"line_number":168,"context_line":"        gnocchi::storage::ceph::ceph_pool: {get_param: GnocchiRbdPoolName}"},{"line_number":169,"context_line":"        gnocchi::storage::ceph::ceph_username: {get_param: CephClientUserName}"},{"line_number":170,"context_line":"        tripleo::profile::base::gnocchi::api::gnocchi_rbd_ceph_conf: {get_param: CephConfigPath}"},{"line_number":171,"context_line":"        gnocchi::storage::ceph::ceph_conffile:"},{"line_number":172,"context_line":"          list_join:"},{"line_number":173,"context_line":"          - \u0027\u0027"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"0d1e7464_74fd8b7d","line":170,"updated":"2020-11-26 13:33:14.000000000","message":"I think this goes in gnocchi-api-container-puppet.yaml","commit_id":"28408a04ad44e6028187bf47aea58bfee93cd2fa"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"e620c133ee5a87c83c34b662c3d1c5b51003ad12","unresolved":false,"context_lines":[{"line_number":167,"context_line":"        gnocchi::storage::swift::swift_endpoint_type: {get_param: GnocchiStorageSwiftEndpointType}"},{"line_number":168,"context_line":"        gnocchi::storage::ceph::ceph_pool: {get_param: GnocchiRbdPoolName}"},{"line_number":169,"context_line":"        gnocchi::storage::ceph::ceph_username: {get_param: CephClientUserName}"},{"line_number":170,"context_line":"        tripleo::profile::base::gnocchi::api::gnocchi_rbd_ceph_conf: {get_param: CephConfigPath}"},{"line_number":171,"context_line":"        gnocchi::storage::ceph::ceph_conffile:"},{"line_number":172,"context_line":"          list_join:"},{"line_number":173,"context_line":"          - \u0027\u0027"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"2b9f2850_7d5c4753","line":170,"in_reply_to":"0d1e7464_74fd8b7d","updated":"2020-11-26 13:58:35.000000000","message":"and at that point we don\u0027t need CephConfigPath here","commit_id":"28408a04ad44e6028187bf47aea58bfee93cd2fa"}],"deployment/manila/manila-backend-cephfs.yaml":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"4e744d91cf1da63dba820c20a9d8b840ab2abaf9","unresolved":true,"context_lines":[{"line_number":93,"context_line":"        manila::backend::cephfs::driver_handles_share_servers: {get_param: ManilaCephFSDriverHandlesShareServers}"},{"line_number":94,"context_line":"        manila::backend::cephfs::pool_name: {get_param: ManilaCephFSDataPoolName}"},{"line_number":95,"context_line":"        manila::backend::cephfs::share_backend_name: {get_param: ManilaCephFSShareBackendName}"},{"line_number":96,"context_line":"        manila::backend::cephfs::ceph_conf: {get_param: CephConfigPath}"},{"line_number":97,"context_line":"        manila::backend::cephfs::cephfs_conf_path:"},{"line_number":98,"context_line":"          list_join:"},{"line_number":99,"context_line":"          - \u0027\u0027"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"8074aa5c_2e9eebe4","line":96,"updated":"2020-11-24 11:23:16.000000000","message":"cephfs_conf_path [1]\n\n1. https://github.com/openstack/puppet-manila/blob/master/manifests/backend/cephfs.pp#L16","commit_id":"c051a1a64535d07769d9ae5fa8105cca062b8e70"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"a84069e54ee11d223c827d913b60c271906d1a91","unresolved":true,"context_lines":[{"line_number":93,"context_line":"        manila::backend::cephfs::driver_handles_share_servers: {get_param: ManilaCephFSDriverHandlesShareServers}"},{"line_number":94,"context_line":"        manila::backend::cephfs::pool_name: {get_param: ManilaCephFSDataPoolName}"},{"line_number":95,"context_line":"        manila::backend::cephfs::share_backend_name: {get_param: ManilaCephFSShareBackendName}"},{"line_number":96,"context_line":"        manila::backend::cephfs::ceph_conf: {get_param: CephConfigPath}"},{"line_number":97,"context_line":"        manila::backend::cephfs::cephfs_conf_path:"},{"line_number":98,"context_line":"          list_join:"},{"line_number":99,"context_line":"          - \u0027\u0027"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"df4d7579_17dff068","line":96,"updated":"2020-11-24 18:12:11.000000000","message":"don\u0027t change this; set manila_cephfs_ceph_conf instead","commit_id":"c31498dc754932e30252fb286aa9254af29122ba"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"e10c6114c4900b2529dc2693c5a037aa3bc98081","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        manila::backend::cephfs::driver_handles_share_servers: {get_param: ManilaCephFSDriverHandlesShareServers}"},{"line_number":94,"context_line":"        manila::backend::cephfs::pool_name: {get_param: ManilaCephFSDataPoolName}"},{"line_number":95,"context_line":"        manila::backend::cephfs::share_backend_name: {get_param: ManilaCephFSShareBackendName}"},{"line_number":96,"context_line":"        manila::backend::cephfs::ceph_conf: {get_param: CephConfigPath}"},{"line_number":97,"context_line":"        manila::backend::cephfs::cephfs_conf_path:"},{"line_number":98,"context_line":"          list_join:"},{"line_number":99,"context_line":"          - \u0027\u0027"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"836eb5fb_ffcf0181","line":96,"in_reply_to":"df4d7579_17dff068","updated":"2020-11-25 06:24:11.000000000","message":"Done","commit_id":"c31498dc754932e30252fb286aa9254af29122ba"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"68f1b59bde283d3dd5f2019f852d9fb118e0716d","unresolved":true,"context_lines":[{"line_number":97,"context_line":"        manila::backend::cephfs::cephfs_conf_path:"},{"line_number":98,"context_line":"          list_join:"},{"line_number":99,"context_line":"          - \u0027\u0027"},{"line_number":100,"context_line":"          - - \u0027/etc/ceph/\u0027"},{"line_number":101,"context_line":"            - {get_param: CephClusterName}"},{"line_number":102,"context_line":"            - .conf"},{"line_number":103,"context_line":"        manila::backend::cephfs::cephfs_auth_id: {get_param: ManilaCephFSCephFSAuthId}"}],"source_content_type":"text/x-yaml","patch_set":32,"id":"ea2087ac_2e938bef","line":100,"updated":"2020-11-30 22:34:04.000000000","message":"please remove the quotes if not needed","commit_id":"58823d3187aef5ebc8da0de8ddca644b0ccb25d8"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"42f88d4093f0617cb554d60e749201f346ef721c","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        manila::backend::cephfs::cephfs_conf_path:"},{"line_number":98,"context_line":"          list_join:"},{"line_number":99,"context_line":"          - \u0027\u0027"},{"line_number":100,"context_line":"          - - \u0027/etc/ceph/\u0027"},{"line_number":101,"context_line":"            - {get_param: CephClusterName}"},{"line_number":102,"context_line":"            - .conf"},{"line_number":103,"context_line":"        manila::backend::cephfs::cephfs_auth_id: {get_param: ManilaCephFSCephFSAuthId}"}],"source_content_type":"text/x-yaml","patch_set":32,"id":"0a8ab323_1284b813","line":100,"in_reply_to":"ea2087ac_2e938bef","updated":"2020-12-01 08:43:08.000000000","message":"Done","commit_id":"58823d3187aef5ebc8da0de8ddca644b0ccb25d8"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"68f1b59bde283d3dd5f2019f852d9fb118e0716d","unresolved":true,"context_lines":[{"line_number":93,"context_line":"        manila::backend::cephfs::driver_handles_share_servers: {get_param: ManilaCephFSDriverHandlesShareServers}"},{"line_number":94,"context_line":"        manila::backend::cephfs::pool_name: {get_param: ManilaCephFSDataPoolName}"},{"line_number":95,"context_line":"        manila::backend::cephfs::share_backend_name: {get_param: ManilaCephFSShareBackendName}"},{"line_number":96,"context_line":"        manila_cephfs_ceph_conf: {get_param: CephConfigPath}"},{"line_number":97,"context_line":"        manila::backend::cephfs::cephfs_conf_path:"},{"line_number":98,"context_line":"          list_join:"},{"line_number":99,"context_line":"          - \u0027\u0027"}],"source_content_type":"text/x-yaml","patch_set":33,"id":"ae1654b0_75401e29","line":96,"updated":"2020-11-30 22:34:04.000000000","message":"manila_cephfs_ceph_conf_path","commit_id":"a9e72de2baad19a6d801aa2f47a1129001fe48d6"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"42f88d4093f0617cb554d60e749201f346ef721c","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        manila::backend::cephfs::driver_handles_share_servers: {get_param: ManilaCephFSDriverHandlesShareServers}"},{"line_number":94,"context_line":"        manila::backend::cephfs::pool_name: {get_param: ManilaCephFSDataPoolName}"},{"line_number":95,"context_line":"        manila::backend::cephfs::share_backend_name: {get_param: ManilaCephFSShareBackendName}"},{"line_number":96,"context_line":"        manila_cephfs_ceph_conf: {get_param: CephConfigPath}"},{"line_number":97,"context_line":"        manila::backend::cephfs::cephfs_conf_path:"},{"line_number":98,"context_line":"          list_join:"},{"line_number":99,"context_line":"          - \u0027\u0027"}],"source_content_type":"text/x-yaml","patch_set":33,"id":"cd31a580_6d356e6e","line":96,"in_reply_to":"ae1654b0_75401e29","updated":"2020-12-01 08:43:08.000000000","message":"Done","commit_id":"a9e72de2baad19a6d801aa2f47a1129001fe48d6"}],"deployment/manila/manila-share-pacemaker-puppet.yaml":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"a84069e54ee11d223c827d913b60c271906d1a91","unresolved":true,"context_lines":[{"line_number":121,"context_line":"            tripleo::profile::pacemaker::manila::share_bundle::docker_volumes: {get_attr: [ManilaCommon, manila_share_volumes]}"},{"line_number":122,"context_line":"            tripleo::profile::pacemaker::manila::share_bundle::docker_environment: {get_attr: [ManilaCommon, manila_share_environment]}"},{"line_number":123,"context_line":"            tripleo::profile::pacemaker::manila::share_bundle::container_backend: {get_param: ContainerCli}"},{"line_number":124,"context_line":"            manila::share::manage_service: false"},{"line_number":125,"context_line":"            manila::share::enabled: false"},{"line_number":126,"context_line":"            manila::host: hostgroup"},{"line_number":127,"context_line":"      service_config_settings: {get_attr: [ManilaShareContainerBase, role_data, service_config_settings]}"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"62b00ec6_60a8e2ac","line":124,"updated":"2020-11-24 18:12:11.000000000","message":"add here tripleo::profile::pacemaker::manila::share_bundle::ceph_conf","commit_id":"c31498dc754932e30252fb286aa9254af29122ba"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"3f2f8b35b728738cc1dbe30b32d6f1fb411fd9ae","unresolved":true,"context_lines":[{"line_number":121,"context_line":"            tripleo::profile::pacemaker::manila::share_bundle::docker_volumes: {get_attr: [ManilaCommon, manila_share_volumes]}"},{"line_number":122,"context_line":"            tripleo::profile::pacemaker::manila::share_bundle::docker_environment: {get_attr: [ManilaCommon, manila_share_environment]}"},{"line_number":123,"context_line":"            tripleo::profile::pacemaker::manila::share_bundle::container_backend: {get_param: ContainerCli}"},{"line_number":124,"context_line":"            manila::share::manage_service: false"},{"line_number":125,"context_line":"            manila::share::enabled: false"},{"line_number":126,"context_line":"            manila::host: hostgroup"},{"line_number":127,"context_line":"      service_config_settings: {get_attr: [ManilaShareContainerBase, role_data, service_config_settings]}"}],"source_content_type":"text/x-yaml","patch_set":34,"id":"03909171_7c0b8b19","line":124,"updated":"2020-12-03 22:17:58.000000000","message":"You also need to set tripleo::profile::pacemaker::manila::share_bundle::ceph_conf_path","commit_id":"4a26a0a88ce226bcf21c369d51ebb4057798e949"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"9893293630f9032fac2e9b300995aaa490dd69b4","unresolved":true,"context_lines":[{"line_number":121,"context_line":"            tripleo::profile::pacemaker::manila::share_bundle::docker_volumes: {get_attr: [ManilaCommon, manila_share_volumes]}"},{"line_number":122,"context_line":"            tripleo::profile::pacemaker::manila::share_bundle::docker_environment: {get_attr: [ManilaCommon, manila_share_environment]}"},{"line_number":123,"context_line":"            tripleo::profile::pacemaker::manila::share_bundle::container_backend: {get_param: ContainerCli}"},{"line_number":124,"context_line":"            manila::share::manage_service: false"},{"line_number":125,"context_line":"            manila::share::enabled: false"},{"line_number":126,"context_line":"            manila::host: hostgroup"},{"line_number":127,"context_line":"      service_config_settings: {get_attr: [ManilaShareContainerBase, role_data, service_config_settings]}"}],"source_content_type":"text/x-yaml","patch_set":34,"id":"19d3e9c0_02164405","line":124,"in_reply_to":"03909171_7c0b8b19","updated":"2020-12-04 07:44:27.000000000","message":"Not sure to follow here, where ceph_conf_path is defined? I think the pacemaker tht refers to [1] but we didn\u0027t introduce this parameter in that puppet.\n\n[1] https://github.com/openstack/puppet-tripleo/blob/master/manifests/profile/pacemaker/manila/share_bundle.pp","commit_id":"4a26a0a88ce226bcf21c369d51ebb4057798e949"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"9e50dc1307230ae6ef18ce6c0a7ae1a33af610f8","unresolved":true,"context_lines":[{"line_number":121,"context_line":"            tripleo::profile::pacemaker::manila::share_bundle::docker_volumes: {get_attr: [ManilaCommon, manila_share_volumes]}"},{"line_number":122,"context_line":"            tripleo::profile::pacemaker::manila::share_bundle::docker_environment: {get_attr: [ManilaCommon, manila_share_environment]}"},{"line_number":123,"context_line":"            tripleo::profile::pacemaker::manila::share_bundle::container_backend: {get_param: ContainerCli}"},{"line_number":124,"context_line":"            manila::share::manage_service: false"},{"line_number":125,"context_line":"            manila::share::enabled: false"},{"line_number":126,"context_line":"            manila::host: hostgroup"},{"line_number":127,"context_line":"      service_config_settings: {get_attr: [ManilaShareContainerBase, role_data, service_config_settings]}"}],"source_content_type":"text/x-yaml","patch_set":34,"id":"9990e003_fd4829c8","line":124,"in_reply_to":"19d3e9c0_02164405","updated":"2020-12-04 17:04:23.000000000","message":"See https://review.opendev.org/c/openstack/puppet-tripleo/+/763545/25/manifests/profile/pacemaker/manila/share_bundle.pp#83","commit_id":"4a26a0a88ce226bcf21c369d51ebb4057798e949"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"4eb48372a7d90779299a0e7e22f63846a2a18ecc","unresolved":false,"context_lines":[{"line_number":121,"context_line":"            tripleo::profile::pacemaker::manila::share_bundle::docker_volumes: {get_attr: [ManilaCommon, manila_share_volumes]}"},{"line_number":122,"context_line":"            tripleo::profile::pacemaker::manila::share_bundle::docker_environment: {get_attr: [ManilaCommon, manila_share_environment]}"},{"line_number":123,"context_line":"            tripleo::profile::pacemaker::manila::share_bundle::container_backend: {get_param: ContainerCli}"},{"line_number":124,"context_line":"            manila::share::manage_service: false"},{"line_number":125,"context_line":"            manila::share::enabled: false"},{"line_number":126,"context_line":"            manila::host: hostgroup"},{"line_number":127,"context_line":"      service_config_settings: {get_attr: [ManilaShareContainerBase, role_data, service_config_settings]}"}],"source_content_type":"text/x-yaml","patch_set":34,"id":"8b3fc6a8_4c775cfd","line":124,"in_reply_to":"9990e003_fd4829c8","updated":"2020-12-04 17:20:59.000000000","message":"Done","commit_id":"4a26a0a88ce226bcf21c369d51ebb4057798e949"}],"deployment/nova/nova-compute-container-puppet.yaml":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"a84069e54ee11d223c827d913b60c271906d1a91","unresolved":true,"context_lines":[{"line_number":775,"context_line":"            nova::compute::rbd::libvirt_images_rbd_ceph_conf:"},{"line_number":776,"context_line":"              list_join:"},{"line_number":777,"context_line":"              - \u0027\u0027"},{"line_number":778,"context_line":"              - - {get_param: CephConfigPath}"},{"line_number":779,"context_line":"                - \u0027/\u0027"},{"line_number":780,"context_line":"                - {get_param: CephClusterName}"},{"line_number":781,"context_line":"                - \u0027.conf\u0027"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"9178ca2f_1d4c6fa9","line":778,"updated":"2020-11-24 18:12:11.000000000","message":"don\u0027t change this, it is the correct path to configure in nova.conf","commit_id":"c31498dc754932e30252fb286aa9254af29122ba"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"e10c6114c4900b2529dc2693c5a037aa3bc98081","unresolved":false,"context_lines":[{"line_number":775,"context_line":"            nova::compute::rbd::libvirt_images_rbd_ceph_conf:"},{"line_number":776,"context_line":"              list_join:"},{"line_number":777,"context_line":"              - \u0027\u0027"},{"line_number":778,"context_line":"              - - {get_param: CephConfigPath}"},{"line_number":779,"context_line":"                - \u0027/\u0027"},{"line_number":780,"context_line":"                - {get_param: CephClusterName}"},{"line_number":781,"context_line":"                - \u0027.conf\u0027"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"7ce4d924_5b2a7a1a","line":778,"in_reply_to":"9178ca2f_1d4c6fa9","updated":"2020-11-25 06:24:11.000000000","message":"Done","commit_id":"c31498dc754932e30252fb286aa9254af29122ba"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"a84069e54ee11d223c827d913b60c271906d1a91","unresolved":true,"context_lines":[{"line_number":780,"context_line":"                - {get_param: CephClusterName}"},{"line_number":781,"context_line":"                - \u0027.conf\u0027"},{"line_number":782,"context_line":"            nova::compute::rbd::libvirt_rbd_user: {get_param: CephClientUserName}"},{"line_number":783,"context_line":"            nova::compute::rbd::libvirt_rbd_ceph_conf: {get_param: CephConfigPath}"},{"line_number":784,"context_line":"            nova::compute::rbd::rbd_keyring:"},{"line_number":785,"context_line":"              list_join:"},{"line_number":786,"context_line":"              - \u0027.\u0027"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"6f47e468_59f40adf","line":783,"updated":"2020-11-24 18:12:11.000000000","message":"remove this, set tripleo::profile::base::nova::compute_libvirt_shared::nova_ceph_conf instead","commit_id":"c31498dc754932e30252fb286aa9254af29122ba"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"e10c6114c4900b2529dc2693c5a037aa3bc98081","unresolved":false,"context_lines":[{"line_number":780,"context_line":"                - {get_param: CephClusterName}"},{"line_number":781,"context_line":"                - \u0027.conf\u0027"},{"line_number":782,"context_line":"            nova::compute::rbd::libvirt_rbd_user: {get_param: CephClientUserName}"},{"line_number":783,"context_line":"            nova::compute::rbd::libvirt_rbd_ceph_conf: {get_param: CephConfigPath}"},{"line_number":784,"context_line":"            nova::compute::rbd::rbd_keyring:"},{"line_number":785,"context_line":"              list_join:"},{"line_number":786,"context_line":"              - \u0027.\u0027"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"6b2ac997_32b3426f","line":783,"in_reply_to":"6f47e468_59f40adf","updated":"2020-11-25 06:24:11.000000000","message":"Done","commit_id":"c31498dc754932e30252fb286aa9254af29122ba"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"68f1b59bde283d3dd5f2019f852d9fb118e0716d","unresolved":true,"context_lines":[{"line_number":779,"context_line":"                - {get_param: CephClusterName}"},{"line_number":780,"context_line":"                - \u0027.conf\u0027"},{"line_number":781,"context_line":"            nova::compute::rbd::libvirt_rbd_user: {get_param: CephClientUserName}"},{"line_number":782,"context_line":"            tripleo::profile::base::nova::compute_libvirt_shared::nova_ceph_conf: {get_param: CephConfigPath}"},{"line_number":783,"context_line":"            nova::compute::rbd::rbd_keyring:"},{"line_number":784,"context_line":"              list_join:"},{"line_number":785,"context_line":"              - \u0027.\u0027"}],"source_content_type":"text/x-yaml","patch_set":33,"id":"881776b8_029557a1","line":782,"updated":"2020-11-30 22:34:04.000000000","message":"::nova_rbd_ceph_conf_path","commit_id":"a9e72de2baad19a6d801aa2f47a1129001fe48d6"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"42f88d4093f0617cb554d60e749201f346ef721c","unresolved":false,"context_lines":[{"line_number":779,"context_line":"                - {get_param: CephClusterName}"},{"line_number":780,"context_line":"                - \u0027.conf\u0027"},{"line_number":781,"context_line":"            nova::compute::rbd::libvirt_rbd_user: {get_param: CephClientUserName}"},{"line_number":782,"context_line":"            tripleo::profile::base::nova::compute_libvirt_shared::nova_ceph_conf: {get_param: CephConfigPath}"},{"line_number":783,"context_line":"            nova::compute::rbd::rbd_keyring:"},{"line_number":784,"context_line":"              list_join:"},{"line_number":785,"context_line":"              - \u0027.\u0027"}],"source_content_type":"text/x-yaml","patch_set":33,"id":"fc6e8727_436c8c5a","line":782,"in_reply_to":"881776b8_029557a1","updated":"2020-12-01 08:43:08.000000000","message":"Done","commit_id":"a9e72de2baad19a6d801aa2f47a1129001fe48d6"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"3f2f8b35b728738cc1dbe30b32d6f1fb411fd9ae","unresolved":true,"context_lines":[{"line_number":779,"context_line":"                - {get_param: CephClusterName}"},{"line_number":780,"context_line":"                - \u0027.conf\u0027"},{"line_number":781,"context_line":"            nova::compute::rbd::libvirt_rbd_user: {get_param: CephClientUserName}"},{"line_number":782,"context_line":"            tripleo::profile::base::nova::compute_libvirt_shared::nova_ceph_conf_path: {get_param: CephConfigPath}"},{"line_number":783,"context_line":"            nova::compute::rbd::rbd_keyring:"},{"line_number":784,"context_line":"              list_join:"},{"line_number":785,"context_line":"              - \u0027.\u0027"}],"source_content_type":"text/x-yaml","patch_set":34,"id":"f202c4da_b970c8e7","line":782,"updated":"2020-12-03 22:17:58.000000000","message":"I think this line is extraneous because that puppet module doesn\u0027t have a nova_ceph_conf_path\u0027 input parameter. It does have a \u0027nova_rbd_ceph_conf_path\u0027 parameter, which is handled elsewhere in this patch (in nova-libvirt-container-puppet.yaml)","commit_id":"4a26a0a88ce226bcf21c369d51ebb4057798e949"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"9893293630f9032fac2e9b300995aaa490dd69b4","unresolved":false,"context_lines":[{"line_number":779,"context_line":"                - {get_param: CephClusterName}"},{"line_number":780,"context_line":"                - \u0027.conf\u0027"},{"line_number":781,"context_line":"            nova::compute::rbd::libvirt_rbd_user: {get_param: CephClientUserName}"},{"line_number":782,"context_line":"            tripleo::profile::base::nova::compute_libvirt_shared::nova_ceph_conf_path: {get_param: CephConfigPath}"},{"line_number":783,"context_line":"            nova::compute::rbd::rbd_keyring:"},{"line_number":784,"context_line":"              list_join:"},{"line_number":785,"context_line":"              - \u0027.\u0027"}],"source_content_type":"text/x-yaml","patch_set":34,"id":"efe2bfb1_b27bba11","line":782,"in_reply_to":"f202c4da_b970c8e7","updated":"2020-12-04 07:44:27.000000000","message":"yeah, you\u0027re right, this comes from an old PS and it wasn\u0027t removed (and it\u0027s basically useless since the real parameter is the one you mentioned).\nRemoving it in the next PS.\nThanks Alan!","commit_id":"4a26a0a88ce226bcf21c369d51ebb4057798e949"}],"deployment/nova/nova-libvirt-container-puppet.yaml":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"a84069e54ee11d223c827d913b60c271906d1a91","unresolved":true,"context_lines":[{"line_number":386,"context_line":"                - {get_param: CephClusterName}"},{"line_number":387,"context_line":"                - \u0027.conf\u0027"},{"line_number":388,"context_line":"            nova::compute::rbd::libvirt_rbd_user: {get_param: CephClientUserName}"},{"line_number":389,"context_line":"            nova::compute::rbd::libvirt_rbd_ceph_conf: {get_param: CephConfigPath}"},{"line_number":390,"context_line":"            nova::compute::rbd::rbd_keyring:"},{"line_number":391,"context_line":"              list_join:"},{"line_number":392,"context_line":"              - \u0027.\u0027"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"371aa1fc_8ce663b7","line":389,"updated":"2020-11-24 18:12:11.000000000","message":"remove this, set tripleo::profile::base::nova::compute_libvirt_shared::nova_ceph_conf instead","commit_id":"c31498dc754932e30252fb286aa9254af29122ba"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"e10c6114c4900b2529dc2693c5a037aa3bc98081","unresolved":false,"context_lines":[{"line_number":386,"context_line":"                - {get_param: CephClusterName}"},{"line_number":387,"context_line":"                - \u0027.conf\u0027"},{"line_number":388,"context_line":"            nova::compute::rbd::libvirt_rbd_user: {get_param: CephClientUserName}"},{"line_number":389,"context_line":"            nova::compute::rbd::libvirt_rbd_ceph_conf: {get_param: CephConfigPath}"},{"line_number":390,"context_line":"            nova::compute::rbd::rbd_keyring:"},{"line_number":391,"context_line":"              list_join:"},{"line_number":392,"context_line":"              - \u0027.\u0027"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"aef5fc9a_2d679078","line":389,"in_reply_to":"371aa1fc_8ce663b7","updated":"2020-11-25 06:24:11.000000000","message":"Done","commit_id":"c31498dc754932e30252fb286aa9254af29122ba"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"68f1b59bde283d3dd5f2019f852d9fb118e0716d","unresolved":true,"context_lines":[{"line_number":386,"context_line":"                - {get_param: CephClusterName}"},{"line_number":387,"context_line":"                - \u0027.conf\u0027"},{"line_number":388,"context_line":"            nova::compute::rbd::libvirt_rbd_user: {get_param: CephClientUserName}"},{"line_number":389,"context_line":"            tripleo::profile::base::nova::compute_libvirt_shared::nova_ceph_conf: {get_param: CephConfigPath}"},{"line_number":390,"context_line":"            nova::compute::rbd::rbd_keyring:"},{"line_number":391,"context_line":"              list_join:"},{"line_number":392,"context_line":"              - \u0027.\u0027"}],"source_content_type":"text/x-yaml","patch_set":33,"id":"6973ee65_1507541a","line":389,"updated":"2020-11-30 22:34:04.000000000","message":"::nova_rbd_ceph_conf_path","commit_id":"a9e72de2baad19a6d801aa2f47a1129001fe48d6"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"42f88d4093f0617cb554d60e749201f346ef721c","unresolved":false,"context_lines":[{"line_number":386,"context_line":"                - {get_param: CephClusterName}"},{"line_number":387,"context_line":"                - \u0027.conf\u0027"},{"line_number":388,"context_line":"            nova::compute::rbd::libvirt_rbd_user: {get_param: CephClientUserName}"},{"line_number":389,"context_line":"            tripleo::profile::base::nova::compute_libvirt_shared::nova_ceph_conf: {get_param: CephConfigPath}"},{"line_number":390,"context_line":"            nova::compute::rbd::rbd_keyring:"},{"line_number":391,"context_line":"              list_join:"},{"line_number":392,"context_line":"              - \u0027.\u0027"}],"source_content_type":"text/x-yaml","patch_set":33,"id":"6fbd99cd_bb602400","line":389,"in_reply_to":"6973ee65_1507541a","updated":"2020-12-01 08:43:08.000000000","message":"Done","commit_id":"a9e72de2baad19a6d801aa2f47a1129001fe48d6"}]}