)]}'
{"deployment/octavia/octavia-api-container-puppet.yaml":[{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"4997d4f72a94dff502779ff8d1e294102f914d6f","unresolved":true,"context_lines":[{"line_number":409,"context_line":"              when: step|int \u003d\u003d 1"},{"line_number":410,"context_line":"              block: \u0026octavia_api_tmpfile_cleanup"},{"line_number":411,"context_line":"                - name: octavia_api_tmpfile_cleanup"},{"line_number":412,"context_line":"                  file:"},{"line_number":413,"context_line":"                    path: /etc/tmpfiles.d/var-run-octavia.conf"},{"line_number":414,"context_line":"                    state: absent"},{"line_number":415,"context_line":"            - name: Set internal tls variable"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"90abfad4_e9f50a65","line":412,"range":{"start_line":412,"start_character":17,"end_line":412,"end_character":23},"updated":"2021-01-21 11:15:56.000000000","message":"\"state: absent\" here ?","commit_id":"4bd15a972a977fd2b73a00c266f349656cc08b29"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"7ba5afe3c2c5dd8e4a12be68e1e33fabae0d1cde","unresolved":true,"context_lines":[{"line_number":411,"context_line":"                - name: octavia_api_tmpfile_cleanup"},{"line_number":412,"context_line":"                  file:"},{"line_number":413,"context_line":"                    path: /etc/tmpfiles.d/var-run-octavia.conf"},{"line_number":414,"context_line":"                    state: absent"},{"line_number":415,"context_line":"            - name: Set internal tls variable"},{"line_number":416,"context_line":"              set_fact:"},{"line_number":417,"context_line":"                internal_tls_enabled: {get_param: EnableInternalTLS}"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"0283260a_11b70011","line":414,"range":{"start_line":414,"start_character":27,"end_line":414,"end_character":33},"updated":"2021-01-25 14:06:12.000000000","message":"is this the absent you are looking for?","commit_id":"4bd15a972a977fd2b73a00c266f349656cc08b29"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"46facb1a39e2018aef7537c7cad4817d6d409c98","unresolved":false,"context_lines":[{"line_number":411,"context_line":"                - name: octavia_api_tmpfile_cleanup"},{"line_number":412,"context_line":"                  file:"},{"line_number":413,"context_line":"                    path: /etc/tmpfiles.d/var-run-octavia.conf"},{"line_number":414,"context_line":"                    state: absent"},{"line_number":415,"context_line":"            - name: Set internal tls variable"},{"line_number":416,"context_line":"              set_fact:"},{"line_number":417,"context_line":"                internal_tls_enabled: {get_param: EnableInternalTLS}"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"e42d40f1_936f0023","line":414,"range":{"start_line":414,"start_character":27,"end_line":414,"end_character":33},"in_reply_to":"0283260a_11b70011","updated":"2021-01-25 16:43:33.000000000","message":"hehe, right, that one :)","commit_id":"4bd15a972a977fd2b73a00c266f349656cc08b29"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"3ba45e141832ce11daf744154d7af239eb068454","unresolved":true,"context_lines":[{"line_number":406,"context_line":"        list_concat:"},{"line_number":407,"context_line":"          - {get_attr: [OctaviaBase, role_data, update_tasks]}"},{"line_number":408,"context_line":"          - - name: octavia_api_tmpfile_cleanup"},{"line_number":409,"context_line":"              when: step|int \u003d\u003d 1"},{"line_number":410,"context_line":"              block: \u0026octavia_api_tmpfile_cleanup"},{"line_number":411,"context_line":"                - name: octavia_api_tmpfile_cleanup"},{"line_number":412,"context_line":"                  file:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7a3be233_c61920c1","line":409,"updated":"2021-01-27 10:22:40.000000000","message":"So octaviabase update is run at step 5, and this cleanup is done at step 1, is that expected ?","commit_id":"3692bb7357f77a6272bc65a6dc8dc2510bda52ec"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"67f2107ef0dfbf6d944a1c404e2bfe806ef3a885","unresolved":false,"context_lines":[{"line_number":406,"context_line":"        list_concat:"},{"line_number":407,"context_line":"          - {get_attr: [OctaviaBase, role_data, update_tasks]}"},{"line_number":408,"context_line":"          - - name: octavia_api_tmpfile_cleanup"},{"line_number":409,"context_line":"              when: step|int \u003d\u003d 1"},{"line_number":410,"context_line":"              block: \u0026octavia_api_tmpfile_cleanup"},{"line_number":411,"context_line":"                - name: octavia_api_tmpfile_cleanup"},{"line_number":412,"context_line":"                  file:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"f6a5b5e1_3d2ef44b","line":409,"in_reply_to":"0e153fdf_c90f9a61","updated":"2021-01-28 09:41:57.000000000","message":"Ack","commit_id":"3692bb7357f77a6272bc65a6dc8dc2510bda52ec"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"7274618e6fd00cefe9a57f7b2aab2997da34e96b","unresolved":true,"context_lines":[{"line_number":406,"context_line":"        list_concat:"},{"line_number":407,"context_line":"          - {get_attr: [OctaviaBase, role_data, update_tasks]}"},{"line_number":408,"context_line":"          - - name: octavia_api_tmpfile_cleanup"},{"line_number":409,"context_line":"              when: step|int \u003d\u003d 1"},{"line_number":410,"context_line":"              block: \u0026octavia_api_tmpfile_cleanup"},{"line_number":411,"context_line":"                - name: octavia_api_tmpfile_cleanup"},{"line_number":412,"context_line":"                  file:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"0e153fdf_c90f9a61","line":409,"in_reply_to":"7a3be233_c61920c1","updated":"2021-01-27 14:54:52.000000000","message":"Yes. This upgrade step removes a file that was introduced in a previous release. There is an updated version of this file on line 400.","commit_id":"3692bb7357f77a6272bc65a6dc8dc2510bda52ec"}],"deployment/octavia/octavia-base.yaml":[{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"4997d4f72a94dff502779ff8d1e294102f914d6f","unresolved":true,"context_lines":[{"line_number":309,"context_line":"            - {}"},{"line_number":310,"context_line":"            - octavia::certificates::client_cert_data: {get_param: OctaviaClientCert}"},{"line_number":311,"context_line":"      update_tasks: \u0026ensure_start_up_files"},{"line_number":312,"context_line":"        - name: make sure that post-deploy.conf exists before restarting containers on update or upgrade"},{"line_number":313,"context_line":"          block:"},{"line_number":314,"context_line":"            - name: check for octavia post-deploy.conf file"},{"line_number":315,"context_line":"              stat:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"0855e6f8_b59778ea","line":312,"range":{"start_line":312,"start_character":10,"end_line":312,"end_character":21},"updated":"2021-01-21 11:15:56.000000000","message":"I think we\u0027re missing a \"when step|int \u003d\u003d X\" conditional here, and that those tasks will be run at every step of the update. \n\nNot sure how this work with the yaml reference for the upgrade tasks though (I think it\u0027s possible to ref the block without the when ... and I think you just do that in other file)\n\nI saw step 1 was used in a previous file, but container restart only happen after all update tasks, so step 5 would be as good. at step 5 all rpm have been updated, but I don\u0027t know if that would make a difference here.","commit_id":"4bd15a972a977fd2b73a00c266f349656cc08b29"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"7ba5afe3c2c5dd8e4a12be68e1e33fabae0d1cde","unresolved":true,"context_lines":[{"line_number":309,"context_line":"            - {}"},{"line_number":310,"context_line":"            - octavia::certificates::client_cert_data: {get_param: OctaviaClientCert}"},{"line_number":311,"context_line":"      update_tasks: \u0026ensure_start_up_files"},{"line_number":312,"context_line":"        - name: make sure that post-deploy.conf exists before restarting containers on update or upgrade"},{"line_number":313,"context_line":"          block:"},{"line_number":314,"context_line":"            - name: check for octavia post-deploy.conf file"},{"line_number":315,"context_line":"              stat:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"55e8ce7c_abf7c8dc","line":312,"range":{"start_line":312,"start_character":10,"end_line":312,"end_character":21},"in_reply_to":"0855e6f8_b59778ea","updated":"2021-01-25 14:06:12.000000000","message":"yeah you\u0027re right. I think step 5 might be okay - it just has to be before the container startup definition changes are applied.","commit_id":"4bd15a972a977fd2b73a00c266f349656cc08b29"}]}