)]}'
{"common/deploy-steps.j2":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"670c84f98b22a19b320203bc38471dbf864a31af","unresolved":true,"context_lines":[{"line_number":694,"context_line":"                    mode: \u00270600\u0027"},{"line_number":695,"context_line":"{% endraw %}"},{"line_number":696,"context_line":"{% if step \u003d\u003d 1 %}"},{"line_number":697,"context_line":"                - name: Overcloud common bootstrap tasks for step 1"},{"line_number":698,"context_line":"                  block:"},{"line_number":699,"context_line":"                    - name: Overcloud common bootstrap tasks for step 1"},{"line_number":700,"context_line":"                      delegate_to: localhost"}],"source_content_type":"text/x-jinja2","patch_set":19,"id":"561404cb_b19cfa07","line":697,"range":{"start_line":697,"start_character":24,"end_line":697,"end_character":67},"updated":"2021-01-13 11:18:49.000000000","message":"this looks logical to me, *bootstrap* tasks for step 1 should be done *before* the Deploy step tasks for step 1, isn\u0027t it?","commit_id":"a3bf8aaf9df460cc79aa828cd549e99876b9fe2e"}],"deployment/frr/frr-container-ansible.yaml":[{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"46d1e13b4543834d8ef7f4a13afb8324ca103ac4","unresolved":true,"context_lines":[{"line_number":71,"context_line":"    type: ../containers-common.yaml"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"conditions:"},{"line_number":74,"context_line":"  bfd_enabled: {equals : [{get_param: FrrBfdEnabled}, True]}"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"outputs:"},{"line_number":77,"context_line":"  role_data:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"f0d0b708_b94e2298","line":74,"updated":"2020-11-26 07:56:06.000000000","message":"I\u0027ve seen this pattern in many other places in THT, but is it really needed? FrrBfdEnabled is a parameter of type boolean.","commit_id":"2c8169157b6bb8d22b075ce994e20a54ef72b579"},{"author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"change_message_id":"92c394ad69a83a83ca32826b401e30aab4a01fe8","unresolved":true,"context_lines":[{"line_number":71,"context_line":"    type: ../containers-common.yaml"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"conditions:"},{"line_number":74,"context_line":"  bfd_enabled: {equals : [{get_param: FrrBfdEnabled}, True]}"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"outputs:"},{"line_number":77,"context_line":"  role_data:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"77ffb0f9_b1af9e4d","line":74,"in_reply_to":"f0d0b708_b94e2298","updated":"2020-11-26 21:08:21.000000000","message":"I think we can move the whole {equals : [{get_param: FrrBfdEnabled}, True]} inside the if.\nI agree that is less verbose","commit_id":"2c8169157b6bb8d22b075ce994e20a54ef72b579"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"46d1e13b4543834d8ef7f4a13afb8324ca103ac4","unresolved":true,"context_lines":[{"line_number":82,"context_line":"      service_config_settings: {}"},{"line_number":83,"context_line":"      firewall_rules:"},{"line_number":84,"context_line":"        map_merge:"},{"line_number":85,"context_line":"          - \u0027156 bgp tcp\u0027:"},{"line_number":86,"context_line":"              proto: \u0027tcp\u0027"},{"line_number":87,"context_line":"              dport: 179"},{"line_number":88,"context_line":"          - if:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"e935937c_5b0649c9","line":85,"updated":"2020-11-26 07:56:06.000000000","message":"In PS 3 I added parameter FrrBgpEnabled defaulted to False. My thinking was to make the FRR service as much customizable as possible from the start. For example, it could later be extended to support OSPF and users wanting OSPF instead of BGP. What do you think? Am I being silly here? Wouldn\u0027t be the first time so fire away! 😉","commit_id":"2c8169157b6bb8d22b075ce994e20a54ef72b579"},{"author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"change_message_id":"92c394ad69a83a83ca32826b401e30aab4a01fe8","unresolved":true,"context_lines":[{"line_number":82,"context_line":"      service_config_settings: {}"},{"line_number":83,"context_line":"      firewall_rules:"},{"line_number":84,"context_line":"        map_merge:"},{"line_number":85,"context_line":"          - \u0027156 bgp tcp\u0027:"},{"line_number":86,"context_line":"              proto: \u0027tcp\u0027"},{"line_number":87,"context_line":"              dport: 179"},{"line_number":88,"context_line":"          - if:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1125a3d5_fbb320be","line":85,"in_reply_to":"e935937c_5b0649c9","updated":"2020-11-26 21:08:21.000000000","message":"Ah no I think I agree, we should make the bgp firewall rule conditionalized to that. \nI.e. all firewall rules will be conditionalized by their respective parameter. I think I like it actually","commit_id":"2c8169157b6bb8d22b075ce994e20a54ef72b579"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"706d6cd3e66d9686010355d70f93d0ad2acd72f4","unresolved":true,"context_lines":[{"line_number":109,"context_line":"        rsyslog:"},{"line_number":110,"context_line":"          tripleo_logging_sources_frr:"},{"line_number":111,"context_line":"            - {get_param: FrrLoggingSource}"},{"line_number":112,"context_line":"      firewall_rules:"},{"line_number":113,"context_line":"        map_merge:"},{"line_number":114,"context_line":"          - if:"},{"line_number":115,"context_line":"            - {get_param: FrrBgpEnabled}"},{"line_number":116,"context_line":"            - \u0027156 bgp tcp\u0027:"},{"line_number":117,"context_line":"                proto: \u0027tcp\u0027"},{"line_number":118,"context_line":"                dport: 179"},{"line_number":119,"context_line":"            - {}"},{"line_number":120,"context_line":"          - if:"},{"line_number":121,"context_line":"            - {get_param: FrrBfdEnabled}"},{"line_number":122,"context_line":"            - \u0027156 bfd udp\u0027:"},{"line_number":123,"context_line":"                 proto: \u0027udp\u0027"},{"line_number":124,"context_line":"                 dport:"},{"line_number":125,"context_line":"                 - 3784"},{"line_number":126,"context_line":"                 - 3785"},{"line_number":127,"context_line":"            - {}"},{"line_number":128,"context_line":"      kolla_config:"},{"line_number":129,"context_line":"        /var/lib/kolla/config_files/frr.json:"},{"line_number":130,"context_line":"          # (FIXME): This is currently a hack because watchfrr *always* demonizes"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"c96843da_acb82bcd","line":127,"range":{"start_line":112,"start_character":0,"end_line":127,"end_character":16},"updated":"2020-12-02 08:38:40.000000000","message":"Should this patch be ported to stable/train, please note firewall rules were converted to TripleO-Ansible in https://review.opendev.org/c/openstack/tripleo-heat-templates/+/677237 (\u003e\u003dUssuri).\n\nThe following was tested on a Train deployment:\n\n      config_settings:\n        map_merge:\n          - tripleo::frr::firewall_rules:\n              map_merge:\n                - if:\n                  - {get_param: FrrBgpEnabled}\n                  - \u0027156 bgp tcp\u0027:\n                      proto: \u0027tcp\u0027\n                      dport: 179\n                  - null\n                - if:\n                  - {get_param: FrrBfdEnabled}\n                  - \u0027156 bfd udp\u0027:\n                       proto: \u0027udp\u0027\n                       dport:\n                       - 3784\n                       - 3785\n                  - null\n          - {}","commit_id":"30455edc9c35282c32ac6a473468366c2938c78a"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"371f0a8e7a7234d1e3cf3761a0fefdb918d4a565","unresolved":true,"context_lines":[{"line_number":198,"context_line":"            tripleo_frr_log_level: {get_param: FrrLogLevel}"},{"line_number":199,"context_line":"            tripleo_frr_zebra: {get_param: FrrZebraEnabled}"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"        - name: Start frr containers before an ha service"},{"line_number":202,"context_line":"          when: step|int \u003d\u003d 1"},{"line_number":203,"context_line":"          shell: |"},{"line_number":204,"context_line":"            sudo paunch apply --file /var/lib/tripleo-config/container-startup-config/step_0/frr.json --config-id frr"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"      upgrade_tasks: []"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"410949e0_1214d08f","line":205,"range":{"start_line":201,"start_character":8,"end_line":205,"end_character":0},"updated":"2021-01-13 11:22:20.000000000","message":"this probably should be done via the new container management systemd implemented in tripleo-ansible? or at least via its paunch as a library implementation","commit_id":"a3bf8aaf9df460cc79aa828cd549e99876b9fe2e"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"46b7a17134f7e39f350bcdb82e5804ce8e7204c6","unresolved":true,"context_lines":[{"line_number":198,"context_line":"            tripleo_frr_log_level: {get_param: FrrLogLevel}"},{"line_number":199,"context_line":"            tripleo_frr_zebra: {get_param: FrrZebraEnabled}"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"        - name: Start frr containers before an ha service"},{"line_number":202,"context_line":"          when: step|int \u003d\u003d 1"},{"line_number":203,"context_line":"          shell: |"},{"line_number":204,"context_line":"            sudo paunch apply --file /var/lib/tripleo-config/container-startup-config/step_0/frr.json --config-id frr"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"      upgrade_tasks: []"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"6499e9f1_21246033","line":205,"range":{"start_line":201,"start_character":8,"end_line":205,"end_character":0},"in_reply_to":"410949e0_1214d08f","updated":"2021-01-13 14:23:28.000000000","message":"yea paunch is not a thing in master anymore","commit_id":"a3bf8aaf9df460cc79aa828cd549e99876b9fe2e"},{"author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"change_message_id":"52af8d1e97741ac51153282d3d8138ee0c24b1b1","unresolved":true,"context_lines":[{"line_number":198,"context_line":"            tripleo_frr_log_level: {get_param: FrrLogLevel}"},{"line_number":199,"context_line":"            tripleo_frr_zebra: {get_param: FrrZebraEnabled}"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"        - name: Start frr containers before an ha service"},{"line_number":202,"context_line":"          when: step|int \u003d\u003d 1"},{"line_number":203,"context_line":"          shell: |"},{"line_number":204,"context_line":"            sudo paunch apply --file /var/lib/tripleo-config/container-startup-config/step_0/frr.json --config-id frr"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"      upgrade_tasks: []"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"ec68cde9_246e6142","line":205,"range":{"start_line":201,"start_character":8,"end_line":205,"end_character":0},"in_reply_to":"6499e9f1_21246033","updated":"2021-01-18 08:49:58.000000000","message":"Yeah I first need to prove that this all does not work by pure accident and then I\u0027ll address this","commit_id":"a3bf8aaf9df460cc79aa828cd549e99876b9fe2e"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"8b6965cd0112d7a10bd99c4dd8d0c30fde734180","unresolved":false,"context_lines":[{"line_number":198,"context_line":"            tripleo_frr_log_level: {get_param: FrrLogLevel}"},{"line_number":199,"context_line":"            tripleo_frr_zebra: {get_param: FrrZebraEnabled}"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"        - name: Start frr containers before an ha service"},{"line_number":202,"context_line":"          when: step|int \u003d\u003d 1"},{"line_number":203,"context_line":"          shell: |"},{"line_number":204,"context_line":"            sudo paunch apply --file /var/lib/tripleo-config/container-startup-config/step_0/frr.json --config-id frr"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"      upgrade_tasks: []"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"c7868aab_5c36c943","line":205,"range":{"start_line":201,"start_character":8,"end_line":205,"end_character":0},"in_reply_to":"ec68cde9_246e6142","updated":"2021-01-20 09:35:35.000000000","message":"Done","commit_id":"a3bf8aaf9df460cc79aa828cd549e99876b9fe2e"},{"author":{"_account_id":20778,"name":"Damien Ciabrini","email":"dciabrin@redhat.com","username":"dciabrin"},"change_message_id":"c850ce66db31d606980e0c7f555c0935ecbf3178","unresolved":true,"context_lines":[{"line_number":142,"context_line":"      kolla_config:"},{"line_number":143,"context_line":"        /var/lib/kolla/config_files/frr.json:"},{"line_number":144,"context_line":"          # Note: This is currently needed because watchfrr *always* demonizes"},{"line_number":145,"context_line":"          command: bash -c $* -- eval /usr/lib/frr/frr start \u0026\u0026 /bin/sleep infinity"},{"line_number":146,"context_line":"          config_files:"},{"line_number":147,"context_line":"            - source: \"/var/lib/kolla/config_files/src/*\""},{"line_number":148,"context_line":"              dest: \"/\""}],"source_content_type":"text/x-yaml","patch_set":39,"id":"edeef05a_68778563","line":145,"updated":"2021-03-12 20:10:57.000000000","message":"would that work if we do \u0027exec /bin/sleep infinity\u0027? to get rid of the parent bash, or will that impact the frr daemon?","commit_id":"f7fda36e5277f51267f5b7802f24acd8708f7ab4"},{"author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"change_message_id":"7b78d1d1ed70f1932acb02e00826d8b520c6e10f","unresolved":true,"context_lines":[{"line_number":142,"context_line":"      kolla_config:"},{"line_number":143,"context_line":"        /var/lib/kolla/config_files/frr.json:"},{"line_number":144,"context_line":"          # Note: This is currently needed because watchfrr *always* demonizes"},{"line_number":145,"context_line":"          command: bash -c $* -- eval /usr/lib/frr/frr start \u0026\u0026 /bin/sleep infinity"},{"line_number":146,"context_line":"          config_files:"},{"line_number":147,"context_line":"            - source: \"/var/lib/kolla/config_files/src/*\""},{"line_number":148,"context_line":"              dest: \"/\""}],"source_content_type":"text/x-yaml","patch_set":39,"id":"28f1a4a6_829c2372","line":145,"in_reply_to":"edeef05a_68778563","updated":"2021-03-14 08:57:04.000000000","message":"I think that should, I\u0027ll address it as a patch on top. Since this version is what we tested extensively in our lab. Thanks for the feedback!","commit_id":"f7fda36e5277f51267f5b7802f24acd8708f7ab4"}],"releasenotes/notes/frr-support-21648d0660a810ac.yaml":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"53bc46370979178198e5272e132957f0ea173f9a","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    This adds support for BGP via the FRR service."}],"source_content_type":"text/x-yaml","patch_set":19,"id":"1b840495_72adb3fa","line":4,"range":{"start_line":4,"start_character":38,"end_line":4,"end_character":41},"updated":"2021-01-13 11:43:24.000000000","message":"OS::TripleO::Services::Frr","commit_id":"a3bf8aaf9df460cc79aa828cd549e99876b9fe2e"},{"author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"change_message_id":"52af8d1e97741ac51153282d3d8138ee0c24b1b1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    This adds support for BGP via the FRR service."}],"source_content_type":"text/x-yaml","patch_set":19,"id":"ee052bb4_2d740e31","line":4,"range":{"start_line":4,"start_character":38,"end_line":4,"end_character":41},"in_reply_to":"1b840495_72adb3fa","updated":"2021-01-18 08:49:58.000000000","message":"Done","commit_id":"a3bf8aaf9df460cc79aa828cd549e99876b9fe2e"}]}