)]}'
{"deployment/undercloud/undercloud-upgrade.yaml":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"576556cf00c92763fee1a9a337e3c025c294b932","unresolved":true,"context_lines":[{"line_number":86,"context_line":"          command: os-net-config --no-activate -c /etc/os-net-config/config.json -v --detailed-exit-codes"},{"line_number":87,"context_line":"          register: os_net_config_upgrade"},{"line_number":88,"context_line":"          failed_when: os_net_config_upgrade.rc not in [0,2]"},{"line_number":89,"context_line":"          changed_when: os_net_config_upgrade.rc \u003d\u003d 2"},{"line_number":90,"context_line":"        # Keepalived was deprecated and the VIPs are now deployed by"},{"line_number":91,"context_line":"        # os-net-config."},{"line_number":92,"context_line":"        # When Keepalived is stopped, it brings down the VIPs which is"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"b89c7209_d82e8e11","line":89,"updated":"2020-11-24 22:18:21.000000000","message":"We should only do this after leap and not always.  A minor update on the undercloud uses \u0027upgrade\u0027","commit_id":"903f4acfab0e26242729b64d26bdd25c09ebc417"},{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"117457036eff5e3fda2eab1500102fa5d03dbe60","unresolved":true,"context_lines":[{"line_number":86,"context_line":"          command: os-net-config --no-activate -c /etc/os-net-config/config.json -v --detailed-exit-codes"},{"line_number":87,"context_line":"          register: os_net_config_upgrade"},{"line_number":88,"context_line":"          failed_when: os_net_config_upgrade.rc not in [0,2]"},{"line_number":89,"context_line":"          changed_when: os_net_config_upgrade.rc \u003d\u003d 2"},{"line_number":90,"context_line":"        # Keepalived was deprecated and the VIPs are now deployed by"},{"line_number":91,"context_line":"        # os-net-config."},{"line_number":92,"context_line":"        # When Keepalived is stopped, it brings down the VIPs which is"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"cd9a5827_4f1bd2ff","line":89,"in_reply_to":"b89c7209_d82e8e11","updated":"2020-11-25 10:39:21.000000000","message":"thanks. fixed in next review","commit_id":"903f4acfab0e26242729b64d26bdd25c09ebc417"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"00c4c01fea40a30dcfb0ec20073b5925ece88651","unresolved":true,"context_lines":[{"line_number":81,"context_line":"            name: \u0027*\u0027"},{"line_number":82,"context_line":"            state: latest"},{"line_number":83,"context_line":"            exclude: ansible"},{"line_number":84,"context_line":"        - name: take new os-net-config parameters into account now"},{"line_number":85,"context_line":"          when:"},{"line_number":86,"context_line":"            - step|int \u003d\u003d 3"},{"line_number":87,"context_line":"            - upgrade_leapp_enabled"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5a69232a_6207cfe4","line":84,"updated":"2020-11-25 11:29:33.000000000","message":"I\u0027m not really familiar with os-net-config, but shouldn\u0027t we check if the config is present before running the command? https://github.com/openstack/tripleo-heat-templates/blob/313d8125cb8c0915aec12cf3ea7b925c8586a133/deployment/tripleo-packages/tripleo-packages-baremetal-puppet.yaml#L267-L271","commit_id":"a66ecf3e47e7c0f0ecd0cfdf763e0999a4fdc0d5"},{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"5cab71ee45e731a700cbedd968d4fba6ae48db02","unresolved":true,"context_lines":[{"line_number":81,"context_line":"            name: \u0027*\u0027"},{"line_number":82,"context_line":"            state: latest"},{"line_number":83,"context_line":"            exclude: ansible"},{"line_number":84,"context_line":"        - name: take new os-net-config parameters into account now"},{"line_number":85,"context_line":"          when:"},{"line_number":86,"context_line":"            - step|int \u003d\u003d 3"},{"line_number":87,"context_line":"            - upgrade_leapp_enabled"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"d5c98555_399e8af7","line":84,"in_reply_to":"5a69232a_6207cfe4","updated":"2020-11-26 00:59:45.000000000","message":"fixed in next patchset. thanks","commit_id":"a66ecf3e47e7c0f0ecd0cfdf763e0999a4fdc0d5"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"00c4c01fea40a30dcfb0ec20073b5925ece88651","unresolved":true,"context_lines":[{"line_number":84,"context_line":"        - name: take new os-net-config parameters into account now"},{"line_number":85,"context_line":"          when:"},{"line_number":86,"context_line":"            - step|int \u003d\u003d 3"},{"line_number":87,"context_line":"            - upgrade_leapp_enabled"},{"line_number":88,"context_line":"          command: os-net-config --no-activate -c /etc/os-net-config/config.json -v --detailed-exit-codes"},{"line_number":89,"context_line":"          register: os_net_config_upgrade"},{"line_number":90,"context_line":"          failed_when: os_net_config_upgrade.rc not in [0,2]"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"cbbb6870_7e25fa6a","line":87,"updated":"2020-11-25 11:29:33.000000000","message":"I think you will need to set this fact upgrade_leapp_enabled, otherwise this task will fail with underfined parameter upgrade_leapp_enabled as this is defined in tripleo-packages and we don\u0027t run those tasks during the undercloud upgrade:\nhttps://github.com/openstack/tripleo-heat-templates/blob/313d8125cb8c0915aec12cf3ea7b925c8586a133/deployment/tripleo-packages/tripleo-packages-baremetal-puppet.yaml#L117-L122","commit_id":"a66ecf3e47e7c0f0ecd0cfdf763e0999a4fdc0d5"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"9db02dab4efece5fea6cc5ced6d4021f4cdd34a9","unresolved":true,"context_lines":[{"line_number":84,"context_line":"        - name: take new os-net-config parameters into account now"},{"line_number":85,"context_line":"          when:"},{"line_number":86,"context_line":"            - step|int \u003d\u003d 3"},{"line_number":87,"context_line":"            - upgrade_leapp_enabled"},{"line_number":88,"context_line":"          command: os-net-config --no-activate -c /etc/os-net-config/config.json -v --detailed-exit-codes"},{"line_number":89,"context_line":"          register: os_net_config_upgrade"},{"line_number":90,"context_line":"          failed_when: os_net_config_upgrade.rc not in [0,2]"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"b254ec39_74cf6d74","line":87,"updated":"2020-11-25 15:44:31.000000000","message":"I\u0027m thinking a little bit more about this condition and I think it will never be met as we set LeappEnabled in the lifecycle environment files: https://github.com/openstack/tripleo-heat-templates/blob/stable/train/environments/lifecycle/upgrade-prepare.yaml#L20 and this file is passed only for the overcloud upgrade. So even though you will include the UpgradeLeappEnabled this won\u0027t get executed because it will set to false. Also, as you have already run leapp you will be in RHEL8, so the conditions to set the parameter won\u0027t be met:\n\nupgrade_leapp_enabled: \u003e-\n              {{ _upgradeLeappEnabled | bool and\n                 ansible_facts[\u0027distribution\u0027] \u003d\u003d \u0027RedHat\u0027 and\n                 ansible_facts[\u0027distribution_major_version\u0027] is version(\u00277\u0027, \u0027\u003d\u003d\u0027) }}\n\nI think we need to find some way to detect if Leapp has been executed or not, or if os-net-config requires a trigger.","commit_id":"a66ecf3e47e7c0f0ecd0cfdf763e0999a4fdc0d5"},{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"5cab71ee45e731a700cbedd968d4fba6ae48db02","unresolved":true,"context_lines":[{"line_number":84,"context_line":"        - name: take new os-net-config parameters into account now"},{"line_number":85,"context_line":"          when:"},{"line_number":86,"context_line":"            - step|int \u003d\u003d 3"},{"line_number":87,"context_line":"            - upgrade_leapp_enabled"},{"line_number":88,"context_line":"          command: os-net-config --no-activate -c /etc/os-net-config/config.json -v --detailed-exit-codes"},{"line_number":89,"context_line":"          register: os_net_config_upgrade"},{"line_number":90,"context_line":"          failed_when: os_net_config_upgrade.rc not in [0,2]"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"89ecc6a5_fa7b5cc1","line":87,"in_reply_to":"b254ec39_74cf6d74","updated":"2020-11-26 00:59:45.000000000","message":"I agree with you. Introducing UpgradeLeappEnabled will require to set it to true on \"openstack undercloud upgrade\" However, operator doesn\u0027t run \"openstack undercloud upgrade\" every five minutes. I still thing it will cause no harm even on next minor update run.","commit_id":"a66ecf3e47e7c0f0ecd0cfdf763e0999a4fdc0d5"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"633a27d7542aa90dafc2600ecab54d4716b1f1ba","unresolved":true,"context_lines":[{"line_number":82,"context_line":"            state: latest"},{"line_number":83,"context_line":"            exclude: ansible"},{"line_number":84,"context_line":"        - name: Check that os-net-config has configuration"},{"line_number":85,"context_line":"          when: step|int \u003d\u003d 3"},{"line_number":86,"context_line":"          stat:"},{"line_number":87,"context_line":"            path: /etc/os-net-config/config.json"},{"line_number":88,"context_line":"            get_attributes: false"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1dd65535_a0cd966c","line":85,"updated":"2020-11-27 12:59:46.000000000","message":"shouldn\u0027t that be step 0 or 1?","commit_id":"a4ed8120ff1b4aada84f2cbdb2bc231a77463fe1"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"f07037ff725950915985383d9c6d345351654e17","unresolved":true,"context_lines":[{"line_number":82,"context_line":"            state: latest"},{"line_number":83,"context_line":"            exclude: ansible"},{"line_number":84,"context_line":"        - name: Check that os-net-config has configuration"},{"line_number":85,"context_line":"          when: step|int \u003d\u003d 3"},{"line_number":86,"context_line":"          stat:"},{"line_number":87,"context_line":"            path: /etc/os-net-config/config.json"},{"line_number":88,"context_line":"            get_attributes: false"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"35597473_0b9bf746","line":85,"in_reply_to":"1dd65535_a0cd966c","updated":"2020-11-27 13:42:19.000000000","message":"LGTM if that works well for the previous tasks w/o properly configured DNS resolvers etc","commit_id":"a4ed8120ff1b4aada84f2cbdb2bc231a77463fe1"}]}