)]}'
{"deployment/cinder/cinder-common-container-puppet.yaml":[{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"45b0954c1e178969acd9dc71ec536bb959126411","unresolved":true,"context_lines":[{"line_number":131,"context_line":"        -"},{"line_number":132,"context_line":"          - name: cinder_enable_iscsi_backend fact"},{"line_number":133,"context_line":"            set_fact:"},{"line_number":134,"context_line":"              cinder_enable_iscsi_backend: {if: [cinder_iscsi_backend_enabled, true, false]}"},{"line_number":135,"context_line":"          - when: cinder_enable_iscsi_backend|bool"},{"line_number":136,"context_line":"            block:"},{"line_number":137,"context_line":"              - name: ensure LVM rpm dependencies are installed"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"a1855ca1_598cb5db","line":134,"updated":"2020-11-30 23:06:12.000000000","message":"is this part of the change actually necessary? just curious.","commit_id":"63b2a989ba4a79c204c6d2a4b1512e3a924ec434"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"ca2e39959e73962e5ea55c61e24624b591b90567","unresolved":true,"context_lines":[{"line_number":131,"context_line":"        -"},{"line_number":132,"context_line":"          - name: cinder_enable_iscsi_backend fact"},{"line_number":133,"context_line":"            set_fact:"},{"line_number":134,"context_line":"              cinder_enable_iscsi_backend: {if: [cinder_iscsi_backend_enabled, true, false]}"},{"line_number":135,"context_line":"          - when: cinder_enable_iscsi_backend|bool"},{"line_number":136,"context_line":"            block:"},{"line_number":137,"context_line":"              - name: ensure LVM rpm dependencies are installed"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"344a0db6_325f3e76","line":134,"in_reply_to":"a1855ca1_598cb5db","updated":"2020-11-30 23:25:26.000000000","message":"I believe the approaches are:\n\n1. Create a conditional as I did at L79, and use the conditional everywhere (L134 and L222)\n2. Skip the conditional, leave this line unchanged and use another {get_param: CinderEnableIscsiBackend} at the new L222 code\n\nI chose 1, but would be happy to switch if you prefer 2.","commit_id":"63b2a989ba4a79c204c6d2a4b1512e3a924ec434"}]}