)]}'
{"deployment/tripleo-packages/tripleo-packages-baremetal-puppet.yaml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"0e90eb2eaac197747a94dbb9f5c8b745a5e8bda5","unresolved":true,"context_lines":[{"line_number":268,"context_line":"          when: step|int \u003d\u003d 3"},{"line_number":269,"context_line":"          stat:"},{"line_number":270,"context_line":"            path: /etc/os-net-config/config.json"},{"line_number":271,"context_line":"          register: stat_config_json"},{"line_number":272,"context_line":"        - block:"},{"line_number":273,"context_line":"            - name: Upgrade os-net-config"},{"line_number":274,"context_line":"              package: name\u003dos-net-config state\u003dlatest"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"96a3ea26_e2cc4a6c","line":271,"updated":"2020-11-26 10:46:24.000000000","message":"Unfortunately using the stat module is a more expensive operation than shell/test. :( Are you sure you really want to do this?\n\nI would recommend at least removing some of the extra arguments that aren\u0027t needed, like checksum, etc which add to the cost.","commit_id":"7291adcc65285cc3141391217f090bc7f0f740a9"},{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"5900d9012c665a92e0d21ddebefab54ef1a05f38","unresolved":true,"context_lines":[{"line_number":268,"context_line":"          when: step|int \u003d\u003d 3"},{"line_number":269,"context_line":"          stat:"},{"line_number":270,"context_line":"            path: /etc/os-net-config/config.json"},{"line_number":271,"context_line":"          register: stat_config_json"},{"line_number":272,"context_line":"        - block:"},{"line_number":273,"context_line":"            - name: Upgrade os-net-config"},{"line_number":274,"context_line":"              package: name\u003dos-net-config state\u003dlatest"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"0335596c_a9c7d6d9","line":271,"in_reply_to":"96a3ea26_e2cc4a6c","updated":"2020-11-26 18:05:31.000000000","message":"I have created the following playbook\n\ncat test_stat.yml\n---\n- hosts: all\n  gather_facts: false\n  tasks:\n    - name: check stat\n      stat:\n        path: /etc/os-net-config/config.json\n        # get_attributes: false\n        # get_checksum: false\n        # get_mime: false\n      register: config_json\n    - name: check shell\n      shell: test -s /etc/os-net-config/config.json\n      register: os_net_config_has_config\n      failed_when: false\n\nand results are \n\nThursday 26 November 2020  12:46:53 -0500 (0:00:00.443)       0:00:01.006 *****\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\ncheck stat ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 0.51s\ncheck shell ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 0.44s\n\nWhen I uncomment get* I get results as \n\nThursday 26 November 2020  12:48:08 -0500 (0:00:00.412)       0:00:00.967 *****\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\ncheck stat ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 0.49s\ncheck shell ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 0.41s\nPlaybook run took 0 days, 0 hours, 0 minutes, 0 seconds\n\n\nThe difference is less than 0.1 second on local connection. Running ansible remotely gives the following result\n\nThursday 26 November 2020  18:02:52 +0000 (0:00:00.615)       0:00:01.434 *****\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\ncheck stat ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 0.72s\ncheck shell ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 0.62s\nPlaybook run took 0 days, 0 hours, 0 minutes, 1 seconds\n\nI will add\n        get_attributes: false\n        get_checksum: false\n        get_mime: false\n\nin next patchset. Thank you very much!","commit_id":"7291adcc65285cc3141391217f090bc7f0f740a9"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"0c317c3a763ef6e2e2e48e8aecb043cb7599d51c","unresolved":true,"context_lines":[{"line_number":271,"context_line":"            get_attributes: false"},{"line_number":272,"context_line":"            get_checksum: false"},{"line_number":273,"context_line":"            get_mime: false"},{"line_number":274,"context_line":"          register: stat_config_json"},{"line_number":275,"context_line":"        - block:"},{"line_number":276,"context_line":"            - name: Upgrade os-net-config"},{"line_number":277,"context_line":"              package: name\u003dos-net-config state\u003dlatest"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"4f56c89f_c54cecc8","line":274,"updated":"2020-12-01 14:34:44.000000000","message":"good suggestion, I also thought on this change when I saw your patch for the undercloud upgrade.","commit_id":"966144d40b1dc04846581d76e4877f3c0bbafcac"}]}