)]}'
{"network/ports/deployed_port.j2":[{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"a3b6ffa96f5774c15e417960dfd3205d7fd98793","unresolved":true,"context_lines":[{"line_number":60,"context_line":"      value:"},{"line_number":61,"context_line":"        ip_address: {get_param: [NodePortMap, DnsName, {{network.name}}, ip_address]}"},{"line_number":62,"context_line":"        ip_address_uri: {get_param: [NodePortMap, DnsName, {{network.name}}, ip_address_uri]}"},{"line_number":63,"context_line":"        ip_subnet: {get_param: [NodePortMap, DnsName, {{network.name}}, ip_subnet]}"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"outputs:"},{"line_number":66,"context_line":"  ip_address:"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"d1898e71_98db501d","line":63,"updated":"2020-12-05 00:29:23.000000000","message":"you need to wrap DnsName in a get_param here.","commit_id":"5cf74f7138f0dddcac1e27759461a67d94b181f2"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"d031ba1e882b777b58596a0b260f9e61d9567608","unresolved":false,"context_lines":[{"line_number":60,"context_line":"      value:"},{"line_number":61,"context_line":"        ip_address: {get_param: [NodePortMap, DnsName, {{network.name}}, ip_address]}"},{"line_number":62,"context_line":"        ip_address_uri: {get_param: [NodePortMap, DnsName, {{network.name}}, ip_address_uri]}"},{"line_number":63,"context_line":"        ip_subnet: {get_param: [NodePortMap, DnsName, {{network.name}}, ip_subnet]}"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"outputs:"},{"line_number":66,"context_line":"  ip_address:"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"c08f9cd0_9187693d","line":63,"in_reply_to":"d1898e71_98db501d","updated":"2020-12-05 00:47:31.000000000","message":"*facepalm*","commit_id":"5cf74f7138f0dddcac1e27759461a67d94b181f2"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"a3b6ffa96f5774c15e417960dfd3205d7fd98793","unresolved":true,"context_lines":[{"line_number":65,"context_line":"outputs:"},{"line_number":66,"context_line":"  ip_address:"},{"line_number":67,"context_line":"    description: {{network.name}} network IP"},{"line_number":68,"context_line":"    value: {get_attr: [{{network.name}}DeployedPort, ip_address]}"},{"line_number":69,"context_line":"  ip_address_uri:"},{"line_number":70,"context_line":"    description: {{network.name}} network IP (with brackets for IPv6 URLs)"},{"line_number":71,"context_line":"    value: {get_attr: [{{network.name}}DeployedPort, ip_address_uri]}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"edd33b6e_9d25f0be","line":68,"updated":"2020-12-05 00:29:23.000000000","message":"all of these outputs need to get_attr on the value of the resource, like so:\n\n{get_attr: [{{network.name}}DeployedPort, value, ip_address]}","commit_id":"5cf74f7138f0dddcac1e27759461a67d94b181f2"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"d031ba1e882b777b58596a0b260f9e61d9567608","unresolved":false,"context_lines":[{"line_number":65,"context_line":"outputs:"},{"line_number":66,"context_line":"  ip_address:"},{"line_number":67,"context_line":"    description: {{network.name}} network IP"},{"line_number":68,"context_line":"    value: {get_attr: [{{network.name}}DeployedPort, ip_address]}"},{"line_number":69,"context_line":"  ip_address_uri:"},{"line_number":70,"context_line":"    description: {{network.name}} network IP (with brackets for IPv6 URLs)"},{"line_number":71,"context_line":"    value: {get_attr: [{{network.name}}DeployedPort, ip_address_uri]}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"40ec33f0_b43e2999","line":68,"in_reply_to":"edd33b6e_9d25f0be","updated":"2020-12-05 00:47:31.000000000","message":"*double facepalm*","commit_id":"5cf74f7138f0dddcac1e27759461a67d94b181f2"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"6a8b53612c8eb65a4c59bb46a5e6e24a4a1c059f","unresolved":true,"context_lines":[{"line_number":60,"context_line":"      value:"},{"line_number":61,"context_line":"        ip_address: {get_param: [NodePortMap, {get_param: DnsName}, {{network.name}}, ip_address]}"},{"line_number":62,"context_line":"        ip_address_uri: {get_param: [NodePortMap, {get_param: DnsName}, {{network.name}}, ip_address_uri]}"},{"line_number":63,"context_line":"        ip_subnet: {get_param: [NodePortMap, {get_param: DnsName}, {{network.name}}, ip_subnet]}"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"outputs:"},{"line_number":66,"context_line":"  ip_address:"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"5b74285b_d9f86470","line":63,"updated":"2020-12-07 21:42:46.000000000","message":"looks like network.name needs to be made all lowercase here as that\u0027s how the values are in NodePortMap.","commit_id":"4a2f6d25fe59fcfc355e17936aa9843cde21496b"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"486b5c115d9abb04ccb98ec9c3b44128177d36d6","unresolved":false,"context_lines":[{"line_number":60,"context_line":"      value:"},{"line_number":61,"context_line":"        ip_address: {get_param: [NodePortMap, {get_param: DnsName}, {{network.name}}, ip_address]}"},{"line_number":62,"context_line":"        ip_address_uri: {get_param: [NodePortMap, {get_param: DnsName}, {{network.name}}, ip_address_uri]}"},{"line_number":63,"context_line":"        ip_subnet: {get_param: [NodePortMap, {get_param: DnsName}, {{network.name}}, ip_subnet]}"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"outputs:"},{"line_number":66,"context_line":"  ip_address:"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"b6972625_1eab77f5","line":63,"in_reply_to":"5b74285b_d9f86470","updated":"2020-12-08 02:33:55.000000000","message":"Done","commit_id":"4a2f6d25fe59fcfc355e17936aa9843cde21496b"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"8e4cc7a4358ba92a8ac1ae8ee2dc0acd578ca428","unresolved":true,"context_lines":[{"line_number":46,"context_line":"  NodeIndex: # Here for compatibility with from_pool.yaml"},{"line_number":47,"context_line":"    default: 0"},{"line_number":48,"context_line":"    type: number"},{"line_number":49,"context_line":"  NodePortMap:"},{"line_number":50,"context_line":"    description: \u003e"},{"line_number":51,"context_line":"      A map of deployed port data"},{"line_number":52,"context_line":"    default: {}"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"e20bd43a_793a0b96","line":49,"range":{"start_line":49,"start_character":2,"end_line":49,"end_character":13},"updated":"2021-03-17 05:58:33.000000000","message":"Can we not have used DeployedServerPortMap? This seems like it\u0027s duplicating it atleast for control plane fixed ips.","commit_id":"fc61731b8c5c95b2d7c380816f1067d91e7fe535"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"11805ff236ae456a3755db37570e1f49dcdc1ef9","unresolved":true,"context_lines":[{"line_number":46,"context_line":"  NodeIndex: # Here for compatibility with from_pool.yaml"},{"line_number":47,"context_line":"    default: 0"},{"line_number":48,"context_line":"    type: number"},{"line_number":49,"context_line":"  NodePortMap:"},{"line_number":50,"context_line":"    description: \u003e"},{"line_number":51,"context_line":"      A map of deployed port data"},{"line_number":52,"context_line":"    default: {}"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"61fca221_761d26e1","line":49,"range":{"start_line":49,"start_character":2,"end_line":49,"end_character":13},"in_reply_to":"e20bd43a_793a0b96","updated":"2021-03-17 10:23:42.000000000","message":"I used a new parameter here because the DeployedServerPortMap and deployed-server/deployed-neutron-port.yaml outputs a \"mirror\" of a neutron port. The existing network/ports/port.j2 output is different as the output is ip_address, ip_address_uri and ip_subnet. Re-using DeployedServerPortMap would mean adding the complex intrinsic functions[1] used in network/ports/port.j2 here. I think it was easier to do the data formating in the ansible module.\n\n  DeployedServerPortMap:\n    overcloud-controller-0-ctlplane:\n      fixed_ips:\n      - ip_address: 192.168.24.22\n\n  NodePortMap:\n    overcloud-controller-0:\n      external:\n        ip_address: 10.0.0.48\n        ip_address_uri: 10.0.0.48\n        ip_subnet: 10.0.0.48/24\n\n\n[1] https://opendev.org/openstack/tripleo-heat-templates/src/branch/master/network/ports/port.j2#L106-L126","commit_id":"fc61731b8c5c95b2d7c380816f1067d91e7fe535"}]}