)]}'
{"deployment/logging/files/nova-libvirt.yaml":[{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"84d6736c7bf526471ac5ad03ae8d5d9de6924bd0","unresolved":true,"context_lines":[{"line_number":13,"context_line":"    description: Set to True to enable debugging libvirt services."},{"line_number":14,"context_line":"    type: string"},{"line_number":15,"context_line":"    constraints:"},{"line_number":16,"context_line":"      - allowed_values: [ \u0027\u0027, \u0027true\u0027, \u0027True\u0027, \u0027TRUE\u0027, \u0027false\u0027, \u0027False\u0027, \u0027FALSE\u0027]"},{"line_number":17,"context_line":"  LibvirtLogLevel:"},{"line_number":18,"context_line":"    default: 3"},{"line_number":19,"context_line":"    description: Defines log level in libvirt to filter log output."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"45e17cb9_bbaf8f30","line":16,"updated":"2020-11-30 22:54:57.000000000","message":"why not just make this a boolean?","commit_id":"b582c423ee2eddf4e0d4d02ec55d90f4c58ef4a2"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"72caab064218cd0efd577b0e85f45b6b99c5eb82","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    description: Set to True to enable debugging libvirt services."},{"line_number":14,"context_line":"    type: string"},{"line_number":15,"context_line":"    constraints:"},{"line_number":16,"context_line":"      - allowed_values: [ \u0027\u0027, \u0027true\u0027, \u0027True\u0027, \u0027TRUE\u0027, \u0027false\u0027, \u0027False\u0027, \u0027FALSE\u0027]"},{"line_number":17,"context_line":"  LibvirtLogLevel:"},{"line_number":18,"context_line":"    default: 3"},{"line_number":19,"context_line":"    description: Defines log level in libvirt to filter log output."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"debccc5a_47904e42","line":16,"in_reply_to":"2de6286f_a97a3675","updated":"2021-01-18 19:07:59.000000000","message":"ok, makes sense. sorry for the confusion.","commit_id":"b582c423ee2eddf4e0d4d02ec55d90f4c58ef4a2"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"4df76e85a9b29f4c568d33f93c335ce5b3f6350c","unresolved":true,"context_lines":[{"line_number":13,"context_line":"    description: Set to True to enable debugging libvirt services."},{"line_number":14,"context_line":"    type: string"},{"line_number":15,"context_line":"    constraints:"},{"line_number":16,"context_line":"      - allowed_values: [ \u0027\u0027, \u0027true\u0027, \u0027True\u0027, \u0027TRUE\u0027, \u0027false\u0027, \u0027False\u0027, \u0027FALSE\u0027]"},{"line_number":17,"context_line":"  LibvirtLogLevel:"},{"line_number":18,"context_line":"    default: 3"},{"line_number":19,"context_line":"    description: Defines log level in libvirt to filter log output."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"2de6286f_a97a3675","line":16,"in_reply_to":"45e17cb9_bbaf8f30","updated":"2020-12-21 03:32:20.000000000","message":"We need to consider not only true/false but also \"unset\" about this parameter, to make this parameter effective only when it is explicitly define.\n\nThus we can\u0027t use boolean which allows only true or false.","commit_id":"b582c423ee2eddf4e0d4d02ec55d90f4c58ef4a2"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3d30e95210860fe5dd30ceb57d7b870e16034ab9","unresolved":true,"context_lines":[{"line_number":34,"context_line":"    and:"},{"line_number":35,"context_line":"      - equals:"},{"line_number":36,"context_line":"          - {get_param: LibvirtDebug}"},{"line_number":37,"context_line":"          - \u0027\u0027"},{"line_number":38,"context_line":"      - equals:"},{"line_number":39,"context_line":"          - {get_param: Debug}"},{"line_number":40,"context_line":"          - false"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"33702bd2_8d2e104d","line":37,"updated":"2021-01-27 12:00:24.000000000","message":"I noticed that this doesn\u0027t work well when LibvirtDebug: False is set... let me update the patch ASAP...","commit_id":"b582c423ee2eddf4e0d4d02ec55d90f4c58ef4a2"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"a37db456d13921c3288c0796986b419e0a3f3b17","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    and:"},{"line_number":35,"context_line":"      - equals:"},{"line_number":36,"context_line":"          - {get_param: LibvirtDebug}"},{"line_number":37,"context_line":"          - \u0027\u0027"},{"line_number":38,"context_line":"      - equals:"},{"line_number":39,"context_line":"          - {get_param: Debug}"},{"line_number":40,"context_line":"          - false"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9502e101_5fe7ad0b","line":37,"in_reply_to":"33702bd2_8d2e104d","updated":"2021-01-27 12:04:11.000000000","message":"Done","commit_id":"b582c423ee2eddf4e0d4d02ec55d90f4c58ef4a2"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"eaceaaf2cbbcb7f19293f7cc46c9915319d34201","unresolved":true,"context_lines":[{"line_number":11,"context_line":"  LibvirtDebug:"},{"line_number":12,"context_line":"    default: \u0027\u0027"},{"line_number":13,"context_line":"    description: Set to True to enable debugging libvirt services."},{"line_number":14,"context_line":"    type: string"},{"line_number":15,"context_line":"    constraints:"},{"line_number":16,"context_line":"      - allowed_values: [ \u0027\u0027, \u0027true\u0027, \u0027True\u0027, \u0027TRUE\u0027, \u0027false\u0027, \u0027False\u0027, \u0027FALSE\u0027]"},{"line_number":17,"context_line":"  LibvirtLogLevel:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"a41753b2_e6f20e4d","line":14,"range":{"start_line":14,"start_character":4,"end_line":14,"end_character":16},"updated":"2021-03-19 07:50:04.000000000","message":"Why is it not a boolean? \u0027Debug\u0027 has been converted to boolean with [1].\n\n[1] https://github.com/openstack/tripleo-heat-templates/commit/c9b7091536ad835634406c92db100bd186c6425d","commit_id":"a582b0ad87e614bfd216ad0d43586232dd9ed07d"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"eaceaaf2cbbcb7f19293f7cc46c9915319d34201","unresolved":true,"context_lines":[{"line_number":41,"context_line":"          - yaql:"},{"line_number":42,"context_line":"              expression: $.data.libvirt_debug.matches(\"true|True|TRUE\")"},{"line_number":43,"context_line":"              data:"},{"line_number":44,"context_line":"                libvirt_debug:"},{"line_number":45,"context_line":"                  get_param: LibvirtDebug"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"outputs:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"12271976_5478aa92","line":44,"updated":"2021-03-19 07:50:04.000000000","message":"we should get rid of these types of yaql crap from templates. I\u0027ve proposed https://review.opendev.org/c/openstack/tripleo-heat-templates/+/781602","commit_id":"a582b0ad87e614bfd216ad0d43586232dd9ed07d"}]}