)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16515,"name":"mbu","email":"mat.bultel@gmail.com","username":"matbu"},"change_message_id":"cca389db94dbed759bc97c57a5226801a85f106d","unresolved":true,"context_lines":[{"line_number":10,"context_line":"to have its hash_prefix parameter set."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: If46a83e5f476ab8ed553b67b624c780a21ee50a5"},{"line_number":13,"context_line":"Closes-bug: 2008411"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a2a8650_75cfa9a3","line":13,"range":{"start_line":13,"start_character":12,"end_line":13,"end_character":19},"updated":"2020-12-03 08:41:11.000000000","message":"The launch pad bug refer to nothing.\nPlease correct the url.","commit_id":"6c93d81648078950edf5822c91ddcaa8b3cbdb81"},{"author":{"_account_id":16515,"name":"mbu","email":"mat.bultel@gmail.com","username":"matbu"},"change_message_id":"9dbf26b7ea335f5881d9c3cdef9bb905ed486c62","unresolved":true,"context_lines":[{"line_number":10,"context_line":"to have its hash_prefix parameter set."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: If46a83e5f476ab8ed553b67b624c780a21ee50a5"},{"line_number":13,"context_line":"Closes-bug: 2008411"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ce0bfe8c_3bee8334","line":13,"range":{"start_line":13,"start_character":12,"end_line":13,"end_character":19},"in_reply_to":"2af28e00_c0dbad5b","updated":"2020-12-03 10:20:06.000000000","message":"Well, I would say Yes, in particular if you plan to backport this patch to older releases a LP will be nice to have (LP or BZ actually)","commit_id":"6c93d81648078950edf5822c91ddcaa8b3cbdb81"},{"author":{"_account_id":30095,"name":"Michele Valsecchi","email":"mvalsecc@redhat.com","username":"mvalsecc"},"change_message_id":"303f681d72cda469cc8cfdaf15d2018b11c81374","unresolved":true,"context_lines":[{"line_number":10,"context_line":"to have its hash_prefix parameter set."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: If46a83e5f476ab8ed553b67b624c780a21ee50a5"},{"line_number":13,"context_line":"Closes-bug: 2008411"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"2af28e00_c0dbad5b","line":13,"range":{"start_line":13,"start_character":12,"end_line":13,"end_character":19},"in_reply_to":"7a2a8650_75cfa9a3","updated":"2020-12-03 10:17:56.000000000","message":"OK! For the records, should have I opened a bug on launchpad, rather than on storyboard[1]?\n\n\n[1] https://storyboard.openstack.org/#!/story/2008411","commit_id":"6c93d81648078950edf5822c91ddcaa8b3cbdb81"},{"author":{"_account_id":30095,"name":"Michele Valsecchi","email":"mvalsecc@redhat.com","username":"mvalsecc"},"change_message_id":"159f088e167a68a26f0100911c0c9b28247ea8b9","unresolved":false,"context_lines":[{"line_number":10,"context_line":"to have its hash_prefix parameter set."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: If46a83e5f476ab8ed553b67b624c780a21ee50a5"},{"line_number":13,"context_line":"Closes-bug: 2008411"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"cece5b06_e02c8733","line":13,"range":{"start_line":13,"start_character":12,"end_line":13,"end_character":19},"in_reply_to":"ce0bfe8c_3bee8334","updated":"2020-12-03 13:00:37.000000000","message":"OK using \"Story: 2008411\" seems to be pointing to the correct link now. Thanks for making me notice that!","commit_id":"6c93d81648078950edf5822c91ddcaa8b3cbdb81"}],"deployment/swift/swift-base.yaml":[{"author":{"_account_id":30095,"name":"Michele Valsecchi","email":"mvalsecc@redhat.com","username":"mvalsecc"},"change_message_id":"55d806b6d0fa1c0fe6c4533914b868798b31b40a","unresolved":false,"context_lines":[{"line_number":35,"context_line":"      in the ring."},{"line_number":36,"context_line":"    hidden: true"},{"line_number":37,"context_line":"    type: string"},{"line_number":38,"context_line":"  SwiftHashPrefix:"},{"line_number":39,"context_line":"    default: \u0027\u0027"},{"line_number":40,"context_line":"    description: A random string to be used as an extra salt when hashing to determine mappings"},{"line_number":41,"context_line":"      in the ring."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"0e9865db_cb8819da","line":38,"range":{"start_line":38,"start_character":2,"end_line":38,"end_character":17},"updated":"2020-12-08 08:51:05.000000000","message":"I was only able to test this patch in a Queens POC, with this patch manually applied on it.\n\nResult: Success. \n\nIn an environment deployed with env file (1), I could not see the prefix being accidentally reverted to an empty string if no SwiftHashPrefix was passed... \n\n(1)\n~~~\n parameter_defaults:\n   ControllerExtraConfig:\n     swift::swift_hash_path_prefix: secret-prefix\n~~~\n\nI\u0027ve deployed multiple times, with different patterns, but I can confirm that:\n\n(for each controller node)\n- manually cleaning up swift_hash_path_prefix from /var/lib/config-data/puppet-generated/swift/etc/swift/swift.conf \n- deleting /etc/puppet/hieradata/controller_extraconfig.json\n- and then issuing multiple deployments using the following environment file (2).\n\n(2)\n~~~\nparameter_defaults:\n    SwiftHashPrefix: new-prefix-through-tht-param\n~~~\n\nstill resulted in the original prefix being applied: i.e. operators that manually set a prefix, using this template without passing a value, will not incur into problems.\n\n~~~\n[heat-admin@controller-0 ~]$ sudo -i\n[root@controller-0 ~]# cat /var/lib/config-data/puppet-generated/swift/etc/swift/swift.conf \n[swift-hash]\nswift_hash_path_suffix \u003d xxx\nswift_hash_path_prefix\u003dsecret-prefix\n\n[swift-constraints]\nmax_header_size\u003d8192\n\n[root@controller-1 ~]# grep -ir prefix /etc/puppet/hieradata/\n/etc/puppet/hieradata/service_configs.json:    \"gnocchi::storage::s3::s3_bucket_prefix\": \"\",\n/etc/puppet/hieradata/service_configs.json:    \"swift::swift_hash_path_prefix\": \"new-prefix-through-tht-param\", \u003c\u003d\u003d\u003d\u003d\n/etc/puppet/hieradata/service_configs.json:    \"tripleo::profile::base::swift::ringbuilder::raw_disk_prefix\": \"r1z1-\",\n/etc/puppet/hieradata/controller_extraconfig.json:    \"swift::swift_hash_path_prefix\": \"secret-prefix\" \u003c\u003d\u003d\u003d\u003d\u003d\n~~~\n\n\nBeing said that, in this exact environment I was not able to actually override the original prefix using (2).\n\nI\u0027ll test again in an environment that has no swift_hash_path_prefix set through (1), and confirm that swift_hash_path_prefix is properly set to the value of SwiftHashPrefix.","commit_id":"0e1c9618b98a0780362ab6761c3aab058dadc7d1"}]}