)]}'
{"common/deploy-steps.j2":[{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"4fc0625c57554cb0c5780c495de66b38290a78cc","unresolved":true,"context_lines":[{"line_number":581,"context_line":"                  run_once: true"},{"line_number":582,"context_line":"                  debug:"},{"line_number":583,"context_line":"                    msg: Use --start-at-task \u0027Server deployments\u0027 to resume from this task"},{"line_number":584,"context_line":"                - include_tasks: deployments.yaml"},{"line_number":585,"context_line":"                  vars:"},{"line_number":586,"context_line":"                    force: false"},{"line_number":587,"context_line":"                  with_items: \"{{ hostvars[inventory_hostname][\u0027pre_deployments_\u0027 ~ tripleo_role_name]|default([]) }}\""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"c485cbe9_955a15cd","line":584,"range":{"start_line":584,"start_character":16,"end_line":584,"end_character":49},"updated":"2021-01-12 10:51:23.000000000","message":"It seems we want tasks in deployments.yaml to run before network configuration (with reasoning that people may be using those to configure network per-requisites). I had earlier moved it after network config[1], but was reverted by Alex.\n\n[1] https://review.opendev.org/c/openstack/tripleo-heat-templates/+/749432/2/common/deploy-steps.j2#535","commit_id":"2360905beedc08bba7266c4327118773868fc4c7"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"bf29f05ed0bf36794fc3a2bec6266e0dd06b0b65","unresolved":true,"context_lines":[{"line_number":581,"context_line":"                  run_once: true"},{"line_number":582,"context_line":"                  debug:"},{"line_number":583,"context_line":"                    msg: Use --start-at-task \u0027Server deployments\u0027 to resume from this task"},{"line_number":584,"context_line":"                - include_tasks: deployments.yaml"},{"line_number":585,"context_line":"                  vars:"},{"line_number":586,"context_line":"                    force: false"},{"line_number":587,"context_line":"                  with_items: \"{{ hostvars[inventory_hostname][\u0027pre_deployments_\u0027 ~ tripleo_role_name]|default([]) }}\""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"b3f396e5_ba1ab942","line":584,"range":{"start_line":584,"start_character":16,"end_line":584,"end_character":49},"in_reply_to":"c485cbe9_955a15cd","updated":"2021-01-25 10:51:03.000000000","message":"The problem is that we mixed up PreNetworkConfig, which is supposed to run before network configurations, and ExtraConfigPre, which WAS supposed to run AFTER network configurations.\nWe should split these to and run PreNetworkConfig only before applying network configurations.","commit_id":"2360905beedc08bba7266c4327118773868fc4c7"}]}