)]}'
{"deployment/nova/nova-compute-container-puppet.yaml":[{"author":{"_account_id":29268,"name":"Matthew Heler","email":"matthew.heler@hotmail.com","username":"mheler"},"change_message_id":"cccedf17987a160ecf05c85cd204d2d5ba72915f","unresolved":true,"context_lines":[{"line_number":21,"context_line":"      file: /var/log/containers/nova/nova-compute.log"},{"line_number":22,"context_line":"  NovaComputeStartupDelay:"},{"line_number":23,"context_line":"    description: \u003e"},{"line_number":24,"context_line":"      Reserved RAM for host processes."},{"line_number":25,"context_line":"    type: number"},{"line_number":26,"context_line":"    default: 0"},{"line_number":27,"context_line":"    constraints:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"67f0cbf0_b0cd3432","line":24,"updated":"2020-12-09 19:19:33.000000000","message":"\"Reserved RAM for host processes\" - Seems incorrect for that this parameter is suppose to do ;)","commit_id":"a5d86a2477130cf0c543d0fb40389e7c7ea7f5b2"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"458effbc31c2b1ef75f9665af28238d94e1d431c","unresolved":true,"context_lines":[{"line_number":69,"context_line":"    type: json"},{"line_number":70,"context_line":"    tags:"},{"line_number":71,"context_line":"      - role_specific"},{"line_number":72,"context_line":"  NovaComputeStartupDelay:"},{"line_number":73,"context_line":"    default: 0"},{"line_number":74,"context_line":"    description: Delays the startup of nova-compute service after compute node is"},{"line_number":75,"context_line":"                 booted. This is to give a chance to ceph to get back healthy"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1349b568_6c85a209","line":72,"updated":"2020-12-16 15:27:14.000000000","message":"this should be a role parameter to be able to not enable/customize for a specific kind of compute nodes.","commit_id":"1f64679e95f8a1bf61b8fd957903d42fd0633289"},{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"1856cd1f1e470c2b04cd6b3d0a5b881b870bb320","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    type: json"},{"line_number":70,"context_line":"    tags:"},{"line_number":71,"context_line":"      - role_specific"},{"line_number":72,"context_line":"  NovaComputeStartupDelay:"},{"line_number":73,"context_line":"    default: 0"},{"line_number":74,"context_line":"    description: Delays the startup of nova-compute service after compute node is"},{"line_number":75,"context_line":"                 booted. This is to give a chance to ceph to get back healthy"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5343c4dd_bb4cc20b","line":72,"in_reply_to":"1349b568_6c85a209","updated":"2020-12-16 16:02:44.000000000","message":"Ack","commit_id":"1f64679e95f8a1bf61b8fd957903d42fd0633289"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"458effbc31c2b1ef75f9665af28238d94e1d431c","unresolved":true,"context_lines":[{"line_number":874,"context_line":"                    template: \u0027/var/lib/nova/delay-nova-compute --delay DELAY --nova-binary\u0027"},{"line_number":875,"context_line":"                    params: { DELAY: {get_param: NovaComputeStartupDelay} }"},{"line_number":876,"context_line":"                - \u0027\u0027"},{"line_number":877,"context_line":"              - if:"},{"line_number":878,"context_line":"                - enable_instance_ha"},{"line_number":879,"context_line":"                - /var/lib/nova/instanceha/check-run-nova-compute"},{"line_number":880,"context_line":"                - /usr/bin/nova-compute"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"19621312_eb650199","line":877,"updated":"2020-12-16 15:27:14.000000000","message":"@Michele, do we want this be able to be combined with instanceha, or should we prevent this combination? like e.g.\n/var/lib/nova/delay-nova-compute --delay DELAY --nova-binary /var/lib/nova/instanceha/check-run-nova-compute","commit_id":"1f64679e95f8a1bf61b8fd957903d42fd0633289"},{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"1856cd1f1e470c2b04cd6b3d0a5b881b870bb320","unresolved":true,"context_lines":[{"line_number":874,"context_line":"                    template: \u0027/var/lib/nova/delay-nova-compute --delay DELAY --nova-binary\u0027"},{"line_number":875,"context_line":"                    params: { DELAY: {get_param: NovaComputeStartupDelay} }"},{"line_number":876,"context_line":"                - \u0027\u0027"},{"line_number":877,"context_line":"              - if:"},{"line_number":878,"context_line":"                - enable_instance_ha"},{"line_number":879,"context_line":"                - /var/lib/nova/instanceha/check-run-nova-compute"},{"line_number":880,"context_line":"                - /usr/bin/nova-compute"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"8ed913af_47bf018e","line":877,"in_reply_to":"19621312_eb650199","updated":"2020-12-16 16:02:44.000000000","message":"We decided offline to not enable delay when instance ha is involved, I\u0027ll fix that.","commit_id":"1f64679e95f8a1bf61b8fd957903d42fd0633289"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"458effbc31c2b1ef75f9665af28238d94e1d431c","unresolved":true,"context_lines":[{"line_number":1137,"context_line":"            - name: If instance HA is enabled on the node activate the evacuation completed check"},{"line_number":1138,"context_line":"              file: path\u003d/var/lib/nova/instanceha/enabled state\u003dtouch"},{"line_number":1139,"context_line":"              when: iha_nodes.stdout|lower is search(\u0027\"\u0027+ansible_hostname|lower+\u0027\"\u0027)"},{"line_number":1140,"context_line":"          - name: Do we prepend nova startup with a delay"},{"line_number":1141,"context_line":"            set_fact:"},{"line_number":1142,"context_line":"              nova_compute_delay: {get_param: NovaComputeStartupDelay}"},{"line_number":1143,"context_line":"          - name: install nova-compute delay wrapper script"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"fd573376_fddeaeec","line":1140,"updated":"2020-12-16 15:27:14.000000000","message":"lets put both tasks in a block and only run if nova_compute_delay|int \u003e 0","commit_id":"1f64679e95f8a1bf61b8fd957903d42fd0633289"},{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"1856cd1f1e470c2b04cd6b3d0a5b881b870bb320","unresolved":true,"context_lines":[{"line_number":1137,"context_line":"            - name: If instance HA is enabled on the node activate the evacuation completed check"},{"line_number":1138,"context_line":"              file: path\u003d/var/lib/nova/instanceha/enabled state\u003dtouch"},{"line_number":1139,"context_line":"              when: iha_nodes.stdout|lower is search(\u0027\"\u0027+ansible_hostname|lower+\u0027\"\u0027)"},{"line_number":1140,"context_line":"          - name: Do we prepend nova startup with a delay"},{"line_number":1141,"context_line":"            set_fact:"},{"line_number":1142,"context_line":"              nova_compute_delay: {get_param: NovaComputeStartupDelay}"},{"line_number":1143,"context_line":"          - name: install nova-compute delay wrapper script"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"0564c899_ffbe0edd","line":1140,"in_reply_to":"fd573376_fddeaeec","updated":"2020-12-16 16:02:44.000000000","message":"In fact, it\u0027s really just a single task. The first task is getting the parameter from heat. This is pretty much how instanceha does it, except that the put it in a block because they have multiple things to do.","commit_id":"1f64679e95f8a1bf61b8fd957903d42fd0633289"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"a20efb32a295f1f6d2c08bd85aaa4b1efa65662e","unresolved":true,"context_lines":[{"line_number":69,"context_line":"    type: json"},{"line_number":70,"context_line":"    tags:"},{"line_number":71,"context_line":"      - role_specific"},{"line_number":72,"context_line":"  NovaComputeStartupDelay:"},{"line_number":73,"context_line":"    default: 0"},{"line_number":74,"context_line":"    description: Delays the startup of nova-compute service after compute node is"},{"line_number":75,"context_line":"                 booted. This is to give a chance to ceph to get back healthy"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"35a7afae_28768bc6","line":72,"updated":"2020-12-18 08:08:54.000000000","message":"please make this a role param so that the delay can be customized per role","commit_id":"27962a6e2f121d66bb9d3dd1f416d211d5e2d175"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"c707ce5b2c594b935f9f2c3dcd261767697f0f64","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    type: json"},{"line_number":70,"context_line":"    tags:"},{"line_number":71,"context_line":"      - role_specific"},{"line_number":72,"context_line":"  NovaComputeStartupDelay:"},{"line_number":73,"context_line":"    default: 0"},{"line_number":74,"context_line":"    description: Delays the startup of nova-compute service after compute node is"},{"line_number":75,"context_line":"                 booted. This is to give a chance to ceph to get back healthy"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"6e31afad_fcb1e219","line":72,"in_reply_to":"35a7afae_28768bc6","updated":"2022-12-12 13:59:56.000000000","message":"https://review.opendev.org/c/openstack/tripleo-heat-templates/+/867226","commit_id":"27962a6e2f121d66bb9d3dd1f416d211d5e2d175"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"83f6082bff61ef1996dd6a828d5a8e5184c98fa6","unresolved":true,"context_lines":[{"line_number":908,"context_line":"                    USER: {get_param: CephClientUserName}"},{"line_number":909,"context_line":"              owner: nova:nova"},{"line_number":910,"context_line":"              perm: \u00270600\u0027"},{"line_number":911,"context_line":"      container_config_scripts:"},{"line_number":912,"context_line":"        map_merge:"},{"line_number":913,"context_line":"          - {get_attr: [ContainersCommon, container_config_scripts]}"},{"line_number":914,"context_line":"          - {get_attr: [NovaComputeCommon, container_config_scripts]}"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"b2fc7197_51e83b74","line":911,"range":{"start_line":911,"start_character":6,"end_line":911,"end_character":30},"updated":"2021-01-11 23:22:00.000000000","message":"could also have re-used this to copy scripts into the container instead of using host_prep_tasks","commit_id":"6eb72aa769d1cfcb3af9c26df562a5410c61f013"},{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"e0ced21a1734b1f15b7c6f0d89aa2b9289b0fb01","unresolved":true,"context_lines":[{"line_number":908,"context_line":"                    USER: {get_param: CephClientUserName}"},{"line_number":909,"context_line":"              owner: nova:nova"},{"line_number":910,"context_line":"              perm: \u00270600\u0027"},{"line_number":911,"context_line":"      container_config_scripts:"},{"line_number":912,"context_line":"        map_merge:"},{"line_number":913,"context_line":"          - {get_attr: [ContainersCommon, container_config_scripts]}"},{"line_number":914,"context_line":"          - {get_attr: [NovaComputeCommon, container_config_scripts]}"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"90d60edb_bfe12c87","line":911,"range":{"start_line":911,"start_character":6,"end_line":911,"end_character":30},"in_reply_to":"b2fc7197_51e83b74","updated":"2021-01-12 02:09:14.000000000","message":"That\u0027s interesting, I just copied how instance-ha did it but I\u0027ll keep a note of that for the future, maybe revisit that in another change. Thanks.","commit_id":"6eb72aa769d1cfcb3af9c26df562a5410c61f013"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"b5ddbfde7bf8ac260ea4dabeb726f3a9b1265791","unresolved":true,"context_lines":[{"line_number":1147,"context_line":"          - name: install nova-compute delay wrapper script"},{"line_number":1148,"context_line":"            copy:"},{"line_number":1149,"context_line":"              content: {get_file: ../../scripts/delay-nova-compute}"},{"line_number":1150,"context_line":"              dest: /var/lib/nova/delay-nova-compute"},{"line_number":1151,"context_line":"              mode: 0755"},{"line_number":1152,"context_line":"            when: nova_compute_delay|int \u003e 0"},{"line_number":1153,"context_line":"          - name: Is irqbalance enabled"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7146d909_8e3b5abc","line":1150,"updated":"2021-01-11 17:56:15.000000000","message":"Does this need a container friendly selinux context set on it?","commit_id":"6eb72aa769d1cfcb3af9c26df562a5410c61f013"},{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"27d5a4a7213ee5064ad9d779117ed9eeebc9895f","unresolved":true,"context_lines":[{"line_number":1147,"context_line":"          - name: install nova-compute delay wrapper script"},{"line_number":1148,"context_line":"            copy:"},{"line_number":1149,"context_line":"              content: {get_file: ../../scripts/delay-nova-compute}"},{"line_number":1150,"context_line":"              dest: /var/lib/nova/delay-nova-compute"},{"line_number":1151,"context_line":"              mode: 0755"},{"line_number":1152,"context_line":"            when: nova_compute_delay|int \u003e 0"},{"line_number":1153,"context_line":"          - name: Is irqbalance enabled"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"cdb4378d_167e4d7e","line":1150,"in_reply_to":"7146d909_8e3b5abc","updated":"2021-01-11 18:32:53.000000000","message":"Based on my testing, no. It\u0027s the same as check-run-nova-compute we use for instance-ha. Should we force one on both these tools? It worked as-is but I didn\u0027t validate the audit logs.","commit_id":"6eb72aa769d1cfcb3af9c26df562a5410c61f013"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"83f6082bff61ef1996dd6a828d5a8e5184c98fa6","unresolved":true,"context_lines":[{"line_number":1147,"context_line":"          - name: install nova-compute delay wrapper script"},{"line_number":1148,"context_line":"            copy:"},{"line_number":1149,"context_line":"              content: {get_file: ../../scripts/delay-nova-compute}"},{"line_number":1150,"context_line":"              dest: /var/lib/nova/delay-nova-compute"},{"line_number":1151,"context_line":"              mode: 0755"},{"line_number":1152,"context_line":"            when: nova_compute_delay|int \u003e 0"},{"line_number":1153,"context_line":"          - name: Is irqbalance enabled"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"58975852_715f1d49","line":1150,"in_reply_to":"cdb4378d_167e4d7e","updated":"2021-01-11 23:22:00.000000000","message":"I suspect it\u0027s a happy accident. They happen to be in /var/lib/nova where the nova_statedir_owner container (L919) will be setting the selinux context and owner/group.","commit_id":"6eb72aa769d1cfcb3af9c26df562a5410c61f013"}]}