)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"8e42a37b988be2dbec983ee4d4e88f160499e98c","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Jose Luis Franco Arza \u003cjfrancoa@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-12-09 18:06:50 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[Train Only] Make the docker restart in hybrid state indempotent."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, we need to perform some docker container operation/restart in order"},{"line_number":10,"context_line":"to take configuration changes into account. However, these tasks are not"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"902cf6da_e68c751b","line":7,"range":{"start_line":7,"start_character":53,"end_line":7,"end_character":64},"updated":"2020-12-09 17:08:53.000000000","message":"Did you mean idempotent ?","commit_id":"ed2c79b6f57d72db3aa451dc034553cb0837f38a"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"98ace694598b01b0032eeed08ed1d0c22e0e27ce","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Jose Luis Franco Arza \u003cjfrancoa@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-12-09 18:06:50 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[Train Only] Make the docker restart in hybrid state indempotent."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, we need to perform some docker container operation/restart in order"},{"line_number":10,"context_line":"to take configuration changes into account. However, these tasks are not"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"de20f73c_45dd483c","line":7,"range":{"start_line":7,"start_character":53,"end_line":7,"end_character":64},"in_reply_to":"902cf6da_e68c751b","updated":"2020-12-10 15:43:32.000000000","message":"Done","commit_id":"ed2c79b6f57d72db3aa451dc034553cb0837f38a"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"3462ec120d53dd9f0b6b331c9bc375c349ed41f4","unresolved":true,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This change will only restart the container/service when the task that modifies"},{"line_number":15,"context_line":"the files is considered as changed. In order to achieve this we are replacing all"},{"line_number":16,"context_line":"the crudini shell taks by ini_file module calls."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Id8cc95fc4e714d934a503de32667dfde0bf9d9b5"},{"line_number":19,"context_line":"Closes-Bug: #1907655"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1aea6d7c_da2083c2","line":16,"updated":"2020-12-14 14:22:54.000000000","message":"Nit, commit message is jagged. Here\u0027s one that should line up better.\n\nCurrently, we need to perform some docker container \noperation/restart in order to take configuration changes\ninto account. However, these tasks are not idempotent, \nthe docker service restart will always run even though\nthe configuration file was already changed (in case you\nre-run the upgrade command).\n\nThis change will only restart the container/service when\nthe task that modifies the files is considered as changed.\nIn order to achieve this we are replacing all the crudini\nshell taks with ini_file module calls.","commit_id":"e3f776cc84a1f45d69adafbc5b1cb3dd15b47544"}],"deployment/ovn/ovn-metadata-container-puppet.yaml":[{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"d6abb452e72a45cdc365cc548ffdaf12d33af20a","unresolved":true,"context_lines":[{"line_number":384,"context_line":"              shell: |"},{"line_number":385,"context_line":"                crudini --verbose --set /var/lib/config-data/puppet-generated/neutron/etc/neutron/plugins/networking-ovn/networking-ovn-metadata-agent.ini ovn ovn_sb_connection \"{{ ovn_sb_conn_str }}\""},{"line_number":386,"context_line":"              registry: crudini_result"},{"line_number":387,"context_line":"              changed_when: crudini_result.stderr is match(\"^changed\")"},{"line_number":388,"context_line":"              when: ovn_sb_conn_str not in ovn_remote.stdout"},{"line_number":389,"context_line":"            - name: Restart ovn_metadata_agent container to apply change in networking-ovn-metadata-agent.ini"},{"line_number":390,"context_line":"              docker_container:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"8059ba33_83d8dfe9","line":387,"range":{"start_line":387,"start_character":14,"end_line":387,"end_character":70},"updated":"2020-12-09 17:13:48.000000000","message":"Looks good otherwise. \n\nNot sure if it\u0027s in scope for your work on this, but if you switch to the Ansiuble ini module you might get idempotence for free. \n\nhttps://docs.ansible.com/ansible/latest/collections/community/general/ini_file_module.html","commit_id":"ed2c79b6f57d72db3aa451dc034553cb0837f38a"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"6c78f397668ace9ece3cdc06e076f25299b4f4ae","unresolved":false,"context_lines":[{"line_number":384,"context_line":"              shell: |"},{"line_number":385,"context_line":"                crudini --verbose --set /var/lib/config-data/puppet-generated/neutron/etc/neutron/plugins/networking-ovn/networking-ovn-metadata-agent.ini ovn ovn_sb_connection \"{{ ovn_sb_conn_str }}\""},{"line_number":386,"context_line":"              registry: crudini_result"},{"line_number":387,"context_line":"              changed_when: crudini_result.stderr is match(\"^changed\")"},{"line_number":388,"context_line":"              when: ovn_sb_conn_str not in ovn_remote.stdout"},{"line_number":389,"context_line":"            - name: Restart ovn_metadata_agent container to apply change in networking-ovn-metadata-agent.ini"},{"line_number":390,"context_line":"              docker_container:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"0b802bd0_3b58e558","line":387,"range":{"start_line":387,"start_character":14,"end_line":387,"end_character":70},"in_reply_to":"48812914_af95082a","updated":"2020-12-11 16:57:46.000000000","message":"OK, cool. Are you going to try a PS here then with that module?","commit_id":"ed2c79b6f57d72db3aa451dc034553cb0837f38a"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"98ace694598b01b0032eeed08ed1d0c22e0e27ce","unresolved":false,"context_lines":[{"line_number":384,"context_line":"              shell: |"},{"line_number":385,"context_line":"                crudini --verbose --set /var/lib/config-data/puppet-generated/neutron/etc/neutron/plugins/networking-ovn/networking-ovn-metadata-agent.ini ovn ovn_sb_connection \"{{ ovn_sb_conn_str }}\""},{"line_number":386,"context_line":"              registry: crudini_result"},{"line_number":387,"context_line":"              changed_when: crudini_result.stderr is match(\"^changed\")"},{"line_number":388,"context_line":"              when: ovn_sb_conn_str not in ovn_remote.stdout"},{"line_number":389,"context_line":"            - name: Restart ovn_metadata_agent container to apply change in networking-ovn-metadata-agent.ini"},{"line_number":390,"context_line":"              docker_container:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"48812914_af95082a","line":387,"range":{"start_line":387,"start_character":14,"end_line":387,"end_character":70},"in_reply_to":"8059ba33_83d8dfe9","updated":"2020-12-10 15:43:32.000000000","message":"Thanks a lot for your suggestion, I did think that ini_file didn\u0027t work on remote servers, but that was only for reading ini files with the lookup ini. The ini_file module works like a charm, I did test it in an environment and the changes took place.","commit_id":"ed2c79b6f57d72db3aa451dc034553cb0837f38a"}]}