)]}'
{"common/deploy-steps-tasks-step-1.yaml":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"bfd3b748c0cab23039e228d82bbbf6a9c317a71d","unresolved":true,"context_lines":[{"line_number":24,"context_line":"  no_log: True"},{"line_number":25,"context_line":"  copy:"},{"line_number":26,"context_line":"    content: \"{{ lookup(\u0027file\u0027, tripleo_role_name + \u0027/step_config.pp\u0027, errors\u003d\u0027ignore\u0027) | default(\u0027\u0027, True) }}\""},{"line_number":27,"context_line":"    dest: /var/lib/tripleo-config/{{ ansible_check_mode | bool | ternary(\u0027check-mode/\u0027, \u0027\u0027) }}puppet_step_config.pp"},{"line_number":28,"context_line":"    force: yes"},{"line_number":29,"context_line":"    mode: \u00270600\u0027"},{"line_number":30,"context_line":"  tags:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"f0a59012_c668be8b","line":27,"updated":"2020-12-16 19:24:37.000000000","message":"This depends on the folder create but you moved it to later","commit_id":"86c5fc2e80003ecce2119cc781255356d6967370"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"8194b6d647f0ac3bc999c3276744ffa34f449a7d","unresolved":true,"context_lines":[{"line_number":24,"context_line":"  no_log: True"},{"line_number":25,"context_line":"  copy:"},{"line_number":26,"context_line":"    content: \"{{ lookup(\u0027file\u0027, tripleo_role_name + \u0027/step_config.pp\u0027, errors\u003d\u0027ignore\u0027) | default(\u0027\u0027, True) }}\""},{"line_number":27,"context_line":"    dest: /var/lib/tripleo-config/{{ ansible_check_mode | bool | ternary(\u0027check-mode/\u0027, \u0027\u0027) }}puppet_step_config.pp"},{"line_number":28,"context_line":"    force: yes"},{"line_number":29,"context_line":"    mode: \u00270600\u0027"},{"line_number":30,"context_line":"  tags:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"e93928fa_a7665e72","line":27,"in_reply_to":"f0a59012_c668be8b","updated":"2020-12-17 14:23:20.000000000","message":"Ack, I see...well, in that case the only thing I need is the tasks:\n\n- Create /var/lib/container-config-scripts\n- Write container config scripts\n\nI moved them all to a different file because all have the container_config_scripts tag, but maybe I can just isolate these two tasks and leave the other three as they are.\n\nThanks a lot for the review!","commit_id":"86c5fc2e80003ecce2119cc781255356d6967370"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"bfd3b748c0cab23039e228d82bbbf6a9c317a71d","unresolved":true,"context_lines":[{"line_number":147,"context_line":"  tags:"},{"line_number":148,"context_line":"    - container_startup_configs"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"- import_tasks: common_container_config_scripts.yaml"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"# This file location is deprecated and the new location is now:"},{"line_number":153,"context_line":"# /var/lib/tripleo-config/container-startup-config/step_X/\u003ccontainer_name\u003e.json"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"b76ee7c8_2da10e41","line":150,"updated":"2020-12-16 19:24:37.000000000","message":"the ordering is incorrect which is why i missed this import. That being said, all folders need to be created upfront. You\u0027ve moved the ordering.","commit_id":"86c5fc2e80003ecce2119cc781255356d6967370"}],"common/deploy-steps.j2":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"f2273ccdc95d799f269b7bfc845b32d615ce800f","unresolved":true,"context_lines":[{"line_number":704,"context_line":"                    - tripleo_role_name \u003d\u003d \u0027{{role.name}}\u0027"},{"line_number":705,"context_line":"                    - \"\u0027{{role.name}}/deploy_steps_tasks_step{{step}}.yaml\u0027 is exists\""},{"line_number":706,"context_line":"{%- endfor %}"},{"line_number":707,"context_line":"{% if step \u003d\u003d 1 %}"},{"line_number":708,"context_line":"                - name: Overcloud common bootstrap tasks for step 1"},{"line_number":709,"context_line":"                  block:"},{"line_number":710,"context_line":"                    - name: Overcloud common bootstrap tasks for step 1"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"8a83cd1e_3dd01d4f","line":707,"updated":"2020-12-16 16:02:20.000000000","message":"Please also add it here since you removed it, it needs to also be done during the deployment","commit_id":"86c5fc2e80003ecce2119cc781255356d6967370"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"7104415b4b58a86024c93d3f5ff1dc0cc5c61b29","unresolved":true,"context_lines":[{"line_number":704,"context_line":"                    - tripleo_role_name \u003d\u003d \u0027{{role.name}}\u0027"},{"line_number":705,"context_line":"                    - \"\u0027{{role.name}}/deploy_steps_tasks_step{{step}}.yaml\u0027 is exists\""},{"line_number":706,"context_line":"{%- endfor %}"},{"line_number":707,"context_line":"{% if step \u003d\u003d 1 %}"},{"line_number":708,"context_line":"                - name: Overcloud common bootstrap tasks for step 1"},{"line_number":709,"context_line":"                  block:"},{"line_number":710,"context_line":"                    - name: Overcloud common bootstrap tasks for step 1"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"a292c4bc_f9a3f50b","line":707,"in_reply_to":"8a83cd1e_3dd01d4f","updated":"2020-12-16 16:19:42.000000000","message":"Hey Alex, I\u0027m not sure I follow...I didn\u0027t add anything from here... the code still gets triggered from deployment\u0027s deploy_steps_tasks_step_1.yaml as you can see here https://review.opendev.org/c/openstack/tripleo-heat-templates/+/766972/2/common/deploy-steps-tasks-step-1.yaml , it\u0027s just that it is now organized in a single yaml so that we can invoke it before the update too.","commit_id":"86c5fc2e80003ecce2119cc781255356d6967370"}]}