)]}'
{"deployment/nova/nova-compute-container-puppet.yaml":[{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"b4f99323e506d5079f219edbd5dfec4e519236b9","unresolved":true,"context_lines":[{"line_number":629,"context_line":"              nova_compute_opt_volumes: NovaComputeOptVolumes"},{"line_number":630,"context_line":"              nova_compute_opt_env_vars: NovaComputeOptEnvVars"},{"line_number":631,"context_line":"              nova::workarounds::never_download_image_if_on_rbd: NovaDisableImageDownloadToRbd"},{"line_number":632,"context_line":"              nova::migration::live_migration_permit_post_copy: {get_param: NovaLiveMigrationPermitPostCopy}"},{"line_number":633,"context_line":"              nova::migration::live_migration_permit_auto_converge: {get_param: NovaLiveMigrationPermitAutoConverge}"},{"line_number":634,"context_line":"            - values: {get_param: [RoleParameters]}"},{"line_number":635,"context_line":"          - values:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1c27f6ad_d004797d","line":632,"updated":"2020-12-16 15:41:22.000000000","message":"lets do it like with the others and do the get_param bellow, like\nNovaLiveMigrationPermitPostCopy: {get_param: NovaLiveMigrationPermitPostCopy}\n\nand here then do \nnova::migration::live_migration_permit_post_copy: NovaLiveMigrationPermitPostCopy","commit_id":"644c907af5ab9ccc59ae57b7217ba059881bfe8f"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"c860560e7a844de33b0061bfa37290c589a4d2e3","unresolved":true,"context_lines":[{"line_number":715,"context_line":"              NovaComputeOptVolumes: {get_param: NovaComputeOptVolumes}"},{"line_number":716,"context_line":"              NovaComputeOptEnvVars: {get_param: NovaComputeOptEnvVars}"},{"line_number":717,"context_line":"              NovaDisableImageDownloadToRbd: {get_param: NovaDisableImageDownloadToRbd}"},{"line_number":718,"context_line":"              NovaLiveMigrationPermitPostCopy: {get_param: NovaLiveMigrationPermitPostCopy}"},{"line_number":719,"context_line":"              NovaLiveMigrationPermitAutoConverge: {get_param: NovaLiveMigrationPermitAutoConverge}"},{"line_number":720,"context_line":""},{"line_number":721,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5fd71bca_c953a09b","line":718,"updated":"2020-12-17 07:06:46.000000000","message":"instead of enable it in the different roles, we could also set it to true here if reserved_huge_pages_set. This would have the advantage that it will be enabled for all roles when HP get configured, but it might be more obvious to the user when we set it in the roles.","commit_id":"a4bdfaf1facbe03b41fec8080a7a9ce68ecf41e4"},{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"3aa49c165b91848a44423ca3436a17b988dd938c","unresolved":true,"context_lines":[{"line_number":715,"context_line":"              NovaComputeOptVolumes: {get_param: NovaComputeOptVolumes}"},{"line_number":716,"context_line":"              NovaComputeOptEnvVars: {get_param: NovaComputeOptEnvVars}"},{"line_number":717,"context_line":"              NovaDisableImageDownloadToRbd: {get_param: NovaDisableImageDownloadToRbd}"},{"line_number":718,"context_line":"              NovaLiveMigrationPermitPostCopy: {get_param: NovaLiveMigrationPermitPostCopy}"},{"line_number":719,"context_line":"              NovaLiveMigrationPermitAutoConverge: {get_param: NovaLiveMigrationPermitAutoConverge}"},{"line_number":720,"context_line":""},{"line_number":721,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3b4b83d4_0ac094a9","line":718,"in_reply_to":"5fd71bca_c953a09b","updated":"2020-12-19 20:11:08.000000000","message":"I really like the idea of autotuning the environment for the user. But I also like the idea to give the option to the user. If the user explicitely disables this in the templates but has a node with HP, this will override the user\u0027s config.\n\nIs there a way to get_param and detect if it\u0027s the default? We could probably put a default string if those were strings but they are booleans, so we\u0027re restricted with 2 choices only.","commit_id":"a4bdfaf1facbe03b41fec8080a7a9ce68ecf41e4"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"ad45ddd37ca31b0d993a8b3c0f636cc12544d11e","unresolved":true,"context_lines":[{"line_number":366,"context_line":"      Wether to switch the VM active on destination node before migration is complete,"},{"line_number":367,"context_line":"      therefore ensuring an upper bound on the memory that needs to be transferred."},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"      This is automatically enabled when `NovaReservedHugePages` are defined. We can override this"},{"line_number":370,"context_line":"      behavior by adding `nova::migration::live_migration_permit_post_copy` in `RoleExtraConfig`."},{"line_number":371,"context_line":"    default: false"},{"line_number":372,"context_line":"    type: boolean"},{"line_number":373,"context_line":"    tags:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"a79a5d66_c98ea911","line":370,"range":{"start_line":369,"start_character":78,"end_line":370,"end_character":97},"updated":"2021-01-12 21:39:30.000000000","message":"can just set it as a role parameter...","commit_id":"e0d0b5a5510e15934fb27b276a9cf8feb3c2f859"},{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"b232e66e81533cfd946ad083a12cc92dc66013ca","unresolved":false,"context_lines":[{"line_number":366,"context_line":"      Wether to switch the VM active on destination node before migration is complete,"},{"line_number":367,"context_line":"      therefore ensuring an upper bound on the memory that needs to be transferred."},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"      This is automatically enabled when `NovaReservedHugePages` are defined. We can override this"},{"line_number":370,"context_line":"      behavior by adding `nova::migration::live_migration_permit_post_copy` in `RoleExtraConfig`."},{"line_number":371,"context_line":"    default: false"},{"line_number":372,"context_line":"    type: boolean"},{"line_number":373,"context_line":"    tags:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7ea388bf_02502b49","line":370,"range":{"start_line":369,"start_character":78,"end_line":370,"end_character":97},"in_reply_to":"a79a5d66_c98ea911","updated":"2021-01-13 14:12:30.000000000","message":"Done","commit_id":"e0d0b5a5510e15934fb27b276a9cf8feb3c2f859"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"3ead18fa49521b8e6adbd743fa04ec8b16546577","unresolved":true,"context_lines":[{"line_number":372,"context_line":"    type: boolean"},{"line_number":373,"context_line":"    tags:"},{"line_number":374,"context_line":"      - role_specific"},{"line_number":375,"context_line":"  NovaLiveMigrationPermitAutoConverge:"},{"line_number":376,"context_line":"    description: |"},{"line_number":377,"context_line":"      Auto converge will throttles down CPU if a progress of on-going live migration is slow."},{"line_number":378,"context_line":"      Auto converge will only be used if this flag is set to True and post copy is not permitted"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3e28d908_e9f5ac84","line":375,"updated":"2021-01-12 22:00:42.000000000","message":"I think it would be much nicer to only automatically enable when the param is not explicitly set. There is no tri-state boolean type in heat though so it\u0027s a bit convoluted, something like:\n\n    parameters:\n      NovaLiveMigrationPermitPostCopy:\n          default: \u0027\u0027\n          type: string\n          constraints:\n            - allowed_values: [ \u0027\u0027, \u0027true\u0027, \u0027True\u0027, \u0027TRUE\u0027, \u0027false\u0027, \u0027False\u0027, \u0027FALSE\u0027]\n          etc...\n\n    resources:\n      RoleParametersValue:\n        ...\n        nova_permit_post_copy: NovaLiveMigrationPermitPostCopy\n        ...\n        NovaLiveMigrationPermitPostCopy: {get_param: NovaLiveMigrationPermitPostCopy}\n\n\n    conditions:\n      permit_postcopy_is_set:\n        not:\n          and:\n           - equals: [{get_param: [RoleParameters, NovaLiveMigrationPermitPostCopy]}, \u0027\u0027]\n           - equals: [{get_param: NovaLiveMigrationPermitPostCopy}, \u0027\u0027]\n\n\n    config_settings:\n      ...\n      nova::migration::live_migration_permit_post_copy:\n        if:\n          - permit_postcopy_is_set\n          - contains:\n            - {get_attr: [RoleParametersValue, value, nova_permit_post_copy]}\n            - [\"TRUE\", \"true\", \"True\"]            \n          - if:\n            - reserved_huge_pages_set\n            - true\n            - false","commit_id":"e0d0b5a5510e15934fb27b276a9cf8feb3c2f859"},{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"d1e2cbf287349ea53bde6f4044276cb687db08b9","unresolved":true,"context_lines":[{"line_number":372,"context_line":"    type: boolean"},{"line_number":373,"context_line":"    tags:"},{"line_number":374,"context_line":"      - role_specific"},{"line_number":375,"context_line":"  NovaLiveMigrationPermitAutoConverge:"},{"line_number":376,"context_line":"    description: |"},{"line_number":377,"context_line":"      Auto converge will throttles down CPU if a progress of on-going live migration is slow."},{"line_number":378,"context_line":"      Auto converge will only be used if this flag is set to True and post copy is not permitted"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"97ac05ee_2334abe2","line":375,"in_reply_to":"3e28d908_e9f5ac84","updated":"2021-01-13 02:56:12.000000000","message":"Thanks for the detailed and constructive feedback. I was wondering how to do something like that. I\u0027ll rewrite this patch, test it and submit a new one shortly.","commit_id":"e0d0b5a5510e15934fb27b276a9cf8feb3c2f859"},{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"b232e66e81533cfd946ad083a12cc92dc66013ca","unresolved":false,"context_lines":[{"line_number":372,"context_line":"    type: boolean"},{"line_number":373,"context_line":"    tags:"},{"line_number":374,"context_line":"      - role_specific"},{"line_number":375,"context_line":"  NovaLiveMigrationPermitAutoConverge:"},{"line_number":376,"context_line":"    description: |"},{"line_number":377,"context_line":"      Auto converge will throttles down CPU if a progress of on-going live migration is slow."},{"line_number":378,"context_line":"      Auto converge will only be used if this flag is set to True and post copy is not permitted"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"72187184_cd3c0a17","line":375,"in_reply_to":"97ac05ee_2334abe2","updated":"2021-01-13 14:12:30.000000000","message":"Done","commit_id":"e0d0b5a5510e15934fb27b276a9cf8feb3c2f859"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"ad45ddd37ca31b0d993a8b3c0f636cc12544d11e","unresolved":true,"context_lines":[{"line_number":723,"context_line":"              NovaComputeOptVolumes: {get_param: NovaComputeOptVolumes}"},{"line_number":724,"context_line":"              NovaComputeOptEnvVars: {get_param: NovaComputeOptEnvVars}"},{"line_number":725,"context_line":"              NovaDisableImageDownloadToRbd: {get_param: NovaDisableImageDownloadToRbd}"},{"line_number":726,"context_line":"              NovaLiveMigrationPermitPostCopy:"},{"line_number":727,"context_line":"                if:"},{"line_number":728,"context_line":"                - reserved_huge_pages_set"},{"line_number":729,"context_line":"                - true"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"ddcc9a72_e8db5588","line":726,"updated":"2021-01-12 21:39:30.000000000","message":"...this doesn\u0027t apply if the param is set in the role parameters","commit_id":"e0d0b5a5510e15934fb27b276a9cf8feb3c2f859"},{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"b232e66e81533cfd946ad083a12cc92dc66013ca","unresolved":false,"context_lines":[{"line_number":723,"context_line":"              NovaComputeOptVolumes: {get_param: NovaComputeOptVolumes}"},{"line_number":724,"context_line":"              NovaComputeOptEnvVars: {get_param: NovaComputeOptEnvVars}"},{"line_number":725,"context_line":"              NovaDisableImageDownloadToRbd: {get_param: NovaDisableImageDownloadToRbd}"},{"line_number":726,"context_line":"              NovaLiveMigrationPermitPostCopy:"},{"line_number":727,"context_line":"                if:"},{"line_number":728,"context_line":"                - reserved_huge_pages_set"},{"line_number":729,"context_line":"                - true"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"52afba86_9cb35631","line":726,"in_reply_to":"ddcc9a72_e8db5588","updated":"2021-01-13 14:12:30.000000000","message":"Done","commit_id":"e0d0b5a5510e15934fb27b276a9cf8feb3c2f859"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"8182d3b9e56646200521297883d8e643efadb21c","unresolved":true,"context_lines":[{"line_number":371,"context_line":"      - role_specific"},{"line_number":372,"context_line":"  NovaLiveMigrationWaitForVIFPlug:"},{"line_number":373,"context_line":"    description: Whether to wait for `network-vif-plugged` events before starting guest transfer."},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"    default: true"},{"line_number":376,"context_line":"    type: boolean"},{"line_number":377,"context_line":"  NovaLiveMigrationPermitPostCopy:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"d9b27cd2_bd4b8995","line":374,"updated":"2021-01-18 06:34:39.000000000","message":"is there a reason you added this blank line?","commit_id":"d2378e27897075a8521ecc52453e46abcfe7b300"},{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"226da713ab7983da176ef11111034f3e1bdf10e8","unresolved":false,"context_lines":[{"line_number":371,"context_line":"      - role_specific"},{"line_number":372,"context_line":"  NovaLiveMigrationWaitForVIFPlug:"},{"line_number":373,"context_line":"    description: Whether to wait for `network-vif-plugged` events before starting guest transfer."},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"    default: true"},{"line_number":376,"context_line":"    type: boolean"},{"line_number":377,"context_line":"  NovaLiveMigrationPermitPostCopy:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"ebb16a91_c1c7aafc","line":374,"in_reply_to":"d9b27cd2_bd4b8995","updated":"2021-01-18 15:30:39.000000000","message":"Typo! Sorry about that.","commit_id":"d2378e27897075a8521ecc52453e46abcfe7b300"}],"releasenotes/notes/nova-live-migration-permit-postcopy-autoconverge-ca1719fd2abed45f.yaml":[{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"7a8f18b4e6727ee953da4376be80d0e393ba6364","unresolved":true,"context_lines":[{"line_number":5,"context_line":"    enabling `NovaLiveMigrationPermitPostCopy` and"},{"line_number":6,"context_line":"    `NovaLiveMigrationPermitAutoConverge`."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    Operators can override this behavior by adding"},{"line_number":9,"context_line":"    `nova::migration::live_migration_permit_post_copy` and"},{"line_number":10,"context_line":"    `nova::migration::live_migration_permit_auto_converge` in the role\u0027s"},{"line_number":11,"context_line":"    `ExtraConfig`."}],"source_content_type":"text/x-yaml","patch_set":11,"id":"6ad4dc42_74b45cf7","line":11,"range":{"start_line":8,"start_character":4,"end_line":11,"end_character":18},"updated":"2021-01-25 04:20:17.000000000","message":"ExtraConfig was the only posibility earlier to provide role-specific input, but it has been improved with role-specific THT parameter itself, and the current implementation of the parameters NovaLiveMigrationPermitPostCopy \u0026 NovaLiveMigrationPermitAutoConverge supports role-specific implementation. I dont see a value in recommending operators to still use the ExtraConfig method.","commit_id":"e8b11f3a353150f5ac45500e32ef3a99828dbe05"}]}