)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"cbd97c1248917c1f7b69c67c9ae8de5ff551a64c","unresolved":true,"context_lines":[{"line_number":12,"context_line":"Also, this change fixes the current logic to make sure that"},{"line_number":13,"context_line":"HorizonDebug: false is honored even when Debug: true is set."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Closes-Bug: #1908362"},{"line_number":16,"context_line":"Change-Id: I514b5a3d4133d3561376ea06a803d019acaa0f0b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1aadf0e6_d7bd60fd","line":15,"updated":"2020-12-22 08:43:16.000000000","message":"looks OK now/no longer has syntax nit.\nhave you tested this to check what happens when you set HorizonDebug \u0026 Debug to true/false? If there are test reviews please add pointer here?","commit_id":"8b00e0ce6b615ad863ea01cf3988a5a0e981a8f1"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"a3e85f0baaab177239fc7115fa6d9fa3d8e9dccf","unresolved":true,"context_lines":[{"line_number":12,"context_line":"Also, this change fixes the current logic to make sure that"},{"line_number":13,"context_line":"HorizonDebug: false is honored even when Debug: true is set."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Closes-Bug: #1908362"},{"line_number":16,"context_line":"Change-Id: I514b5a3d4133d3561376ea06a803d019acaa0f0b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"e07793fd_5681660c","line":15,"in_reply_to":"1aadf0e6_d7bd60fd","updated":"2020-12-24 03:19:18.000000000","message":"I confirmed that debug is disabled as expected in CI result (because we have Debug:true set)\nhttps://6858d98d7a501e0358b0-54baced7b3de4d4a8f29448d2e5adbbf.ssl.cf2.rackcdn.com/767281/5/check/tripleo-ci-centos-8-standalone/9bac17b/logs/undercloud/var/lib/config-data/puppet-generated/horizon/etc/openstack-dashboard/local_settings\n\nI changed the default of HorizonDebug to false in the subsequent commit and confirmed that debug is disabled.\n\nhttps://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_9c6/768177/1/check/tripleo-ci-centos-8-standalone/9c6c1a2/logs/undercloud/var/lib/config-data/puppet-generated/horizon/etc/openstack-dashboard/local_settings\n\nThe other services like nova have debug disabled so HorizonDebug is effective for only debug in Horizon and overrides the Debug parameter.","commit_id":"8b00e0ce6b615ad863ea01cf3988a5a0e981a8f1"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b51b1a1cad26500bd1b8deb7c1998cc7fcd964d9","unresolved":true,"context_lines":[{"line_number":12,"context_line":"Also, this change fixes the current logic to make sure that"},{"line_number":13,"context_line":"HorizonDebug: false is honored even when Debug: true is set."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Closes-Bug: #1908362"},{"line_number":16,"context_line":"Change-Id: I514b5a3d4133d3561376ea06a803d019acaa0f0b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ad42ee15_39182d61","line":15,"in_reply_to":"e07793fd_5681660c","updated":"2020-12-24 10:01:41.000000000","message":"As I mentioned in the bug report, I meant to say;\n\nI confirmed that debug is ENABLED as expected in CI result (because we have Debug:true set)","commit_id":"8b00e0ce6b615ad863ea01cf3988a5a0e981a8f1"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"7286bd8382657597a0b381bba19915e111c7d5a2","unresolved":true,"context_lines":[{"line_number":12,"context_line":"Also, this change fixes the current logic to make sure that"},{"line_number":13,"context_line":"HorizonDebug: false is honored even when Debug: true is set."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Closes-Bug: #1908362"},{"line_number":16,"context_line":"Change-Id: I514b5a3d4133d3561376ea06a803d019acaa0f0b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"f92913a6_134576be","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":6},"updated":"2020-12-24 08:26:37.000000000","message":"thanks for the pointers to \n\nhttps://review.opendev.org/c/openstack/tripleo-heat-templates/+/768177 \nhttps://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_9c6/768177/1/check/tripleo-ci-centos-8-standalone/9c6c1a2/logs/undercloud/var/lib/config-data/puppet-generated/horizon/etc/openstack-dashboard/local_settings  https://6858d98d7a501e0358b0-54baced7b3de4d4a8f29448d2e5adbbf.ssl.cf2.rackcdn.com/767281/5/check/tripleo-ci-centos-8-standalone/9bac17b/logs/undercloud/var/lib/config-data/puppet-generated/horizon/etc/openstack-dashboard/local_settings\n\n\nplease consider adding this info on the bug too since you\u0027ve gone to the trouble to doing it may as well capture that ;)","commit_id":"f89140402ef211f92309646c2d935d5b9e593f99"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b51b1a1cad26500bd1b8deb7c1998cc7fcd964d9","unresolved":false,"context_lines":[{"line_number":12,"context_line":"Also, this change fixes the current logic to make sure that"},{"line_number":13,"context_line":"HorizonDebug: false is honored even when Debug: true is set."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Closes-Bug: #1908362"},{"line_number":16,"context_line":"Change-Id: I514b5a3d4133d3561376ea06a803d019acaa0f0b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"46c8034c_c67cd4dd","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":6},"in_reply_to":"6aaba9c7_6b06d80c","updated":"2020-12-24 10:01:41.000000000","message":"Thank you !","commit_id":"f89140402ef211f92309646c2d935d5b9e593f99"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"f7e29412f6535a095cf89bff73bca8fa5f0c7e4c","unresolved":true,"context_lines":[{"line_number":12,"context_line":"Also, this change fixes the current logic to make sure that"},{"line_number":13,"context_line":"HorizonDebug: false is honored even when Debug: true is set."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Closes-Bug: #1908362"},{"line_number":16,"context_line":"Change-Id: I514b5a3d4133d3561376ea06a803d019acaa0f0b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"6aaba9c7_6b06d80c","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":6},"in_reply_to":"f92913a6_134576be","updated":"2020-12-24 08:29:45.000000000","message":"i just copy pasted what you wrote :D https://bugs.launchpad.net/tripleo/+bug/1908362/comments/2","commit_id":"f89140402ef211f92309646c2d935d5b9e593f99"}],"deployment/horizon/horizon-container-puppet.yaml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"409f91f5b95498cdbc514eb3e6a3115a69a335f3","unresolved":true,"context_lines":[{"line_number":163,"context_line":"      - {get_param: [ServiceData, net_ip_version_map, {get_param: [ServiceNetMap, HorizonNetwork]}]}"},{"line_number":164,"context_line":"      - 6"},{"line_number":165,"context_line":"  horizon_logger_debug:"},{"line_number":166,"context_line":"    if:"},{"line_number":167,"context_line":"      - service_debug_unset"},{"line_number":168,"context_line":"      - get_param: Debug"},{"line_number":169,"context_line":"      - yaql:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"8f14fbd3_8e03ea20","line":166,"range":{"start_line":166,"start_character":4,"end_line":166,"end_character":6},"updated":"2020-12-17 08:27:59.000000000","message":"HEAT doesn\u0027t like that i am not sure why you\u0027ll have to dig @ syntax a bit i suspect you need a \u0027-\u0027 \nhttps://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_d4d/767281/3/check/tripleo-ci-centos-8-standalone/d4d4ebb/logs/undercloud/var/log/heat-launcher/undercloud_deploy-54eldx43/heat.log\n\nheat.common.exception.StackValidationFailed: conditions.horizon_logger_debug.if: The function \"if\" is invalid in this context","commit_id":"4db19ea78437856a4de0c953bccc06be26a110e9"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"c6c14ea3f2817e521845c34cf91e68f70d5a1e9d","unresolved":true,"context_lines":[{"line_number":249,"context_line":"          - {}"},{"line_number":250,"context_line":"        -"},{"line_number":251,"context_line":"          if:"},{"line_number":252,"context_line":"          - service_debug_unset"},{"line_number":253,"context_line":"          - horizon::django_debug: { get_param: Debug }"},{"line_number":254,"context_line":"          - horizon::django_debug: { get_param: HorizonDebug }"},{"line_number":255,"context_line":"        - if:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"0865a2b0_8362dc10","line":252,"range":{"start_line":252,"start_character":12,"end_line":252,"end_character":31},"updated":"2020-12-16 08:30:02.000000000","message":"I was a bit confused as it should have worked already, i.e. before it was if debug is unset, use horizondebug.\n\nbut what you are doing is swapping the precedence, so if horizondebug is not set, then try the debug. OK makes sense per your commit message.","commit_id":"4db19ea78437856a4de0c953bccc06be26a110e9"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"2b31937bbb628c67c9ad865ae4d7d7a57701aefc","unresolved":true,"context_lines":[{"line_number":249,"context_line":"          - {}"},{"line_number":250,"context_line":"        -"},{"line_number":251,"context_line":"          if:"},{"line_number":252,"context_line":"          - service_debug_unset"},{"line_number":253,"context_line":"          - horizon::django_debug: { get_param: Debug }"},{"line_number":254,"context_line":"          - horizon::django_debug: { get_param: HorizonDebug }"},{"line_number":255,"context_line":"        - if:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1a934a3c_2fe4dea5","line":252,"range":{"start_line":252,"start_character":12,"end_line":252,"end_character":31},"in_reply_to":"0865a2b0_8362dc10","updated":"2020-12-16 08:33:50.000000000","message":"Unfortunately the previous implementation has never worked as intended.\nThe Debug parameter is always set to \"true\" or \"false\", and it can\u0027t be \u0027\u0027 because it is boolean.","commit_id":"4db19ea78437856a4de0c953bccc06be26a110e9"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"5c02334c875902b3f1d54ab86d144034d9af6095","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    description: Set to True to enable debugging on all services."},{"line_number":42,"context_line":"    type: boolean"},{"line_number":43,"context_line":"  HorizonDebug:"},{"line_number":44,"context_line":"    default: false"},{"line_number":45,"context_line":"    description: Set to True to enable debugging Horizon service."},{"line_number":46,"context_line":"    type: string"},{"line_number":47,"context_line":"    constraints:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"c5b2622c_7038937a","line":44,"range":{"start_line":44,"start_character":13,"end_line":44,"end_character":18},"updated":"2020-12-22 08:58:42.000000000","message":"This should be also updated, otherwise debug is always disabled even if we set Debug: true.","commit_id":"8b00e0ce6b615ad863ea01cf3988a5a0e981a8f1"}]}