)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"aaefe0a40dc0d1ae018d2e2c2ff4239b7397a4dc","unresolved":true,"context_lines":[{"line_number":14,"context_line":"This change introduces a new cephadm/ branch containing all the services"},{"line_number":15,"context_line":"that should be configured in the TripleO context."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Depends-On: I60d6857b888ef97242c4f4bbf20fbc62de5ef29f"},{"line_number":18,"context_line":"Depends-On: If066dd19f1e9c75fd6581fddb5b55cb37eb57809"},{"line_number":19,"context_line":"Change-Id: Ie9537471924d1d60f7642699e58e734511b91a2b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"f9e43191_862406fe","line":18,"range":{"start_line":17,"start_character":0,"end_line":18,"end_character":53},"updated":"2021-01-17 14:45:24.000000000","message":"I\u0027m not sure you can do two depends-on when both are from the same repository. You should however be able to rebase 771034 on top of 770674 and then delete the first depends-on above (keeping the one that ends with 809).","commit_id":"d8374618901269cdc51ab9db9a0f1627c28a12c8"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"faf832055d6cb89812b113c9d346f329fec5f0a7","unresolved":true,"context_lines":[{"line_number":14,"context_line":"This change introduces a new cephadm/ branch containing all the services"},{"line_number":15,"context_line":"that should be configured in the TripleO context."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Depends-On: I60d6857b888ef97242c4f4bbf20fbc62de5ef29f"},{"line_number":18,"context_line":"Depends-On: If066dd19f1e9c75fd6581fddb5b55cb37eb57809"},{"line_number":19,"context_line":"Change-Id: Ie9537471924d1d60f7642699e58e734511b91a2b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"ebe8fddd_8afd5031","line":18,"range":{"start_line":17,"start_character":0,"end_line":18,"end_character":53},"in_reply_to":"f9e43191_862406fe","updated":"2021-01-17 17:29:08.000000000","message":"yeah that\u0027s true, as you said I just need to rebase my tripleo-ansible review on top of the cephadm role and have a single depends-on here.\nI\u0027ll do in the next PS","commit_id":"d8374618901269cdc51ab9db9a0f1627c28a12c8"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"02a0b9b8ce95a84c793fa45d0ca449d84b29d7a4","unresolved":true,"context_lines":[{"line_number":14,"context_line":"This change introduces a new cephadm/ branch containing all the services"},{"line_number":15,"context_line":"that should be configured in the TripleO context."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Depends-On: If066dd19f1e9c75fd6581fddb5b55cb37eb57809"},{"line_number":18,"context_line":"Depends-On: Ic42055f642312f9e7a6fead1ac72d3a9e2b7a241"},{"line_number":19,"context_line":"Depends-On: Ia8e5247013711662fb9513d1a77e6897e9f70420"},{"line_number":20,"context_line":"Change-Id: Ie9537471924d1d60f7642699e58e734511b91a2b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":58,"id":"2d7a27c3_bbbd5b61","line":19,"range":{"start_line":17,"start_character":0,"end_line":19,"end_character":53},"updated":"2021-02-25 20:09:44.000000000","message":"These have all merged so I\u0027m going to remove them in the next PS.","commit_id":"7ebfcce22db91195a9b7e5d4ba80287cff496a8a"}],"ci/environments/scenario001-standalone.yaml":[{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"c85fad0c62e6525d701386844e6c362eb2fe272f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":16,"id":"46fa8853_1d655971","line":201,"updated":"2021-01-18 21:25:57.000000000","message":"CephSpecPath: \"{{ role_path }}/files/ceph_spec.yaml\"","commit_id":"6be60e38dc9be639f5e01240feecc360af8bee28"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"4bcbcbd162359f4abf5172165f6abab03df4c67a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"9374baa9_5c1442be","line":201,"in_reply_to":"46fa8853_1d655971","updated":"2021-01-19 10:47:00.000000000","message":"Done","commit_id":"6be60e38dc9be639f5e01240feecc360af8bee28"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"023947c9664e58660c2af77ea79e291ef4dcd072","unresolved":true,"context_lines":[{"line_number":191,"context_line":"  CephAnsibleSkipClient: false"},{"line_number":192,"context_line":"  CephConfigPath: \"/etc/ceph\""},{"line_number":193,"context_line":"  CephClientConfigVars: \"{{ playbook_dir }}/cephadm/ceph_client.yml\""},{"line_number":194,"context_line":"  CephSpecPath: \"{{ role_path }}/files/ceph_spec.yaml\""},{"line_number":195,"context_line":"  LVMFilterEnabled: true"},{"line_number":196,"context_line":"  LVMFilterAllowlist:"},{"line_number":197,"context_line":"    - /dev/loop2"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"31116f4d_b6378ecd","line":194,"range":{"start_line":194,"start_character":17,"end_line":194,"end_character":32},"updated":"2021-01-20 09:52:05.000000000","message":"This now resolves the tripleo_run_cephadm role instead of tripleo_cephadm role, causing the playbook to fail.\nThis is caused by the fact the prepare is moved to tripleo_run_cephadm dir","commit_id":"38de963e13aa7082ba45a27f194ccbc919030dc5"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"c768383642ef18b1c670b25d84d4e334be0435a0","unresolved":true,"context_lines":[{"line_number":200,"context_line":"  MultipathdEnable: true"},{"line_number":201,"context_line":"  NovaLibvirtVolumeUseMultipath: true"},{"line_number":202,"context_line":"  # todo(fultonj): remove this workaround for https://review.opendev.org/771424/"},{"line_number":203,"context_line":"  ContainerCephDaemonImage: quay.ceph.io/ceph-ci/daemon:v5.0.7-stable-5.0-octopus-centos-8-x86_64"}],"source_content_type":"text/x-yaml","patch_set":32,"id":"67a8e0e2_e4e56314","line":203,"range":{"start_line":203,"start_character":2,"end_line":203,"end_character":27},"updated":"2021-01-25 06:39:01.000000000","message":"Thanks John, I missed this change, and yes, after merging 771424 we can remove it","commit_id":"99c61bca4a19e8660b839913186a2244ba921927"}],"ci/environments/scenario004-standalone.yaml":[{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"cefdf8b01a1048d4f3a19081762e2a1b5b352696","unresolved":true,"context_lines":[{"line_number":100,"context_line":"  ExtraConfig:"},{"line_number":101,"context_line":"    ganesha_vip: 192.168.24.3"},{"line_number":102,"context_line":"  # TODO: (fpantano) Remove this container when ceph is deployed by cephadm"},{"line_number":103,"context_line":"  ContainerCephDaemonImage: quay.ceph.io/ceph-ci/daemon:v4.0.13-stable-4.0-nautilus-centos-7-x86_64"}],"source_content_type":"text/x-yaml","patch_set":45,"id":"c0e16017_7d11ebbb","line":103,"updated":"2021-02-01 17:37:21.000000000","message":"This can be removed as it\u0027s covered by https://review.opendev.org/c/openstack/tripleo-quickstart-extras/+/772371","commit_id":"adfe100149c6510305c674936a7400eee26e1915"}],"deployment/ceph-ansible/ceph-base.yaml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"65911f41dfb90ebd4a4bc62fc61a4966fcde705b","unresolved":true,"context_lines":[{"line_number":107,"context_line":"  CephPoolDefaultPgNum:"},{"line_number":108,"context_line":"    description: default pg_num to use for the RBD pools"},{"line_number":109,"context_line":"    type: number"},{"line_number":110,"context_line":"    default: 16"},{"line_number":111,"context_line":"  CephPools:"},{"line_number":112,"context_line":"    description: \u003e"},{"line_number":113,"context_line":"      It can be used to override settings for one of the predefined pools, or to create"}],"source_content_type":"text/x-yaml","patch_set":57,"id":"9fb6e62f_0475c0b9","line":110,"updated":"2021-02-25 07:56:25.000000000","message":"seems like a big change in the default is it really necessary? I wonder if it will surprise someone but i guess, there *will* have to be special preparations made anyway if you are going from something deployed with ceph-ansible to now deployed/upgraded with cephadm","commit_id":"6953504fe32561218723690f071fd99d485ecafd"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"be81920c9758f944c93675ecda3fa02584efd486","unresolved":true,"context_lines":[{"line_number":107,"context_line":"  CephPoolDefaultPgNum:"},{"line_number":108,"context_line":"    description: default pg_num to use for the RBD pools"},{"line_number":109,"context_line":"    type: number"},{"line_number":110,"context_line":"    default: 16"},{"line_number":111,"context_line":"  CephPools:"},{"line_number":112,"context_line":"    description: \u003e"},{"line_number":113,"context_line":"      It can be used to override settings for one of the predefined pools, or to create"}],"source_content_type":"text/x-yaml","patch_set":57,"id":"c17e6da5_b28cbf3b","line":110,"in_reply_to":"8c76a1f5_6b522eb6","updated":"2021-02-25 20:03:31.000000000","message":"If you have an existing cluster, then this change shouldn\u0027t affect you so it doesn\u0027t affect upgrades. It affects new deployments. We also have a release note for this. The 128 value has caused more harm than good with new deployments so changing this default and using the auto scaler is a user experience improvement.","commit_id":"6953504fe32561218723690f071fd99d485ecafd"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"428709a2cd49c6fb364cb2dea7b80b0af2f15c0b","unresolved":true,"context_lines":[{"line_number":107,"context_line":"  CephPoolDefaultPgNum:"},{"line_number":108,"context_line":"    description: default pg_num to use for the RBD pools"},{"line_number":109,"context_line":"    type: number"},{"line_number":110,"context_line":"    default: 16"},{"line_number":111,"context_line":"  CephPools:"},{"line_number":112,"context_line":"    description: \u003e"},{"line_number":113,"context_line":"      It can be used to override settings for one of the predefined pools, or to create"}],"source_content_type":"text/x-yaml","patch_set":57,"id":"8c76a1f5_6b522eb6","line":110,"in_reply_to":"9fb6e62f_0475c0b9","updated":"2021-02-25 09:22:07.000000000","message":"Hey Marios thank you for the question. This change comes from a new default in Ceph, which is related to the pg_autoscaling [1].\nSince pg_autoscale is enabled by default, there\u0027s no reason for tuning PG_* parameters anymore, unless there\u0027s a specific need; this means that when a pool is created the pg_autoscaler is enabled by default, but you can still specify this parameter which is now lower to make the CI and even small (or any all-in-one) deployments happy.\nBy doing this, you can start from a low default pg number, which will be automatically increased by the autoscaler module (and no risk of ending up with some sort of pg overflow [_too many PGs per OSD_]).\nThis change is also valid for both nautilus and octopus, and when a stack update is running against an existing environment, there\u0027s no action performed from ceph-ansible on the existing pools, so it\u0027s safe enough.\nWith respect to a potential upgrade scenario, ceph-ansible is able to gather facts from the existing cluster and afaik the impact is only for the deployed daemons, hence pools are not touched (I\u0027m pretty sure it\u0027s the same for the adoption process [2], which happens after the upgrade from ceph4 to ceph5 using [3]) \n\n[1] https://ceph.io/rados/new-in-nautilus-pg-merging-and-autotuning/\n[2] https://github.com/ceph/ceph-ansible/blob/master/infrastructure-playbooks/cephadm-adopt.yml\n[3] https://github.com/ceph/ceph-ansible/blob/master/infrastructure-playbooks/rolling_update.yml","commit_id":"6953504fe32561218723690f071fd99d485ecafd"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"65911f41dfb90ebd4a4bc62fc61a4966fcde705b","unresolved":true,"context_lines":[{"line_number":229,"context_line":"                 config-download, e.g. the mistral user in the mistral-executor"},{"line_number":230,"context_line":"                 container is able to read/write to /var/lib/mistral/ceph_fetch"},{"line_number":231,"context_line":"    type: string"},{"line_number":232,"context_line":"  # end DEPRECATED options for compatibility with older versions"},{"line_number":233,"context_line":"  CephOsdPercentageMin:"},{"line_number":234,"context_line":"    default: 0"},{"line_number":235,"context_line":"    description: The minimum percentage of Ceph OSDs which must be running and"}],"source_content_type":"text/x-yaml","patch_set":57,"id":"cf846049_3031841b","line":232,"updated":"2021-02-25 07:56:25.000000000","message":"so you probably want to move that comment down to include the CephOsdPercentageMin?","commit_id":"6953504fe32561218723690f071fd99d485ecafd"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"428709a2cd49c6fb364cb2dea7b80b0af2f15c0b","unresolved":false,"context_lines":[{"line_number":229,"context_line":"                 config-download, e.g. the mistral user in the mistral-executor"},{"line_number":230,"context_line":"                 container is able to read/write to /var/lib/mistral/ceph_fetch"},{"line_number":231,"context_line":"    type: string"},{"line_number":232,"context_line":"  # end DEPRECATED options for compatibility with older versions"},{"line_number":233,"context_line":"  CephOsdPercentageMin:"},{"line_number":234,"context_line":"    default: 0"},{"line_number":235,"context_line":"    description: The minimum percentage of Ceph OSDs which must be running and"}],"source_content_type":"text/x-yaml","patch_set":57,"id":"00b05809_4bcd5f59","line":232,"in_reply_to":"cf846049_3031841b","updated":"2021-02-25 09:22:07.000000000","message":"Done","commit_id":"6953504fe32561218723690f071fd99d485ecafd"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"65911f41dfb90ebd4a4bc62fc61a4966fcde705b","unresolved":true,"context_lines":[{"line_number":235,"context_line":"    description: The minimum percentage of Ceph OSDs which must be running and"},{"line_number":236,"context_line":"                 in the Ceph cluster, according to ceph osd stat, for the"},{"line_number":237,"context_line":"                 deployment not to fail. Used to catch deployment errors early."},{"line_number":238,"context_line":"                 Set this value to 0 to disable this check. Deprecated in Wallaby"},{"line_number":239,"context_line":"                 because of the move from ceph-ansible to cephadm; the later only"},{"line_number":240,"context_line":"                 brings up OSDs out of band and deployment does not block while"},{"line_number":241,"context_line":"                 waiting for them to come up, thus we cannot do this anymore."}],"source_content_type":"text/x-yaml","patch_set":57,"id":"f242d3cd_83770b36","line":238,"range":{"start_line":238,"start_character":60,"end_line":238,"end_character":70},"updated":"2021-02-25 07:56:25.000000000","message":"is it deprecated or \u0027no longer has any effect do not use this\u0027","commit_id":"6953504fe32561218723690f071fd99d485ecafd"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"428709a2cd49c6fb364cb2dea7b80b0af2f15c0b","unresolved":true,"context_lines":[{"line_number":235,"context_line":"    description: The minimum percentage of Ceph OSDs which must be running and"},{"line_number":236,"context_line":"                 in the Ceph cluster, according to ceph osd stat, for the"},{"line_number":237,"context_line":"                 deployment not to fail. Used to catch deployment errors early."},{"line_number":238,"context_line":"                 Set this value to 0 to disable this check. Deprecated in Wallaby"},{"line_number":239,"context_line":"                 because of the move from ceph-ansible to cephadm; the later only"},{"line_number":240,"context_line":"                 brings up OSDs out of band and deployment does not block while"},{"line_number":241,"context_line":"                 waiting for them to come up, thus we cannot do this anymore."}],"source_content_type":"text/x-yaml","patch_set":57,"id":"ce0dc13a_feb74392","line":238,"range":{"start_line":238,"start_character":60,"end_line":238,"end_character":70},"in_reply_to":"f242d3cd_83770b36","updated":"2021-02-25 09:22:07.000000000","message":"This parameter is used here [1] and it\u0027s required by the ceph-health validation. This should be 0 for cephadm and tht (or can be even removed), and to have params consistency between the two branches (cephadm vs ceph-ansible) [2] we need the same parameter and the same defaults everywhere (or at least I\u0027m not sure how to define the same parameter in different tht w/ different default values ... not sure this is possible).\nSince master/W+ is going to deploy (by default) Ceph using cephadm, the idea is to keep all the involved parameters, and mark them as deprecated and remove them on the X cycle.\nOperators and CI jobs can still override that parameter if needed, but since the status of the Ceph cluster is maintained within ceph orchestrator, this parameter shouldn\u0027t be needed anymore.  \n\n\n[1] https://github.com/openstack/tripleo-heat-templates/blob/master/deployment/ceph-ansible/ceph-base.yaml#L730\n[2] https://review.opendev.org/c/openstack/tripleo-heat-templates/+/767294/57/tools/yaml-validate.py","commit_id":"6953504fe32561218723690f071fd99d485ecafd"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"65911f41dfb90ebd4a4bc62fc61a4966fcde705b","unresolved":true,"context_lines":[{"line_number":353,"context_line":"  - LocalCephAnsibleFetchDirectoryBackup"},{"line_number":354,"context_line":"  - SwiftFetchDirGetTempurl"},{"line_number":355,"context_line":"  - SwiftFetchDirPutTempurl"},{"line_number":356,"context_line":"  - CephIPv6"},{"line_number":357,"context_line":""},{"line_number":358,"context_line":"conditions:"},{"line_number":359,"context_line":"  dashboard_is_enabled: {equals: [{get_param: CephEnableDashboard}, true]}"}],"source_content_type":"text/x-yaml","patch_set":57,"id":"903c3aaf_bc18e2c0","line":356,"updated":"2021-02-25 07:56:25.000000000","message":"add your new deprecations here \n\nthis stuff is picked up by tripleoclient and operator gets a warning about using deprecated parameters https://opendev.org/openstack/python-tripleoclient/src/commit/42aa7357fb59ebad2ef34108fa1ad3e259b10cb6/tripleoclient/workflows/parameters.py#L166","commit_id":"6953504fe32561218723690f071fd99d485ecafd"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"be81920c9758f944c93675ecda3fa02584efd486","unresolved":false,"context_lines":[{"line_number":353,"context_line":"  - LocalCephAnsibleFetchDirectoryBackup"},{"line_number":354,"context_line":"  - SwiftFetchDirGetTempurl"},{"line_number":355,"context_line":"  - SwiftFetchDirPutTempurl"},{"line_number":356,"context_line":"  - CephIPv6"},{"line_number":357,"context_line":""},{"line_number":358,"context_line":"conditions:"},{"line_number":359,"context_line":"  dashboard_is_enabled: {equals: [{get_param: CephEnableDashboard}, true]}"}],"source_content_type":"text/x-yaml","patch_set":57,"id":"a4df3557_5db7fea8","line":356,"in_reply_to":"48bf1a9b_e95ffcd0","updated":"2021-02-25 20:03:31.000000000","message":"Hi Marios,\n\nI think Francesco has taken care of this by adding CephOsdPercentageMin to the deprecated list on line 357 in patch set 58. \n\nIf you want some extra details though here they are. We\u0027re deprecating different types of things: deployment methods (ceph-ansible in favor of cephadm), files used during deployment (deployment/ceph-ansible/* in favor of deployment/cephadm/*), and parameters. There are parameters, used by both deployment methods, which deprecate depending on which method is being used so we have a separate list for each. If you deploy with cephadm, then we have a list of deprecated parameters [1] to warn about. If you deploy with ceph-ansible, then we have another list of deprecated parameters [2] to warn about. Having different lists was deliberate. We aim to remove the ceph-ansible deployment method in X and deprecate it in W. So if you\u0027re using the deprecated ceph-ansible method in W, then you get a different warning. However, per the release note you should also know that the ceph-ansible method is deprecated. In the end (X) it ends up being one list of deprecated parameters though regardless of method.\n\n[1] https://review.opendev.org/c/openstack/tripleo-heat-templates/+/767294/58/deployment/cephadm/ceph-base.yaml#326\n\n[2] https://review.opendev.org/c/openstack/tripleo-heat-templates/+/767294/58/deployment/ceph-ansible/ceph-base.yaml#357","commit_id":"6953504fe32561218723690f071fd99d485ecafd"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"428709a2cd49c6fb364cb2dea7b80b0af2f15c0b","unresolved":false,"context_lines":[{"line_number":353,"context_line":"  - LocalCephAnsibleFetchDirectoryBackup"},{"line_number":354,"context_line":"  - SwiftFetchDirGetTempurl"},{"line_number":355,"context_line":"  - SwiftFetchDirPutTempurl"},{"line_number":356,"context_line":"  - CephIPv6"},{"line_number":357,"context_line":""},{"line_number":358,"context_line":"conditions:"},{"line_number":359,"context_line":"  dashboard_is_enabled: {equals: [{get_param: CephEnableDashboard}, true]}"}],"source_content_type":"text/x-yaml","patch_set":57,"id":"48bf1a9b_e95ffcd0","line":356,"in_reply_to":"903c3aaf_bc18e2c0","updated":"2021-02-25 09:22:07.000000000","message":"Done","commit_id":"6953504fe32561218723690f071fd99d485ecafd"}],"deployment/ceph-ansible/ceph-osd.yaml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"0920565d3e945ebd36a6253f6bad0f6115a7c4bc","unresolved":true,"context_lines":[{"line_number":28,"context_line":"                 via parameter_defaults in the resource registry."},{"line_number":29,"context_line":"    type: json"},{"line_number":30,"context_line":"  CephAnsibleDisksConfig:"},{"line_number":31,"context_line":"    type: json"},{"line_number":32,"context_line":"    description: Disks config settings."},{"line_number":33,"context_line":"    default:"},{"line_number":34,"context_line":"      devices: []"}],"source_content_type":"text/x-yaml","patch_set":59,"id":"ab353e4c_0f55577f","line":31,"updated":"2021-03-01 08:45:44.000000000","message":"so is this CephAnsibleDisksConfig another parameter that should be added to deprecated?","commit_id":"7129465113540cc4418eaca74e9a5a427edfb186"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"0c6f995876bc70a1fd5173734e83ff58b6db745b","unresolved":true,"context_lines":[{"line_number":27,"context_line":"    description: Mapping of service endpoint -\u003e protocol. Typically set"},{"line_number":28,"context_line":"                 via parameter_defaults in the resource registry."},{"line_number":29,"context_line":"    type: json"},{"line_number":30,"context_line":"  CephAnsibleDisksConfig:"},{"line_number":31,"context_line":"    type: json"},{"line_number":32,"context_line":"    description: Disks config settings."},{"line_number":33,"context_line":"    default:"}],"source_content_type":"text/x-yaml","patch_set":61,"id":"e08fcc6e_669129f7","line":30,"range":{"start_line":30,"start_character":2,"end_line":30,"end_character":24},"updated":"2021-03-08 07:50:36.000000000","message":"i asked this on v59 but it seems it was missed. do we want to put this into deprecated too then i.e. don\u0027t use this any more it doesn\u0027t do anything","commit_id":"2b63a3d6254876b1dc4c6e7fef275801ade49c4b"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"cae1a4ff59f6572cf48d199e1521bf9790189b2e","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    description: Mapping of service endpoint -\u003e protocol. Typically set"},{"line_number":28,"context_line":"                 via parameter_defaults in the resource registry."},{"line_number":29,"context_line":"    type: json"},{"line_number":30,"context_line":"  CephAnsibleDisksConfig:"},{"line_number":31,"context_line":"    type: json"},{"line_number":32,"context_line":"    description: Disks config settings."},{"line_number":33,"context_line":"    default:"}],"source_content_type":"text/x-yaml","patch_set":61,"id":"e274d4c8_e17e385f","line":30,"range":{"start_line":30,"start_character":2,"end_line":30,"end_character":24},"in_reply_to":"72f2a20a_bc518938","updated":"2021-03-09 07:44:21.000000000","message":"ack thank you for checking","commit_id":"2b63a3d6254876b1dc4c6e7fef275801ade49c4b"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"baf69d3cb74e257647dea8656c2c15eb39727947","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    description: Mapping of service endpoint -\u003e protocol. Typically set"},{"line_number":28,"context_line":"                 via parameter_defaults in the resource registry."},{"line_number":29,"context_line":"    type: json"},{"line_number":30,"context_line":"  CephAnsibleDisksConfig:"},{"line_number":31,"context_line":"    type: json"},{"line_number":32,"context_line":"    description: Disks config settings."},{"line_number":33,"context_line":"    default:"}],"source_content_type":"text/x-yaml","patch_set":61,"id":"72f2a20a_bc518938","line":30,"range":{"start_line":30,"start_character":2,"end_line":30,"end_character":24},"in_reply_to":"e08fcc6e_669129f7","updated":"2021-03-08 08:27:46.000000000","message":"Sorry I messed with my comments: this parameter is actually still relevant for CephAnsible based deployments, because in that scenario you  can always specify (pass) a list of devices, and that\u0027s the reason is not among the list of deprecated parameters.\nHowever, we changed the default to [] because having /dev/vdb wasn\u0027t a safe default as you don\u0027t know in advance this info from the operator\u0027s environment.\nIn a CephAdm based environment, for now, the OSD(s) are created using the all the available devices, so this isn\u0027t required anymore in that branch, but we\u0027re going to deprecate or remove it during the next cycle, when ceph-ansible will not be supported anymore.","commit_id":"2b63a3d6254876b1dc4c6e7fef275801ade49c4b"}],"deployment/cephadm/ceph-base.yaml":[{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"c816446d1cd20de1e4413875cc76721335169280","unresolved":true,"context_lines":[{"line_number":110,"context_line":"  CephPoolDefaultPgNum:"},{"line_number":111,"context_line":"    description: default pg_num to use for the RBD pools"},{"line_number":112,"context_line":"    type: number"},{"line_number":113,"context_line":"    default: 128"},{"line_number":114,"context_line":"  CephPools:"},{"line_number":115,"context_line":"    description: \u003e"},{"line_number":116,"context_line":"      It can be used to override settings for one of the predefined pools, or to create"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9ad96e33_de90cb74","line":113,"range":{"start_line":113,"start_character":13,"end_line":113,"end_character":16},"updated":"2021-01-15 13:29:59.000000000","message":"Maybe we should default this to 0 and if it\u0027s zero then we use the pg autoscaler [1] since that\u0027s what we want for all new deployments.\n\nThe alternative is to have a boolean PgAutoScaler which defaults to true so that its switched on for everyone unless they go out of their way to disable it. Could this approach possibly get in the way of upgrades though?\n\n[1] https://ceph.io/rados/new-in-nautilus-pg-merging-and-autotuning/","commit_id":"930c9953102712319c163d320b9d057f18e4151d"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"c816446d1cd20de1e4413875cc76721335169280","unresolved":true,"context_lines":[{"line_number":570,"context_line":"          tags:"},{"line_number":571,"context_line":"            - ceph"},{"line_number":572,"context_line":"          block:"},{"line_number":573,"context_line":"            - name: include common ceph defaults"},{"line_number":574,"context_line":"              include_role:"},{"line_number":575,"context_line":"                name: tripleo_ceph_common"},{"line_number":576,"context_line":"            # This is supposed to run a playbook which is responsible to"},{"line_number":577,"context_line":"            # deploy Ceph using cephadm."},{"line_number":578,"context_line":"            # The storage network is supposed to be available since we are"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"fa9dcb86_e30bcd63","line":575,"range":{"start_line":573,"start_character":0,"end_line":575,"end_character":41},"updated":"2021-01-15 13:29:59.000000000","message":"I don\u0027t think we\u0027ll need this anymore. Any reason you kept it?","commit_id":"930c9953102712319c163d320b9d057f18e4151d"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"c816446d1cd20de1e4413875cc76721335169280","unresolved":true,"context_lines":[{"line_number":582,"context_line":"            #       the overcloud."},{"line_number":583,"context_line":"            - name: Deploy the ceph cluster using cephadm"},{"line_number":584,"context_line":"              include_role:"},{"line_number":585,"context_line":"                name: tripleo_run_cephadm"},{"line_number":586,"context_line":"            - name: configure ceph clients"},{"line_number":587,"context_line":"              include_role:"},{"line_number":588,"context_line":"                name: tripleo_ceph_client"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9eb2cdc4_1c507055","line":585,"range":{"start_line":585,"start_character":22,"end_line":585,"end_character":41},"updated":"2021-01-15 13:29:59.000000000","message":"Right, so tripleo_run_cephadm is another role which:\n\n1. enables the ceph-admin user per \nhttps://review.opendev.org/c/openstack/tripleo-ansible/+/770674/2/doc/source/roles/role-tripleo_cephadm.rst#35\n\n2. builds an inventory containing the first monitor\n\n3. runs a playbook which looks like lines 67-109 of\nhttps://review.opendev.org/c/openstack/tripleo-ansible/+/770674/2/doc/source/roles/role-tripleo_cephadm.rst#67\n\nWe can also have the tripleo python client call this role","commit_id":"930c9953102712319c163d320b9d057f18e4151d"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"78cd0c75f71be9ce9d02b6e9aeb12c84be55c035","unresolved":true,"context_lines":[{"line_number":532,"context_line":"            - name: Set the basic facts we need for cephadm"},{"line_number":533,"context_line":"              set_fact:"},{"line_number":534,"context_line":"                ceph_ansible_playbooks_param: {get_param: CephAnsiblePlaybook}"},{"line_number":535,"context_line":"            - name: include common ceph defaults"},{"line_number":536,"context_line":"              include_role:"},{"line_number":537,"context_line":"                name: tripleo_ceph_common"},{"line_number":538,"context_line":"            - name: create cephadm working directory and related files"},{"line_number":539,"context_line":"              include_role:"},{"line_number":540,"context_line":"                name: tripleo_run_cephadm"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"a23de42d_af6051e2","line":537,"range":{"start_line":535,"start_character":0,"end_line":537,"end_character":41},"updated":"2021-01-17 15:05:22.000000000","message":"What do we need tripleo_ceph_common for?","commit_id":"d8374618901269cdc51ab9db9a0f1627c28a12c8"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"d643ac5e9f6a50755f9bd7d602f692396a81faf8","unresolved":true,"context_lines":[{"line_number":532,"context_line":"            - name: Set the basic facts we need for cephadm"},{"line_number":533,"context_line":"              set_fact:"},{"line_number":534,"context_line":"                ceph_ansible_playbooks_param: {get_param: CephAnsiblePlaybook}"},{"line_number":535,"context_line":"            - name: include common ceph defaults"},{"line_number":536,"context_line":"              include_role:"},{"line_number":537,"context_line":"                name: tripleo_ceph_common"},{"line_number":538,"context_line":"            - name: create cephadm working directory and related files"},{"line_number":539,"context_line":"              include_role:"},{"line_number":540,"context_line":"                name: tripleo_run_cephadm"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"0d6dd7e0_459e9a30","line":537,"range":{"start_line":535,"start_character":0,"end_line":537,"end_character":41},"in_reply_to":"a23de42d_af6051e2","updated":"2021-01-17 17:27:29.000000000","message":"No sorry this is useless, probably here due to some tests I conducted before but I definitely need to remove it.\nI\u0027ll do in the next PS","commit_id":"d8374618901269cdc51ab9db9a0f1627c28a12c8"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"78cd0c75f71be9ce9d02b6e9aeb12c84be55c035","unresolved":true,"context_lines":[{"line_number":542,"context_line":"              vars:"},{"line_number":543,"context_line":"                cephadm_extra_vars:"},{"line_number":544,"context_line":"                  tripleo_admin_user: ceph-admin"},{"line_number":545,"context_line":"                  ssh_servers: \"{{ groups[\u0027mons\u0027] }}\""},{"line_number":546,"context_line":"                  distribute_private_key: true"},{"line_number":547,"context_line":"            - name: Prepare cephadm user and keys"},{"line_number":548,"context_line":"              include_role:"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"ea97faaa_2c7e90e7","line":545,"range":{"start_line":545,"start_character":35,"end_line":545,"end_character":49},"updated":"2021-01-17 15:05:22.000000000","message":"This will need to contain all servers that cephadm will touch. Want to try something like this:\n\n{{ groups[\u0027ceph_mon\u0027] |\n   union(groups[\u0027ceph_osd\u0027]) |\n   union(groups[\u0027ceph_mgr\u0027]) |\n   union(groups[\u0027ceph_rgw\u0027]) |\n   union(groups[\u0027ceph_mds\u0027]) |\n   union(groups[\u0027ceph_nfs\u0027]) |\n   union(groups[\u0027ceph_rbdmirror\u0027]) |\n   unique }}\n\nThe inventory group names above are built from the composable roles so it\u0027s a given they will be there, though they have ceph-ansilbe aliases as per:\n\n https://github.com/openstack/tripleo-common/commit/3f48630791f5051b97afba1365d8f5defb797951","commit_id":"d8374618901269cdc51ab9db9a0f1627c28a12c8"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"d643ac5e9f6a50755f9bd7d602f692396a81faf8","unresolved":true,"context_lines":[{"line_number":542,"context_line":"              vars:"},{"line_number":543,"context_line":"                cephadm_extra_vars:"},{"line_number":544,"context_line":"                  tripleo_admin_user: ceph-admin"},{"line_number":545,"context_line":"                  ssh_servers: \"{{ groups[\u0027mons\u0027] }}\""},{"line_number":546,"context_line":"                  distribute_private_key: true"},{"line_number":547,"context_line":"            - name: Prepare cephadm user and keys"},{"line_number":548,"context_line":"              include_role:"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"c5263ff9_0ebd9bec","line":545,"range":{"start_line":545,"start_character":35,"end_line":545,"end_character":49},"in_reply_to":"ea97faaa_2c7e90e7","updated":"2021-01-17 17:27:29.000000000","message":"ack thanks.\nI still need to fix the fact [1] to make it working in the standalone scenario, but we\u0027re on the right way.\n\n[1] https://github.com/openstack/tripleo-ansible/blob/master/tripleo_ansible/playbooks/cli-enable-ssh-admin.yaml#L185","commit_id":"d8374618901269cdc51ab9db9a0f1627c28a12c8"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"2e1f45bd42e5f076a961cbaa3cfcb6b0695521d5","unresolved":true,"context_lines":[{"line_number":538,"context_line":"                name: tripleo_run_cephadm"},{"line_number":539,"context_line":"                tasks_from: prepare.yml"},{"line_number":540,"context_line":"              vars:"},{"line_number":541,"context_line":"                cephadm_extra_vars:"},{"line_number":542,"context_line":"                  tripleo_admin_user: ceph-admin"},{"line_number":543,"context_line":"                  distribute_private_key: true"},{"line_number":544,"context_line":"                  tripleo_ceph_client_vars: {get_param: CephClientConfigVars}"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"7e2d34ff_54fc2088","line":541,"range":{"start_line":541,"start_character":16,"end_line":541,"end_character":34},"updated":"2021-01-18 20:48:18.000000000","message":"Shouldn\u0027t this be called ceph_admin_extra_vars as it\u0027s only for creating the ceph-admin users with cli-enable-ssh-admin.yaml and not for the cephadm role?\n\nhttps://review.opendev.org/c/openstack/tripleo-ansible/+/771034/10/tripleo_ansible/roles/tripleo_run_cephadm/tasks/prepare.yml\n\nI want to use cephadm_extra_vars for this run later at the bottom.\n\n              include_role:\n                name: tripleo_run_cephadm","commit_id":"1728c2e5609224baf348aba534e3ed2a2c5a0298"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"c85fad0c62e6525d701386844e6c362eb2fe272f","unresolved":true,"context_lines":[{"line_number":204,"context_line":"    description: image"},{"line_number":205,"context_line":"    type: string"},{"line_number":206,"context_line":"  # start DEPRECATED options for compatibility with older versions"},{"line_number":207,"context_line":"  CephAnsiblePlaybookVerbosity:"},{"line_number":208,"context_line":"    default: 1"},{"line_number":209,"context_line":"    description: The number of \u0027-v\u0027, \u0027-vv\u0027, etc. passed to ansible-playbook command"},{"line_number":210,"context_line":"    type: number"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"39d4a9ff_d4c99be6","line":207,"range":{"start_line":207,"start_character":2,"end_line":207,"end_character":30},"updated":"2021-01-18 21:25:57.000000000","message":"deprecating parameters specific to ceph-ansible","commit_id":"6be60e38dc9be639f5e01240feecc360af8bee28"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"c85fad0c62e6525d701386844e6c362eb2fe272f","unresolved":true,"context_lines":[{"line_number":313,"context_line":"    type: string"},{"line_number":314,"context_line":"    description: The undercloud path where cephadm exports the Ceph Client configuration."},{"line_number":315,"context_line":"  CephSpecPath:"},{"line_number":316,"context_line":"    default: \"/home/stack/ceph_spec.yml\""},{"line_number":317,"context_line":"    type: string"},{"line_number":318,"context_line":"    description: |"},{"line_number":319,"context_line":"      The undercloud path of a valid Ceph orchestrator-cli-service-spec file. If this"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"e2ce702e_5a7ac9be","line":316,"range":{"start_line":316,"start_character":4,"end_line":316,"end_character":40},"updated":"2021-01-18 21:25:57.000000000","message":"I did this because it\u0027s a default that will be consistent with /home/stack/ceph_client.yml and because it\u0027s harder to do \"{{ role_path }}/files/ceph_spec.yaml\" from inside of THT. However, we\u0027ll need to upcate tripleo_cephadm accordingly as described here.\n\nhttps://review.opendev.org/c/openstack/tripleo-ansible/+/770674/7/tripleo_ansible/roles/tripleo_cephadm/defaults/main.yml\n\nSee the suggestion for the change in ci/environments/scenario001-standalone.yaml too.","commit_id":"6be60e38dc9be639f5e01240feecc360af8bee28"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"4bcbcbd162359f4abf5172165f6abab03df4c67a","unresolved":false,"context_lines":[{"line_number":313,"context_line":"    type: string"},{"line_number":314,"context_line":"    description: The undercloud path where cephadm exports the Ceph Client configuration."},{"line_number":315,"context_line":"  CephSpecPath:"},{"line_number":316,"context_line":"    default: \"/home/stack/ceph_spec.yml\""},{"line_number":317,"context_line":"    type: string"},{"line_number":318,"context_line":"    description: |"},{"line_number":319,"context_line":"      The undercloud path of a valid Ceph orchestrator-cli-service-spec file. If this"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"1a1e800d_b827bb44","line":316,"range":{"start_line":316,"start_character":4,"end_line":316,"end_character":40},"in_reply_to":"e2ce702e_5a7ac9be","updated":"2021-01-19 10:47:00.000000000","message":"Ack","commit_id":"6be60e38dc9be639f5e01240feecc360af8bee28"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"0585a0284e2c58411512e6bbd62d5f253b4e9a24","unresolved":true,"context_lines":[{"line_number":234,"context_line":"                 container is able to read/write to /var/lib/mistral/ceph_fetch"},{"line_number":235,"context_line":"    type: string"},{"line_number":236,"context_line":"  CephOsdPercentageMin:"},{"line_number":237,"context_line":"    default: 66"},{"line_number":238,"context_line":"    description: The minimum percentage of Ceph OSDs which must be running and"},{"line_number":239,"context_line":"                 in the Ceph cluster, according to ceph osd stat, for the"},{"line_number":240,"context_line":"                 deployment not to fail. Used to catch deployment errors early."}],"source_content_type":"text/x-yaml","patch_set":18,"id":"2cda8306_3381fdc9","line":237,"range":{"start_line":237,"start_character":4,"end_line":237,"end_character":15},"updated":"2021-01-19 12:23:24.000000000","message":"This should be consistent with the other tht templates (ceph-ansible/ceph-base.yaml) or validation fails","commit_id":"5b6bccda27839f6ee9fe9fbb18d6d2eb968826de"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"0585a0284e2c58411512e6bbd62d5f253b4e9a24","unresolved":true,"context_lines":[{"line_number":537,"context_line":"                cred: {get_param: ContainerImageRegistryCredentials}"},{"line_number":538,"context_line":"                ns: {get_attr: [ContainerImageUrlParts, value, host]}"},{"line_number":539,"context_line":"              expression: let(c \u003d\u003e $.data.cred) -\u003e $c.get($.data.ns, {}).values().last(default \u003d\u003e \"\")"},{"line_number":540,"context_line":"          monitor_address_block:"},{"line_number":541,"context_line":"            list_join:"},{"line_number":542,"context_line":"              - \u0027,\u0027"},{"line_number":543,"context_line":"              - get_param: [ServiceData, net_cidr_map, {get_param: [ServiceNetMap, CephMonNetwork]}]"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"b0c00841_fc122cca","line":540,"range":{"start_line":540,"start_character":10,"end_line":540,"end_character":32},"updated":"2021-01-19 12:23:24.000000000","message":"Need this param for [1], then we need a task in cephadm role to set the mons network (similar to [2])\n\n[1] https://docs.ceph.com/en/latest/cephadm/install/#deploy-additional-monitors-optional\n[2] https://github.com/fmount/tripleo-ceph/blob/master/roles/tripleo_cluster_mon_config/tasks/set_monitor_public_network.yaml#L3","commit_id":"7b9db0251001c73ed0b90d7d6d3d71d91973ba5f"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"112e42151bd3b755db817a66d088fe640f61ff3a","unresolved":true,"context_lines":[{"line_number":566,"context_line":"                tasks_from: prepare.yml"},{"line_number":567,"context_line":"              vars:"},{"line_number":568,"context_line":"                cephadm_extra_vars:  # cephadm execution"},{"line_number":569,"context_line":"                  map_merge:"},{"line_number":570,"context_line":"                    - {get_attr: [CephAdmVars, value, vars]}"},{"line_number":571,"context_line":"                ceph_admin_extra_vars:  # user creation"},{"line_number":572,"context_line":"                  tripleo_admin_user: ceph-admin"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"a5c68b36_b3ef73a7","line":569,"range":{"start_line":569,"start_character":18,"end_line":569,"end_character":27},"updated":"2021-01-19 12:53:11.000000000","message":"OK, that works too. Thanks.","commit_id":"0a43372015aaf7a6bc2a1d59921fc395ac090b3b"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"c42aa8fd68d5aead9917c692e58f6187bb0f64b9","unresolved":false,"context_lines":[{"line_number":566,"context_line":"                tasks_from: prepare.yml"},{"line_number":567,"context_line":"              vars:"},{"line_number":568,"context_line":"                cephadm_extra_vars:  # cephadm execution"},{"line_number":569,"context_line":"                  map_merge:"},{"line_number":570,"context_line":"                    - {get_attr: [CephAdmVars, value, vars]}"},{"line_number":571,"context_line":"                ceph_admin_extra_vars:  # user creation"},{"line_number":572,"context_line":"                  tripleo_admin_user: ceph-admin"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"37afc7f7_eccbf6f7","line":569,"range":{"start_line":569,"start_character":18,"end_line":569,"end_character":27},"in_reply_to":"a5c68b36_b3ef73a7","updated":"2021-01-20 06:01:28.000000000","message":"Ack","commit_id":"0a43372015aaf7a6bc2a1d59921fc395ac090b3b"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"92514c599623e42b211abe8dcb2ec311715660d9","unresolved":true,"context_lines":[{"line_number":537,"context_line":"                cred: {get_param: ContainerImageRegistryCredentials}"},{"line_number":538,"context_line":"                ns: {get_attr: [ContainerImageUrlParts, value, host]}"},{"line_number":539,"context_line":"              expression: let(c \u003d\u003e $.data.cred) -\u003e $c.get($.data.ns, {}).values().last(default \u003d\u003e \"\")"},{"line_number":540,"context_line":"          monitor_address_block:"},{"line_number":541,"context_line":"            list_join:"},{"line_number":542,"context_line":"              - \u0027,\u0027"},{"line_number":543,"context_line":"              - get_param: [ServiceData, net_cidr_map, {get_param: [ServiceNetMap, CephMonNetwork]}]"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"000c8cff_5a39bf06","line":540,"range":{"start_line":540,"start_character":10,"end_line":540,"end_character":31},"updated":"2021-01-20 18:12:50.000000000","message":"Should we rename this to \u0027public_network\u0027 so that it can map one-to-one with what a ceph.conf file should have?\n\nhttps://access.redhat.com/documentation/en-us/red_hat_ceph_storage/3/html/configuration_guide/network_configuration_reference#public_network\n\nI see we set cluster_network and it maps one-to-one nicely.\n\nhttps://access.redhat.com/documentation/en-us/red_hat_ceph_storage/3/html/configuration_guide/network_configuration_reference#cluster_network","commit_id":"fb7d86abd46ee2d3900ff6b1771b893495143594"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"6df77a3324c8c8e1fa3d48b42240d6d1333ae5ed","unresolved":true,"context_lines":[{"line_number":537,"context_line":"                cred: {get_param: ContainerImageRegistryCredentials}"},{"line_number":538,"context_line":"                ns: {get_attr: [ContainerImageUrlParts, value, host]}"},{"line_number":539,"context_line":"              expression: let(c \u003d\u003e $.data.cred) -\u003e $c.get($.data.ns, {}).values().last(default \u003d\u003e \"\")"},{"line_number":540,"context_line":"          monitor_address_block:"},{"line_number":541,"context_line":"            list_join:"},{"line_number":542,"context_line":"              - \u0027,\u0027"},{"line_number":543,"context_line":"              - get_param: [ServiceData, net_cidr_map, {get_param: [ServiceNetMap, CephMonNetwork]}]"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"a7cbc31a_501dac4a","line":540,"range":{"start_line":540,"start_character":10,"end_line":540,"end_character":31},"in_reply_to":"000c8cff_5a39bf06","updated":"2021-01-20 18:24:02.000000000","message":"+1 good idea, while we can it\u0027s good to use meaningful names","commit_id":"fb7d86abd46ee2d3900ff6b1771b893495143594"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"ebbb2f5574470bcd6b907ac39db9ba8fefbe2332","unresolved":false,"context_lines":[{"line_number":537,"context_line":"                cred: {get_param: ContainerImageRegistryCredentials}"},{"line_number":538,"context_line":"                ns: {get_attr: [ContainerImageUrlParts, value, host]}"},{"line_number":539,"context_line":"              expression: let(c \u003d\u003e $.data.cred) -\u003e $c.get($.data.ns, {}).values().last(default \u003d\u003e \"\")"},{"line_number":540,"context_line":"          monitor_address_block:"},{"line_number":541,"context_line":"            list_join:"},{"line_number":542,"context_line":"              - \u0027,\u0027"},{"line_number":543,"context_line":"              - get_param: [ServiceData, net_cidr_map, {get_param: [ServiceNetMap, CephMonNetwork]}]"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"f0dbeb82_801d6b88","line":540,"range":{"start_line":540,"start_character":10,"end_line":540,"end_character":31},"in_reply_to":"a7cbc31a_501dac4a","updated":"2021-01-20 20:07:56.000000000","message":"Done","commit_id":"fb7d86abd46ee2d3900ff6b1771b893495143594"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"cdb8b3d024fc4115f76d975ca0c0dd084b9cf751","unresolved":true,"context_lines":[{"line_number":580,"context_line":"                              expression: ($.data.default).mergeWith($.data.secure)"},{"line_number":581,"context_line":"                              data:"},{"line_number":582,"context_line":"                                default: {get_attr: [DefaultCephConfigOverrides, value, vars]}"},{"line_number":583,"context_line":"                                secure: {get_attr: [MsgrSecureModeOverrides, value, vars]}"},{"line_number":584,"context_line":"                          - {get_attr: [DefaultCephConfigOverrides, value, vars]}"},{"line_number":585,"context_line":"                ceph_admin_extra_vars:  # user creation"},{"line_number":586,"context_line":"                  tripleo_admin_user: ceph-admin"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"00bcc231_c138547a","line":583,"updated":"2021-01-20 20:07:38.000000000","message":"Let\u0027s process config_overrides the same way we did for ceph-ansible.\nThis can help us reusing some code to process them via ansible [1] \nand providing to cephadm.\nIn addition, the advantage of reusing the code [1] is we can combine \noverrides per-role.\n\n[1] https://github.com/openstack/tripleo-ansible/blob/master/tripleo_ansible/roles/tripleo_ceph_work_dir/tasks/build_config_overrides.yml","commit_id":"fd532196d040b97222f93d3c49bca62deda80f68"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"e011684b0894af9dd56c52bdd263aff54e92ca84","unresolved":true,"context_lines":[{"line_number":580,"context_line":"                              expression: ($.data.default).mergeWith($.data.secure)"},{"line_number":581,"context_line":"                              data:"},{"line_number":582,"context_line":"                                default: {get_attr: [DefaultCephConfigOverrides, value, vars]}"},{"line_number":583,"context_line":"                                secure: {get_attr: [MsgrSecureModeOverrides, value, vars]}"},{"line_number":584,"context_line":"                          - {get_attr: [DefaultCephConfigOverrides, value, vars]}"},{"line_number":585,"context_line":"                ceph_admin_extra_vars:  # user creation"},{"line_number":586,"context_line":"                  tripleo_admin_user: ceph-admin"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"1a84d216_d82097ee","line":583,"in_reply_to":"00bcc231_c138547a","updated":"2021-01-21 03:34:02.000000000","message":"Good idea! \n\nPerhaps we call build_config_overrides.yml from tripleo_run_cephadm and write a resultant ceph.conf to playbook_dir/cephadm/ceph.conf and then we can have tripleo_cephadm bootstrap with that file if it is present. Even if no params are passed, it should at least include the [global]public_network and [global]cluster_network. \n\nPerhaps you can do it this way in tripleo_run_cephadm:\n\n  - include_role: tripleo_ceph_work_dir\n    tasks_from: build_config_overrides\n\nThat way we don\u0027t have to maintain a second copy of build_config_overrides and when tripleo_ceph_work_dir is removed (in X?) we can move the task file into one of our roles.","commit_id":"fd532196d040b97222f93d3c49bca62deda80f68"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"a33cfb4bd1f30841b955555e9f23add245011b1b","unresolved":true,"context_lines":[{"line_number":118,"context_line":"      It can be used to override settings for one of the predefined pools, or to create"},{"line_number":119,"context_line":"      additional ones. Example:"},{"line_number":120,"context_line":"      [{\"name\": \"volumes\", \"pg_num\": 64, \"rule_name\": \"replicated_rule\"},"},{"line_number":121,"context_line":"       {\"name\": \"vms\", \"target_size_ratio\": \"0.4\", \"rule_name\": \"replicated_rule\"}]"},{"line_number":122,"context_line":"    default: []"},{"line_number":123,"context_line":"    type: json"},{"line_number":124,"context_line":"  CinderRbdPoolName:"}],"source_content_type":"text/x-yaml","patch_set":32,"id":"eae62675_221aa97c","line":121,"range":{"start_line":121,"start_character":0,"end_line":121,"end_character":2},"updated":"2021-01-25 20:14:28.000000000","message":"Can we keep this example text with the target_size_ratio?","commit_id":"99c61bca4a19e8660b839913186a2244ba921927"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"97b229ce9accacfbdf319cd535bb4b40301f5af8","unresolved":false,"context_lines":[{"line_number":118,"context_line":"      It can be used to override settings for one of the predefined pools, or to create"},{"line_number":119,"context_line":"      additional ones. Example:"},{"line_number":120,"context_line":"      [{\"name\": \"volumes\", \"pg_num\": 64, \"rule_name\": \"replicated_rule\"},"},{"line_number":121,"context_line":"       {\"name\": \"vms\", \"target_size_ratio\": \"0.4\", \"rule_name\": \"replicated_rule\"}]"},{"line_number":122,"context_line":"    default: []"},{"line_number":123,"context_line":"    type: json"},{"line_number":124,"context_line":"  CinderRbdPoolName:"}],"source_content_type":"text/x-yaml","patch_set":32,"id":"3121b42f_40abb6d5","line":121,"range":{"start_line":121,"start_character":0,"end_line":121,"end_character":2},"in_reply_to":"1ed0917d_4003339d","updated":"2021-01-26 03:19:49.000000000","message":"Done","commit_id":"99c61bca4a19e8660b839913186a2244ba921927"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"de7f892a11b310c321b58f00d439449daedf56b1","unresolved":true,"context_lines":[{"line_number":118,"context_line":"      It can be used to override settings for one of the predefined pools, or to create"},{"line_number":119,"context_line":"      additional ones. Example:"},{"line_number":120,"context_line":"      [{\"name\": \"volumes\", \"pg_num\": 64, \"rule_name\": \"replicated_rule\"},"},{"line_number":121,"context_line":"       {\"name\": \"vms\", \"target_size_ratio\": \"0.4\", \"rule_name\": \"replicated_rule\"}]"},{"line_number":122,"context_line":"    default: []"},{"line_number":123,"context_line":"    type: json"},{"line_number":124,"context_line":"  CinderRbdPoolName:"}],"source_content_type":"text/x-yaml","patch_set":32,"id":"1ed0917d_4003339d","line":121,"range":{"start_line":121,"start_character":0,"end_line":121,"end_character":2},"in_reply_to":"eae62675_221aa97c","updated":"2021-01-25 21:07:43.000000000","message":"\u003e Can we keep this example text with the target_size_ratio?\n\nSure, as long as the ceph_pool module is able to process this parameter [1] we can \nkeep it here.\n\n[1] https://review.opendev.org/c/openstack/tripleo-ansible/+/770674/33/tripleo_ansible/ansible_plugins/modules/ceph_pool.py#90","commit_id":"99c61bca4a19e8660b839913186a2244ba921927"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"0bdef6a9075551cc3f42a5c75eac117d33c95b71","unresolved":false,"context_lines":[{"line_number":570,"context_line":"                tasks_from: prepare.yml"},{"line_number":571,"context_line":"              vars:"},{"line_number":572,"context_line":"                cephadm_extra_vars:  # cephadm execution"},{"line_number":573,"context_line":"                  ceph_config_overrides: {get_param: CephConfigOverrides}"},{"line_number":574,"context_line":"                  ceph_default_overrides:"},{"line_number":575,"context_line":"                    if:"},{"line_number":576,"context_line":"                      - msgr_secure_mode"}],"source_content_type":"text/x-yaml","patch_set":34,"id":"ee5b9948_b8d01b2f","line":573,"updated":"2021-01-25 13:16:36.000000000","message":"These variable were defined in the wrong place and now this should be fixed.\nAccording to scenario001 (where a few config_overrides are defined), the output should be:\n\n````\nceph_conf_overrides:\n    global:\n        anotherkey: anothervalue\n        foo: bar\n        globalkey: globalvalue\n        ms_client_mode: secure\n        ms_cluster_mode: secure\n        ms_service_mode: secure\n        osd_pool_default_pg_num: 32\n        osd_pool_default_pgp_num: 32\n        osd_pool_default_size: 1\n    osd:\n        osdkey: osdvalue\n````\n@fultonj FYI ^^^^","commit_id":"ff692ed0d433ae06380fc14dea5b6721f2de7582"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"a33cfb4bd1f30841b955555e9f23add245011b1b","unresolved":true,"context_lines":[{"line_number":580,"context_line":"                            default: {get_attr: [DefaultCephConfigOverrides, value, vars]}"},{"line_number":581,"context_line":"                            secure: {get_attr: [MsgrSecureModeOverrides, value, vars]}"},{"line_number":582,"context_line":"                      - {get_attr: [DefaultCephConfigOverrides, value, vars]}"},{"line_number":583,"context_line":"                  map_merge:"},{"line_number":584,"context_line":"                    - {get_attr: [CephAdmVars, value, vars]}"},{"line_number":585,"context_line":"                    - ceph_pools: {get_attr: [CephBasePoolVars, value, vars]}"},{"line_number":586,"context_line":"                    - manila_pools: {get_attr: [CephManilaPoolVars, value, vars]}"}],"source_content_type":"text/x-yaml","patch_set":35,"id":"2c035eb7_bb24e789","line":583,"range":{"start_line":583,"start_character":18,"end_line":583,"end_character":27},"updated":"2021-01-25 20:14:28.000000000","message":"I think the formatting here is off because map_merge is getting passed to ansible:\n\n http://paste.openstack.org/show/801961/\n\nthe above is from a new config-download dir genereated by the following:\n\nhttps://review.opendev.org/c/openstack/tripleo-ansible/+/771034/33/tripleo_ansible/roles/tripleo_run_cephadm/tasks/prepare.yml","commit_id":"97b914e4ca8db38905f07a246fe34383f0cdf20e"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"de7f892a11b310c321b58f00d439449daedf56b1","unresolved":true,"context_lines":[{"line_number":580,"context_line":"                            default: {get_attr: [DefaultCephConfigOverrides, value, vars]}"},{"line_number":581,"context_line":"                            secure: {get_attr: [MsgrSecureModeOverrides, value, vars]}"},{"line_number":582,"context_line":"                      - {get_attr: [DefaultCephConfigOverrides, value, vars]}"},{"line_number":583,"context_line":"                  map_merge:"},{"line_number":584,"context_line":"                    - {get_attr: [CephAdmVars, value, vars]}"},{"line_number":585,"context_line":"                    - ceph_pools: {get_attr: [CephBasePoolVars, value, vars]}"},{"line_number":586,"context_line":"                    - manila_pools: {get_attr: [CephManilaPoolVars, value, vars]}"}],"source_content_type":"text/x-yaml","patch_set":35,"id":"bf67fdf6_72467210","line":583,"range":{"start_line":583,"start_character":18,"end_line":583,"end_character":27},"in_reply_to":"2c035eb7_bb24e789","updated":"2021-01-25 21:07:43.000000000","message":"\u003e I think the formatting here is off because map_merge is getting passed to ansible:\n\u003e \n\u003e  http://paste.openstack.org/show/801961/\n\u003e \n\u003e the above is from a new config-download dir genereated by the following:\n\u003e \n\u003e https://review.opendev.org/c/openstack/tripleo-ansible/+/771034/33/tripleo_ansible/roles/tripleo_run_cephadm/tasks/prepare.yml\n\nReally, not sure what happened w/ formatting here, but I\u0027m going to solve this in the next PS!","commit_id":"97b914e4ca8db38905f07a246fe34383f0cdf20e"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"1a20788980423fa4be268eb9003b6e0ceee1d13d","unresolved":true,"context_lines":[{"line_number":579,"context_line":"                          default: {get_attr: [DefaultCephConfigOverrides, value, vars]}"},{"line_number":580,"context_line":"                          secure: {get_attr: [MsgrSecureModeOverrides, value, vars]}"},{"line_number":581,"context_line":"                    - {get_attr: [DefaultCephConfigOverrides, value, vars]}"},{"line_number":582,"context_line":"                cephadm_extra_vars:  # cephadm execution"},{"line_number":583,"context_line":"                  map_merge:"},{"line_number":584,"context_line":"                    - {get_attr: [CephAdmVars, value, vars]}"},{"line_number":585,"context_line":"                    - ceph_pools: {get_attr: [CephBasePoolVars, value, vars]}"}],"source_content_type":"text/x-yaml","patch_set":36,"id":"2a4336c7_807a77ec","line":582,"updated":"2021-01-26 03:07:53.000000000","message":"Here\u0027s what resulted in my new deployment:\n\n http://paste.openstack.org/show/801973/\n\nceph_default_overrides is out which is good.","commit_id":"868899a437f4373fd4198acc82100b17ad3b5602"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"fe14150ea3b74589ee0a7a1282ce8e9c7b3e3f01","unresolved":false,"context_lines":[{"line_number":579,"context_line":"                          default: {get_attr: [DefaultCephConfigOverrides, value, vars]}"},{"line_number":580,"context_line":"                          secure: {get_attr: [MsgrSecureModeOverrides, value, vars]}"},{"line_number":581,"context_line":"                    - {get_attr: [DefaultCephConfigOverrides, value, vars]}"},{"line_number":582,"context_line":"                cephadm_extra_vars:  # cephadm execution"},{"line_number":583,"context_line":"                  map_merge:"},{"line_number":584,"context_line":"                    - {get_attr: [CephAdmVars, value, vars]}"},{"line_number":585,"context_line":"                    - ceph_pools: {get_attr: [CephBasePoolVars, value, vars]}"}],"source_content_type":"text/x-yaml","patch_set":36,"id":"c79ad7c5_81c9c254","line":582,"in_reply_to":"2a4336c7_807a77ec","updated":"2021-01-26 09:05:29.000000000","message":"I see and that\u0027s expected, we should be good for ceph_config_overrides! Thanks for double checking!","commit_id":"868899a437f4373fd4198acc82100b17ad3b5602"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"1a20788980423fa4be268eb9003b6e0ceee1d13d","unresolved":true,"context_lines":[{"line_number":583,"context_line":"                  map_merge:"},{"line_number":584,"context_line":"                    - {get_attr: [CephAdmVars, value, vars]}"},{"line_number":585,"context_line":"                    - ceph_pools: {get_attr: [CephBasePoolVars, value, vars]}"},{"line_number":586,"context_line":"                    - manila_pools: {get_attr: [CephManilaPoolVars, value, vars]}"},{"line_number":587,"context_line":"                    - ceph_keys: {get_attr: [CephKeyVars, value, vars]}"},{"line_number":588,"context_line":"                ceph_admin_extra_vars:  # user creation"},{"line_number":589,"context_line":"                  tripleo_admin_user: ceph-admin"}],"source_content_type":"text/x-yaml","patch_set":36,"id":"37ea1799_a9cf9829","line":586,"updated":"2021-01-26 03:07:53.000000000","message":"I see the cephadm-extra-vars-heat.yml has openstack_pools, manila_pools, and ceph_pools but none of those are currently used by tripleo_cephadm, it only uses \"pools\" from cephadm-extra-vars-ansible.yml.\n\nHowever, that pools is built from the other pool variables I mentioned as seen here:\n\nhttps://review.opendev.org/c/openstack/tripleo-ansible/+/771034/33/tripleo_ansible/roles/tripleo_run_cephadm/tasks/prepare.yml#62\n\nI assume we have the combination we want.","commit_id":"868899a437f4373fd4198acc82100b17ad3b5602"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"fe14150ea3b74589ee0a7a1282ce8e9c7b3e3f01","unresolved":false,"context_lines":[{"line_number":583,"context_line":"                  map_merge:"},{"line_number":584,"context_line":"                    - {get_attr: [CephAdmVars, value, vars]}"},{"line_number":585,"context_line":"                    - ceph_pools: {get_attr: [CephBasePoolVars, value, vars]}"},{"line_number":586,"context_line":"                    - manila_pools: {get_attr: [CephManilaPoolVars, value, vars]}"},{"line_number":587,"context_line":"                    - ceph_keys: {get_attr: [CephKeyVars, value, vars]}"},{"line_number":588,"context_line":"                ceph_admin_extra_vars:  # user creation"},{"line_number":589,"context_line":"                  tripleo_admin_user: ceph-admin"}],"source_content_type":"text/x-yaml","patch_set":36,"id":"f40c3213_569ed6d6","line":586,"in_reply_to":"37ea1799_a9cf9829","updated":"2021-01-26 09:05:29.000000000","message":"Hey John, thanks for pointing this out. \nI\u0027m going to improve this part because I see many info redundancy here.\nFor instance pools are already available in cephadm-extra-vars-ansible.yml, there\u0027s no reason to have this data structure replicated in cephadm-extra-vars-heat.yml (and as you said we rely on \"pools\", which uses the same data structure!!).\nI\u0027m going to clean this thing up in the next PS.","commit_id":"868899a437f4373fd4198acc82100b17ad3b5602"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"1a20788980423fa4be268eb9003b6e0ceee1d13d","unresolved":true,"context_lines":[{"line_number":584,"context_line":"                    - {get_attr: [CephAdmVars, value, vars]}"},{"line_number":585,"context_line":"                    - ceph_pools: {get_attr: [CephBasePoolVars, value, vars]}"},{"line_number":586,"context_line":"                    - manila_pools: {get_attr: [CephManilaPoolVars, value, vars]}"},{"line_number":587,"context_line":"                    - ceph_keys: {get_attr: [CephKeyVars, value, vars]}"},{"line_number":588,"context_line":"                ceph_admin_extra_vars:  # user creation"},{"line_number":589,"context_line":"                  tripleo_admin_user: ceph-admin"},{"line_number":590,"context_line":"                  distribute_private_key: true"}],"source_content_type":"text/x-yaml","patch_set":36,"id":"abee60c8_24b416f5","line":587,"updated":"2021-01-26 03:07:53.000000000","message":"I see that cephadm-extra-vars-heat.yml has ceph_keys but it\u0027s not used by tripleo_cephadm, it only uses \"keys\" from cephadm-extra-vars-ansible.yml.\n\nHowever, I assume that keys structure is built from the other key variables I mentioned as seen here:\n\nhttps://review.opendev.org/c/openstack/tripleo-ansible/+/771034/33/tripleo_ansible/roles/tripleo_run_cephadm/tasks/prepare.yml#54","commit_id":"868899a437f4373fd4198acc82100b17ad3b5602"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"65911f41dfb90ebd4a4bc62fc61a4966fcde705b","unresolved":true,"context_lines":[{"line_number":194,"context_line":"  ContainerCephDaemonImage:"},{"line_number":195,"context_line":"    description: image"},{"line_number":196,"context_line":"    type: string"},{"line_number":197,"context_line":"  # start DEPRECATED options for compatibility with older versions"},{"line_number":198,"context_line":"  CephAnsiblePlaybookVerbosity:"},{"line_number":199,"context_line":"    default: 1"},{"line_number":200,"context_line":"    description: The number of \u0027-v\u0027, \u0027-vv\u0027, etc. passed to ansible-playbook command"}],"source_content_type":"text/x-yaml","patch_set":57,"id":"17003c2b_6bd352dd","line":197,"updated":"2021-02-25 07:56:25.000000000","message":"please try to keep it all together i mean you have this section of deprecated options but then another one on line 262 below","commit_id":"6953504fe32561218723690f071fd99d485ecafd"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"bc94b7dd3a9eb3f8d1e800f2e96a3056647407cb","unresolved":true,"context_lines":[{"line_number":586,"context_line":"                  tripleo_admin_generate_key: true"},{"line_number":587,"context_line":"                  distribute_private_key: true"},{"line_number":588,"context_line":"                  tripleo_admin_user: ceph-admin"},{"line_number":589,"context_line":"                  ansible_user: ceph-admin"},{"line_number":590,"context_line":"                  ansible_home: \"/home/ceph-admin\""},{"line_number":591,"context_line":"                  ssh_servers: \"{{ groups[\u0027ceph_mon\u0027] |"},{"line_number":592,"context_line":"                                   union(groups[\u0027ceph_osd\u0027]|default([])) |"}],"source_content_type":"text/x-yaml","patch_set":65,"id":"7a16d719_a6223f1a","line":589,"updated":"2021-03-10 19:38:15.000000000","message":"I see an issue here, on a fresh standalone environment:\n\nwhen you run [1] with these overrides, [2] is executed using, and it tries to chown the .ssh dir using ceph-admin user (which is not created until [3] is executed) and it fails with:\n\n````\n2021-03-10 19:14:21,766 p\u003d37962 u\u003droot n\u003dansible | 2021-03-10 19:14:21.766526 | 52540030-7dd1-648a-a886-000000000017 |      FATAL | Ensure .ssh directory | undercloud | error\u003d{\"changed\": false, \"gid\": 0, \"group\": \"root\", \"mode\": \"0755\", \"msg\": \"chown failed: failed to look up user ceph-admin\", \"owner\": \"root\", \"path\": \"/home/ceph-admin\", \"secontext\": \"unconfined_u:object_r:user_home_dir_t:s0\", \"size\": 6, \"state\": \"directory\", \"uid\": 0}\n2021-03-10 19:14:21,779 p\u003d37962 u\u003droot n\u003dansible | 2021-03-10 19:14:21.779456 | 52540030-7dd1-648a-a886-000000000017 |      FATAL | Ensure .ssh directory | standalone | error\u003d{\"changed\": false, \"gid\": 0, \"group\": \"root\", \"mode\": \"0755\", \"msg\": \"chown failed: failed to look up user ceph-admin\", \"owner\": \"root\", \"path\": \"/home/ceph-admin/.ssh\", \"secontext\": \"unconfined_u:object_r:ssh_home_t:s0\", \"size\": 6, \"state\": \"directory\", \"uid\": 0}\n\n````\n\nI suspect overriding ansible_{user, home} is the cause of this issue.\n\n[1] https://review.opendev.org/c/openstack/tripleo-ansible/+/779358/14/tripleo_ansible/roles/tripleo_run_cephadm/tasks/enable_ceph_admin_user.yml@27\n\n[2] https://review.opendev.org/c/openstack/tripleo-ansible/+/779358/14/tripleo_ansible/roles/tripleo_create_admin/tasks/ssh_keys.yml#66\n\n[3] https://review.opendev.org/c/openstack/tripleo-ansible/+/779358/14/tripleo_ansible/roles/tripleo_run_cephadm/tasks/enable_ceph_admin_user.yml#29","commit_id":"0e3a0e7693e194fe160748c53a612d919fd1fdb4"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"d48b1c8118170c34511d70fadaf3ba02a00e581d","unresolved":true,"context_lines":[{"line_number":586,"context_line":"                  tripleo_admin_generate_key: true"},{"line_number":587,"context_line":"                  distribute_private_key: true"},{"line_number":588,"context_line":"                  tripleo_admin_user: ceph-admin"},{"line_number":589,"context_line":"                  ansible_user: ceph-admin"},{"line_number":590,"context_line":"                  ansible_home: \"/home/ceph-admin\""},{"line_number":591,"context_line":"                  ssh_servers: \"{{ groups[\u0027ceph_mon\u0027] |"},{"line_number":592,"context_line":"                                   union(groups[\u0027ceph_osd\u0027]|default([])) |"}],"source_content_type":"text/x-yaml","patch_set":65,"id":"79d497db_d38c3221","line":589,"in_reply_to":"03421632_b832eacf","updated":"2021-03-10 20:16:45.000000000","message":"Definitely true, this approach works for standalone if I remove the ansible_{home, user} override and use delegate_to: undercloud.","commit_id":"0e3a0e7693e194fe160748c53a612d919fd1fdb4"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"13757186f620d26933dabee148356ad896752657","unresolved":true,"context_lines":[{"line_number":586,"context_line":"                  tripleo_admin_generate_key: true"},{"line_number":587,"context_line":"                  distribute_private_key: true"},{"line_number":588,"context_line":"                  tripleo_admin_user: ceph-admin"},{"line_number":589,"context_line":"                  ansible_user: ceph-admin"},{"line_number":590,"context_line":"                  ansible_home: \"/home/ceph-admin\""},{"line_number":591,"context_line":"                  ssh_servers: \"{{ groups[\u0027ceph_mon\u0027] |"},{"line_number":592,"context_line":"                                   union(groups[\u0027ceph_osd\u0027]|default([])) |"}],"source_content_type":"text/x-yaml","patch_set":65,"id":"03421632_b832eacf","line":589,"in_reply_to":"7a16d719_a6223f1a","updated":"2021-03-10 19:47:44.000000000","message":"So running:\n\n$ ansible-playbook -i inventory.yml ceph-admin-user-playbook.yml -e @ceph-admin.yml\n\nends with:\n\n```\nTASK [tripleo_create_admin : Ensure .ssh directory] *********************************************************************************************************************************************************************************************************\nfatal: [standalone]: FAILED! \u003d\u003e {\"changed\": false, \"gid\": 0, \"group\": \"root\", \"mode\": \"0755\", \"msg\": \"chown failed: failed to look up user ceph-admin\", \"owner\": \"root\", \"path\": \"/home/ceph-admin/.ssh\", \"secontext\": \"unconfined_u:object_r:ssh_home_t:s0\", \"size\": 6, \"state\": \"directory\", \"uid\": 0}\nfatal: [undercloud]: FAILED! \u003d\u003e {\"changed\": false, \"gid\": 0, \"group\": \"root\", \"mode\": \"0755\", \"msg\": \"chown failed: failed to look up user ceph-admin\", \"owner\": \"root\", \"path\": \"/home/ceph-admin/.ssh\", \"secontext\": \"unconfined_u:object_r:ssh_home_t:s0\", \"size\": 6, \"state\": \"directory\", \"uid\": 0}\n\nPLAY RECAP **************************************************************************************************************************************************************************************************************************************************\nstandalone                 : ok\u003d0    changed\u003d0    unreachable\u003d0    failed\u003d1    skipped\u003d4    rescued\u003d0    ignored\u003d0\nundercloud                 : ok\u003d2    changed\u003d0    unreachable\u003d0    failed\u003d1    skipped\u003d4    rescued\u003d0    ignored\u003d0\n```\n\nRemoving the overrides the playbook ends with:\n\n[root@standalone cephadm]# ls -l /home/ceph-admin/.ssh/\ntotal 12\n-rw-------. 1 ceph-admin ceph-admin  598 Mar 10 19:18 authorized_keys\n-rw-------. 1 ceph-admin ceph-admin 2643 Mar 10 19:18 id_rsa\n-rw-r--r--. 1 ceph-admin ceph-admin  597 Mar 10 19:18 id_rsa.pub\n\n\nHowever, as you can see, the delegate_to: localhost still doesn\u0027t work here, and it raise an issue on the \"undercloud\" inventory node, which can be resolved using delegate_to: undercloud instead of localhost (see http://ix.io/2Sns).\nAnyway the key part here is that the overrides didn\u0027t work as expected on a fresh environment.","commit_id":"0e3a0e7693e194fe160748c53a612d919fd1fdb4"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"28622e56396f9062f42be3e73eb059a42758467b","unresolved":true,"context_lines":[{"line_number":583,"context_line":"                  map_merge:"},{"line_number":584,"context_line":"                    - {get_attr: [CephAdmVars, value, vars]}"},{"line_number":585,"context_line":"                ceph_admin_extra_vars:  # user creation"},{"line_number":586,"context_line":"                  tripleo_admin_generate_key: true"},{"line_number":587,"context_line":"                  distribute_private_key: true"},{"line_number":588,"context_line":"                  tripleo_admin_user: ceph-admin"},{"line_number":589,"context_line":"                  ssh_servers: \"{{ groups[\u0027ceph_mon\u0027] |"}],"source_content_type":"text/x-yaml","patch_set":66,"id":"1df5ba11_25fd75c1","line":586,"range":{"start_line":586,"start_character":18,"end_line":586,"end_character":50},"updated":"2021-03-11 00:28:51.000000000","message":"We want this to be false. We don\u0027t generate the key when we create the user. \nInstead we create the user and then give those users the _same_ key.\n\nhttps://github.com/openstack/tripleo-ansible/blob/master/tripleo_ansible/roles/tripleo_create_admin/tasks/create_user.yml\n\nOtherwise it can lead to this:\n\n http://ix.io/2SoN\n http://paste.openstack.org/show/803450/","commit_id":"3dc4c88142ce469a02e718d2127fc1d2054017b1"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"3740965491c4b0fdf0459326e062c771e49bc25c","unresolved":false,"context_lines":[{"line_number":583,"context_line":"                  map_merge:"},{"line_number":584,"context_line":"                    - {get_attr: [CephAdmVars, value, vars]}"},{"line_number":585,"context_line":"                ceph_admin_extra_vars:  # user creation"},{"line_number":586,"context_line":"                  tripleo_admin_generate_key: true"},{"line_number":587,"context_line":"                  distribute_private_key: true"},{"line_number":588,"context_line":"                  tripleo_admin_user: ceph-admin"},{"line_number":589,"context_line":"                  ssh_servers: \"{{ groups[\u0027ceph_mon\u0027] |"}],"source_content_type":"text/x-yaml","patch_set":66,"id":"5bba58eb_06d71ee5","line":586,"range":{"start_line":586,"start_character":18,"end_line":586,"end_character":50},"in_reply_to":"1df5ba11_25fd75c1","updated":"2021-03-11 05:15:30.000000000","message":"done","commit_id":"3dc4c88142ce469a02e718d2127fc1d2054017b1"}],"deployment/cephadm/ceph-client.yaml":[{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"61f8e09dab9121eeda9a04084e14f05375a5c6f3","unresolved":true,"context_lines":[{"line_number":134,"context_line":"                vars:"},{"line_number":135,"context_line":"                  tripleo_ceph_client_config_home: {get_param: CephConfigPath}"},{"line_number":136,"context_line":"                  dcn: \"{{ item }}\""},{"line_number":137,"context_line":"                loop: \"{{ ceph_external_multi_config }}\""},{"line_number":138,"context_line":"      external_update_tasks: []"},{"line_number":139,"context_line":"      external_upgrade_tasks: []"},{"line_number":140,"context_line":"      config_settings: {}"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"2605d5ab_8b1b264e","line":137,"range":{"start_line":137,"start_character":16,"end_line":137,"end_character":56},"updated":"2021-01-18 19:32:15.000000000","message":"when:\n                  - ceph_external_multi_config is defined\n\nto avoid bug https://launchpad.net/bugs/1912109","commit_id":"1728c2e5609224baf348aba534e3ed2a2c5a0298"}],"deployment/cephadm/ceph-nfs.yaml":[{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"efa2c1fe8e0a2b523706d175b7a963cd668f2d15","unresolved":true,"context_lines":[{"line_number":30,"context_line":"    description: Mapping of service endpoint -\u003e protocol. Typically set"},{"line_number":31,"context_line":"                 via parameter_defaults in the resource registry."},{"line_number":32,"context_line":"    type: json"},{"line_number":33,"context_line":"  ManilaCephFSCephFSAuthId:"},{"line_number":34,"context_line":"    type: string"},{"line_number":35,"context_line":"    default: \u0027manila\u0027"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"e5553d57_f6217cdb","line":33,"updated":"2021-01-15 15:19:08.000000000","message":"Let\u0027s make sure in a release note that we document any parameter that we don\u0027t keep.","commit_id":"8af8b2594b3e9c6425b5f279419defe9dbc50db8"}],"deployment/cephadm/ceph-osd.yaml":[{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"6e1ccf33a7af0d321bcbcc63c33e1cdb1cf5b9d0","unresolved":true,"context_lines":[{"line_number":35,"context_line":"    description: Disks config settings for ceph-ansible"},{"line_number":36,"context_line":"    default:"},{"line_number":37,"context_line":"      devices:"},{"line_number":38,"context_line":"      - /dev/vdb"},{"line_number":39,"context_line":"      osd_scenario: lvm"},{"line_number":40,"context_line":"      osd_objectstore: bluestore"},{"line_number":41,"context_line":"  CephEnableDashboard:"}],"source_content_type":"text/x-yaml","patch_set":32,"id":"3805d218_a94947bc","line":38,"range":{"start_line":38,"start_character":0,"end_line":38,"end_character":2},"updated":"2021-01-25 12:00:22.000000000","message":"I\u0027d prefer to default this to an empty list. There are other new defaults I\u0027d like to set (percentage of in OSDs from 66 to 0) for a better user experience with the new cephadm tool. Can we modify the validators to make an exception?\n\nAlternatively, we can update /{ceph-ansible,cephadm}/ceph-base.yaml on both sides. Adding a new default for Wallaby but keeping the old default in Victoria.","commit_id":"99c61bca4a19e8660b839913186a2244ba921927"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"83a1965e8f47bdce34038218f158c884eb929530","unresolved":true,"context_lines":[{"line_number":35,"context_line":"    description: Disks config settings for ceph-ansible"},{"line_number":36,"context_line":"    default:"},{"line_number":37,"context_line":"      devices:"},{"line_number":38,"context_line":"      - /dev/vdb"},{"line_number":39,"context_line":"      osd_scenario: lvm"},{"line_number":40,"context_line":"      osd_objectstore: bluestore"},{"line_number":41,"context_line":"  CephEnableDashboard:"}],"source_content_type":"text/x-yaml","patch_set":32,"id":"6c3275af_83c82f03","line":38,"range":{"start_line":38,"start_character":0,"end_line":38,"end_character":2},"in_reply_to":"3805d218_a94947bc","updated":"2021-01-25 12:24:01.000000000","message":"ack, I\u0027ll do in the next PS.\nWhen we change a default, we need to make the same change to the ceph-ansible tht branch, which is ok since we\u0027re going to remove that use case during the next cycle and older branches can keep the old defaults. Having the DiskConfig default to emptyList justify also having the OSD(s) percentage set to 0.","commit_id":"99c61bca4a19e8660b839913186a2244ba921927"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"89e33c0827aa57fb13cca548a80b053fca4a39df","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    description: Disks config settings for ceph-ansible"},{"line_number":36,"context_line":"    default:"},{"line_number":37,"context_line":"      devices:"},{"line_number":38,"context_line":"      - /dev/vdb"},{"line_number":39,"context_line":"      osd_scenario: lvm"},{"line_number":40,"context_line":"      osd_objectstore: bluestore"},{"line_number":41,"context_line":"  CephEnableDashboard:"}],"source_content_type":"text/x-yaml","patch_set":32,"id":"e39704f5_8984a56d","line":38,"range":{"start_line":38,"start_character":0,"end_line":38,"end_character":2},"in_reply_to":"6c3275af_83c82f03","updated":"2021-01-26 03:48:14.000000000","message":"Done","commit_id":"99c61bca4a19e8660b839913186a2244ba921927"}],"releasenotes/notes/cephadm-28185ca8ac814567.yaml":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"fb7c55c2c8539ba381ddb9f4e063bd338f869ae1","unresolved":true,"context_lines":[{"line_number":10,"context_line":"    The contents of the deployment/ceph-ansible and environments/ceph-ansible"},{"line_number":11,"context_line":"    directories have been deprecated and replaced with deployment/cephadm and"},{"line_number":12,"context_line":"    environments/cephadm respectively."},{"line_number":13,"context_line":"  - |"},{"line_number":14,"context_line":"    The CephAnsibleDisksConfig parameter has been deprecated as a cephadm OSD"},{"line_number":15,"context_line":"    service specification file should be used in its place to deploy OSDs. The"},{"line_number":16,"context_line":"    devices list within the default CephAnsibleDisksConfig map has been set to"}],"source_content_type":"text/x-yaml","patch_set":45,"id":"224a4f31_48479196","line":13,"updated":"2021-02-01 15:01:19.000000000","message":"maybe move this below CephOsdPercentageMin so the CephAnsible* params are all together at the bottom and add a sentence to say something like \"The cephadm implementation does not reuse the ceph-ansible specific parameters, hence the following are deprecated:\"\n\nI hope this also helps explaining the changes aren\u0027t introduced by us but due to the tool being different","commit_id":"adfe100149c6510305c674936a7400eee26e1915"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"fb7c55c2c8539ba381ddb9f4e063bd338f869ae1","unresolved":true,"context_lines":[{"line_number":30,"context_line":"  - The CephAnsibleSkipClient has been deprecated"},{"line_number":31,"context_line":"  - The CephAnsibleSkipTags parameter has been deprecated"},{"line_number":32,"context_line":"  - The CephAnsibleWarning parameter has been deprecated"},{"line_number":33,"context_line":"  - The LocalCephAnsibleFetchDirectoryBackup parameter has been deprecated"},{"line_number":34,"context_line":"other:"},{"line_number":35,"context_line":"  - |"},{"line_number":36,"context_line":"    The CephPoolDefaultPgNum paramter default is now 16. The Ceph pg_autoscaler"}],"source_content_type":"text/x-yaml","patch_set":45,"id":"13c5c9e5_73667292","line":33,"updated":"2021-02-01 15:01:19.000000000","message":"nice we\u0027re in fact deprecating all the CephAnsible specific params, thanks","commit_id":"adfe100149c6510305c674936a7400eee26e1915"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"f0f00456a5191869ffce49ca5dd047ba19533950","unresolved":true,"context_lines":[{"line_number":7,"context_line":"deprecations:"},{"line_number":8,"context_line":"  - Deployment using Ceph versions older than Octopus is deprecated"},{"line_number":9,"context_line":"  - |"},{"line_number":10,"context_line":"    The contents of the deployment/ceph-ansible and environments/ceph-ansible"},{"line_number":11,"context_line":"    directories have been deprecated and replaced with deployment/cephadm and"},{"line_number":12,"context_line":"    environments/cephadm respectively."},{"line_number":13,"context_line":"  - |"},{"line_number":14,"context_line":"    The CephAnsibleDisksConfig parameter has been deprecated as a cephadm OSD"}],"source_content_type":"text/x-yaml","patch_set":58,"id":"13e5acbd_c6512234","line":11,"range":{"start_line":10,"start_character":4,"end_line":11,"end_character":36},"updated":"2021-02-25 22:40:42.000000000","message":"moved to\n\nhttps://review.opendev.org/c/openstack/tripleo-heat-templates/+/773355/13/releasenotes/notes/ceph-ansible-deprecation-63098f7eca55eddc.yaml","commit_id":"7ebfcce22db91195a9b7e5d4ba80287cff496a8a"}],"tools/yaml-validate.py":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"65911f41dfb90ebd4a4bc62fc61a4966fcde705b","unresolved":true,"context_lines":[{"line_number":342,"context_line":"    return set(old_impl_params).difference(set(new_impl_params))"},{"line_number":343,"context_line":""},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"def compare_ceph_parameters(path):"},{"line_number":346,"context_line":"    old_path \u003d base_path + \"/deployment/ceph-ansible/\""},{"line_number":347,"context_line":"    new_path \u003d base_path + \"/deployment/cephadm/\""},{"line_number":348,"context_line":"    missing \u003d compare_parameters(old_path, new_path)"}],"source_content_type":"text/x-python","patch_set":57,"id":"6cfce491_26a7d92e","line":345,"updated":"2021-02-25 07:56:25.000000000","message":"nice","commit_id":"6953504fe32561218723690f071fd99d485ecafd"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"be81920c9758f944c93675ecda3fa02584efd486","unresolved":true,"context_lines":[{"line_number":342,"context_line":"    return set(old_impl_params).difference(set(new_impl_params))"},{"line_number":343,"context_line":""},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"def compare_ceph_parameters(path):"},{"line_number":346,"context_line":"    old_path \u003d base_path + \"/deployment/ceph-ansible/\""},{"line_number":347,"context_line":"    new_path \u003d base_path + \"/deployment/cephadm/\""},{"line_number":348,"context_line":"    missing \u003d compare_parameters(old_path, new_path)"}],"source_content_type":"text/x-python","patch_set":57,"id":"2070cf36_b6110234","line":345,"in_reply_to":"6cfce491_26a7d92e","updated":"2021-02-25 20:03:31.000000000","message":"This was Giulio\u0027s :)","commit_id":"6953504fe32561218723690f071fd99d485ecafd"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"08d86141a9a280b6be5e24cfa8c8070326699e22","unresolved":true,"context_lines":[{"line_number":343,"context_line":""},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"def compare_ceph_parameters(path):"},{"line_number":346,"context_line":"    old_path \u003d base_path + \"/deployment/ceph-ansible/\""},{"line_number":347,"context_line":"    new_path \u003d base_path + \"/deployment/cephadm/\""},{"line_number":348,"context_line":"    missing \u003d compare_parameters(old_path, new_path)"},{"line_number":349,"context_line":"    if missing:"},{"line_number":350,"context_line":"        print(\"ERROR: Some parameters are missing in Ceph implementation at\""}],"source_content_type":"text/x-python","patch_set":60,"id":"3f8b0011_02481900","line":347,"range":{"start_line":346,"start_character":0,"end_line":347,"end_character":49},"updated":"2021-03-03 13:42:58.000000000","message":"NIT: I think these should use os.path.join (https://docs.python.org/3/library/os.path.html#os.path.join) instead of","commit_id":"fbbc8ff02647d1e2e8fb9fb1dbc322ba718c0bd9"}]}