)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"f21355f32b936bcc9485dab4b87f717723ffd43f","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Making sure virt-guest-shutdown.target exists"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"libvirt-daemon is part of the default overcloud image but it\u0027s also"},{"line_number":10,"context_line":"possible that it\u0027s not installed or simply removed by operators. In this"},{"line_number":11,"context_line":"case, tripleo_nova_libvirt_guests will fail."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Related: https://bugzilla.redhat.com/1810319"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1171e804_3d0c006e","line":10,"range":{"start_line":9,"start_character":1,"end_line":10,"end_character":64},"updated":"2021-01-13 17:19:03.000000000","message":"can we just make this a hard requirement on a package somewhere?","commit_id":"93b5c3a20e113a38aa99ab8266681f4554b1ac97"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"21a4b06469751a17ad1e6ea88c1f7fff3a6ffaee","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Making sure virt-guest-shutdown.target exists"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"libvirt-daemon is part of the default overcloud image but it\u0027s also"},{"line_number":10,"context_line":"possible that it\u0027s not installed or simply removed by operators. In this"},{"line_number":11,"context_line":"case, tripleo_nova_libvirt_guests will fail."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Related: https://bugzilla.redhat.com/1810319"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"e76566ad_310658c0","line":10,"range":{"start_line":9,"start_character":1,"end_line":10,"end_character":64},"in_reply_to":"1171e804_3d0c006e","updated":"2021-01-14 10:46:48.000000000","message":"in general we don\u0027t want libvirt packages installed on the host, but for system shutdown/boot we\u0027d need this on the host.","commit_id":"93b5c3a20e113a38aa99ab8266681f4554b1ac97"}],"deployment/nova/nova-compute-container-puppet.yaml":[{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"c1743fc7f1414c131868947e005e4421d0f2ab5f","unresolved":true,"context_lines":[{"line_number":1041,"context_line":"                    Description\u003dSuspend/Resume Running libvirt Guests"},{"line_number":1042,"context_line":"                    After\u003dnetwork.target"},{"line_number":1043,"context_line":"                    After\u003dtime-sync.target"},{"line_number":1044,"context_line":"                    After\u003dvirt-guest-shutdown.target"},{"line_number":1045,"context_line":"                    After\u003ddocker.service"},{"line_number":1046,"context_line":"                    After\u003dtripleo-container-shutdown.service"},{"line_number":1047,"context_line":"                    After\u003drhel-push-plugin.service"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"103279e6_db2616d9","side":"PARENT","line":1044,"updated":"2021-01-04 07:58:17.000000000","message":"Have you tested this? I don\u0027t think we can just remove this as otherwise the VMs won\u0027t get shutdown gracefully and just get killed during the shutdown. I think the correct way is to create /etc/systemd/system/virt-guest-shutdown.target file.","commit_id":"93a6f9d4cf81b08d3425974903910a5b69a7d4cd"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"c1743fc7f1414c131868947e005e4421d0f2ab5f","unresolved":true,"context_lines":[{"line_number":1078,"context_line":"                  content: |"},{"line_number":1079,"context_line":"                    [Unit]"},{"line_number":1080,"context_line":"                    Description\u003dSuspend libvirt Guests in tripleo"},{"line_number":1081,"context_line":"                    Requires\u003dvirt-guest-shutdown.target"},{"line_number":1082,"context_line":"                    After\u003dsystemd-machined.service"},{"line_number":1083,"context_line":"                    After\u003dtripleo_nova_libvirt.service"},{"line_number":1084,"context_line":"                    Before\u003dtripleo_nova_compute.service"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"b02b4545_fe1f2da6","side":"PARENT","line":1081,"updated":"2021-01-04 07:58:17.000000000","message":"also the above won\u0027t fix it for podman. we should really create the virt-guest-shutdown.target and enable it.","commit_id":"93a6f9d4cf81b08d3425974903910a5b69a7d4cd"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"d6d5de1042dfeb9a2e27bf3e14a39fa84abbd364","unresolved":true,"context_lines":[{"line_number":59,"context_line":"        letters and numbers."},{"line_number":60,"context_line":"  CephConfigPath:"},{"line_number":61,"context_line":"    type: string"},{"line_number":62,"context_line":"    default: \"/var/lib/tripleo-config/ceph\""},{"line_number":63,"context_line":"    description: |"},{"line_number":64,"context_line":"      The path where the Ceph Cluster config files are stored on the host."},{"line_number":65,"context_line":"  NovaComputeOptVolumes:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3864088c_baaa678f","line":62,"updated":"2021-01-12 07:16:05.000000000","message":"maybe just rebase on top of latest to have this change","commit_id":"d77541bf8645346f300719ed590cb41c263b38cb"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"d6d5de1042dfeb9a2e27bf3e14a39fa84abbd364","unresolved":true,"context_lines":[{"line_number":1064,"context_line":"                    WantedBy\u003dmulti-user.target"},{"line_number":1065,"context_line":"              - name: Making sure virt-guest-shutdown.target is present"},{"line_number":1066,"context_line":"                copy:"},{"line_number":1067,"context_line":"                  dest: /usr/lib/systemd/system/virt-guest-shutdown.target"},{"line_number":1068,"context_line":"                  content: |"},{"line_number":1069,"context_line":"                    [Unit]"},{"line_number":1070,"context_line":"                    Description\u003dLibvirt guests shutdown"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1cfd6201_a82f8d9f","line":1067,"range":{"start_line":1067,"start_character":24,"end_line":1067,"end_character":41},"updated":"2021-01-12 07:16:05.000000000","message":"maybe we create it in /etc/systemd/system. content in /usr/lib/systemd is provided by rpms","commit_id":"d77541bf8645346f300719ed590cb41c263b38cb"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"d6d5de1042dfeb9a2e27bf3e14a39fa84abbd364","unresolved":true,"context_lines":[{"line_number":1078,"context_line":"            when:"},{"line_number":1079,"context_line":"              - resume_guests_state_on_host_boot_enabled|bool"},{"line_number":1080,"context_line":"              - container_cli \u003d\u003d \u0027podman\u0027"},{"line_number":1081,"context_line":"            block:"},{"line_number":1082,"context_line":"              - name: libvirt-guests unit to stop nova_compute container before shutdown VMs"},{"line_number":1083,"context_line":"                copy:"},{"line_number":1084,"context_line":"                  dest: /etc/systemd/system/tripleo_nova_libvirt_guests.service"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"f46f174b_e098e95a","line":1081,"range":{"start_line":1081,"start_character":11,"end_line":1081,"end_character":18},"updated":"2021-01-12 07:16:05.000000000","message":"we also have to create it in this block","commit_id":"d77541bf8645346f300719ed590cb41c263b38cb"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"f21355f32b936bcc9485dab4b87f717723ffd43f","unresolved":true,"context_lines":[{"line_number":1083,"context_line":"                    WantedBy\u003dmulti-user.target"},{"line_number":1084,"context_line":"              - name: Making sure virt-guest-shutdown.target is present"},{"line_number":1085,"context_line":"                copy:"},{"line_number":1086,"context_line":"                  dest: /etc/systemd/system/virt-guest-shutdown.target"},{"line_number":1087,"context_line":"                  content: |"},{"line_number":1088,"context_line":"                    [Unit]"},{"line_number":1089,"context_line":"                    Description\u003dLibvirt guests shutdown"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ad4bae84_642cb955","line":1086,"updated":"2021-01-13 17:19:03.000000000","message":"This is provided by libvirt-daemon, we shouldn\u0027t be overriding ownership of this. Can\u0027t we just ensure libvirt-daemon is installed?","commit_id":"93b5c3a20e113a38aa99ab8266681f4554b1ac97"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"21a4b06469751a17ad1e6ea88c1f7fff3a6ffaee","unresolved":true,"context_lines":[{"line_number":1083,"context_line":"                    WantedBy\u003dmulti-user.target"},{"line_number":1084,"context_line":"              - name: Making sure virt-guest-shutdown.target is present"},{"line_number":1085,"context_line":"                copy:"},{"line_number":1086,"context_line":"                  dest: /etc/systemd/system/virt-guest-shutdown.target"},{"line_number":1087,"context_line":"                  content: |"},{"line_number":1088,"context_line":"                    [Unit]"},{"line_number":1089,"context_line":"                    Description\u003dLibvirt guests shutdown"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ef8e24bb_daa10a00","line":1086,"in_reply_to":"ad4bae84_642cb955","updated":"2021-01-14 10:46:48.000000000","message":"We don\u0027t install/want install libvirt packages on the host as it is running inside the libvirt container. Therefore my suggestion to install the file not in /usr/lib/systemd, which is under control of the rpm and instead place it under /etc/systemd as this is the location where a user can overwrite/customize files provided by a RPM package in /usr/lib/systemd/ .","commit_id":"93b5c3a20e113a38aa99ab8266681f4554b1ac97"}]}