)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"9362b04988fc77275ea386bb548c3df88ec59903","unresolved":true,"context_lines":[{"line_number":12,"context_line":"  - neutron-ovn-sriov.yaml"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ia918d8b92d9bb1efac9bec2017b88593bf362834"},{"line_number":15,"context_line":"Resolves: rhbz#1913700"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"8836528d_fc748989","line":15,"range":{"start_line":15,"start_character":10,"end_line":15,"end_character":22},"updated":"2021-01-12 10:48:46.000000000","message":"Perhaps linking upstream LP Bug (can be reported here: https://bugs.launchpad.net/tripleo/+filebug) makes more sense for upstream patches.","commit_id":"831f5d65fa4a30b37bb92c36a7c97005dbbd77f6"}],"environments/services/neutron-ovn-dvr-ha.yaml":[{"author":{"_account_id":19118,"name":"Eran Kuris","email":"ekuris@redhat.com","username":"ekuris"},"change_message_id":"25dc2f638a00d25061aaddd9a614990e38baaadf","unresolved":true,"context_lines":[{"line_number":20,"context_line":"  OVNVifType: ovs"},{"line_number":21,"context_line":"  OVNNeutronSyncMode: log"},{"line_number":22,"context_line":"  OVNQosDriver: ovn-qos"},{"line_number":23,"context_line":"  NeutronTypeDrivers: \u0027geneve,vxlan,vlan,flat\u0027"},{"line_number":24,"context_line":"  NeutronNetworkType: [\u0027geneve\u0027 , \u0027vxlan\u0027, \u0027vlan\u0027, \u0027flat\u0027]"},{"line_number":25,"context_line":"  NeutronServicePlugins: \u0027qos,ovn-router,trunk,segments,port_forwarding\u0027"},{"line_number":26,"context_line":"  NeutronVniRanges: [\u00271:65536\u0027, ]"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"d3aafaf4_14453b07","line":23,"range":{"start_line":23,"start_character":30,"end_line":23,"end_character":36},"updated":"2021-01-07 17:14:30.000000000","message":"I know that its not related to this patch but why do we have here vxlan?","commit_id":"ca0a587f81aeaa5650cdd530b717267d4dedf871"},{"author":{"_account_id":19118,"name":"Eran Kuris","email":"ekuris@redhat.com","username":"ekuris"},"change_message_id":"76e88deaecf2f92ce8510829039ccaac7d5892fe","unresolved":false,"context_lines":[{"line_number":20,"context_line":"  OVNVifType: ovs"},{"line_number":21,"context_line":"  OVNNeutronSyncMode: log"},{"line_number":22,"context_line":"  OVNQosDriver: ovn-qos"},{"line_number":23,"context_line":"  NeutronTypeDrivers: \u0027geneve,vxlan,vlan,flat\u0027"},{"line_number":24,"context_line":"  NeutronNetworkType: [\u0027geneve\u0027 , \u0027vxlan\u0027, \u0027vlan\u0027, \u0027flat\u0027]"},{"line_number":25,"context_line":"  NeutronServicePlugins: \u0027qos,ovn-router,trunk,segments,port_forwarding\u0027"},{"line_number":26,"context_line":"  NeutronVniRanges: [\u00271:65536\u0027, ]"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5a14068c_428cc521","line":23,"range":{"start_line":23,"start_character":30,"end_line":23,"end_character":36},"in_reply_to":"d3aafaf4_14453b07","updated":"2021-01-07 17:31:33.000000000","message":"Done","commit_id":"ca0a587f81aeaa5650cdd530b717267d4dedf871"},{"author":{"_account_id":19118,"name":"Eran Kuris","email":"ekuris@redhat.com","username":"ekuris"},"change_message_id":"25dc2f638a00d25061aaddd9a614990e38baaadf","unresolved":true,"context_lines":[{"line_number":21,"context_line":"  OVNNeutronSyncMode: log"},{"line_number":22,"context_line":"  OVNQosDriver: ovn-qos"},{"line_number":23,"context_line":"  NeutronTypeDrivers: \u0027geneve,vxlan,vlan,flat\u0027"},{"line_number":24,"context_line":"  NeutronNetworkType: [\u0027geneve\u0027 , \u0027vxlan\u0027, \u0027vlan\u0027, \u0027flat\u0027]"},{"line_number":25,"context_line":"  NeutronServicePlugins: \u0027qos,ovn-router,trunk,segments,port_forwarding\u0027"},{"line_number":26,"context_line":"  NeutronVniRanges: [\u00271:65536\u0027, ]"},{"line_number":27,"context_line":"  NeutronRpcWorkers: 1"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"60f25168_6a1f3fd3","line":24,"range":{"start_line":24,"start_character":35,"end_line":24,"end_character":41},"updated":"2021-01-07 17:14:30.000000000","message":"I know that its not related to this patch but why do we have here vxlan?","commit_id":"ca0a587f81aeaa5650cdd530b717267d4dedf871"},{"author":{"_account_id":19118,"name":"Eran Kuris","email":"ekuris@redhat.com","username":"ekuris"},"change_message_id":"76e88deaecf2f92ce8510829039ccaac7d5892fe","unresolved":false,"context_lines":[{"line_number":21,"context_line":"  OVNNeutronSyncMode: log"},{"line_number":22,"context_line":"  OVNQosDriver: ovn-qos"},{"line_number":23,"context_line":"  NeutronTypeDrivers: \u0027geneve,vxlan,vlan,flat\u0027"},{"line_number":24,"context_line":"  NeutronNetworkType: [\u0027geneve\u0027 , \u0027vxlan\u0027, \u0027vlan\u0027, \u0027flat\u0027]"},{"line_number":25,"context_line":"  NeutronServicePlugins: \u0027qos,ovn-router,trunk,segments,port_forwarding\u0027"},{"line_number":26,"context_line":"  NeutronVniRanges: [\u00271:65536\u0027, ]"},{"line_number":27,"context_line":"  NeutronRpcWorkers: 1"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"b7530b52_9625af02","line":24,"range":{"start_line":24,"start_character":35,"end_line":24,"end_character":41},"in_reply_to":"60f25168_6a1f3fd3","updated":"2021-01-07 17:31:33.000000000","message":"Done","commit_id":"ca0a587f81aeaa5650cdd530b717267d4dedf871"}],"environments/services/neutron-ovn-ha.yaml":[{"author":{"_account_id":19118,"name":"Eran Kuris","email":"ekuris@redhat.com","username":"ekuris"},"change_message_id":"25dc2f638a00d25061aaddd9a614990e38baaadf","unresolved":true,"context_lines":[{"line_number":19,"context_line":"  OVNNeutronSyncMode: log"},{"line_number":20,"context_line":"  OVNQosDriver: ovn-qos"},{"line_number":21,"context_line":"  NeutronEnableDVR: False"},{"line_number":22,"context_line":"  NeutronTypeDrivers: \u0027geneve,vxlan,vlan,flat\u0027"},{"line_number":23,"context_line":"  NeutronNetworkType: [\u0027geneve\u0027 , \u0027vxlan\u0027, \u0027vlan\u0027, \u0027flat\u0027]"},{"line_number":24,"context_line":"  NeutronServicePlugins: \u0027qos,ovn-router,trunk,segments,port_forwarding\u0027"},{"line_number":25,"context_line":"  NeutronVniRanges: [\u00271:65536\u0027, ]"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7b5d4ac9_2c3fdeec","line":22,"range":{"start_line":22,"start_character":30,"end_line":22,"end_character":35},"updated":"2021-01-07 17:14:30.000000000","message":"I know that its not related to this patch but why do we have here vxlan?","commit_id":"ca0a587f81aeaa5650cdd530b717267d4dedf871"},{"author":{"_account_id":19118,"name":"Eran Kuris","email":"ekuris@redhat.com","username":"ekuris"},"change_message_id":"76e88deaecf2f92ce8510829039ccaac7d5892fe","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  OVNNeutronSyncMode: log"},{"line_number":20,"context_line":"  OVNQosDriver: ovn-qos"},{"line_number":21,"context_line":"  NeutronEnableDVR: False"},{"line_number":22,"context_line":"  NeutronTypeDrivers: \u0027geneve,vxlan,vlan,flat\u0027"},{"line_number":23,"context_line":"  NeutronNetworkType: [\u0027geneve\u0027 , \u0027vxlan\u0027, \u0027vlan\u0027, \u0027flat\u0027]"},{"line_number":24,"context_line":"  NeutronServicePlugins: \u0027qos,ovn-router,trunk,segments,port_forwarding\u0027"},{"line_number":25,"context_line":"  NeutronVniRanges: [\u00271:65536\u0027, ]"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1f7d22e2_f941c213","line":22,"range":{"start_line":22,"start_character":30,"end_line":22,"end_character":35},"in_reply_to":"7b5d4ac9_2c3fdeec","updated":"2021-01-07 17:31:33.000000000","message":"Done","commit_id":"ca0a587f81aeaa5650cdd530b717267d4dedf871"},{"author":{"_account_id":19118,"name":"Eran Kuris","email":"ekuris@redhat.com","username":"ekuris"},"change_message_id":"25dc2f638a00d25061aaddd9a614990e38baaadf","unresolved":true,"context_lines":[{"line_number":20,"context_line":"  OVNQosDriver: ovn-qos"},{"line_number":21,"context_line":"  NeutronEnableDVR: False"},{"line_number":22,"context_line":"  NeutronTypeDrivers: \u0027geneve,vxlan,vlan,flat\u0027"},{"line_number":23,"context_line":"  NeutronNetworkType: [\u0027geneve\u0027 , \u0027vxlan\u0027, \u0027vlan\u0027, \u0027flat\u0027]"},{"line_number":24,"context_line":"  NeutronServicePlugins: \u0027qos,ovn-router,trunk,segments,port_forwarding\u0027"},{"line_number":25,"context_line":"  NeutronVniRanges: [\u00271:65536\u0027, ]"},{"line_number":26,"context_line":"  NeutronPluginExtensions: \"qos,port_security,dns\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"58fa2d5e_3b710e61","line":23,"range":{"start_line":23,"start_character":35,"end_line":23,"end_character":40},"updated":"2021-01-07 17:14:30.000000000","message":"I know that its not related to this patch but why do we have here vxlan?","commit_id":"ca0a587f81aeaa5650cdd530b717267d4dedf871"},{"author":{"_account_id":19118,"name":"Eran Kuris","email":"ekuris@redhat.com","username":"ekuris"},"change_message_id":"76e88deaecf2f92ce8510829039ccaac7d5892fe","unresolved":false,"context_lines":[{"line_number":20,"context_line":"  OVNQosDriver: ovn-qos"},{"line_number":21,"context_line":"  NeutronEnableDVR: False"},{"line_number":22,"context_line":"  NeutronTypeDrivers: \u0027geneve,vxlan,vlan,flat\u0027"},{"line_number":23,"context_line":"  NeutronNetworkType: [\u0027geneve\u0027 , \u0027vxlan\u0027, \u0027vlan\u0027, \u0027flat\u0027]"},{"line_number":24,"context_line":"  NeutronServicePlugins: \u0027qos,ovn-router,trunk,segments,port_forwarding\u0027"},{"line_number":25,"context_line":"  NeutronVniRanges: [\u00271:65536\u0027, ]"},{"line_number":26,"context_line":"  NeutronPluginExtensions: \"qos,port_security,dns\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"d1669cea_9936b925","line":23,"range":{"start_line":23,"start_character":35,"end_line":23,"end_character":40},"in_reply_to":"58fa2d5e_3b710e61","updated":"2021-01-07 17:31:33.000000000","message":"Done","commit_id":"ca0a587f81aeaa5650cdd530b717267d4dedf871"}],"environments/services/neutron-ovn-sriov.yaml":[{"author":{"_account_id":31291,"name":"Eduardo Olivares","email":"eolivare@redhat.com","username":"eolivare"},"change_message_id":"4fed2872425a53457c6671121fb7b28d9eb03e46","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# EXPERIMENTAL: The configuration enabled by this environment is not considered"},{"line_number":2,"context_line":"# production-ready."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# A Heat environment that can be used to enable SR-IOV support in neutron with OVN"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"d86b6acf_8e1573e4","line":1,"updated":"2021-01-07 13:54:07.000000000","message":"maybe we can remove all this \"EXPERIMENTAL\" comment by adding these lines here: https://github.com/openstack/tripleo-heat-templates/blob/master/environments/services/neutron-ovn-ha.yaml#L3-L13\n\nThis way, neutron-ovn-sriov.yaml could be used alone (without needing neutron-ovn-ha.yaml)\n\nWhat do you think?","commit_id":"7d9bb483f38e4954ab0348a5bf4cbb2792ef32c1"},{"author":{"_account_id":19118,"name":"Eran Kuris","email":"ekuris@redhat.com","username":"ekuris"},"change_message_id":"990c7e68b547d72e14b8a606c991665f343dc9f4","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# EXPERIMENTAL: The configuration enabled by this environment is not considered"},{"line_number":2,"context_line":"# production-ready."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# A Heat environment that can be used to enable SR-IOV support in neutron with OVN"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"4c4c2579_d4603379","line":1,"in_reply_to":"153eb67b_17d854ca","updated":"2021-01-07 14:34:07.000000000","message":"we dont support non-HA  deployment with ml2/ovn","commit_id":"7d9bb483f38e4954ab0348a5bf4cbb2792ef32c1"},{"author":{"_account_id":29350,"name":"Roman Safronov","email":"rsafrono@redhat.com","username":"rsafrono"},"change_message_id":"7ad86846c241f4e8880ca975ec596fdd17bd2edf","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# EXPERIMENTAL: The configuration enabled by this environment is not considered"},{"line_number":2,"context_line":"# production-ready."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# A Heat environment that can be used to enable SR-IOV support in neutron with OVN"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ab0c53be_d8f95e4e","line":1,"in_reply_to":"4c4c2579_d4603379","updated":"2021-01-07 15:14:58.000000000","message":"In Red Hat OSP yes, but I am not sure regarding upstream openstack/tripleo which we are trying to modify here.","commit_id":"7d9bb483f38e4954ab0348a5bf4cbb2792ef32c1"},{"author":{"_account_id":31291,"name":"Eduardo Olivares","email":"eolivare@redhat.com","username":"eolivare"},"change_message_id":"52e988892c64a5c320c3d7ec465331076fe3a13f","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# EXPERIMENTAL: The configuration enabled by this environment is not considered"},{"line_number":2,"context_line":"# production-ready."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# A Heat environment that can be used to enable SR-IOV support in neutron with OVN"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3709d0b3_52e72560","line":1,"in_reply_to":"ab0c53be_d8f95e4e","updated":"2021-01-07 15:23:53.000000000","message":"Roman\u0027s proposal makes sense to me. Please see patch set 2","commit_id":"7d9bb483f38e4954ab0348a5bf4cbb2792ef32c1"},{"author":{"_account_id":29350,"name":"Roman Safronov","email":"rsafrono@redhat.com","username":"rsafrono"},"change_message_id":"3d6df38c1ee2073803ade77920a79aa0b41818a5","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# EXPERIMENTAL: The configuration enabled by this environment is not considered"},{"line_number":2,"context_line":"# production-ready."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# A Heat environment that can be used to enable SR-IOV support in neutron with OVN"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"153eb67b_17d854ca","line":1,"in_reply_to":"d86b6acf_8e1573e4","updated":"2021-01-07 14:31:22.000000000","message":"What if someone need sriov without ha stuff?","commit_id":"7d9bb483f38e4954ab0348a5bf4cbb2792ef32c1"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"60ed89636f08caee513b3460744cd0119ad2a079","unresolved":true,"context_lines":[{"line_number":14,"context_line":"  NovaSchedulerEnabledFilters: [\u0027AvailabilityZoneFilter\u0027,\u0027ComputeFilter\u0027,\u0027ComputeCapabilitiesFilter\u0027,\u0027ImagePropertiesFilter\u0027,\u0027ServerGroupAntiAffinityFilter\u0027,\u0027ServerGroupAffinityFilter\u0027,\u0027PciPassthroughFilter\u0027]"},{"line_number":15,"context_line":"  NovaSchedulerAvailableFilters: [\"nova.scheduler.filters.all_filters\",\"nova.scheduler.filters.pci_passthrough_filter.PciPassthroughFilter\"]"},{"line_number":16,"context_line":"  ControllerSriovParameters:"},{"line_number":17,"context_line":"    OVNCMSOptions: \"enable-chassis-as-gw\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"05c1a5c0_ae7a6830","line":17,"updated":"2021-01-07 13:46:41.000000000","message":"This option should only be set on gateway nodes (controllers / networkers) and not to all nodes (e.g computes). Adding it here will not break this rule, right ?","commit_id":"7d9bb483f38e4954ab0348a5bf4cbb2792ef32c1"},{"author":{"_account_id":31291,"name":"Eduardo Olivares","email":"eolivare@redhat.com","username":"eolivare"},"change_message_id":"4fed2872425a53457c6671121fb7b28d9eb03e46","unresolved":true,"context_lines":[{"line_number":14,"context_line":"  NovaSchedulerEnabledFilters: [\u0027AvailabilityZoneFilter\u0027,\u0027ComputeFilter\u0027,\u0027ComputeCapabilitiesFilter\u0027,\u0027ImagePropertiesFilter\u0027,\u0027ServerGroupAntiAffinityFilter\u0027,\u0027ServerGroupAffinityFilter\u0027,\u0027PciPassthroughFilter\u0027]"},{"line_number":15,"context_line":"  NovaSchedulerAvailableFilters: [\"nova.scheduler.filters.all_filters\",\"nova.scheduler.filters.pci_passthrough_filter.PciPassthroughFilter\"]"},{"line_number":16,"context_line":"  ControllerSriovParameters:"},{"line_number":17,"context_line":"    OVNCMSOptions: \"enable-chassis-as-gw\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"00a2c980_efa582bd","line":17,"in_reply_to":"05c1a5c0_ae7a6830","updated":"2021-01-07 13:54:07.000000000","message":"the way it is, it\u0027ll only be applied to controllers: I\u0027m gonna apply it to networkers as well with next patch set","commit_id":"7d9bb483f38e4954ab0348a5bf4cbb2792ef32c1"},{"author":{"_account_id":19118,"name":"Eran Kuris","email":"ekuris@redhat.com","username":"ekuris"},"change_message_id":"25dc2f638a00d25061aaddd9a614990e38baaadf","unresolved":true,"context_lines":[{"line_number":4,"context_line":"# A Heat environment that can be used to enable SR-IOV support in neutron with OVN"},{"line_number":5,"context_line":"# mechanism driver."},{"line_number":6,"context_line":"# This environment file should be included after the main OVN environment"},{"line_number":7,"context_line":"# file - neutron-ovn-ha.yaml/neutron-ovn-dvr(-ha).yaml is included."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"resource_registry:"},{"line_number":10,"context_line":"  OS::TripleO::Services::NeutronSriovAgent: ../../deployment/neutron/neutron-sriov-agent-container-puppet.yaml"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9f454332_3e14c04d","line":7,"range":{"start_line":7,"start_character":29,"end_line":7,"end_character":44},"updated":"2021-01-07 17:14:30.000000000","message":"do we support sriov with DVR enabled? as I remember we dont","commit_id":"ca0a587f81aeaa5650cdd530b717267d4dedf871"},{"author":{"_account_id":31291,"name":"Eduardo Olivares","email":"eolivare@redhat.com","username":"eolivare"},"change_message_id":"506666be05fb213e10f81b082d2c5c865f22f98d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"# A Heat environment that can be used to enable SR-IOV support in neutron with OVN"},{"line_number":5,"context_line":"# mechanism driver."},{"line_number":6,"context_line":"# This environment file should be included after the main OVN environment"},{"line_number":7,"context_line":"# file - neutron-ovn-ha.yaml/neutron-ovn-dvr(-ha).yaml is included."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"resource_registry:"},{"line_number":10,"context_line":"  OS::TripleO::Services::NeutronSriovAgent: ../../deployment/neutron/neutron-sriov-agent-container-puppet.yaml"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"e363557d_fdda926d","line":7,"range":{"start_line":7,"start_character":29,"end_line":7,"end_character":44},"in_reply_to":"9f454332_3e14c04d","updated":"2021-01-12 10:43:15.000000000","message":"Done","commit_id":"ca0a587f81aeaa5650cdd530b717267d4dedf871"}]}