)]}'
{"deployment/memcached/memcached-container-puppet.yaml":[{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"6f53dc6aeb565cbd46fe2bd8aa18796f952f98a4","unresolved":true,"context_lines":[{"line_number":108,"context_line":"                      - {get_param: [ServiceNetMap, MemcachedNetwork]}"},{"line_number":109,"context_line":"                template:"},{"line_number":110,"context_line":"                  \u0027121 memcached \u003c%net_cidr%\u003e\u0027:"},{"line_number":111,"context_line":"                    dport: 11211"},{"line_number":112,"context_line":"                    proto: \u0027tcp\u0027"},{"line_number":113,"context_line":"                    source: \u003c%net_cidr%\u003e"},{"line_number":114,"context_line":"          - \u0027121 memcached\u0027:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"dac5be4f_df358bd1","line":111,"updated":"2021-01-13 15:55:49.000000000","message":"In case of TLS we will additionally need to open the tls port","commit_id":"de48b0f1b9d6edd36c0c3e55a8686e47488db5f4"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"6f53dc6aeb565cbd46fe2bd8aa18796f952f98a4","unresolved":true,"context_lines":[{"line_number":112,"context_line":"                    proto: \u0027tcp\u0027"},{"line_number":113,"context_line":"                    source: \u003c%net_cidr%\u003e"},{"line_number":114,"context_line":"          - \u0027121 memcached\u0027:"},{"line_number":115,"context_line":"              dport: 11211"},{"line_number":116,"context_line":"              proto: \u0027tcp\u0027"},{"line_number":117,"context_line":"              source: {get_param: MemcachedIpSubnet}"},{"line_number":118,"context_line":"      monitoring_subscription: {get_param: MonitoringSubscriptionMemcached}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"76b46676_3bea007a","line":115,"updated":"2021-01-13 15:55:49.000000000","message":"see above","commit_id":"de48b0f1b9d6edd36c0c3e55a8686e47488db5f4"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"6f53dc6aeb565cbd46fe2bd8aa18796f952f98a4","unresolved":true,"context_lines":[{"line_number":165,"context_line":"            memcached::notls_listener_port:"},{"line_number":166,"context_line":"              - if:"},{"line_number":167,"context_line":"                - internal_tls_enabled"},{"line_number":168,"context_line":"                11211"},{"line_number":169,"context_line":"          -"},{"line_number":170,"context_line":"            if:"},{"line_number":171,"context_line":"            - internal_tls_enabled"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"b0e48ba7_78d15a35","line":168,"updated":"2021-01-13 15:55:49.000000000","message":"You are missing an else clause.\n\nI would also define the port in parameters to this template, ex. MemcachedPort and MemcachedTLSPort and get it here via {get_param: MemcachedPort}\n\nWe then need to set those as memcached_authtoken_port and memcached_port to be consumed by puppet-tripleo.","commit_id":"de48b0f1b9d6edd36c0c3e55a8686e47488db5f4"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"b73206d2d4d95a48d0bc4fde775d4e0a8f856e37","unresolved":true,"context_lines":[{"line_number":171,"context_line":"            - internal_tls_enabled"},{"line_number":172,"context_line":"            - generate_service_certificates: true"},{"line_number":173,"context_line":"              tripleo::memcached::service_certificate: \u0027/etc/pki/tls/certs/memcached.crt\u0027"},{"line_number":174,"context_line":"              tripleo::profile::base::memcached::certificate_specs:"},{"line_number":175,"context_line":"                service_certificate: \u0027/etc/pki/tls/certs/memcached.crt\u0027"},{"line_number":176,"context_line":"                service_key: \u0027/etc/pki/tls/private/memcached.key\u0027"},{"line_number":177,"context_line":"                hostname:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"b263ac73_c110827a","line":174,"updated":"2021-01-13 16:07:34.000000000","message":"I just noticed, you can put the above under this if clause. We then need a depends-on against a puppet-tripleo patch, similar to the one you made for certificate_specs [1], so that it is forwarded to the memcached class.\n\n[1] https://review.opendev.org/c/openstack/puppet-tripleo/+/745532/13/manifests/profile/base/memcached.pp#61","commit_id":"de48b0f1b9d6edd36c0c3e55a8686e47488db5f4"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"6f53dc6aeb565cbd46fe2bd8aa18796f952f98a4","unresolved":true,"context_lines":[{"line_number":193,"context_line":"            collectd::plugin::memcached::instances:"},{"line_number":194,"context_line":"              local:"},{"line_number":195,"context_line":"                host: \"%{hiera(\u0027memcached::listen_ip_uri\u0027)}\""},{"line_number":196,"context_line":"                port: 11211"},{"line_number":197,"context_line":"      # BEGIN DOCKER SETTINGS"},{"line_number":198,"context_line":"      puppet_config:"},{"line_number":199,"context_line":"        config_volume: \u0027memcached\u0027"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1780d484_c0198712","line":196,"updated":"2021-01-13 15:55:49.000000000","message":"I checked that collectd doesn\u0027t support tls, so this has to be set as the non-tls port ({get_param: MemcachedPort}).","commit_id":"de48b0f1b9d6edd36c0c3e55a8686e47488db5f4"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"a079601a9ab2ab889ae3d8de3e319627f69e4dc4","unresolved":true,"context_lines":[{"line_number":68,"context_line":"    type: string"},{"line_number":69,"context_line":"  MemcachedPort:"},{"line_number":70,"context_line":"    default: 11211"},{"line_number":71,"context_line":"    description: Port to have Memcached listening at."},{"line_number":72,"context_line":"    type: number"},{"line_number":73,"context_line":"  MemcachedTLS:"},{"line_number":74,"context_line":"    default: false"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9a2e08a3_77d15b02","line":71,"updated":"2021-01-14 11:06:11.000000000","message":"We should add a note here:\n\nWhen using MemcachedTLS, this has to be set to a different port then the default - see below.","commit_id":"b5a5c9c1340f217447b6df2d45d8b4b6f008e4bc"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"a079601a9ab2ab889ae3d8de3e319627f69e4dc4","unresolved":true,"context_lines":[{"line_number":72,"context_line":"    type: number"},{"line_number":73,"context_line":"  MemcachedTLS:"},{"line_number":74,"context_line":"    default: false"},{"line_number":75,"context_line":"    description: Set to True to enable TLS on Memcached service."},{"line_number":76,"context_line":"    type: boolean"},{"line_number":77,"context_line":"  CertificateKeySize:"},{"line_number":78,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"439e3326_739bfdb8","line":75,"updated":"2021-01-14 11:06:11.000000000","message":"+ add a note:\n\nBecause not all services support Memcached TLS, during the migration period, Memcached will listen on 2 ports - on the port set with MemcachedPort parameter (above) and on 11211, without TLS.","commit_id":"b5a5c9c1340f217447b6df2d45d8b4b6f008e4bc"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"741dc3c1789c7d18c55a0963fbcbe4189ac82285","unresolved":true,"context_lines":[{"line_number":219,"context_line":"            if:"},{"line_number":220,"context_line":"            - enable_non_tls_port"},{"line_number":221,"context_line":"            - memcached::notls_listener_port: 11211"},{"line_number":222,"context_line":"              memcached::notls_listener_addr:"},{"line_number":223,"context_line":"                str_replace:"},{"line_number":224,"context_line":"                  template:"},{"line_number":225,"context_line":"                    \"%{hiera(\u0027$NETWORK_uri\u0027)}\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"a54ba4c6_bbddd286","line":222,"range":{"start_line":222,"start_character":13,"end_line":222,"end_character":1},"updated":"2021-02-04 19:14:46.000000000","message":"This seems to work, but the original code listens on 2 addresses, the localhost and NETWORK_uri.","commit_id":"c85ec4306b718429a11607ced39f145425668c95"}]}