)]}'
{"deployment/tripleo-packages/tripleo-packages-baremetal-puppet.yaml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"935262c7c5b30bb234bc6b670f30c88f0e7389c9","unresolved":true,"context_lines":[{"line_number":213,"context_line":"            - name: reboot to perform the upgrade"},{"line_number":214,"context_line":"              reboot:"},{"line_number":215,"context_line":"                reboot_timeout: \"{{upgrade_leapp_reboot_timeout}}\""},{"line_number":216,"context_line":"                post_reboot_delay: 60"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"        - name: Package and repo update tasks"},{"line_number":219,"context_line":"          when: step|int \u003d\u003d 0"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"297f139c_fbb6c645","line":216,"range":{"start_line":216,"start_character":35,"end_line":216,"end_character":37},"updated":"2021-01-26 14:33:40.000000000","message":"Maybe this should be a configurable value instead?","commit_id":"09b8444b94c029f556383f5047674f16b32cc90f"},{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"267a4f7d1f300c91f179451fa691f6002df0cda3","unresolved":true,"context_lines":[{"line_number":213,"context_line":"            - name: reboot to perform the upgrade"},{"line_number":214,"context_line":"              reboot:"},{"line_number":215,"context_line":"                reboot_timeout: \"{{upgrade_leapp_reboot_timeout}}\""},{"line_number":216,"context_line":"                post_reboot_delay: 60"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"        - name: Package and repo update tasks"},{"line_number":219,"context_line":"          when: step|int \u003d\u003d 0"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bd2a1956_920b36fb","line":216,"range":{"start_line":216,"start_character":35,"end_line":216,"end_character":37},"in_reply_to":"297f139c_fbb6c645","updated":"2021-01-26 17:29:52.000000000","message":"I don\u0027t think so. We have UpgradeLeappRebootTimeout which is responsible for whole reboot. This one is only responsible for delay between connection establishment and reboot validation \nhttps://github.com/ansible/ansible/blob/v2.9.17/lib/ansible/plugins/action/reboot.py#L415-L418\nto settle systemd transient events.","commit_id":"09b8444b94c029f556383f5047674f16b32cc90f"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"0526efcff80c196c158828e17e207316b4973b61","unresolved":true,"context_lines":[{"line_number":213,"context_line":"            - name: reboot to perform the upgrade"},{"line_number":214,"context_line":"              reboot:"},{"line_number":215,"context_line":"                reboot_timeout: \"{{upgrade_leapp_reboot_timeout}}\""},{"line_number":216,"context_line":"                post_reboot_delay: 60"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"        - name: Package and repo update tasks"},{"line_number":219,"context_line":"          when: step|int \u003d\u003d 0"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"c1a17f0f_5b272dbc","line":216,"range":{"start_line":216,"start_character":35,"end_line":216,"end_character":37},"in_reply_to":"57aeb987_ad1ed21d","updated":"2021-01-27 17:09:56.000000000","message":"For some cases it may have to be longer than 60s. IIRC, LACP bonds can take more time to establish connections... was it like 5 min or so?","commit_id":"09b8444b94c029f556383f5047674f16b32cc90f"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"d0983b6952bf6cf52319fd7790b2240b5052c02f","unresolved":true,"context_lines":[{"line_number":213,"context_line":"            - name: reboot to perform the upgrade"},{"line_number":214,"context_line":"              reboot:"},{"line_number":215,"context_line":"                reboot_timeout: \"{{upgrade_leapp_reboot_timeout}}\""},{"line_number":216,"context_line":"                post_reboot_delay: 60"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"        - name: Package and repo update tasks"},{"line_number":219,"context_line":"          when: step|int \u003d\u003d 0"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"57aeb987_ad1ed21d","line":216,"range":{"start_line":216,"start_character":35,"end_line":216,"end_character":37},"in_reply_to":"bd2a1956_920b36fb","updated":"2021-01-27 10:40:05.000000000","message":"Perhaps this would be suitable instead?\n\n      test_command: \u003e-\n          systemctl is-system-running | grep -e running -e degraded\n\nWe\u0027ve used it in https://github.com/redhat-openstack/infrared/blob/aa10309b94de66de7349c42f6047a965ba4310ac/plugins/tripleo-undercloud/tasks/upgrade/upgrade.yml#L89-L99 for some time and it has been quite effective at waiting until systemd has settled everything, whereas the default is just a ping which is not good enough.","commit_id":"09b8444b94c029f556383f5047674f16b32cc90f"},{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"b3c80f0db0052b2895b3dd7dbc95c5e2d8d8e642","unresolved":true,"context_lines":[{"line_number":213,"context_line":"            - name: reboot to perform the upgrade"},{"line_number":214,"context_line":"              reboot:"},{"line_number":215,"context_line":"                reboot_timeout: \"{{upgrade_leapp_reboot_timeout}}\""},{"line_number":216,"context_line":"                post_reboot_delay: 60"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"        - name: Package and repo update tasks"},{"line_number":219,"context_line":"          when: step|int \u003d\u003d 0"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"088b0f78_ee81f30a","line":216,"range":{"start_line":216,"start_character":35,"end_line":216,"end_character":37},"in_reply_to":"c1a17f0f_5b272dbc","updated":"2021-02-03 12:03:22.000000000","message":"if we look at 802.3ad standard the default timeout after PDU is sent is 30 seconds. In theory, 1 minute should be enough. However, I set 2 minutes. If the customers have very exotic hardware they can change value in tht or submit a bug so we\u0027ll introduce variable as I don\u0027t want to introduce yet another variable that won\u0027t be used by anyone.","commit_id":"09b8444b94c029f556383f5047674f16b32cc90f"}]}