)]}'
{"deployment/ironic/ironic-inspector-container-puppet.yaml":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"41e8fc1d60d3ff4c522bdf2f8ee7ad0921eb6c27","unresolved":true,"context_lines":[{"line_number":151,"context_line":"  IronicInspectorUseSwift:"},{"line_number":152,"context_line":"    default: true"},{"line_number":153,"context_line":"    description: |"},{"line_number":154,"context_line":"      DEPRECATED: Use IronicInspectorStorageBackend instead."},{"line_number":155,"context_line":"      Whether to use Swift for storing introspection data."},{"line_number":156,"context_line":"    type: boolean"},{"line_number":157,"context_line":"  IronicInspectorStorageBackend:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"13f6ecfc_b6a94798","line":154,"updated":"2021-01-29 11:48:48.000000000","message":"could you please also make this deprecated as Heat allows to specify that for params?","commit_id":"26b6e9a8f20a73075c1c9ea131ae7c72a5866517"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"1dd5ed1a68361978c9e0ec99a29736f6dcd4f728","unresolved":true,"context_lines":[{"line_number":151,"context_line":"  IronicInspectorUseSwift:"},{"line_number":152,"context_line":"    default: true"},{"line_number":153,"context_line":"    description: |"},{"line_number":154,"context_line":"      DEPRECATED: Use IronicInspectorStorageBackend instead."},{"line_number":155,"context_line":"      Whether to use Swift for storing introspection data."},{"line_number":156,"context_line":"    type: boolean"},{"line_number":157,"context_line":"  IronicInspectorStorageBackend:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"e6be81fd_19d66761","line":154,"in_reply_to":"13f6ecfc_b6a94798","updated":"2021-02-01 05:15:49.000000000","message":"AFAIK heat does not have anything, tht uses \u0027parameter_group\u0027 with label \u0027deprecated\u0027 to identify these deprecated parameters. Though it does not seem to be strictly adhered for all deprecated params, if we want I can add for this.","commit_id":"26b6e9a8f20a73075c1c9ea131ae7c72a5866517"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"b0926587787e4013e449ec9de4103f9c8168edda","unresolved":true,"context_lines":[{"line_number":154,"context_line":"      DEPRECATED: Use IronicInspectorStorageBackend instead."},{"line_number":155,"context_line":"      Whether to use Swift for storing introspection data."},{"line_number":156,"context_line":"    type: boolean"},{"line_number":157,"context_line":"  IronicInspectorStorageBackend:"},{"line_number":158,"context_line":"    default: \u0027none\u0027"},{"line_number":159,"context_line":"    description: Storage backend for storing introspection data."},{"line_number":160,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"a1a6216f_fa18c3f6","line":157,"range":{"start_line":157,"start_character":2,"end_line":157,"end_character":31},"updated":"2021-02-03 07:40:29.000000000","message":"do we want to add an allowed_values here? \n\n\u0027database\u0027, what else can it be?\n\nhttps://docs.openstack.org/heat/rocky/template_guide/hot_guide.html#restricting-user-input\n\n(link for the benefit of anyone else reading here not your ramishra ;) )","commit_id":"983928d32ae7904a90acb9f99e1bb97a53f290f7"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"e2dd59e0daad5045aacec55c12564817f9646b0a","unresolved":true,"context_lines":[{"line_number":154,"context_line":"      DEPRECATED: Use IronicInspectorStorageBackend instead."},{"line_number":155,"context_line":"      Whether to use Swift for storing introspection data."},{"line_number":156,"context_line":"    type: boolean"},{"line_number":157,"context_line":"  IronicInspectorStorageBackend:"},{"line_number":158,"context_line":"    default: \u0027none\u0027"},{"line_number":159,"context_line":"    description: Storage backend for storing introspection data."},{"line_number":160,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9adb2aea_db41ef1a","line":157,"range":{"start_line":157,"start_character":2,"end_line":157,"end_character":31},"in_reply_to":"608d90ab_8bd2c623","updated":"2021-02-04 09:17:45.000000000","message":"i don\u0027t think the overhead of making this change once every long time is a huge problem compared to the benefit of getting some early validation on that parameter before anything has been done for the service?\nespecially if we want to catch those places where someone might still be passing in the value of \u0027swift\u0027 ??","commit_id":"983928d32ae7904a90acb9f99e1bb97a53f290f7"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"4bc4f3fb9750da50952e00e6a4c481643638d044","unresolved":true,"context_lines":[{"line_number":154,"context_line":"      DEPRECATED: Use IronicInspectorStorageBackend instead."},{"line_number":155,"context_line":"      Whether to use Swift for storing introspection data."},{"line_number":156,"context_line":"    type: boolean"},{"line_number":157,"context_line":"  IronicInspectorStorageBackend:"},{"line_number":158,"context_line":"    default: \u0027none\u0027"},{"line_number":159,"context_line":"    description: Storage backend for storing introspection data."},{"line_number":160,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"c467dfae_c8dd8979","line":157,"range":{"start_line":157,"start_character":2,"end_line":157,"end_character":31},"in_reply_to":"630058df_f719b373","updated":"2021-02-04 09:44:10.000000000","message":"but don\u0027t you see how it\u0027s feasible that someone could be passing in \u0027swift\u0027 here from old deployment templates for example?\nwell i agree it is an overhead for heat to validate that parameter but it is also an overhead if it fails later in the deployment and we have to chase to find out why","commit_id":"983928d32ae7904a90acb9f99e1bb97a53f290f7"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"7f851a4a3a09d30301d01612730697c1dbea535c","unresolved":true,"context_lines":[{"line_number":154,"context_line":"      DEPRECATED: Use IronicInspectorStorageBackend instead."},{"line_number":155,"context_line":"      Whether to use Swift for storing introspection data."},{"line_number":156,"context_line":"    type: boolean"},{"line_number":157,"context_line":"  IronicInspectorStorageBackend:"},{"line_number":158,"context_line":"    default: \u0027none\u0027"},{"line_number":159,"context_line":"    description: Storage backend for storing introspection data."},{"line_number":160,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"630058df_f719b373","line":157,"range":{"start_line":157,"start_character":2,"end_line":157,"end_character":31},"in_reply_to":"9adb2aea_db41ef1a","updated":"2021-02-04 09:23:00.000000000","message":"I mean validations are always an overhead. But if you insist I can add it in a followup as changing this would require rebasing number of patches in the series.","commit_id":"983928d32ae7904a90acb9f99e1bb97a53f290f7"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"dabe856a91b16adb5652c05d4cccb03f2d0aa360","unresolved":true,"context_lines":[{"line_number":154,"context_line":"      DEPRECATED: Use IronicInspectorStorageBackend instead."},{"line_number":155,"context_line":"      Whether to use Swift for storing introspection data."},{"line_number":156,"context_line":"    type: boolean"},{"line_number":157,"context_line":"  IronicInspectorStorageBackend:"},{"line_number":158,"context_line":"    default: \u0027none\u0027"},{"line_number":159,"context_line":"    description: Storage backend for storing introspection data."},{"line_number":160,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ce6775b2_9ef0e2e9","line":157,"range":{"start_line":157,"start_character":2,"end_line":157,"end_character":31},"in_reply_to":"a1a6216f_fa18c3f6","updated":"2021-02-03 08:21:54.000000000","message":"We probably can which is an additional validation, but we don\u0027t do it consistently across the template for things like this. ex. IronicInspectorDiscoveryDefaultDriver param.","commit_id":"983928d32ae7904a90acb9f99e1bb97a53f290f7"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"60b7a1a20d1cd7b560df723719493ef532b71e0f","unresolved":true,"context_lines":[{"line_number":154,"context_line":"      DEPRECATED: Use IronicInspectorStorageBackend instead."},{"line_number":155,"context_line":"      Whether to use Swift for storing introspection data."},{"line_number":156,"context_line":"    type: boolean"},{"line_number":157,"context_line":"  IronicInspectorStorageBackend:"},{"line_number":158,"context_line":"    default: \u0027none\u0027"},{"line_number":159,"context_line":"    description: Storage backend for storing introspection data."},{"line_number":160,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"608d90ab_8bd2c623","line":157,"range":{"start_line":157,"start_character":2,"end_line":157,"end_character":31},"in_reply_to":"ce6775b2_9ef0e2e9","updated":"2021-02-04 02:12:43.000000000","message":"The reason we probably should not add hard-coded parameter constraints is because when services add more options, we\u0027ve to go though this kind of change. The earlier parameter assumed that it would only be \u0027swift\u0027 or \u0027none\u0027, now that \u0027database\u0027 is an option we\u0027ve to go through this change. Validations like this also adds some overhead though it can fail early (before service validates it).","commit_id":"983928d32ae7904a90acb9f99e1bb97a53f290f7"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"b0926587787e4013e449ec9de4103f9c8168edda","unresolved":true,"context_lines":[{"line_number":190,"context_line":"   parameters, please contact the TripleO development team on IRC or the"},{"line_number":191,"context_line":"   OpenStack mailing list."},{"line_number":192,"context_line":"  parameters:"},{"line_number":193,"context_line":"  - IronicInspectorIpRange"},{"line_number":194,"context_line":"  - IronicInspectorUseSwift"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"conditions:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"f2699be7_c14e9f61","line":193,"range":{"start_line":193,"start_character":4,"end_line":193,"end_character":26},"updated":"2021-02-03 07:40:29.000000000","message":"k this was already deprecated (line 104 above) but you are adding the parameter_groups here so including it ...","commit_id":"983928d32ae7904a90acb9f99e1bb97a53f290f7"}]}