)]}'
{"deployment/nova/nova-compute-container-puppet.yaml":[{"author":{"_account_id":29268,"name":"Matthew Heler","email":"matthew.heler@hotmail.com","username":"mheler"},"change_message_id":"f3efa09e2bad9479554aac316943620defe96291","unresolved":true,"context_lines":[{"line_number":208,"context_line":"      Set to one of the following valid values:"},{"line_number":209,"context_line":"      - ext2"},{"line_number":210,"context_line":"      - ext3"},{"line_number":211,"context_line":"      - ext4 "},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"      The ext4 format provides much faster initialization times than ext3 for new,"},{"line_number":214,"context_line":"      large disks. You can also override per instance using the guest_format"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"d2e697ad_fac2ebbe","line":211,"updated":"2021-01-31 03:07:49.000000000","message":"Whitespace","commit_id":"463b8303d7611c4f6f4d89ec1e13749d2de928c6"},{"author":{"_account_id":29268,"name":"Matthew Heler","email":"matthew.heler@hotmail.com","username":"mheler"},"change_message_id":"d4c309d4f06694a616d46be010a70aefac9a9a36","unresolved":true,"context_lines":[{"line_number":917,"context_line":"              NovaImageTypeExcludeList: {get_param: NovaImageTypeExcludeList}"},{"line_number":918,"context_line":"              NovaLiveMigrationPermitPostCopy: {get_param: NovaLiveMigrationPermitPostCopy}"},{"line_number":919,"context_line":"              NovaLiveMigrationPermitAutoConverge: {get_param: NovaLiveMigrationPermitAutoConverge}"},{"line_number":920,"context_line":"\u003c\u003c\u003c\u003c\u003c\u003c\u003c HEAD"},{"line_number":921,"context_line":"              NovaLibvirtMaxQueues: {get_param: NovaLibvirtMaxQueues}"},{"line_number":922,"context_line":""},{"line_number":923,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"a471462a_79d6e820","line":920,"updated":"2021-01-31 15:27:06.000000000","message":"bad merge?","commit_id":"f5c538c0267d54d1b59e43f4b0b4bb992330c4b5"},{"author":{"_account_id":29268,"name":"Matthew Heler","email":"matthew.heler@hotmail.com","username":"mheler"},"change_message_id":"d4c309d4f06694a616d46be010a70aefac9a9a36","unresolved":true,"context_lines":[{"line_number":920,"context_line":"\u003c\u003c\u003c\u003c\u003c\u003c\u003c HEAD"},{"line_number":921,"context_line":"              NovaLibvirtMaxQueues: {get_param: NovaLibvirtMaxQueues}"},{"line_number":922,"context_line":""},{"line_number":923,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":924,"context_line":"              NovaComputeForceRawImages: {get_param: NovaComputeForceRawImages}"},{"line_number":925,"context_line":"              NovaComputeUseCowImages: {get_param: NovaComputeUseCowImages}"},{"line_number":926,"context_line":"              NovaComputeLibvirtPreAllocateImages: {get_param: NovaComputeLibvirtPreAllocateImages}"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"aaa0cb4a_5cd62ecb","line":923,"updated":"2021-01-31 15:27:06.000000000","message":"same for here","commit_id":"f5c538c0267d54d1b59e43f4b0b4bb992330c4b5"},{"author":{"_account_id":29268,"name":"Matthew Heler","email":"matthew.heler@hotmail.com","username":"mheler"},"change_message_id":"d4c309d4f06694a616d46be010a70aefac9a9a36","unresolved":true,"context_lines":[{"line_number":931,"context_line":"              NovaComputeImageCacheRemoveUnusedResizedMinimumAge: {get_param: NovaComputeImageCacheRemoveUnusedResizedMinimumAge}"},{"line_number":932,"context_line":"              NovaComputeImageCacheSubdirectoryName: {get_param: NovaComputeImageCacheSubdirectoryName}"},{"line_number":933,"context_line":"              NovaComputeImageCachePrecacheConcurrency: {get_param: NovaComputeImageCachePrecacheConcurrency}"},{"line_number":934,"context_line":"\u003e\u003e\u003e\u003e\u003e\u003e\u003e 10d03c4b3... Introducing parametrable storage configuration"},{"line_number":935,"context_line":""},{"line_number":936,"context_line":"conditions:"},{"line_number":937,"context_line":"  enable_instance_ha: {equals: [{get_param: EnableInstanceHA}, true]}"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"8655dcb9_265dbfb8","line":934,"updated":"2021-01-31 15:27:06.000000000","message":"and here","commit_id":"f5c538c0267d54d1b59e43f4b0b4bb992330c4b5"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"44c4eb0aa1788382ba129e65efccdec9335c2e6c","unresolved":true,"context_lines":[{"line_number":161,"context_line":"      - The raw image format uses more space than other image formats, for example,"},{"line_number":162,"context_line":"        qcow2."},{"line_number":163,"context_line":"        Raw base images are always used with libvirt_images_type\u003dlvm."},{"line_number":164,"context_line":"    type: string"},{"line_number":165,"context_line":"    constraints:"},{"line_number":166,"context_line":"      - allowed_values: [ \u0027\u0027, \u0027true\u0027, \u0027True\u0027, \u0027TRUE\u0027, \u0027false\u0027, \u0027False\u0027, \u0027FALSE\u0027]"},{"line_number":167,"context_line":"    tags:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"abfa4e14_5f523edf","line":164,"updated":"2021-01-31 16:30:18.000000000","message":"if we default to true, why not just use a boolean?","commit_id":"63f819c6cbf7553921a666d69cfb7db8e6b3aff1"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"44c4eb0aa1788382ba129e65efccdec9335c2e6c","unresolved":true,"context_lines":[{"line_number":175,"context_line":"      on its own copy."},{"line_number":176,"context_line":"      Set to \"False\" to use the raw format. Raw format uses more space for common"},{"line_number":177,"context_line":"      parts of the disk image."},{"line_number":178,"context_line":"    type: string"},{"line_number":179,"context_line":"    constraints:"},{"line_number":180,"context_line":"      - allowed_values: [ \u0027\u0027, \u0027true\u0027, \u0027True\u0027, \u0027TRUE\u0027, \u0027false\u0027, \u0027False\u0027, \u0027FALSE\u0027]"},{"line_number":181,"context_line":"    tags:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ffd870cb_0452046d","line":178,"updated":"2021-01-31 16:30:18.000000000","message":"same, if we default to true, why not just use a boolean?","commit_id":"63f819c6cbf7553921a666d69cfb7db8e6b3aff1"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"44c4eb0aa1788382ba129e65efccdec9335c2e6c","unresolved":true,"context_lines":[{"line_number":208,"context_line":"      Set to one of the following valid values:"},{"line_number":209,"context_line":"      - ext2"},{"line_number":210,"context_line":"      - ext3"},{"line_number":211,"context_line":"      - ext4 "},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"      The ext4 format provides much faster initialization times than ext3 for new,"},{"line_number":214,"context_line":"      large disks. You can also override per instance using the guest_format"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bfa9b0b2_879ef42f","line":211,"updated":"2021-01-31 16:30:18.000000000","message":"nit, trailing space","commit_id":"63f819c6cbf7553921a666d69cfb7db8e6b3aff1"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"44c4eb0aa1788382ba129e65efccdec9335c2e6c","unresolved":true,"context_lines":[{"line_number":241,"context_line":"      specified by using remove_unused_original_minimum_age_seconds."},{"line_number":242,"context_line":"    type: string"},{"line_number":243,"context_line":"    constraints:"},{"line_number":244,"context_line":"      - allowed_values: [ \u0027\u0027, \u0027true\u0027, \u0027True\u0027, \u0027TRUE\u0027, \u0027false\u0027, \u0027False\u0027, \u0027FALSE\u0027]"},{"line_number":245,"context_line":"    tags:"},{"line_number":246,"context_line":"      - role_specific"},{"line_number":247,"context_line":"  NovaComputeImageCacheRemoveUnusedOriginalMinimumAge:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"03d2731c_b09a5282","line":244,"updated":"2021-01-31 16:30:18.000000000","message":"same, can\u0027t this just be a boolean?","commit_id":"63f819c6cbf7553921a666d69cfb7db8e6b3aff1"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"31684bfe8cb9088a4915a9e2b3356d118257749f","unresolved":true,"context_lines":[{"line_number":148,"context_line":"    tags:"},{"line_number":149,"context_line":"      - role_specific"},{"line_number":150,"context_line":"  NovaComputeForceRawImages:"},{"line_number":151,"context_line":"    default: \u0027True\u0027"},{"line_number":152,"context_line":"    description: |"},{"line_number":153,"context_line":"      Set to \"True\" to convert non-raw cached base images to raw format."},{"line_number":154,"context_line":"      Set to \"False\" if you have a system with slow I/O or low available space,"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"957fd3ee_6cc0c899","line":151,"updated":"2021-02-01 10:28:11.000000000","message":"if we default to true, why not just use a boolean?","commit_id":"085a468f1236927a8a90a5f158cad1968bcbaffa"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"31684bfe8cb9088a4915a9e2b3356d118257749f","unresolved":true,"context_lines":[{"line_number":166,"context_line":"      - allowed_values: [ \u0027\u0027, \u0027true\u0027, \u0027True\u0027, \u0027TRUE\u0027, \u0027false\u0027, \u0027False\u0027, \u0027FALSE\u0027]"},{"line_number":167,"context_line":"    tags:"},{"line_number":168,"context_line":"      - role_specific"},{"line_number":169,"context_line":"  NovaComputeUseCowImages:"},{"line_number":170,"context_line":"    default: \u0027True\u0027"},{"line_number":171,"context_line":"    description: |"},{"line_number":172,"context_line":"      Set to \"True\" to use CoW (Copy on Write) images in cqow2 format for libvirt"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"2b3c680a_1fd4ab5b","line":169,"updated":"2021-02-01 10:28:11.000000000","message":"same, if we default to true, why not just use a boolean?","commit_id":"085a468f1236927a8a90a5f158cad1968bcbaffa"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"31684bfe8cb9088a4915a9e2b3356d118257749f","unresolved":true,"context_lines":[{"line_number":233,"context_line":"    tags:"},{"line_number":234,"context_line":"      - role_specific"},{"line_number":235,"context_line":"  NovaComputeImageCacheRemoveUnusedBaseImages:"},{"line_number":236,"context_line":"    default: \u0027True\u0027"},{"line_number":237,"context_line":"    description: |"},{"line_number":238,"context_line":"      Set to \"True\" to automatically remove unused base images from the cache"},{"line_number":239,"context_line":"      at intervals configured by using image_cache_manager_interval. Images"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"b3bdc445_2f6b90ac","line":236,"updated":"2021-02-01 10:28:11.000000000","message":"same, if we default to true, why not just use a boolean?","commit_id":"085a468f1236927a8a90a5f158cad1968bcbaffa"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"d7c0efb743c3ac2d7c59fa69ad7848fa8d52ae50","unresolved":true,"context_lines":[{"line_number":826,"context_line":"              nova::compute::default_ephemeral_format: NovaComputeDefaultEphemeralFormat"},{"line_number":827,"context_line":"              nova::compute::image_cache::manager_interval: NovaComputeImageCacheManagerInterval"},{"line_number":828,"context_line":"              nova::compute::image_cache::remove_unused_base_images: NovaComputeImageCacheRemoveUnusedBaseImages"},{"line_number":829,"context_line":"              nova::compute::image_cache::remove_unused_original_minimum_age_seconds: NovaComputeImageCacheRemoveUnusedOriginalMinimumAge"},{"line_number":830,"context_line":"              nova::compute::image_cache::remove_unused_resized_minimum_age_seconds: NovaComputeImageCacheRemoveUnusedResizedMinimumAge"},{"line_number":831,"context_line":"              nova::compute::image_cache::subdirectory_name: NovaComputeImageCacheSubdirectoryName"},{"line_number":832,"context_line":"              nova::compute::image_cache::precache_concurrency: NovaComputeImageCachePrecacheConcurrency"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"d75614d2_bc6dd720","line":829,"updated":"2021-02-01 10:50:13.000000000","message":"same as line 810 where we already have a parameter NovaImageCacheTTL , was moved from nova::compute::libvirt to nova::compute::image_cache https://review.opendev.org/c/openstack/nova/+/690723 . we probably want to align the parameter names with the one we already have.","commit_id":"085a468f1236927a8a90a5f158cad1968bcbaffa"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"92bd492c51b24cda53883ea23da02b49f18f930e","unresolved":true,"context_lines":[{"line_number":197,"context_line":"      - allowed_values: [ \u0027none\u0027, \u0027space\u0027]"},{"line_number":198,"context_line":"    tags:"},{"line_number":199,"context_line":"      - role_specific"},{"line_number":200,"context_line":"  NovaComputeDefaultEphemeralFormat:"},{"line_number":201,"context_line":"    default: \u0027ext4\u0027"},{"line_number":202,"context_line":"    description: |"},{"line_number":203,"context_line":"      Specifies the default format that is used for a new ephemeral volume."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"299cb529_4dbd0488","line":200,"range":{"start_line":200,"start_character":2,"end_line":200,"end_character":35},"updated":"2021-02-08 11:11:58.000000000","message":"Do we really expect any users would try using ancient ext3 or ext2?\n\nI\u0027d agree to implement an interface in tht layer so that users can find available options more easily, but adding too much parameters would cause more problems with our future maintenance of tht.\n\nIMO we should focus on the parameters useful in real deployments instead of implementing all available parameters.","commit_id":"3596ddd126c2697bb720655e6eac4f13f6c15363"},{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"2610feaedbb4735ec11cc634f1dc29498052d4a2","unresolved":true,"context_lines":[{"line_number":197,"context_line":"      - allowed_values: [ \u0027none\u0027, \u0027space\u0027]"},{"line_number":198,"context_line":"    tags:"},{"line_number":199,"context_line":"      - role_specific"},{"line_number":200,"context_line":"  NovaComputeDefaultEphemeralFormat:"},{"line_number":201,"context_line":"    default: \u0027ext4\u0027"},{"line_number":202,"context_line":"    description: |"},{"line_number":203,"context_line":"      Specifies the default format that is used for a new ephemeral volume."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"b72ca0bc_5abbf417","line":200,"range":{"start_line":200,"start_character":2,"end_line":200,"end_character":35},"in_reply_to":"299cb529_4dbd0488","updated":"2021-02-09 03:05:26.000000000","message":"I have to agree with you here. I know some tenants are still running legacy applications and some of them are probably running ext3, or even ext2 but you\u0027re right, we don\u0027t need to set these as the default. I\u0027ll drop this.","commit_id":"3596ddd126c2697bb720655e6eac4f13f6c15363"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"92bd492c51b24cda53883ea23da02b49f18f930e","unresolved":true,"context_lines":[{"line_number":239,"context_line":"    tags:"},{"line_number":240,"context_line":"      - role_specific"},{"line_number":241,"context_line":"  NovaComputeImageCacheRemoveUnusedResizedMinimumAge:"},{"line_number":242,"context_line":"    default: \"86400\""},{"line_number":243,"context_line":"    description: |"},{"line_number":244,"context_line":"      (Optional) Specifies the minimum age that an unused resized base image must"},{"line_number":245,"context_line":"      be to be removed from the cache, in seconds. Unused unresized base images"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"96c34b30_09be5b69","line":242,"range":{"start_line":242,"start_character":14,"end_line":242,"end_character":19},"updated":"2021-02-08 11:11:58.000000000","message":"Is there any good reason to set the different value from the default defined in nova ? (3600)","commit_id":"3596ddd126c2697bb720655e6eac4f13f6c15363"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"63a9770eee24810b491fac3618c8e4492e0e58fa","unresolved":true,"context_lines":[{"line_number":239,"context_line":"    tags:"},{"line_number":240,"context_line":"      - role_specific"},{"line_number":241,"context_line":"  NovaComputeImageCacheRemoveUnusedResizedMinimumAge:"},{"line_number":242,"context_line":"    default: \"86400\""},{"line_number":243,"context_line":"    description: |"},{"line_number":244,"context_line":"      (Optional) Specifies the minimum age that an unused resized base image must"},{"line_number":245,"context_line":"      be to be removed from the cache, in seconds. Unused unresized base images"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"e44a7b30_c92e85aa","line":242,"range":{"start_line":242,"start_character":14,"end_line":242,"end_character":19},"in_reply_to":"96c34b30_09be5b69","updated":"2021-02-08 12:58:33.000000000","message":"yes that\u0027s a valid concern, when I checked I mixed it with remove_unused_original_minimum_age_seconds, where the default is 86400.","commit_id":"3596ddd126c2697bb720655e6eac4f13f6c15363"},{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"2610feaedbb4735ec11cc634f1dc29498052d4a2","unresolved":true,"context_lines":[{"line_number":239,"context_line":"    tags:"},{"line_number":240,"context_line":"      - role_specific"},{"line_number":241,"context_line":"  NovaComputeImageCacheRemoveUnusedResizedMinimumAge:"},{"line_number":242,"context_line":"    default: \"86400\""},{"line_number":243,"context_line":"    description: |"},{"line_number":244,"context_line":"      (Optional) Specifies the minimum age that an unused resized base image must"},{"line_number":245,"context_line":"      be to be removed from the cache, in seconds. Unused unresized base images"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3ee782eb_f643bc9e","line":242,"range":{"start_line":242,"start_character":14,"end_line":242,"end_character":19},"in_reply_to":"e44a7b30_c92e85aa","updated":"2021-02-09 03:05:26.000000000","message":"I thought the default was 86400, I\u0027ll change this.","commit_id":"3596ddd126c2697bb720655e6eac4f13f6c15363"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"92bd492c51b24cda53883ea23da02b49f18f930e","unresolved":true,"context_lines":[{"line_number":243,"context_line":"    description: |"},{"line_number":244,"context_line":"      (Optional) Specifies the minimum age that an unused resized base image must"},{"line_number":245,"context_line":"      be to be removed from the cache, in seconds. Unused unresized base images"},{"line_number":246,"context_line":"      younger than this will not be removed. Set to \"undef\" to disable."},{"line_number":247,"context_line":"    type: string"},{"line_number":248,"context_line":"    constraints:"},{"line_number":249,"context_line":"      - allowed_pattern: \"^(undef|[0-9]+)$\""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"12ed889f_f5b4b0f1","line":246,"range":{"start_line":246,"start_character":45,"end_line":246,"end_character":71},"updated":"2021-02-08 11:11:58.000000000","message":"I don\u0027t think nova supports disabling this feature.\n\nAlso, I\u0027m afraid that the current puppet-nova doesn\u0027t handle the string \"undef\" in puppet as expected.","commit_id":"3596ddd126c2697bb720655e6eac4f13f6c15363"},{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"2610feaedbb4735ec11cc634f1dc29498052d4a2","unresolved":true,"context_lines":[{"line_number":243,"context_line":"    description: |"},{"line_number":244,"context_line":"      (Optional) Specifies the minimum age that an unused resized base image must"},{"line_number":245,"context_line":"      be to be removed from the cache, in seconds. Unused unresized base images"},{"line_number":246,"context_line":"      younger than this will not be removed. Set to \"undef\" to disable."},{"line_number":247,"context_line":"    type: string"},{"line_number":248,"context_line":"    constraints:"},{"line_number":249,"context_line":"      - allowed_pattern: \"^(undef|[0-9]+)$\""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"97574970_5fd412bc","line":246,"range":{"start_line":246,"start_character":45,"end_line":246,"end_character":71},"in_reply_to":"12ed889f_f5b4b0f1","updated":"2021-02-09 03:05:26.000000000","message":"As discussed, we\u0027ll only pass the hieradata if this param is defined.","commit_id":"3596ddd126c2697bb720655e6eac4f13f6c15363"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"92bd492c51b24cda53883ea23da02b49f18f930e","unresolved":true,"context_lines":[{"line_number":251,"context_line":"          Must be either \"undef\" or a number of seconds"},{"line_number":252,"context_line":"    tags:"},{"line_number":253,"context_line":"      - role_specific"},{"line_number":254,"context_line":"  NovaComputeImageCacheSubdirectoryName:"},{"line_number":255,"context_line":"    default: \"_base\""},{"line_number":256,"context_line":"    description: |"},{"line_number":257,"context_line":"      Name of the folder where cached images are stored, relative to"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"965656db_ac6edada","line":254,"range":{"start_line":254,"start_character":2,"end_line":254,"end_character":39},"updated":"2021-02-08 11:11:58.000000000","message":"ditto. I\u0027m not aware of any usecase where a user want to change this value, IMHO.","commit_id":"3596ddd126c2697bb720655e6eac4f13f6c15363"},{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"2610feaedbb4735ec11cc634f1dc29498052d4a2","unresolved":true,"context_lines":[{"line_number":251,"context_line":"          Must be either \"undef\" or a number of seconds"},{"line_number":252,"context_line":"    tags:"},{"line_number":253,"context_line":"      - role_specific"},{"line_number":254,"context_line":"  NovaComputeImageCacheSubdirectoryName:"},{"line_number":255,"context_line":"    default: \"_base\""},{"line_number":256,"context_line":"    description: |"},{"line_number":257,"context_line":"      Name of the folder where cached images are stored, relative to"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"903d7c9d_2fd0dc74","line":254,"range":{"start_line":254,"start_character":2,"end_line":254,"end_character":39},"in_reply_to":"965656db_ac6edada","updated":"2021-02-09 03:05:26.000000000","message":"Good point, it might cause issues if changed, I\u0027ll drop this.","commit_id":"3596ddd126c2697bb720655e6eac4f13f6c15363"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"08cf16659b1dacf14110f623be2c16b1cc25c9ad","unresolved":true,"context_lines":[{"line_number":224,"context_line":"  NovaComputeImageCacheRemoveUnusedResizedMinimumAge:"},{"line_number":225,"context_line":"    default: 3600"},{"line_number":226,"context_line":"    description: |"},{"line_number":227,"context_line":"      (Optional) Specifies the minimum age that an unused resized base image must"},{"line_number":228,"context_line":"      be to be removed from the cache, in seconds. Unused unresized base images"},{"line_number":229,"context_line":"      younger than this will not be removed."},{"line_number":230,"context_line":"    type: number"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"33cbb79f_b1d602cf","line":227,"range":{"start_line":227,"start_character":6,"end_line":227,"end_character":17},"updated":"2021-02-09 12:51:08.000000000","message":"Can we remove this? I guess it came from puppet-nova.","commit_id":"d2e7f82018d1ae2694269e2ca33e0b13f003c14a"},{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"eadf84b641c0caa0e38856b62f8b118d9373de68","unresolved":false,"context_lines":[{"line_number":224,"context_line":"  NovaComputeImageCacheRemoveUnusedResizedMinimumAge:"},{"line_number":225,"context_line":"    default: 3600"},{"line_number":226,"context_line":"    description: |"},{"line_number":227,"context_line":"      (Optional) Specifies the minimum age that an unused resized base image must"},{"line_number":228,"context_line":"      be to be removed from the cache, in seconds. Unused unresized base images"},{"line_number":229,"context_line":"      younger than this will not be removed."},{"line_number":230,"context_line":"    type: number"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"56ee4ab6_a3d4bb91","line":227,"range":{"start_line":227,"start_character":6,"end_line":227,"end_character":17},"in_reply_to":"33cbb79f_b1d602cf","updated":"2021-02-09 17:17:22.000000000","message":"Done","commit_id":"d2e7f82018d1ae2694269e2ca33e0b13f003c14a"}],"releasenotes/notes/nova-compute-image-parameters-eb3a11bf0fd4691b.yaml":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"08cf16659b1dacf14110f623be2c16b1cc25c9ad","unresolved":true,"context_lines":[{"line_number":5,"context_line":"      - NovaComputeForceRawImages"},{"line_number":6,"context_line":"      - NovaComputeUseCowImages"},{"line_number":7,"context_line":"      - NovaComputeLibvirtPreAllocateImages"},{"line_number":8,"context_line":"      - NovaComputeDefaultEphemeralFormat"},{"line_number":9,"context_line":"      - NovaComputeImageCacheManagerInterval"},{"line_number":10,"context_line":"      - NovaComputeImageCacheRemoveUnusedBaseImages"},{"line_number":11,"context_line":"      - NovaComputeImageCacheRemoveUnusedOriginalMinimumAge"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"7bbdf1bc_5af7996a","line":8,"range":{"start_line":8,"start_character":8,"end_line":8,"end_character":41},"updated":"2021-02-09 12:51:08.000000000","message":"This was removed from this change.","commit_id":"d2e7f82018d1ae2694269e2ca33e0b13f003c14a"},{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"eadf84b641c0caa0e38856b62f8b118d9373de68","unresolved":false,"context_lines":[{"line_number":5,"context_line":"      - NovaComputeForceRawImages"},{"line_number":6,"context_line":"      - NovaComputeUseCowImages"},{"line_number":7,"context_line":"      - NovaComputeLibvirtPreAllocateImages"},{"line_number":8,"context_line":"      - NovaComputeDefaultEphemeralFormat"},{"line_number":9,"context_line":"      - NovaComputeImageCacheManagerInterval"},{"line_number":10,"context_line":"      - NovaComputeImageCacheRemoveUnusedBaseImages"},{"line_number":11,"context_line":"      - NovaComputeImageCacheRemoveUnusedOriginalMinimumAge"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"754c1ad5_7ea06864","line":8,"range":{"start_line":8,"start_character":8,"end_line":8,"end_character":41},"in_reply_to":"7bbdf1bc_5af7996a","updated":"2021-02-09 17:17:22.000000000","message":"Done","commit_id":"d2e7f82018d1ae2694269e2ca33e0b13f003c14a"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"08cf16659b1dacf14110f623be2c16b1cc25c9ad","unresolved":true,"context_lines":[{"line_number":8,"context_line":"      - NovaComputeDefaultEphemeralFormat"},{"line_number":9,"context_line":"      - NovaComputeImageCacheManagerInterval"},{"line_number":10,"context_line":"      - NovaComputeImageCacheRemoveUnusedBaseImages"},{"line_number":11,"context_line":"      - NovaComputeImageCacheRemoveUnusedOriginalMinimumAge"},{"line_number":12,"context_line":"      - NovaComputeImageCacheRemoveUnusedResizedMinimumAge"},{"line_number":13,"context_line":"      - NovaComputeImageCacheSubdirectoryName"},{"line_number":14,"context_line":"      - NovaComputeImageCachePrecacheConcurrency"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"21e00b9c_23c31af3","line":11,"range":{"start_line":11,"start_character":8,"end_line":11,"end_character":59},"updated":"2021-02-09 12:51:08.000000000","message":"This is not implemented in the change.","commit_id":"d2e7f82018d1ae2694269e2ca33e0b13f003c14a"},{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"eadf84b641c0caa0e38856b62f8b118d9373de68","unresolved":false,"context_lines":[{"line_number":8,"context_line":"      - NovaComputeDefaultEphemeralFormat"},{"line_number":9,"context_line":"      - NovaComputeImageCacheManagerInterval"},{"line_number":10,"context_line":"      - NovaComputeImageCacheRemoveUnusedBaseImages"},{"line_number":11,"context_line":"      - NovaComputeImageCacheRemoveUnusedOriginalMinimumAge"},{"line_number":12,"context_line":"      - NovaComputeImageCacheRemoveUnusedResizedMinimumAge"},{"line_number":13,"context_line":"      - NovaComputeImageCacheSubdirectoryName"},{"line_number":14,"context_line":"      - NovaComputeImageCachePrecacheConcurrency"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"50d3868a_9cc7193a","line":11,"range":{"start_line":11,"start_character":8,"end_line":11,"end_character":59},"in_reply_to":"21e00b9c_23c31af3","updated":"2021-02-09 17:17:22.000000000","message":"Done","commit_id":"d2e7f82018d1ae2694269e2ca33e0b13f003c14a"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"08cf16659b1dacf14110f623be2c16b1cc25c9ad","unresolved":true,"context_lines":[{"line_number":10,"context_line":"      - NovaComputeImageCacheRemoveUnusedBaseImages"},{"line_number":11,"context_line":"      - NovaComputeImageCacheRemoveUnusedOriginalMinimumAge"},{"line_number":12,"context_line":"      - NovaComputeImageCacheRemoveUnusedResizedMinimumAge"},{"line_number":13,"context_line":"      - NovaComputeImageCacheSubdirectoryName"},{"line_number":14,"context_line":"      - NovaComputeImageCachePrecacheConcurrency"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"445af393_aa851520","line":13,"range":{"start_line":13,"start_character":8,"end_line":13,"end_character":45},"updated":"2021-02-09 12:51:08.000000000","message":"This was removed from this change.","commit_id":"d2e7f82018d1ae2694269e2ca33e0b13f003c14a"},{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"eadf84b641c0caa0e38856b62f8b118d9373de68","unresolved":false,"context_lines":[{"line_number":10,"context_line":"      - NovaComputeImageCacheRemoveUnusedBaseImages"},{"line_number":11,"context_line":"      - NovaComputeImageCacheRemoveUnusedOriginalMinimumAge"},{"line_number":12,"context_line":"      - NovaComputeImageCacheRemoveUnusedResizedMinimumAge"},{"line_number":13,"context_line":"      - NovaComputeImageCacheSubdirectoryName"},{"line_number":14,"context_line":"      - NovaComputeImageCachePrecacheConcurrency"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"dd80e119_1296449b","line":13,"range":{"start_line":13,"start_character":8,"end_line":13,"end_character":45},"in_reply_to":"445af393_aa851520","updated":"2021-02-09 17:17:22.000000000","message":"Done","commit_id":"d2e7f82018d1ae2694269e2ca33e0b13f003c14a"}]}