)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"ff90840d24c259e8b2ae2ce59e7423729a53c5c3","unresolved":true,"context_lines":[{"line_number":12,"context_line":"\u0027cinder_use_multipath\u0027"},{"line_number":13,"context_line":"\u0027cinder_enforce_multipath\u0027"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Enabling both parameters when multipath is enabled."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Depends-On: Ic2c86e6a890b58ca7703ea3a3147c8d4ecf13953"},{"line_number":18,"context_line":"Change-Id: I03e042b9684e6bdd8c277066776df23d2eb84ecd"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"c91413c4_e91fe3b5","line":15,"updated":"2021-02-08 15:50:08.000000000","message":"This is no longer true. My suggestion is to reword the entire message and just focus on enabling (setting True) cinder_use_multipath. I don\u0027t think you need to mention the other setting.","commit_id":"edf7b4f780017c6ae90d3dca59de0d16d100d81a"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"8ccfdaab942aa6053685a6494dc6341257d14a44","unresolved":true,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Enabling \u0027cinder_use_multipath\u0027 when multipath is enabled."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Depends-On: Ic2c86e6a890b58ca7703ea3a3147c8d4ecf13953"},{"line_number":15,"context_line":"Change-Id: I03e042b9684e6bdd8c277066776df23d2eb84ecd"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"beafa531_e66e296f","line":14,"range":{"start_line":14,"start_character":12,"end_line":14,"end_character":53},"updated":"2021-02-15 15:07:23.000000000","message":"careful when using change-ids instead of urls as the backport prevents this from landing.","commit_id":"4535e0f35630d718f5d5a25c91af629ffad95689"}],"deployment/glance/glance-api-container-puppet.yaml":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"08fe22b9cbaa435718ea20ccaa7120d14d131b07","unresolved":true,"context_lines":[{"line_number":528,"context_line":"          -"},{"line_number":529,"context_line":"            if:"},{"line_number":530,"context_line":"            - cinder_multipathd_enabled"},{"line_number":531,"context_line":"            - glance::backend::cinder::cinder_enforce_multipath: true"},{"line_number":532,"context_line":"              glance::backend::cinder::cinder_use_multipath: true"},{"line_number":533,"context_line":"            - {}"},{"line_number":534,"context_line":"          -"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"149e6e3a_9cc0f5d0","line":531,"updated":"2021-02-05 14:49:42.000000000","message":"-1: I do not think we want to enforce multipath, because that will cause glance operations to fail if *any* of the paths are down. I believe nova might want to enforce multipath for HA purposes, but for glance and cinder itself, we want the operation to succeed as long as any path is available.\n\nIn other words, I think you should just delete L531.","commit_id":"fd6388a21d7beecc6521845af1b9149dde4b2057"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"9b8a37ebff0f143aab864d87f172d110cb52c5b0","unresolved":true,"context_lines":[{"line_number":528,"context_line":"          -"},{"line_number":529,"context_line":"            if:"},{"line_number":530,"context_line":"            - cinder_multipathd_enabled"},{"line_number":531,"context_line":"            - glance::backend::cinder::cinder_enforce_multipath: true"},{"line_number":532,"context_line":"              glance::backend::cinder::cinder_use_multipath: true"},{"line_number":533,"context_line":"            - {}"},{"line_number":534,"context_line":"          -"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"464c2f8b_7a942d6b","line":531,"in_reply_to":"149e6e3a_9cc0f5d0","updated":"2021-02-05 14:53:25.000000000","message":"I shouldn\u0027t have written \"if *any* paths are down,\" although my point still stands. Typically, multipath deployments specify 2 paths, and so if either of them go down you no longer have multiple paths. That\u0027s what I meant by \"if *any* paths are down.\" I should have said \"when *either* (of two) paths are down.\"","commit_id":"fd6388a21d7beecc6521845af1b9149dde4b2057"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"27cf31eef1238562bdcee38ee26551d840081aaf","unresolved":true,"context_lines":[{"line_number":528,"context_line":"          -"},{"line_number":529,"context_line":"            if:"},{"line_number":530,"context_line":"            - cinder_multipathd_enabled"},{"line_number":531,"context_line":"              glance::backend::cinder::cinder_use_multipath: true"},{"line_number":532,"context_line":"            - {}"},{"line_number":533,"context_line":"          -"},{"line_number":534,"context_line":"            if:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"60db9d83_d6f0c9a1","line":531,"range":{"start_line":531,"start_character":12,"end_line":531,"end_character":13},"updated":"2021-02-10 12:07:21.000000000","message":"You should add \u0027-\u0027 here.","commit_id":"7d94668b2a18bd022690f9b7c70835fe12548943"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"526936a27046e8776321e39b633fc212348a8404","unresolved":true,"context_lines":[{"line_number":528,"context_line":"          -"},{"line_number":529,"context_line":"            if:"},{"line_number":530,"context_line":"            - cinder_multipathd_enabled"},{"line_number":531,"context_line":"              glance::backend::cinder::cinder_use_multipath: true"},{"line_number":532,"context_line":"            - {}"},{"line_number":533,"context_line":"          -"},{"line_number":534,"context_line":"            if:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"c1b86fd4_916bd1ff","line":531,"range":{"start_line":531,"start_character":12,"end_line":531,"end_character":13},"in_reply_to":"60db9d83_d6f0c9a1","updated":"2021-02-11 07:09:43.000000000","message":"oops sorry, this got missed during edit :/","commit_id":"7d94668b2a18bd022690f9b7c70835fe12548943"}]}