)]}'
{"deployment/ceph-ansible/ceph-nfs.yaml":[{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"091cb272e79ce8bb650e574f8841de8766a3273d","unresolved":true,"context_lines":[{"line_number":48,"context_line":"      RoleName: {get_param: RoleName}"},{"line_number":49,"context_line":"      RoleParameters: {get_param: RoleParameters}"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"  CephNfsAnsibleVars:"},{"line_number":52,"context_line":"    type: OS::Heat::Value"},{"line_number":53,"context_line":"    properties:"},{"line_number":54,"context_line":"      type: json"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"e05a1b13_bb24e9b8","line":51,"range":{"start_line":51,"start_character":2,"end_line":51,"end_character":20},"updated":"2021-04-27 05:20:36.000000000","message":"Where is this value resource used?  I guess you\u0027ve to add vars in L67/68 at L150.","commit_id":"90a177507af32896ed47ace3ae872c8eadbf3773"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"67279c33d7e053276afc71f47e0d3fc259f11484","unresolved":false,"context_lines":[{"line_number":48,"context_line":"      RoleName: {get_param: RoleName}"},{"line_number":49,"context_line":"      RoleParameters: {get_param: RoleParameters}"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"  CephNfsAnsibleVars:"},{"line_number":52,"context_line":"    type: OS::Heat::Value"},{"line_number":53,"context_line":"    properties:"},{"line_number":54,"context_line":"      type: json"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"8f436348_40c38880","line":51,"range":{"start_line":51,"start_character":2,"end_line":51,"end_character":20},"in_reply_to":"e05a1b13_bb24e9b8","updated":"2021-04-29 14:51:21.000000000","message":"removing per discussion below.","commit_id":"90a177507af32896ed47ace3ae872c8eadbf3773"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"f7ce0f0e9594f85d07857fdd62504af355c8e920","unresolved":true,"context_lines":[{"line_number":136,"context_line":"              - ceph_fstobs"},{"line_number":137,"context_line":"              - ceph_systemd"},{"line_number":138,"context_line":"            block:"},{"line_number":139,"context_line":"              - name: set ceph-ansible group vars nfss"},{"line_number":140,"context_line":"                set_fact:"},{"line_number":141,"context_line":"                  ceph_ansible_group_vars_nfss:"},{"line_number":142,"context_line":"                    ceph_nfs_bind_addr: {get_param: [EndpointMap, GaneshaInternal, host_nobrackets]}"},{"line_number":143,"context_line":"                    ceph_nfs_enable_service: false"},{"line_number":144,"context_line":"                    ceph_nfs_use_pacemaker: true"},{"line_number":145,"context_line":"                    ceph_nfs_dynamic_exports: true"},{"line_number":146,"context_line":"                    ceph_nfs_service_suffix: pacemaker"},{"line_number":147,"context_line":"                    nfs_obj_gw: false"},{"line_number":148,"context_line":"                    ceph_nfs_rados_backend: true"},{"line_number":149,"context_line":"                    ceph_nfs_disable_caching: true"},{"line_number":150,"context_line":"                    ceph_nfs_ceph_user: {get_param: ManilaCephFSCephFSAuthId}"},{"line_number":151,"context_line":"              - name: generate ceph-ansible group vars nfss"},{"line_number":152,"context_line":"                copy:"},{"line_number":153,"context_line":"                  dest: \"{{playbook_dir}}/ceph-ansible/group_vars/nfss.yml\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"36bc45ba_d6e29f7d","line":150,"range":{"start_line":139,"start_character":14,"end_line":150,"end_character":77},"updated":"2021-04-27 05:36:38.000000000","message":"I\u0027m not sure when (and why) this has been changed, but this task can be turned into [1] and the variables can be consumed from the \u0027CephNfsAnsibleVars\u0027 block (where the new parameters are placed).\n\nThe alternative could be:\n\n1. Add L66 and L67 after L150\n2. Remove the block from L51 to L67\n\nI\u0027m more for the first approach (consuming here the variables provided by CephNfsAnsibleVars like [1]), but the other way would work too.\n\n[1] https://github.com/openstack/tripleo-heat-templates/blob/stable/train/deployment/ceph-ansible/ceph-nfs.yaml#L129-L135","commit_id":"90a177507af32896ed47ace3ae872c8eadbf3773"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"67279c33d7e053276afc71f47e0d3fc259f11484","unresolved":false,"context_lines":[{"line_number":136,"context_line":"              - ceph_fstobs"},{"line_number":137,"context_line":"              - ceph_systemd"},{"line_number":138,"context_line":"            block:"},{"line_number":139,"context_line":"              - name: set ceph-ansible group vars nfss"},{"line_number":140,"context_line":"                set_fact:"},{"line_number":141,"context_line":"                  ceph_ansible_group_vars_nfss:"},{"line_number":142,"context_line":"                    ceph_nfs_bind_addr: {get_param: [EndpointMap, GaneshaInternal, host_nobrackets]}"},{"line_number":143,"context_line":"                    ceph_nfs_enable_service: false"},{"line_number":144,"context_line":"                    ceph_nfs_use_pacemaker: true"},{"line_number":145,"context_line":"                    ceph_nfs_dynamic_exports: true"},{"line_number":146,"context_line":"                    ceph_nfs_service_suffix: pacemaker"},{"line_number":147,"context_line":"                    nfs_obj_gw: false"},{"line_number":148,"context_line":"                    ceph_nfs_rados_backend: true"},{"line_number":149,"context_line":"                    ceph_nfs_disable_caching: true"},{"line_number":150,"context_line":"                    ceph_nfs_ceph_user: {get_param: ManilaCephFSCephFSAuthId}"},{"line_number":151,"context_line":"              - name: generate ceph-ansible group vars nfss"},{"line_number":152,"context_line":"                copy:"},{"line_number":153,"context_line":"                  dest: \"{{playbook_dir}}/ceph-ansible/group_vars/nfss.yml\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"de3509b0_cd7807a8","line":150,"range":{"start_line":139,"start_character":14,"end_line":150,"end_character":77},"in_reply_to":"05b48f62_e96af15f","updated":"2021-04-29 14:51:21.000000000","message":"will do, Thanks!","commit_id":"90a177507af32896ed47ace3ae872c8eadbf3773"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"605124ec17e832b73f928c53573091ecf2ad2fd2","unresolved":true,"context_lines":[{"line_number":136,"context_line":"              - ceph_fstobs"},{"line_number":137,"context_line":"              - ceph_systemd"},{"line_number":138,"context_line":"            block:"},{"line_number":139,"context_line":"              - name: set ceph-ansible group vars nfss"},{"line_number":140,"context_line":"                set_fact:"},{"line_number":141,"context_line":"                  ceph_ansible_group_vars_nfss:"},{"line_number":142,"context_line":"                    ceph_nfs_bind_addr: {get_param: [EndpointMap, GaneshaInternal, host_nobrackets]}"},{"line_number":143,"context_line":"                    ceph_nfs_enable_service: false"},{"line_number":144,"context_line":"                    ceph_nfs_use_pacemaker: true"},{"line_number":145,"context_line":"                    ceph_nfs_dynamic_exports: true"},{"line_number":146,"context_line":"                    ceph_nfs_service_suffix: pacemaker"},{"line_number":147,"context_line":"                    nfs_obj_gw: false"},{"line_number":148,"context_line":"                    ceph_nfs_rados_backend: true"},{"line_number":149,"context_line":"                    ceph_nfs_disable_caching: true"},{"line_number":150,"context_line":"                    ceph_nfs_ceph_user: {get_param: ManilaCephFSCephFSAuthId}"},{"line_number":151,"context_line":"              - name: generate ceph-ansible group vars nfss"},{"line_number":152,"context_line":"                copy:"},{"line_number":153,"context_line":"                  dest: \"{{playbook_dir}}/ceph-ansible/group_vars/nfss.yml\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"36f76d6b_133fa2f9","line":150,"range":{"start_line":139,"start_character":14,"end_line":150,"end_character":77},"in_reply_to":"36bc45ba_d6e29f7d","updated":"2021-04-27 06:07:42.000000000","message":"Changed because you don\u0027t need heat resource unnecessarily ( i.e create a static map with some parameters). They can be specified in outputs directly.\n\nHaving so many heat resources is always an overhead. Please check https://review.opendev.org/c/openstack/tripleo-heat-templates/+/787910","commit_id":"90a177507af32896ed47ace3ae872c8eadbf3773"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"11fe587243cebb5b0994504940be663faa7b2cd3","unresolved":true,"context_lines":[{"line_number":136,"context_line":"              - ceph_fstobs"},{"line_number":137,"context_line":"              - ceph_systemd"},{"line_number":138,"context_line":"            block:"},{"line_number":139,"context_line":"              - name: set ceph-ansible group vars nfss"},{"line_number":140,"context_line":"                set_fact:"},{"line_number":141,"context_line":"                  ceph_ansible_group_vars_nfss:"},{"line_number":142,"context_line":"                    ceph_nfs_bind_addr: {get_param: [EndpointMap, GaneshaInternal, host_nobrackets]}"},{"line_number":143,"context_line":"                    ceph_nfs_enable_service: false"},{"line_number":144,"context_line":"                    ceph_nfs_use_pacemaker: true"},{"line_number":145,"context_line":"                    ceph_nfs_dynamic_exports: true"},{"line_number":146,"context_line":"                    ceph_nfs_service_suffix: pacemaker"},{"line_number":147,"context_line":"                    nfs_obj_gw: false"},{"line_number":148,"context_line":"                    ceph_nfs_rados_backend: true"},{"line_number":149,"context_line":"                    ceph_nfs_disable_caching: true"},{"line_number":150,"context_line":"                    ceph_nfs_ceph_user: {get_param: ManilaCephFSCephFSAuthId}"},{"line_number":151,"context_line":"              - name: generate ceph-ansible group vars nfss"},{"line_number":152,"context_line":"                copy:"},{"line_number":153,"context_line":"                  dest: \"{{playbook_dir}}/ceph-ansible/group_vars/nfss.yml\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"05b48f62_e96af15f","line":150,"range":{"start_line":139,"start_character":14,"end_line":150,"end_character":77},"in_reply_to":"36f76d6b_133fa2f9","updated":"2021-04-27 06:46:37.000000000","message":"It could makes sense in terms of overhead and the resources allocated by heat.\nSince it was already done for ceph-ansible, let\u0027s do the same on cephadm. \nThanks Rabi, I\u0027ll check 78910 and let\u0027s go w/ the following here:\n\n1. Add L66 and L67 after L150\n2. Remove the block from L51 to L67","commit_id":"90a177507af32896ed47ace3ae872c8eadbf3773"}],"deployment/cephadm/ceph-nfs.yaml":[{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"091cb272e79ce8bb650e574f8841de8766a3273d","unresolved":true,"context_lines":[{"line_number":33,"context_line":"  ManilaCephFSCephFSAuthId:"},{"line_number":34,"context_line":"    type: string"},{"line_number":35,"context_line":"    default: \u0027manila\u0027"},{"line_number":36,"context_line":"  ManilaCephFSNFSIdmapConf:"},{"line_number":37,"context_line":"    type: string"},{"line_number":38,"context_line":"    default: \u0027/etc/ganesha/idmap.conf\u0027"},{"line_number":39,"context_line":"  ManilaCephFSNFSIdmapOverrides:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"4e653aed_16a699fd","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":2},"updated":"2021-04-27 05:20:36.000000000","message":"These parameters are not used in this template.","commit_id":"90a177507af32896ed47ace3ae872c8eadbf3773"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"67279c33d7e053276afc71f47e0d3fc259f11484","unresolved":false,"context_lines":[{"line_number":33,"context_line":"  ManilaCephFSCephFSAuthId:"},{"line_number":34,"context_line":"    type: string"},{"line_number":35,"context_line":"    default: \u0027manila\u0027"},{"line_number":36,"context_line":"  ManilaCephFSNFSIdmapConf:"},{"line_number":37,"context_line":"    type: string"},{"line_number":38,"context_line":"    default: \u0027/etc/ganesha/idmap.conf\u0027"},{"line_number":39,"context_line":"  ManilaCephFSNFSIdmapOverrides:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"978c646a_686cf04b","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":2},"in_reply_to":"3bda82cc_a8a11e12","updated":"2021-04-29 14:51:21.000000000","message":"I had noticed they weren\u0027t really used yet but was matching what is current for ManilaCephFSCephFSAuthId at line 33.","commit_id":"90a177507af32896ed47ace3ae872c8eadbf3773"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"f7ce0f0e9594f85d07857fdd62504af355c8e920","unresolved":false,"context_lines":[{"line_number":33,"context_line":"  ManilaCephFSCephFSAuthId:"},{"line_number":34,"context_line":"    type: string"},{"line_number":35,"context_line":"    default: \u0027manila\u0027"},{"line_number":36,"context_line":"  ManilaCephFSNFSIdmapConf:"},{"line_number":37,"context_line":"    type: string"},{"line_number":38,"context_line":"    default: \u0027/etc/ganesha/idmap.conf\u0027"},{"line_number":39,"context_line":"  ManilaCephFSNFSIdmapOverrides:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3bda82cc_a8a11e12","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":2},"in_reply_to":"4e653aed_16a699fd","updated":"2021-04-27 05:36:38.000000000","message":"They\u0027re needed here because of [1], and ensures we don\u0027t miss any existing parameter during the migration from ceph-ansible to cephadm.\n\n[1] https://github.com/openstack/tripleo-heat-templates/blob/master/tools/yaml-validate.py#L345-L354","commit_id":"90a177507af32896ed47ace3ae872c8eadbf3773"}]}