)]}'
{"deployment/glance/glance-api-container-puppet.yaml":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"d18f36193ef66e7fa4055a99b6be0696b56d08e4","unresolved":true,"context_lines":[{"line_number":264,"context_line":"          cinder_store:"},{"line_number":265,"context_line":"            GlanceBackend: cinder"},{"line_number":266,"context_line":"            GlanceStoreDescription: \u0027Cinder store\u0027"},{"line_number":267,"context_line":"  CinderMountPointBase:"},{"line_number":268,"context_line":"    default: \u0027/var/lib/glance/mnt\u0027"},{"line_number":269,"context_line":"    type: string"},{"line_number":270,"context_line":"    description: |"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"51fd51fd_d44a3db8","line":267,"updated":"2021-02-08 16:14:07.000000000","message":"As I mentioned in another review, this is a glance parameter and so its name should start with Glance.\n\nI gather glance\u0027s use of the parameter is related to it using cinder for its backend, but I find it interesting the default value \u0027/var/lib/glance/mnt\u0027 doesn\u0027t mention cinder. I see two possible names for the THT parameter:\n\n1. GlanceCinderMountPointBase\n2. GlanceMountPointBase\n\nI would be happy with either choice, and only ask the name does not start with \"Cinder\" as that would imply it\u0027s a cinder parameter.","commit_id":"571c797977eef965166cf5758c243be3a13ac9b6"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"817fb6ffa19037b0d5b77fa8bb1745dbc630a8d4","unresolved":true,"context_lines":[{"line_number":529,"context_line":"            - glance::backend::cinder::cinder_store_auth_address: {get_param: [EndpointMap, KeystoneV3Internal, uri]}"},{"line_number":530,"context_line":"              glance::backend::cinder::cinder_store_project_name: \u0027service\u0027"},{"line_number":531,"context_line":"              glance::backend::cinder::cinder_store_user_name: \u0027glance\u0027"},{"line_number":532,"context_line":"              glance::backend::cinder::cinder_store_password: {get_param: GlancePassword}"},{"line_number":533,"context_line":"              tripleo::profile::base::glance::backend::cinder::cinder_mount_point_base: {get_parame: GlanceCinderMountPointBase}"},{"line_number":534,"context_line":"            - {}"},{"line_number":535,"context_line":"          -"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"0e1ba6e5_00c8da2c","line":532,"updated":"2021-02-15 10:46:15.000000000","message":"This is not related to this change but IMO we should use parameters in puppet-tripleo to set backend parameters like cinder_store_project_name, regarding the fact we have deprecated classes for single stores like glance::backend::cinder.","commit_id":"365f16e21d25e6ffeed65a65c22df48a857935b0"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"40ca1c5d28f21e8652e0795db108524c38f773d8","unresolved":false,"context_lines":[{"line_number":529,"context_line":"            - glance::backend::cinder::cinder_store_auth_address: {get_param: [EndpointMap, KeystoneV3Internal, uri]}"},{"line_number":530,"context_line":"              glance::backend::cinder::cinder_store_project_name: \u0027service\u0027"},{"line_number":531,"context_line":"              glance::backend::cinder::cinder_store_user_name: \u0027glance\u0027"},{"line_number":532,"context_line":"              glance::backend::cinder::cinder_store_password: {get_param: GlancePassword}"},{"line_number":533,"context_line":"              tripleo::profile::base::glance::backend::cinder::cinder_mount_point_base: {get_parame: GlanceCinderMountPointBase}"},{"line_number":534,"context_line":"            - {}"},{"line_number":535,"context_line":"          -"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"8978217f_e0da73e6","line":532,"in_reply_to":"0e1ba6e5_00c8da2c","updated":"2021-02-16 14:03:03.000000000","message":"Ack. I will address this in another patch.","commit_id":"365f16e21d25e6ffeed65a65c22df48a857935b0"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"e585202105489e90fa986a848a6dcfe2660c5b92","unresolved":false,"context_lines":[{"line_number":529,"context_line":"            - glance::backend::cinder::cinder_store_auth_address: {get_param: [EndpointMap, KeystoneV3Internal, uri]}"},{"line_number":530,"context_line":"              glance::backend::cinder::cinder_store_project_name: \u0027service\u0027"},{"line_number":531,"context_line":"              glance::backend::cinder::cinder_store_user_name: \u0027glance\u0027"},{"line_number":532,"context_line":"              glance::backend::cinder::cinder_store_password: {get_param: GlancePassword}"},{"line_number":533,"context_line":"              tripleo::profile::base::glance::backend::cinder::cinder_mount_point_base: {get_parame: GlanceCinderMountPointBase}"},{"line_number":534,"context_line":"            - {}"},{"line_number":535,"context_line":"          -"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3c1cab54_0c0dd4ea","line":532,"in_reply_to":"8978217f_e0da73e6","updated":"2021-02-19 18:28:48.000000000","message":"I agree it would be cleaner if we switch all cinder/glance/manila backend parameters to use puppet-tripleo\u0027s namespace (e.g. tripleo::profile::base::glance::backend::cinder::cinder_store_password), especially because puppet-[cinder|glance|manila] backends are defined resources so hiera bindings don\u0027t apply.\n\nThat said, updating all the hiera parameters will need to be carefully orchestrated. If we undertake the task then it just needs to be done with extra care.","commit_id":"365f16e21d25e6ffeed65a65c22df48a857935b0"}],"releasenotes/notes/add-glance-cinder-mount-point-base-parameter-852554398b9f3a19.yaml":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"d18f36193ef66e7fa4055a99b6be0696b56d08e4","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The new parameter CinderMountPointBase has been added which will be used"},{"line_number":5,"context_line":"    for mounting NFS volumes on glance nodes."},{"line_number":6,"context_line":"    When glance uses cinder as store and cinder backend is NFS, the mount"},{"line_number":7,"context_line":"    point would be required to be set with this parameter."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"cd24f8d7_162a0572","line":4,"range":{"start_line":4,"start_character":22,"end_line":4,"end_character":42},"updated":"2021-02-08 16:14:07.000000000","message":"Don\u0027t forget to update the release note when you fix the parameter to not start with \"Cinder\"","commit_id":"571c797977eef965166cf5758c243be3a13ac9b6"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"d18f36193ef66e7fa4055a99b6be0696b56d08e4","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    The new parameter CinderMountPointBase has been added which will be used"},{"line_number":5,"context_line":"    for mounting NFS volumes on glance nodes."},{"line_number":6,"context_line":"    When glance uses cinder as store and cinder backend is NFS, the mount"},{"line_number":7,"context_line":"    point would be required to be set with this parameter."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"425ee448_53836358","line":7,"range":{"start_line":7,"start_character":10,"end_line":7,"end_character":57},"updated":"2021-02-08 16:14:07.000000000","message":"This is a little awkward. How about:\n\n\"When glance uses cinder as store and cinder backend is NFS, this parameter must be set to match cinder\u0027s mount point.\"","commit_id":"571c797977eef965166cf5758c243be3a13ac9b6"}]}