)]}'
{"deployment/tripleo-packages/tripleo-packages-baremetal-puppet.yaml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"a933e599fb7e866222fffb356bde03d3391d99fa","unresolved":true,"context_lines":[{"line_number":212,"context_line":"                  - \u0027\u0027"},{"line_number":213,"context_line":"                  - - \"#!/bin/bash\\n\\n\""},{"line_number":214,"context_line":"                    - {get_param: LeappRepoInitCommand}"},{"line_number":215,"context_line":"            # WA for UEFI systems rhbz#1925078"},{"line_number":216,"context_line":"            - name: Check if system was booted via EFI"},{"line_number":217,"context_line":"              failed_when: false"},{"line_number":218,"context_line":"              shell: |"},{"line_number":219,"context_line":"                dmesg | grep \"EFI v\""},{"line_number":220,"context_line":"              register: efi"},{"line_number":221,"context_line":"            - name: Check if efi partition is present in /etc/fstab"},{"line_number":222,"context_line":"              failed_when: false"},{"line_number":223,"context_line":"              register: efi_fstab"},{"line_number":224,"context_line":"              shell: |"},{"line_number":225,"context_line":"                grep efi /etc/fstab"},{"line_number":226,"context_line":"            - name: Find out the UUID of UEFI device"},{"line_number":227,"context_line":"              register: efi_dev"},{"line_number":228,"context_line":"              failed_when: false"},{"line_number":229,"context_line":"              shell: |"},{"line_number":230,"context_line":"                blkid -s UUID -o value $(blkid -t TYPE\u003dvfat | grep -i efi | cut -d \u0027:\u0027 -f1)"},{"line_number":231,"context_line":"            - name: Check if red is in efibootmgr"},{"line_number":232,"context_line":"              register: efi_broken"},{"line_number":233,"context_line":"              failed_when: false"},{"line_number":234,"context_line":"              shell: |"},{"line_number":235,"context_line":"                efibootmgr -v | grep  \u0027\\\\red\\\\\u0027"},{"line_number":236,"context_line":"            - when:"},{"line_number":237,"context_line":"                - efi.rc \u003d\u003d 0"},{"line_number":238,"context_line":"                - efi_fstab.rc \u003d\u003d 1"},{"line_number":239,"context_line":"                - efi_dev.rc \u003d\u003d 0"},{"line_number":240,"context_line":"                - efi_broken.rc \u003d\u003d 0"},{"line_number":241,"context_line":"              block:"},{"line_number":242,"context_line":"                - name: Insert /etc/fstab record"},{"line_number":243,"context_line":"                  lineinfile:"},{"line_number":244,"context_line":"                    dest: \"/etc/fstab\""},{"line_number":245,"context_line":"                    line: \"UUID\u003d{{ efi_dev.stdout }} /boot/efi vfat umask\u003d0077 0 1\""},{"line_number":246,"context_line":"                - name: Mount the /boot/efi"},{"line_number":247,"context_line":"                  command: mount /boot/efi"},{"line_number":248,"context_line":"                - name: Reinstall the grub2-efi and shim"},{"line_number":249,"context_line":"                  shell: |"},{"line_number":250,"context_line":"                    yum reinstall -y grub2-efi-x64 shim-x64"},{"line_number":251,"context_line":"                - name: Create boot record"},{"line_number":252,"context_line":"                  shell: |"},{"line_number":253,"context_line":"                    DEVICE_PATH\u003d\"$(blkid -t TYPE\u003dvfat | grep -i efi | cut -d \u0027:\u0027 -f1)\""},{"line_number":254,"context_line":"                    DEVICE\u003d\"$(lsblk -no pkname $DEVICE_PATH)\""},{"line_number":255,"context_line":"                    PARTITION\u003d\"$(echo $DEVICE_PATH | awk \u0027{print $NF}\u0027 FS\u003d/$DEVICE)\""},{"line_number":256,"context_line":"                    efibootmgr -c -L \u0027Red Hat Enterprise Linux\u0027 -d $(echo $DEVICE_PATH | sed s/$PARTITION\\$//) -p $PARTITION -l \u0027\\EFI\\redhat\\shimx64.efi\u0027"},{"line_number":257,"context_line":"                - name: Create grub config file"},{"line_number":258,"context_line":"                  command: grub2-mkconfig -o /boot/efi/EFI/redhat/grub.cfg"},{"line_number":259,"context_line":"            - name: install leapp"},{"line_number":260,"context_line":"              package:"},{"line_number":261,"context_line":"                name: leapp"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"c40a5db5_e90f7362","line":258,"range":{"start_line":215,"start_character":0,"end_line":258,"end_character":74},"updated":"2021-02-11 17:01:21.000000000","message":"All of this could be done in a single shell task or script task. Is there any advantage to having it done in so many tasks? The disadvantage here is that it\u0027s quite verbose and slow as-is.","commit_id":"76b1c977cd6965f677500a1da1ff84ebc308f79c"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"fe2989aac2afaa44bba957e97b0568bf8c61f0b8","unresolved":true,"context_lines":[{"line_number":234,"context_line":"                efibootmgr | grep \"red$\""},{"line_number":235,"context_line":"            - when:"},{"line_number":236,"context_line":"                - efi.stat.exists|bool"},{"line_number":237,"context_line":"                - efi_fstab.rc \u003d\u003d 1"},{"line_number":238,"context_line":"                - efi_dev.rc \u003d\u003d 0"},{"line_number":239,"context_line":"                - efi_broken.rc \u003d\u003d 0"},{"line_number":240,"context_line":"              block:"},{"line_number":241,"context_line":"                - name: Copy /boot/efi/EFI/redhat to /tmp"},{"line_number":242,"context_line":"                  copy:"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"ff88663b_0030bbb9","line":239,"range":{"start_line":237,"start_character":0,"end_line":239,"end_character":36},"updated":"2021-02-16 15:56:43.000000000","message":"Please add the following conditions before these: (they are needed for check mode to work):\n\n- efi_fstab.rc is defined\n- efi_dev.rc is defined\n- efi_borken.rc is defined","commit_id":"3263a7492143612589aeff52d7d90256a47cf689"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"b14e70a6122aed0ea903e5de62bef31438ea80d3","unresolved":true,"context_lines":[{"line_number":226,"context_line":"              register: efi_dev"},{"line_number":227,"context_line":"              failed_when: false"},{"line_number":228,"context_line":"              shell: |"},{"line_number":229,"context_line":"                blkid -s UUID -o value \"$(blkid -t TYPE\u003dvfat | grep -i efi | cut -d \u0027:\u0027 -f1)\""},{"line_number":230,"context_line":"            - name: Check if red is in efibootmgr"},{"line_number":231,"context_line":"              register: efi_broken"},{"line_number":232,"context_line":"              failed_when: false"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"b5d59dc3_6fa8b0be","line":229,"range":{"start_line":229,"start_character":61,"end_line":229,"end_character":91},"updated":"2021-02-19 09:04:03.000000000","message":"might be replaced by a single |awk -F \u0027:\u0027 \u0027BEGIN{IGNORECASE\u003d1} /efi/ {print $1}\u0027","commit_id":"19bb2152ffdf7aa91694dc9fdf3eb3b8a110d41b"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"b14e70a6122aed0ea903e5de62bef31438ea80d3","unresolved":true,"context_lines":[{"line_number":259,"context_line":"                    remote_src: true"},{"line_number":260,"context_line":"                - name: Create boot record"},{"line_number":261,"context_line":"                  shell: |"},{"line_number":262,"context_line":"                    DEVICE_PATH\u003d\"$(blkid -t TYPE\u003dvfat | grep -i efi | cut -d \u0027:\u0027 -f1)\""},{"line_number":263,"context_line":"                    DEVICE\u003d\"$(lsblk -no pkname $DEVICE_PATH)\""},{"line_number":264,"context_line":"                    PARTITION\u003d\"$(echo $DEVICE_PATH | awk \u0027{print $NF}\u0027 FS\u003d/$DEVICE)\""},{"line_number":265,"context_line":"                    efibootmgr -c -L \u0027Red Hat Enterprise Linux\u0027 -d $(echo $DEVICE_PATH | sed s/$PARTITION\\$//) -p $PARTITION -l \u0027\\EFI\\redhat\\shimx64.efi\u0027"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"67e0266d_e4f4a5b8","line":262,"range":{"start_line":262,"start_character":54,"end_line":262,"end_character":84},"updated":"2021-02-19 09:04:03.000000000","message":"ditto","commit_id":"19bb2152ffdf7aa91694dc9fdf3eb3b8a110d41b"}]}