)]}'
{"deployment/ceph-ansible/ceph-base.yaml":[{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"fb7b8d0f1c40c936db4b51f195d4e5d1398ad78b","unresolved":true,"context_lines":[{"line_number":764,"context_line":"              fail:"},{"line_number":765,"context_line":"                msg: The ceph-ansible filestore to bluestore playbook limit is not set; please use -e ceph_ansible_limit\u003d##nodename##"},{"line_number":766,"context_line":"              when: (ceph_ansible_limit is not defined) or (ceph_ansible_limit|length \u003d\u003d 0)"},{"line_number":767,"context_line":"            - name: ensure ceph health is OK before proceeding"},{"line_number":768,"context_line":"              import_role:"},{"line_number":769,"context_line":"                role: ceph"},{"line_number":770,"context_line":"                tasks_from: ceph-health"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"987f80c6_9cd5f055","line":767,"range":{"start_line":767,"start_character":14,"end_line":767,"end_character":62},"updated":"2021-02-15 12:26:42.000000000","message":"Thanks Giulio for this patch: this validation ensures the cluster is healthy before starting the playbook.\nAs per [1] this fails only when HEALTH \u003d\u003d ERR, warning the user when HEALTH \u003d\u003d WARN.\n\nMy question is: in a context where fs2bs is executed and acts on the osd nodes, does having additional constraints on the OSDs makes sense (e.g. having osd_percentage_min \u003e 0) ?\nThis kind of check is generic though and it works at cluster level, instead the fs2bs playbook is supposed to work node by node, and this could explain why you don\u0027t need this kind of check here.   \n\n[1] https://github.com/openstack/tripleo-validations/blob/master/roles/ceph/tasks/ceph-health.yaml#L56","commit_id":"ed8236da2308aa0f07acb49e8e4652981b581a37"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"82c2148ad0364ac6944094a3a02b4ab0b62c9405","unresolved":true,"context_lines":[{"line_number":764,"context_line":"              fail:"},{"line_number":765,"context_line":"                msg: The ceph-ansible filestore to bluestore playbook limit is not set; please use -e ceph_ansible_limit\u003d##nodename##"},{"line_number":766,"context_line":"              when: (ceph_ansible_limit is not defined) or (ceph_ansible_limit|length \u003d\u003d 0)"},{"line_number":767,"context_line":"            - name: ensure ceph health is OK before proceeding"},{"line_number":768,"context_line":"              import_role:"},{"line_number":769,"context_line":"                role: ceph"},{"line_number":770,"context_line":"                tasks_from: ceph-health"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"fd4ad3a2_5dc0a319","line":767,"range":{"start_line":767,"start_character":14,"end_line":767,"end_character":62},"in_reply_to":"987f80c6_9cd5f055","updated":"2021-02-15 14:36:38.000000000","message":"I see the existing validation is passing when HEALTH_WARN which we don\u0027t want; will work on it","commit_id":"ed8236da2308aa0f07acb49e8e4652981b581a37"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"d413c3c2d4db801602a534981d7feed12c68218c","unresolved":true,"context_lines":[{"line_number":772,"context_line":"                fail_on_ceph_health_err: true"},{"line_number":773,"context_line":"                fail_on_ceph_health_warn: true"},{"line_number":774,"context_line":"                osd_percentage_min: 0"},{"line_number":775,"context_line":"                tripleo_delegate_to: \"{{ groups[\u0027ceph_mon\u0027] | default([]) }}\""},{"line_number":776,"context_line":"              tags:"},{"line_number":777,"context_line":"                - ceph_health"},{"line_number":778,"context_line":"            - name: set ceph_ansible_playbooks_default"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"621d1c62_b0d4da87","line":775,"updated":"2021-02-15 16:24:44.000000000","message":"If this run with --limit ceph-storage-0 will it be able to delegate to the mon?","commit_id":"eb6a52cf32ce0aabf69f2922f4244eada82557d7"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"384a998f20c18ba03ab3e608093a3033f8662238","unresolved":true,"context_lines":[{"line_number":772,"context_line":"                fail_on_ceph_health_err: true"},{"line_number":773,"context_line":"                fail_on_ceph_health_warn: true"},{"line_number":774,"context_line":"                osd_percentage_min: 0"},{"line_number":775,"context_line":"                tripleo_delegate_to: \"{{ groups[\u0027ceph_mon\u0027] | default([]) }}\""},{"line_number":776,"context_line":"              tags:"},{"line_number":777,"context_line":"                - ceph_health"},{"line_number":778,"context_line":"            - name: set ceph_ansible_playbooks_default"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7f2b8d73_8b383b1b","line":775,"in_reply_to":"582be281_138b626e","updated":"2021-02-16 07:25:17.000000000","message":"Let\u0027s see CI and how the tests go, then we should be able to easily review this change.","commit_id":"eb6a52cf32ce0aabf69f2922f4244eada82557d7"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"7fe5fa6d222145ffe1838645b7a20b9b87567989","unresolved":true,"context_lines":[{"line_number":772,"context_line":"                fail_on_ceph_health_err: true"},{"line_number":773,"context_line":"                fail_on_ceph_health_warn: true"},{"line_number":774,"context_line":"                osd_percentage_min: 0"},{"line_number":775,"context_line":"                tripleo_delegate_to: \"{{ groups[\u0027ceph_mon\u0027] | default([]) }}\""},{"line_number":776,"context_line":"              tags:"},{"line_number":777,"context_line":"                - ceph_health"},{"line_number":778,"context_line":"            - name: set ceph_ansible_playbooks_default"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"582be281_138b626e","line":775,"in_reply_to":"621d1c62_b0d4da87","updated":"2021-02-15 17:03:14.000000000","message":"AFAICT it should run for ceph-storage-0 but connect to the mon.","commit_id":"eb6a52cf32ce0aabf69f2922f4244eada82557d7"}]}