)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"303844effed7d8abd6e01e158a3e3cfada530949","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add ports filtering support to XtremIO Cinder driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If there are some iSCSI or FC targets (ESXi for example) that"},{"line_number":10,"context_line":"are not connected to the OpenStack host,"},{"line_number":11,"context_line":"attach volume operation waits until timeout."},{"line_number":12,"context_line":"The XtremIO Cinder driver needs a new option to support ports"},{"line_number":13,"context_line":"filtering."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Depends-On: https://review.opendev.org/#/c/776264"},{"line_number":16,"context_line":"Related-Bug: #1915800"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"993eb2eb_075fa01b","line":13,"range":{"start_line":9,"start_character":0,"end_line":13,"end_character":10},"updated":"2021-02-18 16:58:17.000000000","message":"maybe something more specific to tripleo-heat-templates","commit_id":"e0adf10564209e75d02d9a9ceb43d58b69c96d51"}],"deployment/cinder/cinder-backend-dellemc-xtremio-iscsi-puppet.yaml":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"03647f057713c4f42ad2a3c906b59052670c0794","unresolved":true,"context_lines":[{"line_number":59,"context_line":"    type: string"},{"line_number":60,"context_line":"    default: \u0027\u0027"},{"line_number":61,"context_line":"    description: Allowed ports. Comma separated list of XtremIO"},{"line_number":62,"context_line":"                 iSCSI IPs or FC WWNs (ex. 58:cc:f0:98:49:22:07:02)"},{"line_number":63,"context_line":"                 to be used. If option is not set all ports are allowed."},{"line_number":64,"context_line":"  ServiceData:"},{"line_number":65,"context_line":"    default: {}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ac9f20b2_a8c45267","line":62,"updated":"2021-03-03 19:06:18.000000000","message":"nit: This THT specifically supports iSCSI only, so the description probably should not even mention FC. The other template\u0027s CinderXtremioPorts description correctly mentions both protocols.","commit_id":"e0adf10564209e75d02d9a9ceb43d58b69c96d51"},{"author":{"_account_id":31016,"name":"Ivan Pchelintsev","email":"i.pchelintsev@yadro.com","username":"pcheli"},"change_message_id":"386a3addd67996a0e14cf818fb74359cc39e2613","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    type: string"},{"line_number":60,"context_line":"    default: \u0027\u0027"},{"line_number":61,"context_line":"    description: Allowed ports. Comma separated list of XtremIO"},{"line_number":62,"context_line":"                 iSCSI IPs or FC WWNs (ex. 58:cc:f0:98:49:22:07:02)"},{"line_number":63,"context_line":"                 to be used. If option is not set all ports are allowed."},{"line_number":64,"context_line":"  ServiceData:"},{"line_number":65,"context_line":"    default: {}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"93e3b271_0a84e4bb","line":62,"in_reply_to":"ac9f20b2_a8c45267","updated":"2021-03-03 20:03:08.000000000","message":"I don\u0027t think we need to change it now.\nThis file is deprecated and will be removed in another patch.","commit_id":"e0adf10564209e75d02d9a9ceb43d58b69c96d51"}],"deployment/cinder/cinder-backend-dellemc-xtremio-puppet.yaml":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"03647f057713c4f42ad2a3c906b59052670c0794","unresolved":true,"context_lines":[{"line_number":68,"context_line":"      - allowed_values: [ \u0027iSCSI\u0027, \u0027FC\u0027]"},{"line_number":69,"context_line":"  CinderXtremioPorts:"},{"line_number":70,"context_line":"    type: string"},{"line_number":71,"context_line":"    default: \u0027\u0027"},{"line_number":72,"context_line":"    description: Allowed ports. Comma separated list of XtremIO"},{"line_number":73,"context_line":"                 iSCSI IPs or FC WWNs (ex. 58:cc:f0:98:49:22:07:02)"},{"line_number":74,"context_line":"                 to be used. If option is not set all ports are allowed."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa69bc8_4a10f412","line":71,"updated":"2021-03-03 19:06:18.000000000","message":"I believe this empty string will ultimately be passed on to the corresponding puppet-cinder parameter. You should check and see how this lands in cinder.conf, and whether an empty value is functionally equivalent to *not* setting any value.\n\nIf there is an issue with the cinder driver encountering an empty value, then you may need to add a conditional like the one at L119..122","commit_id":"e0adf10564209e75d02d9a9ceb43d58b69c96d51"},{"author":{"_account_id":31016,"name":"Ivan Pchelintsev","email":"i.pchelintsev@yadro.com","username":"pcheli"},"change_message_id":"386a3addd67996a0e14cf818fb74359cc39e2613","unresolved":true,"context_lines":[{"line_number":68,"context_line":"      - allowed_values: [ \u0027iSCSI\u0027, \u0027FC\u0027]"},{"line_number":69,"context_line":"  CinderXtremioPorts:"},{"line_number":70,"context_line":"    type: string"},{"line_number":71,"context_line":"    default: \u0027\u0027"},{"line_number":72,"context_line":"    description: Allowed ports. Comma separated list of XtremIO"},{"line_number":73,"context_line":"                 iSCSI IPs or FC WWNs (ex. 58:cc:f0:98:49:22:07:02)"},{"line_number":74,"context_line":"                 to be used. If option is not set all ports are allowed."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bcab6e3d_88146936","line":71,"in_reply_to":"3fa69bc8_4a10f412","updated":"2021-03-03 20:03:08.000000000","message":"I\u0027ve tested driver with xtremio_ports set to empty value in cinder.conf and \nwithout xtremio_ports in config. \nI\u0027ve added additional log message to check that value is the same.\n19:54:41 u20 cinder-volume[3429162]: INFO cinder.volume.drivers.dell_emc.xtremio [None req-c433ab86-2a7a-4214-a304-a92b1fd267f9 None None] xtremio ports: []\n19:56:43 u20 cinder-volume[3430673]: INFO cinder.volume.drivers.dell_emc.xtremio [None req-a3642f8d-b6b3-4977-9626-9d39e37c166d None None] xtremio ports: []","commit_id":"e0adf10564209e75d02d9a9ceb43d58b69c96d51"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"9aa4414ccb50234c581f2feeff48c210ac2e7b8e","unresolved":false,"context_lines":[{"line_number":68,"context_line":"      - allowed_values: [ \u0027iSCSI\u0027, \u0027FC\u0027]"},{"line_number":69,"context_line":"  CinderXtremioPorts:"},{"line_number":70,"context_line":"    type: string"},{"line_number":71,"context_line":"    default: \u0027\u0027"},{"line_number":72,"context_line":"    description: Allowed ports. Comma separated list of XtremIO"},{"line_number":73,"context_line":"                 iSCSI IPs or FC WWNs (ex. 58:cc:f0:98:49:22:07:02)"},{"line_number":74,"context_line":"                 to be used. If option is not set all ports are allowed."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"392a0fdb_ae3e60d1","line":71,"in_reply_to":"bcab6e3d_88146936","updated":"2021-03-03 20:17:17.000000000","message":"Great, thanks for confirming it works as desired.","commit_id":"e0adf10564209e75d02d9a9ceb43d58b69c96d51"}]}