)]}'
{"deployment/deprecated/novajoin/novajoin-container-puppet.yaml":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"de79a3b2790d67f8eb1120a670de830cad2a9ebf","unresolved":true,"context_lines":[{"line_number":239,"context_line":"        - name: Ensure openssl-perl package is present on RHEL8"},{"line_number":240,"context_line":"          when:"},{"line_number":241,"context_line":"            - ansible_facts[\u0027os_family\u0027] \u003d\u003d \u0027RedHat\u0027"},{"line_number":242,"context_line":"            - ansible_facts[\u0027distribution_major_version\u0027] is version(\u00278\u0027, \u0027\u003d\u003d)"},{"line_number":243,"context_line":"          package:"},{"line_number":244,"context_line":"            name: openssl-perl"},{"line_number":245,"context_line":"            state: present"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"6360f50e_bd37e101","line":242,"range":{"start_line":242,"start_character":74,"end_line":242,"end_character":77},"updated":"2021-02-22 12:16:50.000000000","message":"this doesn\u0027t look correct?","commit_id":"2b2f00d9e430548b5047ca2c8868f389d1c29404"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"0833aeab904626a77c05c7ac3f6ffb219bda7c84","unresolved":false,"context_lines":[{"line_number":239,"context_line":"        - name: Ensure openssl-perl package is present on RHEL8"},{"line_number":240,"context_line":"          when:"},{"line_number":241,"context_line":"            - ansible_facts[\u0027os_family\u0027] \u003d\u003d \u0027RedHat\u0027"},{"line_number":242,"context_line":"            - ansible_facts[\u0027distribution_major_version\u0027] is version(\u00278\u0027, \u0027\u003d\u003d)"},{"line_number":243,"context_line":"          package:"},{"line_number":244,"context_line":"            name: openssl-perl"},{"line_number":245,"context_line":"            state: present"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"2c36e7a7_8d0d2cfa","line":242,"range":{"start_line":242,"start_character":74,"end_line":242,"end_character":77},"in_reply_to":"6360f50e_bd37e101","updated":"2021-02-22 14:36:10.000000000","message":"Ack","commit_id":"2b2f00d9e430548b5047ca2c8868f389d1c29404"}],"deployment/octavia/octavia-worker-container-puppet.yaml":[{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"5c654a70438745fefcc4f08cb38d3357f8c23270","unresolved":true,"context_lines":[{"line_number":156,"context_line":"                  - python3-openstackclient"},{"line_number":157,"context_line":"                  - openssl"},{"line_number":158,"context_line":"                state: present"},{"line_number":159,"context_line":"              when: ansible__facts[\u0027distribution_major_version\u0027] is version(8, \u0027\u003e\u003d\u0027)"},{"line_number":160,"context_line":"          when: {get_param: EnablePackageInstall}"},{"line_number":161,"context_line":"        - name: enable virt_sandbox_use_netlink for healthcheck"},{"line_number":162,"context_line":"          seboolean:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"f061f836_5bf7e9cd","line":159,"range":{"start_line":159,"start_character":27,"end_line":159,"end_character":28},"updated":"2021-02-24 10:23:43.000000000","message":"extra","commit_id":"8d1fc85744f6a17415ce8e57afd4e8f1a1f7c922"}],"deployment/swift/swift-storage-container-puppet.yaml":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"1b9fbd30a8617db763dcf41dbfa8d9f54d742716","unresolved":true,"context_lines":[{"line_number":628,"context_line":"              - \u0027!all\u0027"},{"line_number":629,"context_line":"              - \u0027!min\u0027"},{"line_number":630,"context_line":"              - \u0027hardware\u0027"},{"line_number":631,"context_line":"            filter: \u0027ansible_device_links\u0027"},{"line_number":632,"context_line":"          when: swift_raw_disks|length \u003e 0"},{"line_number":633,"context_line":"        - name: Mount devices defined in SwiftRawDisks"},{"line_number":634,"context_line":"          mount:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"a64f5c72_56a9abd0","line":631,"updated":"2021-02-22 12:20:31.000000000","message":"could you please put this into a separate change?\nI\u0027m also not sure if ansible_device_links is the right filter after we change it to device_links in ansible_facts dict?","commit_id":"2b2f00d9e430548b5047ca2c8868f389d1c29404"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"0833aeab904626a77c05c7ac3f6ffb219bda7c84","unresolved":true,"context_lines":[{"line_number":628,"context_line":"              - \u0027!all\u0027"},{"line_number":629,"context_line":"              - \u0027!min\u0027"},{"line_number":630,"context_line":"              - \u0027hardware\u0027"},{"line_number":631,"context_line":"            filter: \u0027ansible_device_links\u0027"},{"line_number":632,"context_line":"          when: swift_raw_disks|length \u003e 0"},{"line_number":633,"context_line":"        - name: Mount devices defined in SwiftRawDisks"},{"line_number":634,"context_line":"          mount:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"32a83244_9b845967","line":631,"in_reply_to":"a64f5c72_56a9abd0","updated":"2021-02-22 14:36:10.000000000","message":"There are already too many patches that i\u0027m going to have to backport. I\u0027d prefer not to split this one out since it\u0027s directly related to L636. I also tested the filter. When you filter you have to use the ansible_ version for whatever reason.\n\n- hosts: localhost\n  gather_facts: false\n  tasks:\n    - name: get facts\n      setup:\n        gather_subset:\n          - \u0027!all\u0027\n          - min\n        filter: \u0027device_links\u0027\n    - name: \"ansible_fact[\u0027device_links\u0027]\"\n      debug:\n        var: ansible_facts[\u0027device_links\u0027]\n    - name: get devices\n      setup:\n        gather_subset:\n          - \u0027!all\u0027\n          - devices\n        filter: \u0027ansible_device_links\u0027\n    - name: \"ansible_fact[\u0027device_links\u0027]\"\n      debug:\n        var: ansible_facts[\u0027device_links\u0027]\n\n\nPLAY [localhost] *****************************************************************************************************\n\nTASK [get facts] *****************************************************************************************************\nok: [localhost]\n\nTASK [ansible_fact[\u0027device_links\u0027]] **********************************************************************************\nok: [localhost] \u003d\u003e {\n    \"ansible_facts[\u0027device_links\u0027]\": \"VARIABLE IS NOT DEFINED!\"\n}\n\nTASK [get devices] ***************************************************************************************************\nok: [localhost]\n\nTASK [ansible_fact[\u0027device_links\u0027]] **********************************************************************************\nok: [localhost] \u003d\u003e {\n    \"ansible_facts[\u0027device_links\u0027]\": {\n...SNIP...\n    }\n}","commit_id":"2b2f00d9e430548b5047ca2c8868f389d1c29404"}]}