)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"52e2e1118369e281714a85e0d4335a1d12fca87a","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     ramishra \u003cramishra@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-02-24 09:40:34 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove default plan-environment.yaml"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Left the one used for derive parameters that includes"},{"line_number":10,"context_line":"the playbooks for derive parameters."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"089d558b_b34a9314","line":7,"range":{"start_line":7,"start_character":15,"end_line":7,"end_character":31},"updated":"2021-03-04 07:27:56.000000000","message":"lets remove that too ? https://opendev.org/openstack/tripleo-heat-templates/src/commit/d56a191590b669249569e01d8507b00849c85fb4/plan-samples/README.rst","commit_id":"147335f79983d34e7decab4be1fa98d44e120447"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"dac06f9b7df6e0c71ade7023665056fbfa236af2","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     ramishra \u003cramishra@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-02-24 09:40:34 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove default plan-environment.yaml"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Left the one used for derive parameters that includes"},{"line_number":10,"context_line":"the playbooks for derive parameters."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"aa040f82_330dda9f","line":7,"range":{"start_line":7,"start_character":15,"end_line":7,"end_character":31},"in_reply_to":"089d558b_b34a9314","updated":"2021-03-04 07:35:40.000000000","message":"Nope, it\u0027s still used by derive parameters, so we should leave it around. But it seems that\u0027s not updated since we moved to use playbooks.","commit_id":"147335f79983d34e7decab4be1fa98d44e120447"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"f0b3f94d15ccdafe11a20ff50cbde8486e9c9152","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     ramishra \u003cramishra@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-02-24 09:40:34 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove default plan-environment.yaml"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Left the one used for derive parameters that includes"},{"line_number":10,"context_line":"the playbooks for derive parameters."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"8ead6ec9_440fc768","line":7,"range":{"start_line":7,"start_character":15,"end_line":7,"end_character":31},"in_reply_to":"aa040f82_330dda9f","updated":"2021-03-04 08:12:30.000000000","message":"we really should update it then and remove any references to the file we are removing here it literally starts with \"The plan-environment.yaml file\"\n\nfine as a followup if you prefer that","commit_id":"147335f79983d34e7decab4be1fa98d44e120447"}],"plan-environment.yaml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"52e2e1118369e281714a85e0d4335a1d12fca87a","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"78ec5aa6_a03cc687","side":"PARENT","updated":"2021-03-04 07:27:56.000000000","message":"looks like we should reach out to the folks working @ tripleo-validations i still see a few places explicitly referencing it via hound [1]\n\nlooks like there is a constant @ https://opendev.org/openstack/tripleo-common/src/commit/6e40cc707155a58e09acf6060335746b4f37273e/tripleo_common/constants.py#L172 which we should remove too?\n\ndocs are really a mess so won\u0027t block on it but we should also update those at some point too \n\n\n\n[1] https://codesearch.opendev.org/?q\u003dplan-environment.yaml\u0026repos\u003dopenstack/tripleo-ansible,openstack/tripleo-ci,openstack/tripleo-common,openstack/tripleo-common-tempest-plugin,openstack/tripleo-docs,openstack/tripleo-ha-utils,openstack/tripleo-heat-templates,openstack/tripleo-image-elements,openstack/tripleo-ipsec,openstack/tripleo-operator-ansible,openstack/tripleo-puppet-elements,openstack/tripleo-quickstart,openstack/tripleo-quickstart-extras,openstack/tripleo-repos,openstack/tripleo-specs,openstack/tripleo-upgrade,openstack/tripleo-validations,openstack/python-tripleoclient,openstack/puppet-tripleo","commit_id":"72b60678e0226ef31cb59c4f9cae33fb6e25360a"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"f0b3f94d15ccdafe11a20ff50cbde8486e9c9152","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c8274f8d_ef51f94c","side":"PARENT","in_reply_to":"09c68858_760a619e","updated":"2021-03-04 08:12:30.000000000","message":"OK i was mainly concerned that the validations folks should know about this change and make sure we aren\u0027t breaking something - via irc Gael and Cedric have had a look so we should be OK sounds like some of those are old and need updating\n\nit would be good to remove that constant in tripleo-common too and there is some more cleanup needed generally there see https://opendev.org/openstack/tripleo-common/src/commit/6e40cc707155a58e09acf6060335746b4f37273e/tripleo_common/utils/plan.py","commit_id":"72b60678e0226ef31cb59c4f9cae33fb6e25360a"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"dac06f9b7df6e0c71ade7023665056fbfa236af2","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"09c68858_760a619e","side":"PARENT","in_reply_to":"78ec5aa6_a03cc687","updated":"2021-03-04 07:35:40.000000000","message":"I don\u0027t know why validations using plan-environment.yaml, it should not.. Anyway that can be changed later I guess.","commit_id":"72b60678e0226ef31cb59c4f9cae33fb6e25360a"}]}
