)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"aa54036ba9cc4ceeb64f5b255c225fe85cd5550b","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"These are default roles and we don\u0027t need to create them for"},{"line_number":10,"context_line":"ceph. Also swift user does not need admin role."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I4d4c01d4ace8c51ae9f47f4dafd76bb3b5ed674f"},{"line_number":13,"context_line":"Related: https://bugzilla.redhat.com/show_bug.cgi?id\u003d1932208"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"16fda174_57a85ad3","line":11,"updated":"2021-02-24 13:26:42.000000000","message":"To ease backporting we can add\n\nCloses-Bug: 1916756","commit_id":"281d9193743ea2043a419a598d054c421c6b3819"}],"deployment/ceph-ansible/ceph-rgw.yaml":[{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"4fb910076dddd6ba5cad4cc48e9f986abb79652b","unresolved":true,"context_lines":[{"line_number":127,"context_line":"          users:"},{"line_number":128,"context_line":"            swift:"},{"line_number":129,"context_line":"              password: {get_param: SwiftPassword}"},{"line_number":130,"context_line":"              roles:"},{"line_number":131,"context_line":"                - admin"},{"line_number":132,"context_line":"                - member"},{"line_number":133,"context_line":"          region: {get_param: KeystoneRegion}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7853dbd1_6abb9151","side":"PARENT","line":130,"updated":"2021-02-24 11:43:37.000000000","message":"@giulio @john, since these roles are not used [1], can we assume this is legacy code that can just be removed?\n\n[1] https://github.com/openstack/tripleo-heat-templates/blob/master/deployment/swift/swift-proxy-container-puppet.yaml#L136-L142","commit_id":"9790824f576fad5d9fe398e73b5238837194d399"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"042a05125042b187269dedc188e8551eefabaa15","unresolved":true,"context_lines":[{"line_number":127,"context_line":"          users:"},{"line_number":128,"context_line":"            swift:"},{"line_number":129,"context_line":"              password: {get_param: SwiftPassword}"},{"line_number":130,"context_line":"              roles:"},{"line_number":131,"context_line":"                - admin"},{"line_number":132,"context_line":"                - member"},{"line_number":133,"context_line":"          region: {get_param: KeystoneRegion}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"245ae2f7_f6e628b7","side":"PARENT","line":130,"in_reply_to":"1b56c3bf_0ad90999","updated":"2021-02-24 13:08:50.000000000","message":"yeah that\u0027s correct.\n\nreg, rgw_keystone_accepted_roles (though I don\u0027t how it works with ceph),  does not seem to be related to swift user, rather rgw users and their roles(?).","commit_id":"9790824f576fad5d9fe398e73b5238837194d399"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"7ca6079839bc05fe0636c36ad44a0e8f1c076498","unresolved":true,"context_lines":[{"line_number":127,"context_line":"          users:"},{"line_number":128,"context_line":"            swift:"},{"line_number":129,"context_line":"              password: {get_param: SwiftPassword}"},{"line_number":130,"context_line":"              roles:"},{"line_number":131,"context_line":"                - admin"},{"line_number":132,"context_line":"                - member"},{"line_number":133,"context_line":"          region: {get_param: KeystoneRegion}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"63f8b9b0_d8ff83db","side":"PARENT","line":130,"in_reply_to":"245ae2f7_f6e628b7","updated":"2021-02-24 13:38:10.000000000","message":"that\u0027s the list of allowed roles for RGW, not Swift related","commit_id":"9790824f576fad5d9fe398e73b5238837194d399"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"c7fa3515a0a2c33d34a01e810f427d3928e03d36","unresolved":true,"context_lines":[{"line_number":127,"context_line":"          users:"},{"line_number":128,"context_line":"            swift:"},{"line_number":129,"context_line":"              password: {get_param: SwiftPassword}"},{"line_number":130,"context_line":"              roles:"},{"line_number":131,"context_line":"                - admin"},{"line_number":132,"context_line":"                - member"},{"line_number":133,"context_line":"          region: {get_param: KeystoneRegion}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1b56c3bf_0ad90999","side":"PARENT","line":130,"in_reply_to":"7853dbd1_6abb9151","updated":"2021-02-24 12:55:40.000000000","message":"I think this is meant to avoid the role from being forcibly created by the module, the role  will be created on keystone init instead so it will continue to be used as per [1]\n\nRabi if my understanding is correct, please ack it so we can merge this!\n\nThanks\n\n1. https://github.com/openstack/tripleo-heat-templates/blob/stable/train/deployment/ceph-ansible/ceph-rgw.yaml#L98","commit_id":"9790824f576fad5d9fe398e73b5238837194d399"}]}