)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"47f7eb79e00a5181c2796777ee83a0bcb7b53a16","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Grzegorz Grasza \u003cxek@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-02-25 16:55:50 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Enable fernet token cache by default"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Enables fernet token cache if Memcached TLS is enabled."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fac91daa_e4242480","line":7,"range":{"start_line":7,"start_character":29,"end_line":7,"end_character":36},"updated":"2021-03-02 13:34:59.000000000","message":"nit: We\u0027re only enabling this for deployments using TLS-e, right? We\u0027re not enabling this for all deployments are well?","commit_id":"afffd26624b6b1aa8e47e20bcdd8bc3e20769453"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"411de20e8f2e668bbb6bfb423ad508472611173c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Grzegorz Grasza \u003cxek@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-02-25 16:55:50 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Enable fernet token cache by default"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Enables fernet token cache if Memcached TLS is enabled."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"d7af2a38_f72a214d","line":7,"range":{"start_line":7,"start_character":29,"end_line":7,"end_character":36},"in_reply_to":"d66bddc6_12dba2b7","updated":"2021-03-15 20:54:45.000000000","message":"Ok - cool. The wording of the commit message title makes it seem like we\u0027re turning this on for all deployments by default.","commit_id":"afffd26624b6b1aa8e47e20bcdd8bc3e20769453"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"1f97ada5cd642febff7abbf8ab48998e6dbd498d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Grzegorz Grasza \u003cxek@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-02-25 16:55:50 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Enable fernet token cache by default"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Enables fernet token cache if Memcached TLS is enabled."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"d66bddc6_12dba2b7","line":7,"range":{"start_line":7,"start_character":29,"end_line":7,"end_character":36},"in_reply_to":"fac91daa_e4242480","updated":"2021-03-15 08:51:00.000000000","message":"That\u0027s right, see below.","commit_id":"afffd26624b6b1aa8e47e20bcdd8bc3e20769453"}],"deployment/keystone/keystone-container-puppet.yaml":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"fa591dac6c28c15b90a5cebb6eb88560660c9d47","unresolved":true,"context_lines":[{"line_number":497,"context_line":"            if:"},{"line_number":498,"context_line":"            - tls_cache_enabled"},{"line_number":499,"context_line":"            - keystone::cache::backend: \u0027dogpile.cache.pymemcache\u0027"},{"line_number":500,"context_line":"              keystone::token_caching: true"},{"line_number":501,"context_line":"            - keystone::cache::backend: \u0027dogpile.cache.memcached\u0027"},{"line_number":502,"context_line":"          -"},{"line_number":503,"context_line":"            if:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"c8e593f9_01dfc2bd","line":500,"range":{"start_line":500,"start_character":14,"end_line":500,"end_character":43},"updated":"2021-10-07 09:32:01.000000000","message":"this puppet parameter does not exist. It should be keystone::cache::token_caching.\n\nAlso, token_caching is enabled by default. I don\u0027t see any clear reason why we need to define the parameter to enable it.\nIf caching token without tls is considered to be risky then we can disable it when tls is disabled. But based on my past experience disabling token cache results in huge performance degradation with fernet token.","commit_id":"b6ae699567b09eb0c2789883e0823839e1cedc81"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"142a53ce62a668e1711ca1202aab381ca52164c3","unresolved":false,"context_lines":[{"line_number":497,"context_line":"            if:"},{"line_number":498,"context_line":"            - tls_cache_enabled"},{"line_number":499,"context_line":"            - keystone::cache::backend: \u0027dogpile.cache.pymemcache\u0027"},{"line_number":500,"context_line":"              keystone::token_caching: true"},{"line_number":501,"context_line":"            - keystone::cache::backend: \u0027dogpile.cache.memcached\u0027"},{"line_number":502,"context_line":"          -"},{"line_number":503,"context_line":"            if:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"89fe9e5a_80573df6","line":500,"range":{"start_line":500,"start_character":14,"end_line":500,"end_character":43},"in_reply_to":"c8e593f9_01dfc2bd","updated":"2021-10-12 14:58:30.000000000","message":"Ack, so looks like we can just revert this patch.","commit_id":"b6ae699567b09eb0c2789883e0823839e1cedc81"}]}