)]}'
{"deployment/nova/nova-migration-target-container-puppet.yaml":[{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"ff61c38362157bd61263f746f5e42ebf48c074f0","unresolved":true,"context_lines":[{"line_number":113,"context_line":"                template:"},{"line_number":114,"context_line":"                  \"%{hiera(\u0027$NETWORK\u0027)}\""},{"line_number":115,"context_line":"                params:"},{"line_number":116,"context_line":"                  $NETWORK: {get_param: [ServiceNetMap, NovaLibvirtNetwork]}"},{"line_number":117,"context_line":"            tripleo::profile::base::sshd::port:"},{"line_number":118,"context_line":"              - 22"},{"line_number":119,"context_line":"      puppet_config:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ea2b838a_105b9334","line":116,"range":{"start_line":116,"start_character":56,"end_line":116,"end_character":74},"updated":"2021-03-11 10:19:49.000000000","message":"I expect this needs to be the same as nova::my_ip so NovaApiNetwork","commit_id":"7ea9057f9c385929b9e658b03b7d772cd16b982b"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"5ca2fc541080432fc8cf7129c4898440a2eeb096","unresolved":true,"context_lines":[{"line_number":113,"context_line":"                template:"},{"line_number":114,"context_line":"                  \"%{hiera(\u0027$NETWORK\u0027)}\""},{"line_number":115,"context_line":"                params:"},{"line_number":116,"context_line":"                  $NETWORK: {get_param: [ServiceNetMap, NovaLibvirtNetwork]}"},{"line_number":117,"context_line":"            tripleo::profile::base::sshd::port:"},{"line_number":118,"context_line":"              - 22"},{"line_number":119,"context_line":"      puppet_config:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"d906efc7_6dab92c0","line":116,"range":{"start_line":116,"start_character":56,"end_line":116,"end_character":74},"in_reply_to":"ea2b838a_105b9334","updated":"2021-03-11 13:27:38.000000000","message":"correct, col_migration needs to match nova::my_ip. the live_migration is used by nova_libvirt container to ssh.","commit_id":"7ea9057f9c385929b9e658b03b7d772cd16b982b"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"11d785bdb95c70adadc4dacaf9c7492384b19fbc","unresolved":true,"context_lines":[{"line_number":101,"context_line":"                template:"},{"line_number":102,"context_line":"                  \"%{hiera(\u0027$NETWORK\u0027)}\""},{"line_number":103,"context_line":"                params:"},{"line_number":104,"context_line":"                  $NETWORK: {get_param: [ServiceNetMap, NovaLibvirtNetwork]}"},{"line_number":105,"context_line":"            cold_migration_ssh_inbound_addr:"},{"line_number":106,"context_line":"              str_replace:"},{"line_number":107,"context_line":"                template:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"fe769f10_7f8892e0","line":104,"updated":"2021-03-11 15:11:18.000000000","message":"need to match nova::migration::libvirt::live_migration_inbound_addr from nova-libvirt-container-puppet\nhttps://github.com/openstack/tripleo-heat-templates/blob/master/deployment/nova/nova-libvirt-container-puppet.yaml#L459-L464","commit_id":"352f75f166b52a03b0f40622dcb7237cbdf0172e"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"52d4bbb26f90b74189ac673f378ad2cb5dcdbb30","unresolved":true,"context_lines":[{"line_number":101,"context_line":"                template:"},{"line_number":102,"context_line":"                  \"%{hiera(\u0027$NETWORK\u0027)}\""},{"line_number":103,"context_line":"                params:"},{"line_number":104,"context_line":"                  $NETWORK: {get_param: [ServiceNetMap, NovaLibvirtNetwork]}"},{"line_number":105,"context_line":"            cold_migration_ssh_inbound_addr:"},{"line_number":106,"context_line":"              str_replace:"},{"line_number":107,"context_line":"                template:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"84315ec1_51acf5a4","line":104,"range":{"start_line":104,"start_character":56,"end_line":104,"end_character":74},"updated":"2021-03-15 14:24:07.000000000","message":"Previous value looks wrong indeed. This should be the same as nova::migration::libvirt::live_migration_inbound_addr which is set to NovaLibvirtNetwork.","commit_id":"dadf71fcae73825888b8ed4850de5a6ecf2fc29d"}]}