)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"b2c38d4ae981760e6f6970bc2fd18eddf7678267","unresolved":true,"context_lines":[{"line_number":9,"context_line":"Set up tag hints on all OS::Neutron::Port resources."},{"line_number":10,"context_line":"With all resources tagged heat plug-in to handle"},{"line_number":11,"context_line":"ephemeral \u0027create\u0027 always heat can be introduced."},{"line_number":12,"context_line":"See: https://review.opendev.org/778786"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Partial-Implements: blueprint network-data-v2-ports"},{"line_number":15,"context_line":"Change-Id: I3d43ae22cc45e5528ecfb1a6b2cb8602faa162a0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"b871be68_58ecdff1","line":12,"range":{"start_line":12,"start_character":5,"end_line":12,"end_character":38},"updated":"2021-03-17 07:24:27.000000000","message":"this is abandoned - update if there is a newer one or remove?","commit_id":"e883f9c2fb3cb08ac6e20a69bc67cdf4926179b2"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"7ebe985fded869efbf324e7bfb1c9e1df6d30e89","unresolved":true,"context_lines":[{"line_number":9,"context_line":"Set up tag hints on all OS::Neutron::Port resources."},{"line_number":10,"context_line":"With all resources tagged heat plug-in to handle"},{"line_number":11,"context_line":"ephemeral \u0027create\u0027 always heat can be introduced."},{"line_number":12,"context_line":"See: https://review.opendev.org/778786"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Partial-Implements: blueprint network-data-v2-ports"},{"line_number":15,"context_line":"Change-Id: I3d43ae22cc45e5528ecfb1a6b2cb8602faa162a0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"11efa387_a56082cc","line":12,"range":{"start_line":12,"start_character":5,"end_line":12,"end_character":38},"in_reply_to":"b871be68_58ecdff1","updated":"2021-03-17 08:24:51.000000000","message":"I\u0027ve updated the commit message to make better sense. The heat plug-in idea wouldn\u0027t work with ephemeral heat.\nAdding the tags, and probably backporting all the THT changes adding tags makes sense to ease migration/upgrade.","commit_id":"e883f9c2fb3cb08ac6e20a69bc67cdf4926179b2"}],"deployed-server/ctlplane-port.yaml":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"354459bbf9d3bd4188059049cf837f2fbaa6f23b","unresolved":true,"context_lines":[{"line_number":38,"context_line":"      replacement_policy: AUTO"},{"line_number":39,"context_line":"      tags:"},{"line_number":40,"context_line":"        - str_replace:"},{"line_number":41,"context_line":"            template: triple_ctlplane_port_name\u003d$PORT_NAME"},{"line_number":42,"context_line":"            params:"},{"line_number":43,"context_line":"              $PORT_NAME:"},{"line_number":44,"context_line":"                list_join:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"2b41a70c_b8088b4b","line":41,"range":{"start_line":41,"start_character":22,"end_line":41,"end_character":28},"updated":"2021-03-05 18:12:17.000000000","message":"tripleo?","commit_id":"8cd3ad614a63bfb872ff9585080442254b2d22e6"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"6e8121a44b037ced7a5123b33bf47d3405471a99","unresolved":false,"context_lines":[{"line_number":38,"context_line":"      replacement_policy: AUTO"},{"line_number":39,"context_line":"      tags:"},{"line_number":40,"context_line":"        - str_replace:"},{"line_number":41,"context_line":"            template: triple_ctlplane_port_name\u003d$PORT_NAME"},{"line_number":42,"context_line":"            params:"},{"line_number":43,"context_line":"              $PORT_NAME:"},{"line_number":44,"context_line":"                list_join:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"b808e200_0c132f79","line":41,"range":{"start_line":41,"start_character":22,"end_line":41,"end_character":28},"in_reply_to":"2b41a70c_b8088b4b","updated":"2021-03-05 18:56:06.000000000","message":"Done","commit_id":"8cd3ad614a63bfb872ff9585080442254b2d22e6"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"5420f11f70be53c28c4512afc767101e88640776","unresolved":true,"context_lines":[{"line_number":38,"context_line":"      replacement_policy: AUTO"},{"line_number":39,"context_line":"      tags:"},{"line_number":40,"context_line":"        - str_replace:"},{"line_number":41,"context_line":"            template: tripleo_ctlplane_port_name\u003d$PORT_NAME"},{"line_number":42,"context_line":"            params:"},{"line_number":43,"context_line":"              $PORT_NAME:"},{"line_number":44,"context_line":"                list_join:"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"eecf2e9c_fbcde0a2","line":41,"range":{"start_line":41,"start_character":22,"end_line":41,"end_character":59},"updated":"2021-04-12 07:39:33.000000000","message":"Can we not fetch it from the stack (if exists) rather than maintaining these specific naming convention in the tags?","commit_id":"28af0094dbfdecca4f5718e2f059e8a2889d5b2b"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"ddb93de644e099a91fce279a46124aa146d46e0b","unresolved":true,"context_lines":[{"line_number":38,"context_line":"      replacement_policy: AUTO"},{"line_number":39,"context_line":"      tags:"},{"line_number":40,"context_line":"        - str_replace:"},{"line_number":41,"context_line":"            template: tripleo_ctlplane_port_name\u003d$PORT_NAME"},{"line_number":42,"context_line":"            params:"},{"line_number":43,"context_line":"              $PORT_NAME:"},{"line_number":44,"context_line":"                list_join:"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"f4c913d1_33512313","line":41,"range":{"start_line":41,"start_character":22,"end_line":41,"end_character":59},"in_reply_to":"1e432874_dd5bd5c1","updated":"2021-04-12 12:37:32.000000000","message":"\u003e True, the stack would have to be updated with these tags. My idea is that these tags can be backported to Train (OSP 16.x) so that tags are present prior to upgrade. Before proposing those backports we\u0027d have to backport this heat change as well: https://review.opendev.org/c/openstack/heat/+/750662/7\n\u003e \n\nNote, if this can\u0027t be backported to Train. I remember the consensus for the W PTG was that users would upgrade to W, then migrate nic-configs to ansible j2. Once there we can start managing ports without heat, and applying node network config prior to the stack update etc. I\u0027m open to discuss this further.","commit_id":"28af0094dbfdecca4f5718e2f059e8a2889d5b2b"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"49abb9fb9b19e88eed485a64e3c83390526d36b5","unresolved":true,"context_lines":[{"line_number":38,"context_line":"      replacement_policy: AUTO"},{"line_number":39,"context_line":"      tags:"},{"line_number":40,"context_line":"        - str_replace:"},{"line_number":41,"context_line":"            template: tripleo_ctlplane_port_name\u003d$PORT_NAME"},{"line_number":42,"context_line":"            params:"},{"line_number":43,"context_line":"              $PORT_NAME:"},{"line_number":44,"context_line":"                list_join:"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"1e432874_dd5bd5c1","line":41,"range":{"start_line":41,"start_character":22,"end_line":41,"end_character":59},"in_reply_to":"247108e1_6486abfd","updated":"2021-04-12 12:18:53.000000000","message":"True, the stack would have to be updated with these tags. My idea is that these tags can be backported to Train (OSP 16.x) so that tags are present prior to upgrade. Before proposing those backports we\u0027d have to backport this heat change as well: https://review.opendev.org/c/openstack/heat/+/750662/7\n\nFor idempotency without tags I think we\u0027d have to use our own database, since ports for nodes are created using threading.","commit_id":"28af0094dbfdecca4f5718e2f059e8a2889d5b2b"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"e2187f9cbddf9c46ee0a5a5a7d623e891566cb0b","unresolved":true,"context_lines":[{"line_number":38,"context_line":"      replacement_policy: AUTO"},{"line_number":39,"context_line":"      tags:"},{"line_number":40,"context_line":"        - str_replace:"},{"line_number":41,"context_line":"            template: tripleo_ctlplane_port_name\u003d$PORT_NAME"},{"line_number":42,"context_line":"            params:"},{"line_number":43,"context_line":"              $PORT_NAME:"},{"line_number":44,"context_line":"                list_join:"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"247108e1_6486abfd","line":41,"range":{"start_line":41,"start_character":22,"end_line":41,"end_character":59},"in_reply_to":"97c2e4a3_b845c3b8","updated":"2021-04-12 11:12:53.000000000","message":"Right, this would need they have to update the resource (stack) to add these tags for them to be managed with ansible next time.\n\nAlso, I was thinking if there is a better way than that of using tag based idempotency, but we can live with it.","commit_id":"28af0094dbfdecca4f5718e2f059e8a2889d5b2b"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"68ac8f81893df4afb008ca380ba08a1a4d8db507","unresolved":true,"context_lines":[{"line_number":38,"context_line":"      replacement_policy: AUTO"},{"line_number":39,"context_line":"      tags:"},{"line_number":40,"context_line":"        - str_replace:"},{"line_number":41,"context_line":"            template: tripleo_ctlplane_port_name\u003d$PORT_NAME"},{"line_number":42,"context_line":"            params:"},{"line_number":43,"context_line":"              $PORT_NAME:"},{"line_number":44,"context_line":"                list_join:"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"97c2e4a3_b845c3b8","line":41,"range":{"start_line":41,"start_character":22,"end_line":41,"end_character":59},"in_reply_to":"eecf2e9c_fbcde0a2","updated":"2021-04-12 10:55:32.000000000","message":"Let\u0027s drop this tag. As I\u0027m looking over the code in tripleo-ansible and tripleo-common I don\u0027t see this one used. I probably did use it in some version of the patches and forgot to remove it here.\n\nThe ansible modules managing ports without heat uses the resource tags to be idempotent, these module need to adopt the ports previously created by heat. This is why I\u0027m adding all these tags in THT.\n\nDo you mean that we should change the modules in ansible to lookup resources in the stack if they exist, and add the tags there as an adoption step instead?","commit_id":"28af0094dbfdecca4f5718e2f059e8a2889d5b2b"}],"deployed-server/deployed-neutron-port.yaml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"ed590038e60aed5a6151e4ee70802c1bafd30f4d","unresolved":true,"context_lines":[{"line_number":39,"context_line":"  DeployedServerPortMap:"},{"line_number":40,"context_line":"    default: {}"},{"line_number":41,"context_line":"    type: json"},{"line_number":42,"context_line":"  VipPort:  # Here for compatibility"},{"line_number":43,"context_line":"    default: false"},{"line_number":44,"context_line":"    type: boolean"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"40e66acd_8dd69d43","line":42,"range":{"start_line":42,"start_character":2,"end_line":42,"end_character":9},"updated":"2021-03-25 08:28:42.000000000","message":"does that one need to become IsVirtualIP too I think? sorry didn\u0027t notice it on last review.","commit_id":"e010a3a644a96f60156c9bd47358f20d7e22b5ce"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"165ed813693d4a62f2970d7c1f5dc428a9172dde","unresolved":false,"context_lines":[{"line_number":39,"context_line":"  DeployedServerPortMap:"},{"line_number":40,"context_line":"    default: {}"},{"line_number":41,"context_line":"    type: json"},{"line_number":42,"context_line":"  VipPort:  # Here for compatibility"},{"line_number":43,"context_line":"    default: false"},{"line_number":44,"context_line":"    type: boolean"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"c9b54033_92f04d02","line":42,"range":{"start_line":42,"start_character":2,"end_line":42,"end_character":9},"in_reply_to":"40e66acd_8dd69d43","updated":"2021-03-25 11:04:15.000000000","message":"Thanks Marios!","commit_id":"e010a3a644a96f60156c9bd47358f20d7e22b5ce"}],"deployed-server/deployed-server.yaml":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"354459bbf9d3bd4188059049cf837f2fbaa6f23b","unresolved":true,"context_lines":[{"line_number":81,"context_line":"      replacement_policy: AUTO"},{"line_number":82,"context_line":"      tags:"},{"line_number":83,"context_line":"        - str_replace:"},{"line_number":84,"context_line":"            template: triple_ctlplane_port_name\u003d$PORT_NAME"},{"line_number":85,"context_line":"            params:"},{"line_number":86,"context_line":"              $PORT_NAME:"},{"line_number":87,"context_line":"                list_join:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"f9742bfe_f158414e","line":84,"range":{"start_line":84,"start_character":22,"end_line":84,"end_character":28},"updated":"2021-03-05 18:12:17.000000000","message":"tripleo?","commit_id":"8cd3ad614a63bfb872ff9585080442254b2d22e6"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"6e8121a44b037ced7a5123b33bf47d3405471a99","unresolved":false,"context_lines":[{"line_number":81,"context_line":"      replacement_policy: AUTO"},{"line_number":82,"context_line":"      tags:"},{"line_number":83,"context_line":"        - str_replace:"},{"line_number":84,"context_line":"            template: triple_ctlplane_port_name\u003d$PORT_NAME"},{"line_number":85,"context_line":"            params:"},{"line_number":86,"context_line":"              $PORT_NAME:"},{"line_number":87,"context_line":"                list_join:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"a736ee15_5013d8c6","line":84,"range":{"start_line":84,"start_character":22,"end_line":84,"end_character":28},"in_reply_to":"f9742bfe_f158414e","updated":"2021-03-05 18:56:06.000000000","message":"Done","commit_id":"8cd3ad614a63bfb872ff9585080442254b2d22e6"}],"network/ports/ovn_mac_addr_port.yaml":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"354459bbf9d3bd4188059049cf837f2fbaa6f23b","unresolved":true,"context_lines":[{"line_number":34,"context_line":"      fixed_ips: []"},{"line_number":35,"context_line":"      tags:"},{"line_number":36,"context_line":"        - str_replace:"},{"line_number":37,"context_line":"            template: triple_ovn_mac_port_name\u003d$PORT_NAME"},{"line_number":38,"context_line":"            params:"},{"line_number":39,"context_line":"              $PORT_NAME: {get_param: PortName}"},{"line_number":40,"context_line":"        - str_replace:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"ea6ab91b_e977f51a","line":37,"range":{"start_line":37,"start_character":22,"end_line":37,"end_character":28},"updated":"2021-03-05 18:12:17.000000000","message":"tripleo?","commit_id":"8cd3ad614a63bfb872ff9585080442254b2d22e6"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"6e8121a44b037ced7a5123b33bf47d3405471a99","unresolved":false,"context_lines":[{"line_number":34,"context_line":"      fixed_ips: []"},{"line_number":35,"context_line":"      tags:"},{"line_number":36,"context_line":"        - str_replace:"},{"line_number":37,"context_line":"            template: triple_ovn_mac_port_name\u003d$PORT_NAME"},{"line_number":38,"context_line":"            params:"},{"line_number":39,"context_line":"              $PORT_NAME: {get_param: PortName}"},{"line_number":40,"context_line":"        - str_replace:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"a787a007_2fe64a8a","line":37,"range":{"start_line":37,"start_character":22,"end_line":37,"end_character":28},"in_reply_to":"ea6ab91b_e977f51a","updated":"2021-03-05 18:56:06.000000000","message":"Done","commit_id":"8cd3ad614a63bfb872ff9585080442254b2d22e6"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"354459bbf9d3bd4188059049cf837f2fbaa6f23b","unresolved":true,"context_lines":[{"line_number":38,"context_line":"            params:"},{"line_number":39,"context_line":"              $PORT_NAME: {get_param: PortName}"},{"line_number":40,"context_line":"        - str_replace:"},{"line_number":41,"context_line":"            template: triple_ovn_mac_net\u003d$NET_NAME"},{"line_number":42,"context_line":"            params:"},{"line_number":43,"context_line":"              $NET_NAME: {get_param: OVNMacAddressNetworkName}"},{"line_number":44,"context_line":"        - str_replace:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"cab184a1_900cf7a8","line":41,"range":{"start_line":41,"start_character":22,"end_line":41,"end_character":28},"updated":"2021-03-05 18:12:17.000000000","message":"tripleo?","commit_id":"8cd3ad614a63bfb872ff9585080442254b2d22e6"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"6e8121a44b037ced7a5123b33bf47d3405471a99","unresolved":false,"context_lines":[{"line_number":38,"context_line":"            params:"},{"line_number":39,"context_line":"              $PORT_NAME: {get_param: PortName}"},{"line_number":40,"context_line":"        - str_replace:"},{"line_number":41,"context_line":"            template: triple_ovn_mac_net\u003d$NET_NAME"},{"line_number":42,"context_line":"            params:"},{"line_number":43,"context_line":"              $NET_NAME: {get_param: OVNMacAddressNetworkName}"},{"line_number":44,"context_line":"        - str_replace:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"22b56f42_20331da5","line":41,"range":{"start_line":41,"start_character":22,"end_line":41,"end_character":28},"in_reply_to":"cab184a1_900cf7a8","updated":"2021-03-05 18:56:06.000000000","message":"Done","commit_id":"8cd3ad614a63bfb872ff9585080442254b2d22e6"}],"network/ports/port.j2":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"354459bbf9d3bd4188059049cf837f2fbaa6f23b","unresolved":true,"context_lines":[{"line_number":102,"context_line":"          - - if:"},{"line_number":103,"context_line":"              - {get_param: VipPort}"},{"line_number":104,"context_line":"              - str_replace:"},{"line_number":105,"context_line":"                  template: triple_net_vip\u003d$NET_NAME"},{"line_number":106,"context_line":"                  params:"},{"line_number":107,"context_line":"                    $NET_NAME: {get_param: {{network.name}}NetName}"},{"line_number":108,"context_line":"              - null"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"2340f2a4_ac095430","line":105,"range":{"start_line":105,"start_character":28,"end_line":105,"end_character":34},"updated":"2021-03-05 18:12:17.000000000","message":"tripleo?","commit_id":"8cd3ad614a63bfb872ff9585080442254b2d22e6"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"6e8121a44b037ced7a5123b33bf47d3405471a99","unresolved":false,"context_lines":[{"line_number":102,"context_line":"          - - if:"},{"line_number":103,"context_line":"              - {get_param: VipPort}"},{"line_number":104,"context_line":"              - str_replace:"},{"line_number":105,"context_line":"                  template: triple_net_vip\u003d$NET_NAME"},{"line_number":106,"context_line":"                  params:"},{"line_number":107,"context_line":"                    $NET_NAME: {get_param: {{network.name}}NetName}"},{"line_number":108,"context_line":"              - null"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"d5fb4aee_97458c9c","line":105,"range":{"start_line":105,"start_character":28,"end_line":105,"end_character":34},"in_reply_to":"2340f2a4_ac095430","updated":"2021-03-05 18:56:06.000000000","message":"Done","commit_id":"8cd3ad614a63bfb872ff9585080442254b2d22e6"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"c1d75a5474d653e387c7802309466bc2a6f6cc03","unresolved":true,"context_lines":[{"line_number":113,"context_line":"              params:"},{"line_number":114,"context_line":"                $STACK_NAME: {get_param: RootStackName}"},{"line_number":115,"context_line":"        - - str_replace:"},{"line_number":116,"context_line":"              template: tripleo_stack_name\u003d$STACK_NAME"},{"line_number":117,"context_line":"              params:"},{"line_number":118,"context_line":"                $STACK_NAME: {get_param: RootStackName}"},{"line_number":119,"context_line":"          - str_replace:"}],"source_content_type":"text/x-jinja2","patch_set":23,"id":"0ee2113b_2adf0f1c","line":116,"range":{"start_line":116,"start_character":24,"end_line":116,"end_character":42},"updated":"2021-04-14 06:54:27.000000000","message":"looks like you added that one twice? \n\nEDIT: no sorry this is fine... it is the else clause of the if","commit_id":"73684d0a894599e331e323597c3705453baab4d0"}],"network/ports/vip.yaml":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"354459bbf9d3bd4188059049cf837f2fbaa6f23b","unresolved":true,"context_lines":[{"line_number":88,"context_line":"      replacement_policy: AUTO"},{"line_number":89,"context_line":"      tags:"},{"line_number":90,"context_line":"        - str_replace:"},{"line_number":91,"context_line":"            template: triple_service_vip\u003d$SERVICE_NAME"},{"line_number":92,"context_line":"            params:"},{"line_number":93,"context_line":"              $SERVICE_NAME: {get_param: ServiceName}"},{"line_number":94,"context_line":"        - str_replace:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"67a4453c_64658d34","line":91,"range":{"start_line":91,"start_character":22,"end_line":91,"end_character":28},"updated":"2021-03-05 18:12:17.000000000","message":"tripleo?","commit_id":"8cd3ad614a63bfb872ff9585080442254b2d22e6"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"6e8121a44b037ced7a5123b33bf47d3405471a99","unresolved":false,"context_lines":[{"line_number":88,"context_line":"      replacement_policy: AUTO"},{"line_number":89,"context_line":"      tags:"},{"line_number":90,"context_line":"        - str_replace:"},{"line_number":91,"context_line":"            template: triple_service_vip\u003d$SERVICE_NAME"},{"line_number":92,"context_line":"            params:"},{"line_number":93,"context_line":"              $SERVICE_NAME: {get_param: ServiceName}"},{"line_number":94,"context_line":"        - str_replace:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"e5fa56ef_e0c8b605","line":91,"range":{"start_line":91,"start_character":22,"end_line":91,"end_character":28},"in_reply_to":"67a4453c_64658d34","updated":"2021-03-05 18:56:06.000000000","message":"Done","commit_id":"8cd3ad614a63bfb872ff9585080442254b2d22e6"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"352923dbcc68e01b7f041fa216379e2cd0121b20","unresolved":true,"context_lines":[{"line_number":8,"context_line":"  RootStackName:"},{"line_number":9,"context_line":"    description: The name of the stack/plan."},{"line_number":10,"context_line":"    type: string"},{"line_number":11,"context_line":"  ServiceName:"},{"line_number":12,"context_line":"    description: Name of the service to lookup"},{"line_number":13,"context_line":"    default: \u0027\u0027"},{"line_number":14,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"ecdd4d5f_9994a141","line":11,"updated":"2021-03-30 07:22:19.000000000","message":"lost the comment on that one # Here for compatibility with from_service.yaml","commit_id":"7997719cef88bbcb8a558ec055dc83ee0b41d9a6"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"ad8e62763f946618bb0e3985f85aa067aefd4a32","unresolved":false,"context_lines":[{"line_number":8,"context_line":"  RootStackName:"},{"line_number":9,"context_line":"    description: The name of the stack/plan."},{"line_number":10,"context_line":"    type: string"},{"line_number":11,"context_line":"  ServiceName:"},{"line_number":12,"context_line":"    description: Name of the service to lookup"},{"line_number":13,"context_line":"    default: \u0027\u0027"},{"line_number":14,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"91df04b0_77dbf863","line":11,"in_reply_to":"ecdd4d5f_9994a141","updated":"2021-03-30 13:16:46.000000000","message":"Done","commit_id":"7997719cef88bbcb8a558ec055dc83ee0b41d9a6"}],"network/ports/vip_v6.yaml":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"354459bbf9d3bd4188059049cf837f2fbaa6f23b","unresolved":true,"context_lines":[{"line_number":82,"context_line":"      replacement_policy: AUTO"},{"line_number":83,"context_line":"      tags:"},{"line_number":84,"context_line":"        - str_replace:"},{"line_number":85,"context_line":"            template: triple_service_vip\u003d$SERVICE_NAME"},{"line_number":86,"context_line":"            params:"},{"line_number":87,"context_line":"              $SERVICE_NAME: {get_param: ServiceName}"},{"line_number":88,"context_line":"        - str_replace:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"2f3f1e91_c139cb66","line":85,"range":{"start_line":85,"start_character":22,"end_line":85,"end_character":28},"updated":"2021-03-05 18:12:17.000000000","message":"tripleo?","commit_id":"8cd3ad614a63bfb872ff9585080442254b2d22e6"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"6e8121a44b037ced7a5123b33bf47d3405471a99","unresolved":false,"context_lines":[{"line_number":82,"context_line":"      replacement_policy: AUTO"},{"line_number":83,"context_line":"      tags:"},{"line_number":84,"context_line":"        - str_replace:"},{"line_number":85,"context_line":"            template: triple_service_vip\u003d$SERVICE_NAME"},{"line_number":86,"context_line":"            params:"},{"line_number":87,"context_line":"              $SERVICE_NAME: {get_param: ServiceName}"},{"line_number":88,"context_line":"        - str_replace:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"b992b743_f2ad52ec","line":85,"range":{"start_line":85,"start_character":22,"end_line":85,"end_character":28},"in_reply_to":"2f3f1e91_c139cb66","updated":"2021-03-05 18:56:06.000000000","message":"Done","commit_id":"8cd3ad614a63bfb872ff9585080442254b2d22e6"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"352923dbcc68e01b7f041fa216379e2cd0121b20","unresolved":true,"context_lines":[{"line_number":8,"context_line":"  RootStackName:"},{"line_number":9,"context_line":"    description: The name of the stack/plan."},{"line_number":10,"context_line":"    type: string"},{"line_number":11,"context_line":"  ServiceName:"},{"line_number":12,"context_line":"    description: Name of the service to lookup"},{"line_number":13,"context_line":"    default: \u0027\u0027"},{"line_number":14,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"481858c1_23132eb4","line":11,"updated":"2021-03-30 07:22:19.000000000","message":"same (lost comment)","commit_id":"7997719cef88bbcb8a558ec055dc83ee0b41d9a6"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"ad8e62763f946618bb0e3985f85aa067aefd4a32","unresolved":false,"context_lines":[{"line_number":8,"context_line":"  RootStackName:"},{"line_number":9,"context_line":"    description: The name of the stack/plan."},{"line_number":10,"context_line":"    type: string"},{"line_number":11,"context_line":"  ServiceName:"},{"line_number":12,"context_line":"    description: Name of the service to lookup"},{"line_number":13,"context_line":"    default: \u0027\u0027"},{"line_number":14,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"d282f977_ba71dba7","line":11,"in_reply_to":"481858c1_23132eb4","updated":"2021-03-30 13:16:46.000000000","message":"Done","commit_id":"7997719cef88bbcb8a558ec055dc83ee0b41d9a6"}],"overcloud.j2.yaml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"b2c38d4ae981760e6f6970bc2fd18eddf7678267","unresolved":true,"context_lines":[{"line_number":1103,"context_line":"        - get_param: ControlFixedIPs"},{"line_number":1104,"context_line":"      replacement_policy: AUTO"},{"line_number":1105,"context_line":"      tags:"},{"line_number":1106,"context_line":"        - tripleo_net_vip\u003dctlplane"},{"line_number":1107,"context_line":"        - str_replace:"},{"line_number":1108,"context_line":"            template: tripleo_stack_name\u003d$STACK_NAME"},{"line_number":1109,"context_line":"            params:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"848fc868_fb4cf6db","line":1106,"updated":"2021-03-17 07:24:27.000000000","message":"this is the only instance of this string i can find in tripleo-heat-templates and i can\u0027t find it anywhere else either [1] -  why do we need to change this one ? or rather, where is this used please? :) \n\n\n[1] https://codesearch.opendev.org/?q\u003dtripleo_net_vip\u0026repos\u003dopenstack/tripleo-ansible,openstack/tripleo-ci,openstack/tripleo-common,openstack/tripleo-common-tempest-plugin,openstack/tripleo-docs,openstack/tripleo-ha-utils,openstack/tripleo-heat-templates,openstack/tripleo-image-elements,openstack/tripleo-ipsec,openstack/tripleo-operator-ansible,openstack/tripleo-puppet-elements,openstack/tripleo-quickstart,openstack/tripleo-quickstart-extras,openstack/tripleo-repos,openstack/tripleo-specs,openstack/tripleo-upgrade,openstack/tripleo-validations,openstack/python-tripleoclient,openstack/puppet-tripleo","commit_id":"e883f9c2fb3cb08ac6e20a69bc67cdf4926179b2"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"7ebe985fded869efbf324e7bfb1c9e1df6d30e89","unresolved":false,"context_lines":[{"line_number":1103,"context_line":"        - get_param: ControlFixedIPs"},{"line_number":1104,"context_line":"      replacement_policy: AUTO"},{"line_number":1105,"context_line":"      tags:"},{"line_number":1106,"context_line":"        - tripleo_net_vip\u003dctlplane"},{"line_number":1107,"context_line":"        - str_replace:"},{"line_number":1108,"context_line":"            template: tripleo_stack_name\u003d$STACK_NAME"},{"line_number":1109,"context_line":"            params:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"4f5d116d_c12b7bb6","line":1106,"in_reply_to":"848fc868_fb4cf6db","updated":"2021-03-17 08:24:51.000000000","message":"right, let\u0027s not change this. I can update https://review.opendev.org/c/openstack/tripleo-ansible/+/774857 instead.\n\nDONE.","commit_id":"e883f9c2fb3cb08ac6e20a69bc67cdf4926179b2"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"d4d3f66c4add751455086a296e290da283f70dc1","unresolved":true,"context_lines":[{"line_number":1175,"context_line":"        - {get_param: {{network.name}}VirtualFixedIPs}"},{"line_number":1176,"context_line":"        {%- endif %}"},{"line_number":1177,"context_line":"        - [{subnet: {get_attr: [ServiceNetMap, vip_subnet_map, {{network.name}}]}}]"},{"line_number":1178,"context_line":"      VipPort: true"},{"line_number":1179,"context_line":"{%- endfor %}"},{"line_number":1180,"context_line":""},{"line_number":1181,"context_line":"  VipMap:"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"74c18bd3_6877702f","line":1178,"updated":"2021-03-19 07:24:49.000000000","message":"why do we need that please\nmainly am a bit confused about why it is now needed but wasn\u0027t before, and why this is a boolean. I noticed you added it in the templates above with the compatibility comment and they are all boolean too.\n\nWhereas we have an actual OS::Neutron::Port thing we call VipPort: at https://opendev.org/openstack/tripleo-heat-templates/src/commit/211d5fc385497fce3047a8114cf5c39ce9bc03c5/network/ports/vip.yaml#L74-L75 and so that one is not a boolean thing.","commit_id":"b650eb4472cd03a2bddfe07c0d0347b561781dfe"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"b299ac2c2a5b504be7c737eb7a0938c8ded2ed4b","unresolved":true,"context_lines":[{"line_number":1175,"context_line":"        - {get_param: {{network.name}}VirtualFixedIPs}"},{"line_number":1176,"context_line":"        {%- endif %}"},{"line_number":1177,"context_line":"        - [{subnet: {get_attr: [ServiceNetMap, vip_subnet_map, {{network.name}}]}}]"},{"line_number":1178,"context_line":"      VipPort: true"},{"line_number":1179,"context_line":"{%- endfor %}"},{"line_number":1180,"context_line":""},{"line_number":1181,"context_line":"  VipMap:"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"27de8783_2a73a65c","line":1178,"in_reply_to":"74c18bd3_6877702f","updated":"2021-03-22 09:26:36.000000000","message":"OS::TripleO::Network::Ports::{{network.name}}VipPort maps to https://review.opendev.org/c/openstack/tripleo-heat-templates/+/778792/15/network/ports/port.j2. I use the boolean in a condition there to set tags differently if its a VIP or not a VIP.\n\nI think the parameter name is bad, we could change it to \u0027is_vip\u0027 or \u0027IsVip\u0027.","commit_id":"b650eb4472cd03a2bddfe07c0d0347b561781dfe"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"f992752b910d993e82cd70430f40345a60ae79a3","unresolved":true,"context_lines":[{"line_number":1175,"context_line":"        - {get_param: {{network.name}}VirtualFixedIPs}"},{"line_number":1176,"context_line":"        {%- endif %}"},{"line_number":1177,"context_line":"        - [{subnet: {get_attr: [ServiceNetMap, vip_subnet_map, {{network.name}}]}}]"},{"line_number":1178,"context_line":"      IsVirtualIp: true"},{"line_number":1179,"context_line":"{%- endfor %}"},{"line_number":1180,"context_line":""},{"line_number":1181,"context_line":"  VipMap:"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"a54c6d8a_ccfa686f","line":1178,"range":{"start_line":1178,"start_character":16,"end_line":1178,"end_character":17},"updated":"2021-03-24 08:30:19.000000000","message":"thanks for updating the var name\n\nI think we want to capilatlise IP ... in line with e.g. the FixedIPs var just above","commit_id":"6f5b861d60deaf49bb3d3c2d866116347836d191"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"9bad0a3461478cc4c5ab576f8ec1b2c9ef17ce5f","unresolved":false,"context_lines":[{"line_number":1175,"context_line":"        - {get_param: {{network.name}}VirtualFixedIPs}"},{"line_number":1176,"context_line":"        {%- endif %}"},{"line_number":1177,"context_line":"        - [{subnet: {get_attr: [ServiceNetMap, vip_subnet_map, {{network.name}}]}}]"},{"line_number":1178,"context_line":"      IsVirtualIp: true"},{"line_number":1179,"context_line":"{%- endfor %}"},{"line_number":1180,"context_line":""},{"line_number":1181,"context_line":"  VipMap:"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"d9f0941d_34da8814","line":1178,"range":{"start_line":1178,"start_character":16,"end_line":1178,"end_character":17},"in_reply_to":"a54c6d8a_ccfa686f","updated":"2021-03-24 09:28:42.000000000","message":"Done","commit_id":"6f5b861d60deaf49bb3d3c2d866116347836d191"}]}