)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"6fac4ceb28337a58eddb87ff728ce6ba4774d621","unresolved":true,"context_lines":[{"line_number":1,"context_line":"Parent:     eafc63b7 (Merge \"Use include task for host prep tasks\" into stable/train)"},{"line_number":2,"context_line":"Author:     Marios Andreou \u003cmarios@redhat.com\u003e"},{"line_number":3,"context_line":"AuthorDate: 2021-03-05 12:56:41 +0200"},{"line_number":4,"context_line":"Commit:     Marios Andreou \u003cmarios@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"e896df0b_ae87902f","line":1,"updated":"2021-03-08 15:28:43.000000000","message":"Shouldn\u0027t the file matches be updated first in https://opendev.org/openstack/tripleo-ci/src/branch/master/zuul.d/standalone-jobs.yaml#L286-L291 as i see files: in tht have extra location, which after this patch will not run scenario010 on these file changes?","commit_id":"54414a14b47de5f15bb5ca01009fca041462f2bd"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"38294b4e6507eefaf84d59bfb855dadb95c66bdd","unresolved":true,"context_lines":[{"line_number":1,"context_line":"Parent:     eafc63b7 (Merge \"Use include task for host prep tasks\" into stable/train)"},{"line_number":2,"context_line":"Author:     Marios Andreou \u003cmarios@redhat.com\u003e"},{"line_number":3,"context_line":"AuthorDate: 2021-03-05 12:56:41 +0200"},{"line_number":4,"context_line":"Commit:     Marios Andreou \u003cmarios@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"947d12bd_3715bb66","line":1,"in_reply_to":"e896df0b_ae87902f","updated":"2021-03-09 09:45:55.000000000","message":"thanks for your comment ykarel. \n\nI did check at the time I posted this but it seems I was mistaken about ceph-ansible - I commented inline with pointers/comment about the others","commit_id":"54414a14b47de5f15bb5ca01009fca041462f2bd"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"e9ca5b9acac1ff1bd39851878bec7034a609723b","unresolved":true,"context_lines":[{"line_number":11,"context_line":"doesn\u0027t run on train or even U."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Also removes the tripleo-ci-centos-8-scenario010-standalone override"},{"line_number":14,"context_line":"as it is already included by the tripleo-standalone-scenarios-pipeline"},{"line_number":15,"context_line":"template. The files: matches here meant the job was run on more changes"},{"line_number":16,"context_line":"than defined by the template itself [2]. Part of CI optimisation [3]."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f524352_7e7f0af1","line":14,"range":{"start_line":14,"start_character":33,"end_line":14,"end_character":70},"updated":"2021-03-08 09:59:31.000000000","message":"Yes correct https://opendev.org/openstack/tripleo-ci/src/branch/master/zuul.d/standalone-jobs.yaml#L377","commit_id":"54414a14b47de5f15bb5ca01009fca041462f2bd"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"38294b4e6507eefaf84d59bfb855dadb95c66bdd","unresolved":true,"context_lines":[{"line_number":11,"context_line":"doesn\u0027t run on train or even U."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Also removes the tripleo-ci-centos-8-scenario010-standalone override"},{"line_number":14,"context_line":"as it is already included by the tripleo-standalone-scenarios-pipeline"},{"line_number":15,"context_line":"template. The files: matches here meant the job was run on more changes"},{"line_number":16,"context_line":"than defined by the template itself [2]. Part of CI optimisation [3]."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"27d7c60d_8c95d0f2","line":14,"range":{"start_line":14,"start_character":33,"end_line":14,"end_character":70},"in_reply_to":"3f524352_7e7f0af1","updated":"2021-03-09 09:45:55.000000000","message":"thanks for keeping me honest :)","commit_id":"54414a14b47de5f15bb5ca01009fca041462f2bd"}],"zuul.d/layout.yaml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"38294b4e6507eefaf84d59bfb855dadb95c66bdd","unresolved":true,"context_lines":[{"line_number":39,"context_line":"            vars: *multi_consumer_vars"},{"line_number":40,"context_line":"            dependencies: *deps_cprovider"},{"line_number":41,"context_line":"            files:"},{"line_number":42,"context_line":"              - ^(deployment|docker|puppet)/.*octavia.*$"},{"line_number":43,"context_line":"              - ^deployment/ceph-ansible.*$"},{"line_number":44,"context_line":"              - ^deployment/octavia/*$"},{"line_number":45,"context_line":"              - ci/environments/scenario010-standalone.yaml"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"40bf95e0_6225cc58","side":"PARENT","line":42,"range":{"start_line":42,"start_character":18,"end_line":42,"end_character":28},"updated":"2021-03-09 09:45:55.000000000","message":"https://opendev.org/openstack/tripleo-ci/src/commit/b488e174efe4e3e16689d88d86a21dead5e3d398/zuul.d/standalone-jobs.yaml#L289","commit_id":"eafc63b7199d8645e17be6139462a9217165d903"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"38294b4e6507eefaf84d59bfb855dadb95c66bdd","unresolved":true,"context_lines":[{"line_number":40,"context_line":"            dependencies: *deps_cprovider"},{"line_number":41,"context_line":"            files:"},{"line_number":42,"context_line":"              - ^(deployment|docker|puppet)/.*octavia.*$"},{"line_number":43,"context_line":"              - ^deployment/ceph-ansible.*$"},{"line_number":44,"context_line":"              - ^deployment/octavia/*$"},{"line_number":45,"context_line":"              - ci/environments/scenario010-standalone.yaml"},{"line_number":46,"context_line":"              - ^ci/common/.*$"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"93c834ab_8b7e8e11","side":"PARENT","line":43,"range":{"start_line":43,"start_character":28,"end_line":43,"end_character":40},"updated":"2021-03-09 09:45:55.000000000","message":"i think this is the only one I missed ... \n\nI thought it was a mistake i didn\u0027t realise we also have ceph as the cinder backend in this scenario I just checked and saw that this was the case https://opendev.org/openstack/tripleo-heat-templates/src/commit/a94f17d98cd00cd6b43d0da405e590162abacd18/ci/environments/scenario010-standalone.yaml#L2\n\nposted there https://review.opendev.org/c/openstack/tripleo-ci/+/779447 please check and vote","commit_id":"eafc63b7199d8645e17be6139462a9217165d903"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"38294b4e6507eefaf84d59bfb855dadb95c66bdd","unresolved":true,"context_lines":[{"line_number":42,"context_line":"              - ^(deployment|docker|puppet)/.*octavia.*$"},{"line_number":43,"context_line":"              - ^deployment/ceph-ansible.*$"},{"line_number":44,"context_line":"              - ^deployment/octavia/*$"},{"line_number":45,"context_line":"              - ci/environments/scenario010-standalone.yaml"},{"line_number":46,"context_line":"              - ^ci/common/.*$"},{"line_number":47,"context_line":"              - ^environments\\/.*.yaml"},{"line_number":48,"context_line":"              - ^deployed-server/.*$"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"4af40f9e_437a1671","side":"PARENT","line":45,"range":{"start_line":45,"start_character":16,"end_line":45,"end_character":25},"updated":"2021-03-09 09:45:55.000000000","message":"https://opendev.org/openstack/tripleo-ci/src/commit/b488e174efe4e3e16689d88d86a21dead5e3d398/zuul.d/standalone-jobs.yaml#L290","commit_id":"eafc63b7199d8645e17be6139462a9217165d903"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"cbdeb0ad34e18f329e77f8d3b3f513a185a52f73","unresolved":true,"context_lines":[{"line_number":42,"context_line":"              - ^(deployment|docker|puppet)/.*octavia.*$"},{"line_number":43,"context_line":"              - ^deployment/ceph-ansible.*$"},{"line_number":44,"context_line":"              - ^deployment/octavia/*$"},{"line_number":45,"context_line":"              - ci/environments/scenario010-standalone.yaml"},{"line_number":46,"context_line":"              - ^ci/common/.*$"},{"line_number":47,"context_line":"              - ^environments\\/.*.yaml"},{"line_number":48,"context_line":"              - ^deployed-server/.*$"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"505ffcb2_0dac3928","side":"PARENT","line":45,"range":{"start_line":45,"start_character":16,"end_line":45,"end_character":25},"in_reply_to":"4af40f9e_437a1671","updated":"2021-03-09 10:04:11.000000000","message":"ok","commit_id":"eafc63b7199d8645e17be6139462a9217165d903"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"38294b4e6507eefaf84d59bfb855dadb95c66bdd","unresolved":true,"context_lines":[{"line_number":48,"context_line":"              - ^deployed-server/.*$"},{"line_number":49,"context_line":"              - ^network/endpoints/.*$"},{"line_number":50,"context_line":"              - ^common/.*$"},{"line_number":51,"context_line":"              - zuul.d/*"},{"line_number":52,"context_line":"    gate:"},{"line_number":53,"context_line":"      queue: tripleo"},{"line_number":54,"context_line":"      jobs:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"eaaf7e8d_d058321f","side":"PARENT","line":51,"updated":"2021-03-09 09:45:55.000000000","message":"the above 6 are all general matches for * i.e. generic files used in all deployments and we have removed these as part of https://review.opendev.org/q/topic:tripleo-ci-reduce so we don\u0027t want them in files: matches\n\nfor example we definitely don\u0027t want this scenario010 (non voting) job to be run on any change to *any* environment file in tripleo-heat-templates.","commit_id":"eafc63b7199d8645e17be6139462a9217165d903"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"cbdeb0ad34e18f329e77f8d3b3f513a185a52f73","unresolved":false,"context_lines":[{"line_number":48,"context_line":"              - ^deployed-server/.*$"},{"line_number":49,"context_line":"              - ^network/endpoints/.*$"},{"line_number":50,"context_line":"              - ^common/.*$"},{"line_number":51,"context_line":"              - zuul.d/*"},{"line_number":52,"context_line":"    gate:"},{"line_number":53,"context_line":"      queue: tripleo"},{"line_number":54,"context_line":"      jobs:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3dfc3ef8_9fa2026f","side":"PARENT","line":51,"in_reply_to":"eaaf7e8d_d058321f","updated":"2021-03-09 10:04:11.000000000","message":"Ack","commit_id":"eafc63b7199d8645e17be6139462a9217165d903"}]}
