)]}'
{"ci/environments/scenario001-standalone.yaml":[{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"f571633e340bd9df2fbba25ac99b058a479b5ab6","unresolved":true,"context_lines":[{"line_number":62,"context_line":"    data_devices:"},{"line_number":63,"context_line":"      paths:"},{"line_number":64,"context_line":"        - /dev/ceph_vg/ceph_lv_data"},{"line_number":65,"context_line":"  CephPoolDefaultPgNum: 32"},{"line_number":66,"context_line":"  CephPoolDefaultSize: 1"},{"line_number":67,"context_line":"  CinderRbdExtraPools: altrbd,pool2,pool3"},{"line_number":68,"context_line":"  CephPools:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7095125c_398d4ab6","line":65,"range":{"start_line":65,"start_character":2,"end_line":65,"end_character":26},"updated":"2021-03-10 10:34:53.000000000","message":"I would keep this param to 8 for CI (standalone) purposes.\nThe autoscaler should be able to increase this value if needed.","commit_id":"5cf89006c3406c437ed86b4358aef975c281c241"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"2028900977240baef0d6512757e4b593222c84ae","unresolved":true,"context_lines":[{"line_number":176,"context_line":"  CephAnsibleSkipClient: false"},{"line_number":177,"context_line":"  CephConfigPath: \"/etc/ceph\""},{"line_number":178,"context_line":"  CephClientConfigVars: \"{{ playbook_dir }}/cephadm/ceph_client.yml\""},{"line_number":179,"context_line":"  CephSpecPath: \"/usr/share/ansible/roles/tripleo_cephadm/files/ceph_spec.yaml\""},{"line_number":180,"context_line":"  LVMFilterEnabled: true"},{"line_number":181,"context_line":"  LVMFilterAllowlist:"},{"line_number":182,"context_line":"    - /dev/loop2"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"036be280_6150220e","line":179,"updated":"2021-03-16 00:19:42.000000000","message":"I wonder how this got left here. +1 on removing it","commit_id":"7a1d6a5e13f589d684777a19e77314feee788871"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"7ada32ef2e2358a842f51ac3db53560090917e01","unresolved":false,"context_lines":[{"line_number":176,"context_line":"  CephAnsibleSkipClient: false"},{"line_number":177,"context_line":"  CephConfigPath: \"/etc/ceph\""},{"line_number":178,"context_line":"  CephClientConfigVars: \"{{ playbook_dir }}/cephadm/ceph_client.yml\""},{"line_number":179,"context_line":"  CephSpecPath: \"/usr/share/ansible/roles/tripleo_cephadm/files/ceph_spec.yaml\""},{"line_number":180,"context_line":"  LVMFilterEnabled: true"},{"line_number":181,"context_line":"  LVMFilterAllowlist:"},{"line_number":182,"context_line":"    - /dev/loop2"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"ff865d7f_27a6316a","line":179,"in_reply_to":"036be280_6150220e","updated":"2021-03-16 08:17:40.000000000","message":"yeah, not sure if this was caused by the rebasing on 294 (which needed it). Removing it turn this change green since that path is already defined in tht","commit_id":"7a1d6a5e13f589d684777a19e77314feee788871"}],"deployment/cephadm/ceph-base.yaml":[{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"8ae4e6100fd07aa55263cfd465a3ab3e3f8e2eec","unresolved":true,"context_lines":[{"line_number":600,"context_line":"                ceph_config_overrides: {get_param: CephConfigOverrides}"},{"line_number":601,"context_line":"                tripleo_run_cephadm_spec_path: {get_param: CephSpecPath}"},{"line_number":602,"context_line":"                tripleo_run_cephadm_dynamic_spec: {get_param: CephDynamicSpec}"},{"line_number":603,"context_line":"                ceph_spec_fqdn: {get_param: CephSpecFqdn}"},{"line_number":604,"context_line":"                ceph_osd_spec: {get_param: CephOsdSpec}"},{"line_number":605,"context_line":"                ceph_default_overrides:"},{"line_number":606,"context_line":"                  if:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"eafca92c_0c940121","line":603,"range":{"start_line":603,"start_character":16,"end_line":603,"end_character":30},"updated":"2021-03-09 10:05:54.000000000","message":"Can we use here: tripleo_cephadm_fqdn as param name since I introduced it here [1] ?\n\n[1] https://review.opendev.org/c/openstack/tripleo-ansible/+/773364/62..64/tripleo_ansible/roles/tripleo_cephadm/defaults/main.yml#41","commit_id":"57f85225860475523429dc8aff0fd6aa5c91ea85"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"ad3d271977e764d1f3e1a045cd8110d4483a89bb","unresolved":true,"context_lines":[{"line_number":600,"context_line":"                ceph_config_overrides: {get_param: CephConfigOverrides}"},{"line_number":601,"context_line":"                tripleo_run_cephadm_spec_path: {get_param: CephSpecPath}"},{"line_number":602,"context_line":"                tripleo_run_cephadm_dynamic_spec: {get_param: CephDynamicSpec}"},{"line_number":603,"context_line":"                ceph_spec_fqdn: {get_param: CephSpecFqdn}"},{"line_number":604,"context_line":"                ceph_osd_spec: {get_param: CephOsdSpec}"},{"line_number":605,"context_line":"                ceph_default_overrides:"},{"line_number":606,"context_line":"                  if:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"0f9fd64c_8cb6089c","line":603,"range":{"start_line":603,"start_character":16,"end_line":603,"end_character":30},"in_reply_to":"5b556248_8198a429","updated":"2021-03-10 04:59:04.000000000","message":"OK, I think I got what you were after by adding this. Let me know if you need something different. \n\nhttps://review.opendev.org/c/openstack/tripleo-ansible/+/777767/29/tripleo_ansible/roles/tripleo_run_cephadm/tasks/prepare.yml#129","commit_id":"57f85225860475523429dc8aff0fd6aa5c91ea85"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"41d71dee5e481a5453c927cd7f45fab90a1b7e99","unresolved":true,"context_lines":[{"line_number":600,"context_line":"                ceph_config_overrides: {get_param: CephConfigOverrides}"},{"line_number":601,"context_line":"                tripleo_run_cephadm_spec_path: {get_param: CephSpecPath}"},{"line_number":602,"context_line":"                tripleo_run_cephadm_dynamic_spec: {get_param: CephDynamicSpec}"},{"line_number":603,"context_line":"                ceph_spec_fqdn: {get_param: CephSpecFqdn}"},{"line_number":604,"context_line":"                ceph_osd_spec: {get_param: CephOsdSpec}"},{"line_number":605,"context_line":"                ceph_default_overrides:"},{"line_number":606,"context_line":"                  if:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5b556248_8198a429","line":603,"range":{"start_line":603,"start_character":16,"end_line":603,"end_character":30},"in_reply_to":"eafca92c_0c940121","updated":"2021-03-09 10:18:33.000000000","message":"Sorry, it\u0027s ok having this name here, ignore my previous comment.\n\nFYI I added this parameter to scenario004 [1]\n\n[1] https://review.opendev.org/c/openstack/tripleo-heat-templates/+/773355","commit_id":"57f85225860475523429dc8aff0fd6aa5c91ea85"}]}