)]}'
{"deployment/frr/frr-container-ansible.yaml":[{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"515760e193003570ecd1e926923575b0cb87f8a2","unresolved":true,"context_lines":[{"line_number":207,"context_line":"        # and tripleo-startup-containers)"},{"line_number":208,"context_line":"        list_concat:"},{"line_number":209,"context_line":"        - {get_attr: [PodmanBase, role_data, host_prep_tasks]}"},{"line_number":210,"context_line":"        - - include_tasks: common_deploy_steps_tasks_step_1.yaml"},{"line_number":211,"context_line":"          - name: create persistent directories"},{"line_number":212,"context_line":"            file:"},{"line_number":213,"context_line":"              path: \"{{ item.path }}\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"67eb0c7a_47d79c2f","line":210,"range":{"start_line":210,"start_character":53,"end_line":210,"end_character":59},"updated":"2021-03-18 04:37:08.000000000","message":"step_1 tasks are invoked in host_prep_tasks. It creates a difference in steps with FRR and without FRR. Is it possible to extract those required steps to host_prep_tasks in the respective services and invoke it as like Podman?","commit_id":"4885a9eb998c17597143813285159c3722631449"},{"author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"change_message_id":"9e083d3805efe6633cd87b1d3d7df9a209ba6717","unresolved":true,"context_lines":[{"line_number":207,"context_line":"        # and tripleo-startup-containers)"},{"line_number":208,"context_line":"        list_concat:"},{"line_number":209,"context_line":"        - {get_attr: [PodmanBase, role_data, host_prep_tasks]}"},{"line_number":210,"context_line":"        - - include_tasks: common_deploy_steps_tasks_step_1.yaml"},{"line_number":211,"context_line":"          - name: create persistent directories"},{"line_number":212,"context_line":"            file:"},{"line_number":213,"context_line":"              path: \"{{ item.path }}\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"f6ff86e2_9ac2e906","line":210,"range":{"start_line":210,"start_character":53,"end_line":210,"end_character":59},"in_reply_to":"0a982525_c31f924c","updated":"2021-03-18 10:37:42.000000000","message":"\u003e My concern is that the well defined steps (in this case \u0027step1\u0027) is being executed in host_prep_tasks. That too only with FRR. It defeats the steps definition. I was trying to see if there is any alternative to avoid it.\n\nYou are not wrong :) I don\u0027t necessarily love the idea, but we could not come up with anything cleaner that did not involve ripping massive amounts of stuff out or changing how do thinks substantially.","commit_id":"4885a9eb998c17597143813285159c3722631449"},{"author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"change_message_id":"c2a911d83f4ed18b0b3fa50be1fa089ccae4d371","unresolved":true,"context_lines":[{"line_number":207,"context_line":"        # and tripleo-startup-containers)"},{"line_number":208,"context_line":"        list_concat:"},{"line_number":209,"context_line":"        - {get_attr: [PodmanBase, role_data, host_prep_tasks]}"},{"line_number":210,"context_line":"        - - include_tasks: common_deploy_steps_tasks_step_1.yaml"},{"line_number":211,"context_line":"          - name: create persistent directories"},{"line_number":212,"context_line":"            file:"},{"line_number":213,"context_line":"              path: \"{{ item.path }}\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"d65df96d_224df3cb","line":210,"range":{"start_line":210,"start_character":53,"end_line":210,"end_character":59},"in_reply_to":"67eb0c7a_47d79c2f","updated":"2021-03-18 08:01:52.000000000","message":"Thanks Saravanan\n\nSo these common_deploy_steps_tasks_step_1.yaml are not run during host_prep_tasks normally, but in the deploy step tasks at step1 (common/deploy-steps.j2 \u0027Overcloud common bootstrap tasks for step 1\u0027).\n\nThe difference is that with FRR enabled those tasks are executed twice (during host_prep_tasks due to this frr service and later during the \"normal\" run of \u0027Overcloud common bootstrap tasks for step 1\u0027). They are idempotent so this should be okay (albeit obviously less than ideal)\n\nI just don\u0027t know if \u0027Overcloud common bootstrap tasks for step 1\u0027 could be moved to host_prep_tasks in general or if it would break anything?\n\nNot sure in which respective service we would move the tasks inside common_deploy_steps_tasks_step_1.yaml, or am I misunderstanding?","commit_id":"4885a9eb998c17597143813285159c3722631449"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"4487096aa325fcf0d75e41f0014ef2afa2529612","unresolved":true,"context_lines":[{"line_number":207,"context_line":"        # and tripleo-startup-containers)"},{"line_number":208,"context_line":"        list_concat:"},{"line_number":209,"context_line":"        - {get_attr: [PodmanBase, role_data, host_prep_tasks]}"},{"line_number":210,"context_line":"        - - include_tasks: common_deploy_steps_tasks_step_1.yaml"},{"line_number":211,"context_line":"          - name: create persistent directories"},{"line_number":212,"context_line":"            file:"},{"line_number":213,"context_line":"              path: \"{{ item.path }}\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"0a982525_c31f924c","line":210,"range":{"start_line":210,"start_character":53,"end_line":210,"end_character":59},"in_reply_to":"d65df96d_224df3cb","updated":"2021-03-18 08:30:19.000000000","message":"\u003e Not sure in which respective service we would move the tasks inside common_deploy_steps_tasks_step_1.yaml, or am I misunderstanding?\n\nOk, misunderstood \"deploy_step_tasks\" on each service with \"common/deploy-steps.j2\". Its clear now. \n\n\u003e They are idempotent so this should be okay (albeit obviously less than ideal)\n\nMy concern is that the well defined steps (in this case \u0027step1\u0027) is being executed in host_prep_tasks. That too only with FRR. It defeats the steps definition. I was trying to see if there is any alternative to avoid it.","commit_id":"4885a9eb998c17597143813285159c3722631449"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"1efafc1af9aee1e682dc5ef78cfadadbcf058617","unresolved":true,"context_lines":[{"line_number":203,"context_line":"            - { \u0027path\u0027: /var/lib/config-data/ansible-generated/frr, \u0027setype\u0027: container_file_t, \u0027mode\u0027: \u00270750\u0027 }"},{"line_number":204,"context_line":"      deploy_steps_tasks:"},{"line_number":205,"context_line":"        - name: Configure and start FRR before an HA service"},{"line_number":206,"context_line":"          when: step|int \u003d\u003d 1"},{"line_number":207,"context_line":"          block:"},{"line_number":208,"context_line":"            - name: Configure FRR"},{"line_number":209,"context_line":"              import_role:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"56a8269c_65b4e7a9","side":"PARENT","line":206,"updated":"2021-03-19 09:45:35.000000000","message":"or maybe we could just add step 0?.. later","commit_id":"211d5fc385497fce3047a8114cf5c39ce9bc03c5"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"74f5ca1c28ac7e9692ddf3beddcc644072e24cb8","unresolved":true,"context_lines":[{"line_number":203,"context_line":"            - { \u0027path\u0027: /var/lib/config-data/ansible-generated/frr, \u0027setype\u0027: container_file_t, \u0027mode\u0027: \u00270750\u0027 }"},{"line_number":204,"context_line":"      deploy_steps_tasks:"},{"line_number":205,"context_line":"        - name: Configure and start FRR before an HA service"},{"line_number":206,"context_line":"          when: step|int \u003d\u003d 1"},{"line_number":207,"context_line":"          block:"},{"line_number":208,"context_line":"            - name: Configure FRR"},{"line_number":209,"context_line":"              import_role:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9cca4c89_6d465060","side":"PARENT","line":206,"in_reply_to":"56a8269c_65b4e7a9","updated":"2021-03-19 18:41:47.000000000","message":"I was just now leaving a comment in the commit message asking if we had explored moving FRR to step 0 when I read your message -- great minds think alike?! Heh.\nMoving to step 0 would still require including tasks from common_deploy_steps_tasks_step_1.yaml but at least the podman bits could be dropped. Michele, what do you think? Have we tested/ruled out this option?","commit_id":"211d5fc385497fce3047a8114cf5c39ce9bc03c5"},{"author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"change_message_id":"5c44b23e7738d3409ca7a79f38cfa7571c5eacc8","unresolved":true,"context_lines":[{"line_number":203,"context_line":"            - { \u0027path\u0027: /var/lib/config-data/ansible-generated/frr, \u0027setype\u0027: container_file_t, \u0027mode\u0027: \u00270750\u0027 }"},{"line_number":204,"context_line":"      deploy_steps_tasks:"},{"line_number":205,"context_line":"        - name: Configure and start FRR before an HA service"},{"line_number":206,"context_line":"          when: step|int \u003d\u003d 1"},{"line_number":207,"context_line":"          block:"},{"line_number":208,"context_line":"            - name: Configure FRR"},{"line_number":209,"context_line":"              import_role:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"8752646c_21f5cbc0","side":"PARENT","line":206,"in_reply_to":"82a1fa12_0b024a16","updated":"2021-03-20 10:15:22.000000000","message":"So the only way we can do this 100% cleanly is the following:\nA) Split out the common_deploy_steps_tasks_step_1.yaml tasks from the deploy step loop and place them after host_prep_tasks and before the external deploy tasks\nB) Create a new set of tasks that go after (A) and before external deploy tasks (call them pre-external-deploy or something) and move the frr setup tasks to (B)","commit_id":"211d5fc385497fce3047a8114cf5c39ce9bc03c5"},{"author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"change_message_id":"d5a88396dafc8750127d0c0ce16906b9a764519b","unresolved":true,"context_lines":[{"line_number":203,"context_line":"            - { \u0027path\u0027: /var/lib/config-data/ansible-generated/frr, \u0027setype\u0027: container_file_t, \u0027mode\u0027: \u00270750\u0027 }"},{"line_number":204,"context_line":"      deploy_steps_tasks:"},{"line_number":205,"context_line":"        - name: Configure and start FRR before an HA service"},{"line_number":206,"context_line":"          when: step|int \u003d\u003d 1"},{"line_number":207,"context_line":"          block:"},{"line_number":208,"context_line":"            - name: Configure FRR"},{"line_number":209,"context_line":"              import_role:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"4e8f8d76_5ae920ab","side":"PARENT","line":206,"in_reply_to":"8752646c_21f5cbc0","updated":"2021-03-20 10:26:39.000000000","message":"So A) is https://review.opendev.org/c/openstack/tripleo-heat-templates/+/781963. We can also investigate doing B). My problem with all this is that we\u0027re adding plays which set ansible concurrency boundaries (i.e. tripleo_free does not cross separate plays), so we\u0027re adding slowness/complexity only for the frr case.","commit_id":"211d5fc385497fce3047a8114cf5c39ce9bc03c5"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"ff39965835bbd42fd22712d7950087e79e9bcfa0","unresolved":true,"context_lines":[{"line_number":203,"context_line":"            - { \u0027path\u0027: /var/lib/config-data/ansible-generated/frr, \u0027setype\u0027: container_file_t, \u0027mode\u0027: \u00270750\u0027 }"},{"line_number":204,"context_line":"      deploy_steps_tasks:"},{"line_number":205,"context_line":"        - name: Configure and start FRR before an HA service"},{"line_number":206,"context_line":"          when: step|int \u003d\u003d 1"},{"line_number":207,"context_line":"          block:"},{"line_number":208,"context_line":"            - name: Configure FRR"},{"line_number":209,"context_line":"              import_role:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"82a1fa12_0b024a16","side":"PARENT","line":206,"in_reply_to":"96a095ae_3bf248fd","updated":"2021-03-20 09:40:15.000000000","message":"Oh, you\u0027re totally right. Sorry for the noise.","commit_id":"211d5fc385497fce3047a8114cf5c39ce9bc03c5"},{"author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"change_message_id":"d41898ec65b6171f9b4b25ba8fec4e9d186e0e07","unresolved":true,"context_lines":[{"line_number":203,"context_line":"            - { \u0027path\u0027: /var/lib/config-data/ansible-generated/frr, \u0027setype\u0027: container_file_t, \u0027mode\u0027: \u00270750\u0027 }"},{"line_number":204,"context_line":"      deploy_steps_tasks:"},{"line_number":205,"context_line":"        - name: Configure and start FRR before an HA service"},{"line_number":206,"context_line":"          when: step|int \u003d\u003d 1"},{"line_number":207,"context_line":"          block:"},{"line_number":208,"context_line":"            - name: Configure FRR"},{"line_number":209,"context_line":"              import_role:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"96a095ae_3bf248fd","side":"PARENT","line":206,"in_reply_to":"9cca4c89_6d465060","updated":"2021-03-20 09:12:40.000000000","message":"The problem is that step0 runs before the network and even before host_prep_tasks, so we could not pull down the containers and podman would run afterwards:\nhttps://github.com/openstack/tripleo-heat-templates/blob/master/common/deploy-steps.j2#L506","commit_id":"211d5fc385497fce3047a8114cf5c39ce9bc03c5"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"6c0e2f11da534ec1642b9347082c796153387b0f","unresolved":true,"context_lines":[{"line_number":204,"context_line":"      host_prep_tasks:"},{"line_number":205,"context_line":"        # Frr is special because it needs to be up before we try any tasks that need to reach nodes"},{"line_number":206,"context_line":"        # via the network  That is why we need to duplicate a few things here (podman setup, kolla config"},{"line_number":207,"context_line":"        # and tripleo-startup-containers)"},{"line_number":208,"context_line":"        list_concat:"},{"line_number":209,"context_line":"        - {get_attr: [PodmanBase, role_data, host_prep_tasks]}"},{"line_number":210,"context_line":"        - - include_tasks: common_deploy_steps_tasks_step_1.yaml"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7fce97f7_97578084","line":207,"updated":"2021-03-23 13:57:15.000000000","message":"this is awful. it\u0027s really not great to duplicate all these. have we considered not bothering to containerize frr instead of doing this?","commit_id":"39cf64519fc96aa006614fdcd15e39732d91022f"}]}