)]}'
{"environments/barbican-backend-simple-crypto.yaml":[{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"2229dcbd02236f63e96051cb6fb0862d3b410e23","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# A Heat environment file to enable the barbican simple crypto backend. Note"},{"line_number":2,"context_line":"# that barbican needs to be enabled in order to use this."},{"line_number":3,"context_line":"# parameter_defaults:"},{"line_number":4,"context_line":"  # In order to use this backend, you need to uncomment this value and"},{"line_number":5,"context_line":"  # provide an appropriate KEK that barbican will use to encrypt secrets"},{"line_number":6,"context_line":"  # in the database."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"11a78c95_4788cdb4","line":3,"range":{"start_line":3,"start_character":0,"end_line":3,"end_character":20},"updated":"2021-03-19 05:22:54.000000000","message":"Don\u0027t think that registry mapping in L13 would work without these parameters when this environment is included as is, i.e BarbicanSimpleCryptoKek does not have a default[1]. \n\nIf we want to avoid this being included unintentionally, we should probably comment out everything and also update the text mentioning that user have to uncomment both sections.\n\n[1] https://github.com/openstack/tripleo-heat-templates/blob/master/deployment/barbican/barbican-backend-simple-crypto-puppet.yaml#L31","commit_id":"8799a94214915195d466b82a0102aa2558069a60"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"6c94bcca8104562971a8e0cbc2512ea0d04f68ca","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# A Heat environment file to enable the barbican simple crypto backend. Note"},{"line_number":2,"context_line":"# that barbican needs to be enabled in order to use this."},{"line_number":3,"context_line":"# parameter_defaults:"},{"line_number":4,"context_line":"  # In order to use this backend, you need to uncomment this value and"},{"line_number":5,"context_line":"  # provide an appropriate KEK that barbican will use to encrypt secrets"},{"line_number":6,"context_line":"  # in the database."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bfbd543f_009913bd","line":3,"range":{"start_line":3,"start_character":0,"end_line":3,"end_character":20},"in_reply_to":"11a78c95_4788cdb4","updated":"2021-03-19 13:53:39.000000000","message":"So I think this is one of those odd things we require end users to do to enable services.  Techincally they need to provide that parameter, but it doesn\u0027t make sense to modify the THT version of this file. There would be two things that a user needs to do and it would be include -e THT/environments/barbican-backend-simple-crypto.yaml and include the BarbicanSimpleCrypto* params in another environment file (e.g. user params)  I know a lot of times these are example files and the expectation would be for a user to copy this somewhere and modify, but they would also need to update the path for the services reference.  IMHO i think the documentation should be updated to point that they need to include these params somewhere (it doesn\u0027t have to be this file)","commit_id":"8799a94214915195d466b82a0102aa2558069a60"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"54a10b4d2a396d00d40fe1da77a915f26c02514c","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# A Heat environment file to enable the barbican simple crypto backend. Note"},{"line_number":2,"context_line":"# that barbican needs to be enabled in order to use this."},{"line_number":3,"context_line":"# parameter_defaults:"},{"line_number":4,"context_line":"  # In order to use this backend, you need to uncomment this value and"},{"line_number":5,"context_line":"  # provide an appropriate KEK that barbican will use to encrypt secrets"},{"line_number":6,"context_line":"  # in the database."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"a7d73ef4_7ca84649","line":3,"range":{"start_line":3,"start_character":0,"end_line":3,"end_character":20},"in_reply_to":"bfbd543f_009913bd","updated":"2021-03-20 04:09:43.000000000","message":"I think environments are expected to be self contained (at least from heat pov, i.e supposed to contain registry mappings and parameter_defaults required for those). Also, those are called \u0027parameter_defaults\u0027 for a reason, defaults unless overridden. With the tht interface we\u0027ve to enable services (include specific environments), IMO, they should have all parameter_defaults required and not expect users to specify it in some other environment for it to work by default.","commit_id":"8799a94214915195d466b82a0102aa2558069a60"}]}