)]}'
{"deployment/logging/rsyslog-container-puppet.yaml":[{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"f38a4d53ee17f0b807a73188d162f7747f017f63","unresolved":true,"context_lines":[{"line_number":62,"context_line":"    type: json"},{"line_number":63,"context_line":"    default: []"},{"line_number":64,"context_line":"    description: Additional source log file(s) loaded by the rsyslog service"},{"line_number":65,"context_line":"    tags:"},{"line_number":66,"context_line":"      - role_specific"},{"line_number":67,"context_line":"  CloudName:"},{"line_number":68,"context_line":"    default: overcloud.localdomain"},{"line_number":69,"context_line":"    description: The DNS name of this cloud. E.g. ci-overcloud.tripleo.org"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"d2b6eaa5_8efad000","line":66,"range":{"start_line":65,"start_character":0,"end_line":66,"end_character":21},"updated":"2022-02-24 10:18:18.000000000","message":"Any reason this has to be role specific? Role specific parameters with an empty default are kind of an antipattern to the whole role_specific parameter implementation.","commit_id":"a1b967fafefb1df39e9e04fae0476b14063dfff4"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"9b1ffc4dcb5b4de0eba43ef0ef9eba36d916b9cb","unresolved":true,"context_lines":[{"line_number":62,"context_line":"    type: json"},{"line_number":63,"context_line":"    default: []"},{"line_number":64,"context_line":"    description: Additional source log file(s) loaded by the rsyslog service"},{"line_number":65,"context_line":"    tags:"},{"line_number":66,"context_line":"      - role_specific"},{"line_number":67,"context_line":"  CloudName:"},{"line_number":68,"context_line":"    default: overcloud.localdomain"},{"line_number":69,"context_line":"    description: The DNS name of this cloud. E.g. ci-overcloud.tripleo.org"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"b314ee32_fb454513","line":66,"range":{"start_line":65,"start_character":0,"end_line":66,"end_character":21},"in_reply_to":"2027bfe4_8fdeb672","updated":"2022-02-24 15:33:42.000000000","message":"\u003e Any reason this has to be role specific?\nI\u0027m adding this parameter to allow adding arbitrarily log files. Because we usually deploy different services in different roles, we are likely to have different set of log files in different roles. That\u0027s why I\u0027ve made this role-specific.\n\n\n\u003e it seems that other *LoggingSource are not role specific\nThe other LoggingSource parameters defines log files generated by the services defined in that template file. Generally log files should be \u0027static\u0027 according to the services, so the other parameters don\u0027t need to be role-specific.","commit_id":"a1b967fafefb1df39e9e04fae0476b14063dfff4"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"a2bbfcb783e5b7fbf4ae844e2d8dd16df55891b6","unresolved":true,"context_lines":[{"line_number":62,"context_line":"    type: json"},{"line_number":63,"context_line":"    default: []"},{"line_number":64,"context_line":"    description: Additional source log file(s) loaded by the rsyslog service"},{"line_number":65,"context_line":"    tags:"},{"line_number":66,"context_line":"      - role_specific"},{"line_number":67,"context_line":"  CloudName:"},{"line_number":68,"context_line":"    default: overcloud.localdomain"},{"line_number":69,"context_line":"    description: The DNS name of this cloud. E.g. ci-overcloud.tripleo.org"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"2027bfe4_8fdeb672","line":66,"range":{"start_line":65,"start_character":0,"end_line":66,"end_character":21},"in_reply_to":"d2b6eaa5_8efad000","updated":"2022-02-24 15:26:53.000000000","message":"good question, it seems that other *LoggingSource are not role specific","commit_id":"a1b967fafefb1df39e9e04fae0476b14063dfff4"}]}