)]}'
{"deployment/aodh/aodh-base.yaml":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"c8c8c1a663cbafef07be483fcd84e096447872ba","unresolved":true,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        aodh::logging::debug:"},{"line_number":93,"context_line":"          if:"},{"line_number":94,"context_line":"          - service_debug_unset"},{"line_number":95,"context_line":"          - {get_param: Debug }"},{"line_number":96,"context_line":"          - {get_param: AodhDebug }"},{"line_number":97,"context_line":"        aodh::auth::auth_url: {get_param: [EndpointMap, KeystoneInternal, uri_no_suffix] }"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"155728cd_b40977aa","line":94,"updated":"2021-03-19 09:27:15.000000000","message":"It would be more simple if we can get rid of service_debug_unset.\n\n```\nif:\n  - {get_param: AodhDebug }\n  - true\n  - {get_param: Debug }\n```","commit_id":"1f3071eed548fdee5d93c7814bb841051b579617"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"9e8d8d0feed87d67e146e0867bad33c68e2e6920","unresolved":true,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        aodh::logging::debug:"},{"line_number":93,"context_line":"          if:"},{"line_number":94,"context_line":"          - service_debug_unset"},{"line_number":95,"context_line":"          - {get_param: Debug }"},{"line_number":96,"context_line":"          - {get_param: AodhDebug }"},{"line_number":97,"context_line":"        aodh::auth::auth_url: {get_param: [EndpointMap, KeystoneInternal, uri_no_suffix] }"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"e37517c1_e31dee4b","line":94,"in_reply_to":"155728cd_b40977aa","updated":"2021-03-19 10:13:48.000000000","message":"sure. I left them as is as I expected them possibly to be used in multiple places and they won\u0027t be evaluated every time.","commit_id":"1f3071eed548fdee5d93c7814bb841051b579617"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"62f482b412c854f424155fcafc5516bca52837ad","unresolved":true,"context_lines":[{"line_number":90,"context_line":"        aodh::logging::debug:"},{"line_number":91,"context_line":"          if:"},{"line_number":92,"context_line":"          - {get_param: AodhDebug}"},{"line_number":93,"context_line":"          - true"},{"line_number":94,"context_line":"          - {get_param: Debug}"},{"line_number":95,"context_line":"        aodh::auth::auth_url: {get_param: [EndpointMap, KeystoneInternal, uri_no_suffix] }"},{"line_number":96,"context_line":"        aodh::notification_driver: {get_param: NotificationDriver}"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"80b2d869_a3a0ad1a","line":93,"updated":"2021-03-19 12:43:23.000000000","message":"so this prevents disabling Debug for a specific server when we enable it globally - if I understand correctly Takashi comment, it seems to be something used? (won\u0027t repeat the comment for the other files since the syntax is the same)","commit_id":"870dd2c839ab6880074d86a8a5f7f20e98801f66"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"6b7dbcc2c2f8e8e3a977e137f24f9055fa136327","unresolved":true,"context_lines":[{"line_number":90,"context_line":"        aodh::logging::debug:"},{"line_number":91,"context_line":"          if:"},{"line_number":92,"context_line":"          - {get_param: AodhDebug}"},{"line_number":93,"context_line":"          - true"},{"line_number":94,"context_line":"          - {get_param: Debug}"},{"line_number":95,"context_line":"        aodh::auth::auth_url: {get_param: [EndpointMap, KeystoneInternal, uri_no_suffix] }"},{"line_number":96,"context_line":"        aodh::notification_driver: {get_param: NotificationDriver}"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"133dc189_6ed5df7b","line":93,"in_reply_to":"3f3913d6_d33d1b04","updated":"2021-03-19 13:12:15.000000000","message":"\u003e What\u0027s the need/use-case for that? You \u0027only\u0027 enable for a specific service to troubleshoot when it\u0027s disabled by default globally.\n\nI think the main use case would be to enable debug for services but avoid too verbose debug.\nIn queens, I used to use Debug:true and DockerDebug:false to enable debug in all services(for easy trouble shooting) except for docker, because docker debug log was too verbose.\n\nThe above case would be much rare compared to the case where users want to enable debug in only specific services, so I agree with current proposal as long as the change in behavior is documented. We still be able to disable debug in specific service using ExtraConfig","commit_id":"870dd2c839ab6880074d86a8a5f7f20e98801f66"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"03e156b37aac2773b93f53a8e5cd8cdc08e05d33","unresolved":true,"context_lines":[{"line_number":90,"context_line":"        aodh::logging::debug:"},{"line_number":91,"context_line":"          if:"},{"line_number":92,"context_line":"          - {get_param: AodhDebug}"},{"line_number":93,"context_line":"          - true"},{"line_number":94,"context_line":"          - {get_param: Debug}"},{"line_number":95,"context_line":"        aodh::auth::auth_url: {get_param: [EndpointMap, KeystoneInternal, uri_no_suffix] }"},{"line_number":96,"context_line":"        aodh::notification_driver: {get_param: NotificationDriver}"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3f3913d6_d33d1b04","line":93,"in_reply_to":"80b2d869_a3a0ad1a","updated":"2021-03-19 12:50:06.000000000","message":"\u003e so this prevents disabling Debug for a specific server when we enable it globally\n\nWhat\u0027s the need/use-case for that? You \u0027only\u0027 enable for a specific service to troubleshoot when it\u0027s disabled by default globally.\n\nAFAICT, one would either enable it globally or enable it for a service.","commit_id":"870dd2c839ab6880074d86a8a5f7f20e98801f66"}]}